Re: [PATCH] pahole: correct libbpf git url

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>, dwarves@vger.kernel.org
Subject: Re: [PATCH] pahole: correct libbpf git url
Date: Fri, 6 Aug 2021 15:45:03 -0300	[thread overview]
Message-ID: <YQ2DL8SVk3OxDAaL@kernel.org> (raw)
In-Reply-To: <YQ2Chd/j62NCY2NX@kernel.org>

Em Fri, Aug 06, 2021 at 03:42:13PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Aug 06, 2021 at 06:12:43PM +0800, Joseph Qi escreveu:
> > Otherwise it will encounter the following error:
> > fatal: unable to access 'https://github.com/libbpf/libbpf/': Encountered end of file
> > fatal: clone of 'https://github.com/libbpf/libbpf' into submodule path '/home/workspace/pahole/lib/bpf' failed
> > 
> > Also update README to add step 'make'.
> 
> You forgot to add Andrii, the author of the patch you're fixing, to the
> CC list, please do it next time.

Also here it works without your patch:

⬢[acme@toolbox git]$ git clone pahole bla
Cloning into 'bla'...
done.
⬢[acme@toolbox git]$ cd bla
⬢[acme@toolbox bla]$ mkdir build
⬢[acme@toolbox bla]$ cd build
⬢[acme@toolbox build]$ cmake ..
-- The C compiler identification is GNU 11.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Setting BUILD_SHARED_LIBS = ON
-- Checking availability of DWARF and ELF development libraries
-- Looking for dwfl_module_build_id in elf
-- Looking for dwfl_module_build_id in elf - found
-- Found dwarf.h header: /usr/include
-- Found elfutils/libdw.h header: /usr/include
-- Found libdw library: /usr/lib64/libdw.so
-- Found libelf library: /usr/lib64/libelf.so
-- Checking availability of DWARF and ELF development libraries - done
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.11")
-- Submodule update
Submodule 'lib/bpf' (https://github.com/libbpf/libbpf) registered for path 'lib/bpf'
Cloning into '/var/home/acme/git/bla/lib/bpf'...
Submodule path 'lib/bpf': checked out '986962fade5dfa89c2890f3854eb040d2a64ab38'
-- Submodule update - done
-- Performing Test HAVE_REALLOCARRAY_SUPPORT
-- Performing Test HAVE_REALLOCARRAY_SUPPORT - Success
-- Configuring done
-- Generating done
-- Build files have been written to: /var/home/acme/git/bla/build
⬢[acme@toolbox build]$ cd ..
⬢[acme@toolbox bla]$ make -j26 -C build
make: Entering directory '/var/home/acme/git/bla/build'
make[1]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
[  2%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/bpf_prog_linfo.c.o
[  6%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/bpf.c.o
[  6%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/btf.c.o
[  8%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/hashmap.c.o
[ 10%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/btf_dump.c.o
[ 12%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/libbpf.c.o
[ 14%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/libbpf_errno.c.o
[ 16%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/nlattr.c.o
[ 18%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/libbpf_probes.c.o
[ 20%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/netlink.c.o
[ 22%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/ringbuf.c.o
[ 24%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/xsk.c.o
[ 26%] Building C object CMakeFiles/bpf.dir/lib/bpf/src/str_error.c.o
make[2]: Leaving directory '/var/home/acme/git/bla/build'
[ 26%] Built target bpf
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
[ 28%] Building C object CMakeFiles/dwarves.dir/dwarves.c.o
[ 30%] Building C object CMakeFiles/dwarves.dir/dwarves_fprintf.c.o
[ 32%] Building C object CMakeFiles/dwarves.dir/gobuffer.c.o
[ 34%] Building C object CMakeFiles/dwarves.dir/libctf.c.o
[ 36%] Building C object CMakeFiles/dwarves.dir/ctf_loader.c.o
[ 38%] Building C object CMakeFiles/dwarves.dir/dutil.c.o
[ 40%] Building C object CMakeFiles/dwarves.dir/btf_encoder.c.o
[ 44%] Building C object CMakeFiles/dwarves.dir/rbtree.c.o
[ 44%] Building C object CMakeFiles/dwarves.dir/btf_loader.c.o
[ 46%] Building C object CMakeFiles/dwarves.dir/elf_symtab.c.o
[ 48%] Building C object CMakeFiles/dwarves.dir/dwarf_loader.c.o
[ 50%] Linking C shared library libdwarves.so
make[2]: Leaving directory '/var/home/acme/git/bla/build'
[ 50%] Built target dwarves
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
[ 52%] Building C object CMakeFiles/syscse.dir/syscse.c.o
[ 58%] Building C object CMakeFiles/scncopy.dir/elfcreator.c.o
[ 58%] Building C object CMakeFiles/scncopy.dir/scncopy.c.o
[ 58%] Building C object CMakeFiles/dwarves_emit.dir/dwarves_emit.c.o
[ 62%] Building C object CMakeFiles/dwarves_reorganize.dir/dwarves_reorganize.c.o
[ 62%] Building C object CMakeFiles/dtagnames.dir/dtagnames.c.o
[ 64%] Building C object CMakeFiles/codiff.dir/codiff.c.o
[ 70%] Building C object CMakeFiles/pdwtags.dir/pdwtags.c.o
[ 70%] Building C object CMakeFiles/prefcnt.dir/prefcnt.c.o
[ 70%] Building C object CMakeFiles/pglobal.dir/pglobal.c.o
[ 72%] Linking C executable dtagnames
[ 76%] Linking C executable prefcnt
[ 76%] Linking C executable syscse
[ 78%] Linking C executable pglobal
[ 80%] Linking C shared library libdwarves_reorganize.so
[ 82%] Linking C executable pdwtags
[ 84%] Linking C executable scncopy
make[2]: Leaving directory '/var/home/acme/git/bla/build'
[ 86%] Linking C shared library libdwarves_emit.so
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
[ 86%] Built target dtagnames
[ 86%] Built target prefcnt
[ 86%] Built target syscse
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
[ 88%] Linking C executable codiff
[ 88%] Built target pglobal
[ 88%] Built target scncopy
[ 88%] Built target pdwtags
[ 88%] Built target dwarves_reorganize
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
[ 88%] Built target dwarves_emit
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
[ 90%] Building C object CMakeFiles/pahole.dir/pahole.c.o
make[2]: Leaving directory '/var/home/acme/git/bla/build'
make[2]: Leaving directory '/var/home/acme/git/bla/build'
[ 90%] Built target codiff
make[2]: Entering directory '/var/home/acme/git/bla/build'
make[2]: Entering directory '/var/home/acme/git/bla/build'
[ 92%] Building C object CMakeFiles/pfunct.dir/pfunct.c.o
[ 94%] Building C object CMakeFiles/ctracer.dir/ctracer.c.o
[ 96%] Linking C executable pfunct
[ 98%] Linking C executable ctracer
make[2]: Leaving directory '/var/home/acme/git/bla/build'
[ 98%] Built target pfunct
make[2]: Leaving directory '/var/home/acme/git/bla/build'
[ 98%] Built target ctracer
[100%] Linking C executable pahole
make[2]: Leaving directory '/var/home/acme/git/bla/build'
[100%] Built target pahole
make[1]: Leaving directory '/var/home/acme/git/bla/build'
make: Leaving directory '/var/home/acme/git/bla/build'
⬢[acme@toolbox bla]$

next prev parent reply	other threads:[~2021-08-06 18:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06 10:12 [PATCH] pahole: correct libbpf git url Joseph Qi
2021-08-06 18:42 ` Arnaldo Carvalho de Melo
2021-08-06 18:45   ` Arnaldo Carvalho de Melo [this message]
2021-08-06 21:11   ` Andrii Nakryiko
2021-08-08 11:37     ` Joseph Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQ2DL8SVk3OxDAaL@kernel.org \
    --to=acme@kernel.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=dwarves@vger.kernel.org \
    --cc=joseph.qi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.