From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36F09C4338F for ; Fri, 6 Aug 2021 18:47:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2ADD61167 for ; Fri, 6 Aug 2021 18:47:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B2ADD61167 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6DDE316D1; Fri, 6 Aug 2021 20:46:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6DDE316D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628275640; bh=oAVC0k8WGSbGkKP+o+xceOlJxnllsw5yXvL4gjncCwE=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tDFQpq1wjEdhKqSDdyiaZfg+gafbh6vj3MDTUqUL+DrMmshD82DqJJnnU9wq5NkVN /SEOXKv6jw3UmWX47MjbGhYEZcI6M7YLIHN4LcT/vYlNuasCP9W4GI32IVRejLFqx7 x5jEEpTUApwcIL1UxDmPsARajv8A5fv/B4uo3yrA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EF47AF801F7; Fri, 6 Aug 2021 20:46:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8C17AF8025F; Fri, 6 Aug 2021 20:46:28 +0200 (CEST) Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 40833F80169 for ; Fri, 6 Aug 2021 20:46:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 40833F80169 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oPU85Ks4" Received: by mail-pj1-x102a.google.com with SMTP id j1so18021404pjv.3 for ; Fri, 06 Aug 2021 11:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lq+ZJabFR/aEqAVLWWQwRS+Bk30mmVgINsLo2QOd63g=; b=oPU85Ks4t/BD97TfUEBxq2w8KeO5d4b1Nvchn+Yv7kB9wyq/mf6St5MBYsxebm3xyK 2TryVrMzKvdFR8lsNpJJvPTGVD4xpl+ayOSVdJa9rxZqEG8whTlQ9VyP8dlNEQrJJob9 L1GJYfPOIitMNMopL09Z+xctxoFgA0e1jTOj55Hexm/8/2DIwLeTuQql2G/TkU9C3erd aqjtHdqEda9mrydWw7Nl7tQlscqzQhgaTkh3FsV8iPW0Y607/KxDgxiwjF79JrWcFsfS nD/+RPX0BYNASPKwyYxj4WgS75i+bpNHRnG/mqXLAaY3TvvGXIOmp2cf1T5bSsVeRVnR 2OKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lq+ZJabFR/aEqAVLWWQwRS+Bk30mmVgINsLo2QOd63g=; b=Erz8oiHQKFxqqkon6SN5VSKqwA9sZdvqv0tQwTVsqveVc0waoNHLNwrpS3vfUamXdy TfclSjbpE/LWBeK+7yGbWuZVF3jspejskJJiL9FknrJgTtmfx0MbiBe6aD3L27uj70C8 oCqQMxhV3F+o8ERfPL0FJWFEpHaCFRjnD/TI41F6mXmg87BJZEX/0kAmbaeQjB6v8acq gRiafx4+JUNu7JCQphTnT0svlHw6yIjXJEvDrzi4/IaekOrc5fHeaidwtCY8NLOKt2li kScJEWalOS6LtoMvKoK7obKqoFrA8mF4IitkmLoO8Bv6NfhuhBKzRNX+J+D5tQmkctHP LmDw== X-Gm-Message-State: AOAM53090++ayr/3+0GGcH3j/av1R+vSY6qvQyOdv5DqIj6oIN92fr92 8ixE60eORpsphV3mYlFlsGM= X-Google-Smtp-Source: ABdhPJzzMFSdpyMOk7GztnyuZ8fgTAmGVjar/iMG55IOe92tbJufWKgnV6AdQl2ufQFq5C/G1yNdUw== X-Received: by 2002:a62:8f86:0:b029:32e:33d7:998b with SMTP id n128-20020a628f860000b029032e33d7998bmr12215091pfd.64.1628275577437; Fri, 06 Aug 2021 11:46:17 -0700 (PDT) Received: from google.com ([2620:15c:202:201:8873:2b2a:719c:18c7]) by smtp.gmail.com with ESMTPSA id jz24sm10017062pjb.9.2021.08.06.11.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 11:46:16 -0700 (PDT) Date: Fri, 6 Aug 2021 11:46:13 -0700 From: Dmitry Torokhov To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] parisc: Make struct parisc_driver::remove() return void Message-ID: References: <20210806093938.1950990-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210806093938.1950990-1-u.kleine-koenig@pengutronix.de> Cc: kernel@pengutronix.de, alsa-devel@alsa-project.org, "Martin K. Petersen" , Corey Minyard , linux-scsi@vger.kernel.org, Greg Kroah-Hartman , Helge Deller , Takashi Iwai , Sudip Mukherjee , "James E.J. Bottomley" , netdev@vger.kernel.org, linux-parisc@vger.kernel.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , openipmi-developer@lists.sourceforge.net, Jiri Slaby , "David S. Miller" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Aug 06, 2021 at 11:39:38AM +0200, Uwe Kleine-König wrote: > The caller of this function (parisc_driver_remove() in > arch/parisc/kernel/drivers.c) ignores the return value, so better don't > return any value at all to not wake wrong expectations in driver authors. > > The only function that could return a non-zero value before was > ipmi_parisc_remove() which returns the return value of > ipmi_si_remove_by_dev(). Make this function return void, too, as for all > other callers the value is ignored, too. > > Also fold in a small checkpatch fix for: > > WARNING: Unnecessary space before function pointer arguments > + void (*remove) (struct parisc_device *dev); > > Signed-off-by: Uwe Kleine-König > --- ... > drivers/input/keyboard/hilkbd.c | 4 +--- > drivers/input/serio/gscps2.c | 3 +-- Acked-by: Dmitry Torokhov Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FCD3C4320A for ; Fri, 6 Aug 2021 18:46:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21AA460234 for ; Fri, 6 Aug 2021 18:46:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243339AbhHFSqf (ORCPT ); Fri, 6 Aug 2021 14:46:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231889AbhHFSqf (ORCPT ); Fri, 6 Aug 2021 14:46:35 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00C1AC0613CF; Fri, 6 Aug 2021 11:46:18 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id t7-20020a17090a5d87b029017807007f23so20864357pji.5; Fri, 06 Aug 2021 11:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lq+ZJabFR/aEqAVLWWQwRS+Bk30mmVgINsLo2QOd63g=; b=oPU85Ks4t/BD97TfUEBxq2w8KeO5d4b1Nvchn+Yv7kB9wyq/mf6St5MBYsxebm3xyK 2TryVrMzKvdFR8lsNpJJvPTGVD4xpl+ayOSVdJa9rxZqEG8whTlQ9VyP8dlNEQrJJob9 L1GJYfPOIitMNMopL09Z+xctxoFgA0e1jTOj55Hexm/8/2DIwLeTuQql2G/TkU9C3erd aqjtHdqEda9mrydWw7Nl7tQlscqzQhgaTkh3FsV8iPW0Y607/KxDgxiwjF79JrWcFsfS nD/+RPX0BYNASPKwyYxj4WgS75i+bpNHRnG/mqXLAaY3TvvGXIOmp2cf1T5bSsVeRVnR 2OKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lq+ZJabFR/aEqAVLWWQwRS+Bk30mmVgINsLo2QOd63g=; b=DucPVjjs0ZsvWYowKi+0i2xiOpQfbZ6htuepHQYDtVV/xB/HOyWy+ZEUwaJBaj0E7T kqI8tS6Q/8ExE6mn69Knt+K0ZVfSFAjwkpHwH3RCwazvCphLC6UIVLj+Mb0gxQfjJMc7 PmVoomIqHbYgxr/nGguyYDSLiflnRYfNcAbWrOdEZ7yUia+cTZyrKDKV7EB4UI9EabHj EUmf89xO0vXQB3iHCUXddkfov+Ym17e/RvZ9yiKdA4x7Z6jqPldTi+qhfyL7s4VbR1up J7yhgnB3TSS1Wm+k6fA5IWB6rZ0Aj0oA+K8hpr9UOPW9avLdg7XdL/BzYCAmh7/t4D/E RwbA== X-Gm-Message-State: AOAM530kZahHgGV18PkCCoCHNrird3Zmbke3lYJzSsa6g40sQ1CheERm D2mu3sep3fbmrkoIGFsOfyI= X-Google-Smtp-Source: ABdhPJzzMFSdpyMOk7GztnyuZ8fgTAmGVjar/iMG55IOe92tbJufWKgnV6AdQl2ufQFq5C/G1yNdUw== X-Received: by 2002:a62:8f86:0:b029:32e:33d7:998b with SMTP id n128-20020a628f860000b029032e33d7998bmr12215091pfd.64.1628275577437; Fri, 06 Aug 2021 11:46:17 -0700 (PDT) Received: from google.com ([2620:15c:202:201:8873:2b2a:719c:18c7]) by smtp.gmail.com with ESMTPSA id jz24sm10017062pjb.9.2021.08.06.11.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 11:46:16 -0700 (PDT) Date: Fri, 6 Aug 2021 11:46:13 -0700 From: Dmitry Torokhov To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: "James E.J. Bottomley" , Helge Deller , Corey Minyard , "David S. Miller" , Jakub Kicinski , Sudip Mukherjee , "Martin K. Petersen" , Greg Kroah-Hartman , Jiri Slaby , Jaroslav Kysela , Takashi Iwai , linux-parisc@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, kernel@pengutronix.de Subject: Re: [PATCH] parisc: Make struct parisc_driver::remove() return void Message-ID: References: <20210806093938.1950990-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210806093938.1950990-1-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, Aug 06, 2021 at 11:39:38AM +0200, Uwe Kleine-König wrote: > The caller of this function (parisc_driver_remove() in > arch/parisc/kernel/drivers.c) ignores the return value, so better don't > return any value at all to not wake wrong expectations in driver authors. > > The only function that could return a non-zero value before was > ipmi_parisc_remove() which returns the return value of > ipmi_si_remove_by_dev(). Make this function return void, too, as for all > other callers the value is ignored, too. > > Also fold in a small checkpatch fix for: > > WARNING: Unnecessary space before function pointer arguments > + void (*remove) (struct parisc_device *dev); > > Signed-off-by: Uwe Kleine-König > --- ... > drivers/input/keyboard/hilkbd.c | 4 +--- > drivers/input/serio/gscps2.c | 3 +-- Acked-by: Dmitry Torokhov Thanks. -- Dmitry