Re: [PATCH 02/14] drm/kmb: Define driver date and major/minor version

[Sam Ravnborg <sam@ravnborg.org>]

Hi Anitha,
On Tue, Jul 27, 2021 at 05:31:14PM -0700, Anitha Chrisanthus wrote:
> From: Edmund Dea <edmund.j.dea@intel.com>
> 
> Added macros for date and version
> 
> Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display")
> Signed-off-by: Edmund Dea <edmund.j.dea@intel.com>
Your s-o-b is missing.

I find it of no use with macros here, as the figures are not used
anywhere else, but whatever.

With s-o-b fixed:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> ---
>  drivers/gpu/drm/kmb/kmb_drv.c | 8 ++++----
>  drivers/gpu/drm/kmb/kmb_drv.h | 5 +++++
>  2 files changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c
> index c0b1c6f99249..f54392ec4fab 100644
> --- a/drivers/gpu/drm/kmb/kmb_drv.c
> +++ b/drivers/gpu/drm/kmb/kmb_drv.c
> @@ -425,10 +425,10 @@ static const struct drm_driver kmb_driver = {
>  	.fops = &fops,
>  	DRM_GEM_CMA_DRIVER_OPS_VMAP,
>  	.name = "kmb-drm",
> -	.desc = "KEEMBAY DISPLAY DRIVER ",
> -	.date = "20201008",
> -	.major = 1,
> -	.minor = 0,
> +	.desc = "KEEMBAY DISPLAY DRIVER",
> +	.date = DRIVER_DATE,
> +	.major = DRIVER_MAJOR,
> +	.minor = DRIVER_MINOR,
>  };
>  
>  static int kmb_remove(struct platform_device *pdev)
> diff --git a/drivers/gpu/drm/kmb/kmb_drv.h b/drivers/gpu/drm/kmb/kmb_drv.h
> index 02e806712a64..ebbaa5f422d5 100644
> --- a/drivers/gpu/drm/kmb/kmb_drv.h
> +++ b/drivers/gpu/drm/kmb/kmb_drv.h
> @@ -15,6 +15,11 @@
>  #define KMB_MAX_HEIGHT			1080 /*Max height in pixels */
>  #define KMB_MIN_WIDTH                   1920 /*Max width in pixels */
>  #define KMB_MIN_HEIGHT                  1080 /*Max height in pixels */
> +
> +#define DRIVER_DATE			"20210223"
> +#define DRIVER_MAJOR			1
> +#define DRIVER_MINOR			1
> +
>  #define KMB_LCD_DEFAULT_CLK		200000000
>  #define KMB_SYS_CLK_MHZ			500
>  
> -- 
> 2.25.1