From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41D39C4338F for ; Wed, 28 Jul 2021 20:38:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B33A60F46 for ; Wed, 28 Jul 2021 20:38:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0B33A60F46 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zl4Rhc/1aAxTnasOjCPcz3Ul2j0666I7BkPBCuVx2TA=; b=U283VzLF3hRRSB HO/YY22Tif13Wdp8uM+eBx7h3m9qQk4q0tk9Aj//ASBDTodCj+Yy6/cSFlx4Ylvd05OIJO/Hw6fr0 0j4vnaTNykeh/KzoT23dqvhPsJi0P+vopMqvCEI8GvFn6q4zthy0pH8XsAlyaSMHLdrBxy7kuueL3 SKUDDLS1yeVuoi5G4cRl4KEGLB48Pxxfe9Y7NA5xcc24lw/4gldupvT+W8kDPterj3r9j8SEnERWn WQ+cZ4L8z/O/iDf8l1MCo/6FWJrZsQDinVnj7kkKtVnnkS6iBlF1JNGZItXLRk0+EWyj2TkAn84QP iG1mwPOAvXtodCIpVEug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8qJe-002K9P-UX; Wed, 28 Jul 2021 20:38:10 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8qJS-002K87-10; Wed, 28 Jul 2021 20:37:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=R7bNU8BZCOB5iHa54MHFRtshuOZCZQe5szk1h/9GSv4=; b=J3gS7vLVbdobYkuyQnS/5NIZXG LM0+y/ogncES/luhSa1aiof9fn2vigm1e0bj6MkI7gkilPMaCrc89un0I56HZ6f6UEBkvBSvGDbo/ CXREAGn3PQPnFRYRnNDDhBsDf9GKxjETl0hHhOkDzzVIfEy1XHZJptJ7qwL74WvfnaN4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m8qJK-00FEMI-Rg; Wed, 28 Jul 2021 22:37:50 +0200 Date: Wed, 28 Jul 2021 22:37:50 +0200 From: Andrew Lunn To: Peter Geis Cc: Michael Riesch , devicetree@vger.kernel.org, arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , Rob Herring , Heiko Stuebner , Liang Chen , Simon Xue Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support Message-ID: References: <20210728161020.3905-1-michael.riesch@wolfvision.net> <20210728161020.3905-3-michael.riesch@wolfvision.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_133758_136033_4BEC24A3 X-CRM114-Status: UNSURE ( 7.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org > Generally all rockchip boards use this value instead of the rgmii_id, > I imagine because it's more consistent to tune here than the hit or > miss support of the phy drivers. Most PHY drivers actually implement it correctly, since by default, most systems get the PHY to do the delays. But if most Rockchip boards do it this way, there is a lot to be said for consistence, so this is fine by me. Andrew _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F33C4338F for ; Wed, 28 Jul 2021 20:40:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDD6161019 for ; Wed, 28 Jul 2021 20:40:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DDD6161019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tIx4oceStRs3le6AR84ouQ46OGBio1cuIquTCPYEkNc=; b=xZsn5tSBKeeZBY HFABZLbLy99fBFD5Gvot2dMKRpgeozzalf6eG+U0sa32fIys2Hubn0ZefpdnMDzzb9RMnnBA5hBZ9 qUyp64Qyqu3XYqEKPjaWKGHdZECdffVuL92JDsxK8ATq1E7GxlXyyc4rbAKNKiGJYdcGJAgZhtMrp w9TZ30bA8NsziTPNqF82oAbanVAOIkNFiILLouWbGTBZuTvEki02C/CnbT/SueQ7/gGgTD27apB7i IPfo9E56Pb6/2mS20ujy7bku5TwuSastwmCc7jKgJvznRo7hFqZi++1q8fCd4eCHUv+R+vc8DeAyo ZstReeFDrhGpEK1ufp9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8qJV-002K8f-Io; Wed, 28 Jul 2021 20:38:01 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8qJS-002K87-10; Wed, 28 Jul 2021 20:37:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=R7bNU8BZCOB5iHa54MHFRtshuOZCZQe5szk1h/9GSv4=; b=J3gS7vLVbdobYkuyQnS/5NIZXG LM0+y/ogncES/luhSa1aiof9fn2vigm1e0bj6MkI7gkilPMaCrc89un0I56HZ6f6UEBkvBSvGDbo/ CXREAGn3PQPnFRYRnNDDhBsDf9GKxjETl0hHhOkDzzVIfEy1XHZJptJ7qwL74WvfnaN4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m8qJK-00FEMI-Rg; Wed, 28 Jul 2021 22:37:50 +0200 Date: Wed, 28 Jul 2021 22:37:50 +0200 From: Andrew Lunn To: Peter Geis Cc: Michael Riesch , devicetree@vger.kernel.org, arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , Rob Herring , Heiko Stuebner , Liang Chen , Simon Xue Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support Message-ID: References: <20210728161020.3905-1-michael.riesch@wolfvision.net> <20210728161020.3905-3-michael.riesch@wolfvision.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_133758_136033_4BEC24A3 X-CRM114-Status: UNSURE ( 7.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Generally all rockchip boards use this value instead of the rgmii_id, > I imagine because it's more consistent to tune here than the hit or > miss support of the phy drivers. Most PHY drivers actually implement it correctly, since by default, most systems get the PHY to do the delays. But if most Rockchip boards do it this way, there is a lot to be said for consistence, so this is fine by me. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C23C4338F for ; Wed, 28 Jul 2021 20:37:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AA8460F46 for ; Wed, 28 Jul 2021 20:37:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231605AbhG1UiA (ORCPT ); Wed, 28 Jul 2021 16:38:00 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50656 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231571AbhG1Uh7 (ORCPT ); Wed, 28 Jul 2021 16:37:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=R7bNU8BZCOB5iHa54MHFRtshuOZCZQe5szk1h/9GSv4=; b=J3gS7vLVbdobYkuyQnS/5NIZXG LM0+y/ogncES/luhSa1aiof9fn2vigm1e0bj6MkI7gkilPMaCrc89un0I56HZ6f6UEBkvBSvGDbo/ CXREAGn3PQPnFRYRnNDDhBsDf9GKxjETl0hHhOkDzzVIfEy1XHZJptJ7qwL74WvfnaN4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m8qJK-00FEMI-Rg; Wed, 28 Jul 2021 22:37:50 +0200 Date: Wed, 28 Jul 2021 22:37:50 +0200 From: Andrew Lunn To: Peter Geis Cc: Michael Riesch , devicetree@vger.kernel.org, arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , Rob Herring , Heiko Stuebner , Liang Chen , Simon Xue Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet support Message-ID: References: <20210728161020.3905-1-michael.riesch@wolfvision.net> <20210728161020.3905-3-michael.riesch@wolfvision.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > Generally all rockchip boards use this value instead of the rgmii_id, > I imagine because it's more consistent to tune here than the hit or > miss support of the phy drivers. Most PHY drivers actually implement it correctly, since by default, most systems get the PHY to do the delays. But if most Rockchip boards do it this way, there is a lot to be said for consistence, so this is fine by me. Andrew