From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0898DC4338F for ; Thu, 29 Jul 2021 16:52:57 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 6AE8060F23 for ; Thu, 29 Jul 2021 16:52:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6AE8060F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id ED0574A5A0; Thu, 29 Jul 2021 12:52:55 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2ZkCsDlZXebj; Thu, 29 Jul 2021 12:52:55 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0936C40629; Thu, 29 Jul 2021 12:52:55 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3EDC440573 for ; Thu, 29 Jul 2021 12:52:54 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WjACuwxnS5am for ; Thu, 29 Jul 2021 12:52:53 -0400 (EDT) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 3A4054048A for ; Thu, 29 Jul 2021 12:52:53 -0400 (EDT) Received: by mail-wr1-f53.google.com with SMTP id q3so7806366wrx.0 for ; Thu, 29 Jul 2021 09:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+D+WQ6dthjR+r0AdBLApfx1B5e7Pkkf4I29v7UyCASI=; b=juIc7gELG7oN7gWL10hEXKAxzCKfQ3+sXIXbR8NVbv6H6/8iyg7e5nZinla68omfBb pJpFFeqW+7tNmBT3QkjlBbDReKO8n2PbzQz3d77E7PZ0q/OrwNaBD97Aa9ZAvTjI2boz wt1J1hBbyiLjD0zz4d+HP27f045C5hKwbqgPpJCj8+eSu5Orkr4Vl1ZAf+4WDVyBXmcJ OZJEBITH+AOxbJko2FNW5gO3AMZQ/0O5QbdhFoa4zbUZnMlvy63Cf/GBBX+Gh5o/4Fbc r3MUSxUe13D+9pOCExT/UwXJemJzILzsz9i7KJQdbLvRY6qX2Cj9v4tai1maVHI/jTRe B0+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+D+WQ6dthjR+r0AdBLApfx1B5e7Pkkf4I29v7UyCASI=; b=j2bUWrqm6aUMlQ6WkMzyGYI6O4SJlK/1PDgPrn4Dh8j0a5xIwlqZGMtVgLx9+h2mok r6x9Ca9k/2f8veyGJ4N7AYhko0LwZQzDKhalNKs4qcqug9kkECLM3uPnSLhWI2Q2NDFa GZNBxj5k39A78Yy5f+4pEj8AkPyhNqMjp/7LzzXGaqFmt8alE4zReHR5WfssO1HkVmQX eN8Lh1H5w1VEFEA24pLTZitnTqqgSd1KtMoFAlbgHxktbQcv92XNMEyzuUV6gzrPXRm7 oD/VHClHyhG8Sw3RJcgUrCQ7y5tP3Pfw94q7p/xva0CCKR1jifej94BRSg1m5ii7DA8r nqWg== X-Gm-Message-State: AOAM533qW/XfI/IfU2nKc218L1wSrWW+KpGJmdHd9c6fV+e1pJUu+AHm KbMY6Ienj56wtdHSyPXQ16SDqg== X-Google-Smtp-Source: ABdhPJyuOEXmaCM+TGYzMuW7Y5FKOpp4wnpTdqH3IdxX/TQTz9aynuGEL16s1B6g9wYjmkjo8JDYfA== X-Received: by 2002:a5d:54c7:: with SMTP id x7mr5939815wrv.77.1627577572042; Thu, 29 Jul 2021 09:52:52 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:293a:bc89:7514:5218]) by smtp.gmail.com with ESMTPSA id j1sm9301709wmo.4.2021.07.29.09.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 09:52:51 -0700 (PDT) Date: Thu, 29 Jul 2021 17:52:49 +0100 From: Quentin Perret To: David Brazdil Subject: Re: [PATCH 1/2] KVM: arm64: Fix off-by-one in range_is_memory Message-ID: References: <20210728153232.1018911-1-dbrazdil@google.com> <20210728153232.1018911-2-dbrazdil@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210728153232.1018911-2-dbrazdil@google.com> Cc: Will Deacon , Marc Zyngier , linux-kernel@vger.kernel.org, Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wednesday 28 Jul 2021 at 15:32:31 (+0000), David Brazdil wrote: > Hyp checks whether an address range only covers RAM by checking the > start/endpoints against a list of memblock_region structs. However, > the endpoint here is exclusive but internally is treated as inclusive. > Fix the off-by-one error that caused valid address ranges to be > rejected. > > Cc: Quentin Perret > Fixes: 90134ac9cabb6 ("KVM: arm64: Protect the .hyp sections from the host") > Signed-off-by: David Brazdil > --- > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > index d938ce95d3bd..a6ce991b1467 100644 > --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c > +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > @@ -193,7 +193,7 @@ static bool range_is_memory(u64 start, u64 end) > { > struct kvm_mem_range r1, r2; > > - if (!find_mem_range(start, &r1) || !find_mem_range(end, &r2)) > + if (!find_mem_range(start, &r1) || !find_mem_range(end - 1, &r2)) > return false; > if (r1.start != r2.start) > return false; Looks good to me: Reviewed-by: Quentin Perret Thanks, Quentin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73BFAC4338F for ; Thu, 29 Jul 2021 16:54:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33E2B60560 for ; Thu, 29 Jul 2021 16:54:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 33E2B60560 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TTAYRnLIhtrFWPSUpsk3hz9KZPKxAHou+Ab62d3zXL0=; b=tVneVgyLfELRZK 45NIsVC7LtbMENU+I/IjxgdNNItbsWy9GsVSzzh20JB5tSODpxBXQJqvRvxFYbBTjb8IbzTBueqgV 1AMxmg3Y87/OD/Coq6NjObXbr3hAtVOuMbgC5qJMzfCSfnlV5yufilYMmWLT0pByX+kUQcvRxoI2w oQ/mjom9zdiPthN0mo28oKBK3x7Hh8ipplExCB8QLhPUgVAoW8KU0rWR9NzmkKmwoXs6SV/Eg3UD2 iDnXFsH0qVq+TW03w0cWyMeBZ5hLIxr8wD4qnnxfpnrBWQFklpnRsI20QG1uVGf0+BWrkG/xt+94+ vMB2HOLLDfJk4JpHmxCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m99HG-0059n6-Ga; Thu, 29 Jul 2021 16:52:58 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m99HC-0059lE-1B for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 16:52:55 +0000 Received: by mail-wr1-x42c.google.com with SMTP id p5so7755499wro.7 for ; Thu, 29 Jul 2021 09:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+D+WQ6dthjR+r0AdBLApfx1B5e7Pkkf4I29v7UyCASI=; b=juIc7gELG7oN7gWL10hEXKAxzCKfQ3+sXIXbR8NVbv6H6/8iyg7e5nZinla68omfBb pJpFFeqW+7tNmBT3QkjlBbDReKO8n2PbzQz3d77E7PZ0q/OrwNaBD97Aa9ZAvTjI2boz wt1J1hBbyiLjD0zz4d+HP27f045C5hKwbqgPpJCj8+eSu5Orkr4Vl1ZAf+4WDVyBXmcJ OZJEBITH+AOxbJko2FNW5gO3AMZQ/0O5QbdhFoa4zbUZnMlvy63Cf/GBBX+Gh5o/4Fbc r3MUSxUe13D+9pOCExT/UwXJemJzILzsz9i7KJQdbLvRY6qX2Cj9v4tai1maVHI/jTRe B0+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+D+WQ6dthjR+r0AdBLApfx1B5e7Pkkf4I29v7UyCASI=; b=QQHMRVfV5KVa3rn+ZfDnifA4O2nNw4GwBiPQz/SBCsc79X9iRxdIZUBy9SWnWamyC3 mfjZ4ThETUvNvFm1v0ZgfB10HBJRhPt6h8zdo0nslFdIj3JpbprzZ/9RwWB4QFBwLwM8 eRtaTNyF4ivU3s2NyRq4TOcfgMIks5a9JtDFimuMZStT+FPg9mo0s2rwkLAXB0PO4jf9 oZBn4B9iQqjUyHH3suuGARIWqyeGmyY+CpJwavTMYLkSRKjCbJBG9/dt6KPkSIIc0xW9 1LwbcVGYXk4bE3Zmvnoi8bRygv/hTjPSTp4oyna8iRRUqXAwUa+Z/IFGjoybgBKsqiZH 1nLw== X-Gm-Message-State: AOAM5329GfcHM79NFGd93IFbLEWVZF2r1dKxmC4tUqX7JSCV8pZXl8i9 19jkduDXKYp0Qrw8SOgHwI7yKw== X-Google-Smtp-Source: ABdhPJyuOEXmaCM+TGYzMuW7Y5FKOpp4wnpTdqH3IdxX/TQTz9aynuGEL16s1B6g9wYjmkjo8JDYfA== X-Received: by 2002:a5d:54c7:: with SMTP id x7mr5939815wrv.77.1627577572042; Thu, 29 Jul 2021 09:52:52 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:293a:bc89:7514:5218]) by smtp.gmail.com with ESMTPSA id j1sm9301709wmo.4.2021.07.29.09.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 09:52:51 -0700 (PDT) Date: Thu, 29 Jul 2021 17:52:49 +0100 From: Quentin Perret To: David Brazdil Cc: kvmarm@lists.cs.columbia.edu, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: arm64: Fix off-by-one in range_is_memory Message-ID: References: <20210728153232.1018911-1-dbrazdil@google.com> <20210728153232.1018911-2-dbrazdil@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210728153232.1018911-2-dbrazdil@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_095254_140068_F3DD9EBE X-CRM114-Status: GOOD ( 18.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 28 Jul 2021 at 15:32:31 (+0000), David Brazdil wrote: > Hyp checks whether an address range only covers RAM by checking the > start/endpoints against a list of memblock_region structs. However, > the endpoint here is exclusive but internally is treated as inclusive. > Fix the off-by-one error that caused valid address ranges to be > rejected. > > Cc: Quentin Perret > Fixes: 90134ac9cabb6 ("KVM: arm64: Protect the .hyp sections from the host") > Signed-off-by: David Brazdil > --- > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > index d938ce95d3bd..a6ce991b1467 100644 > --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c > +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > @@ -193,7 +193,7 @@ static bool range_is_memory(u64 start, u64 end) > { > struct kvm_mem_range r1, r2; > > - if (!find_mem_range(start, &r1) || !find_mem_range(end, &r2)) > + if (!find_mem_range(start, &r1) || !find_mem_range(end - 1, &r2)) > return false; > if (r1.start != r2.start) > return false; Looks good to me: Reviewed-by: Quentin Perret Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45170C4320A for ; Thu, 29 Jul 2021 16:52:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 298A360F43 for ; Thu, 29 Jul 2021 16:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230502AbhG2Qw7 (ORCPT ); Thu, 29 Jul 2021 12:52:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbhG2Qw6 (ORCPT ); Thu, 29 Jul 2021 12:52:58 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9A53C061765 for ; Thu, 29 Jul 2021 09:52:53 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id d8so7747387wrm.4 for ; Thu, 29 Jul 2021 09:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+D+WQ6dthjR+r0AdBLApfx1B5e7Pkkf4I29v7UyCASI=; b=juIc7gELG7oN7gWL10hEXKAxzCKfQ3+sXIXbR8NVbv6H6/8iyg7e5nZinla68omfBb pJpFFeqW+7tNmBT3QkjlBbDReKO8n2PbzQz3d77E7PZ0q/OrwNaBD97Aa9ZAvTjI2boz wt1J1hBbyiLjD0zz4d+HP27f045C5hKwbqgPpJCj8+eSu5Orkr4Vl1ZAf+4WDVyBXmcJ OZJEBITH+AOxbJko2FNW5gO3AMZQ/0O5QbdhFoa4zbUZnMlvy63Cf/GBBX+Gh5o/4Fbc r3MUSxUe13D+9pOCExT/UwXJemJzILzsz9i7KJQdbLvRY6qX2Cj9v4tai1maVHI/jTRe B0+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+D+WQ6dthjR+r0AdBLApfx1B5e7Pkkf4I29v7UyCASI=; b=No20V8PjsKFCD1npg4+B9xbhWedDYvG5EwSVsUAMm/6idaX1YABM6k2p1oKSWI0LWA LOs96SBR+k7fpZuOsXvYccHI2les5Y+DWvgqvCniMQptyIs3l/1uKYp99ACRn21LcYIU sAJjelE/44sUaJKblGZ8gXm35swMQGXS9h+14ExZXDlY2DXghTv2kfudL4GAul2+tD6w G1v1zsLTJ58Dl0UrzRRLHjGlNZ3isSP9fSDTSt00Bd/ss47uf6hEJM8j4oQkOsdS9unz V47F7v2FwqTzGNiSNGrvl1Q/3vctMTH5H6mlYUvCsVLYMUX6XjNpWAbEaRYj26+TUVlf sZMw== X-Gm-Message-State: AOAM532P5z1CGbwxMeZ/a6m7DuO9vW1H8WPHRq3Vl297PAQhr5ENcndp SK1IKPacg3cT+BEv98KYIbzOGw== X-Google-Smtp-Source: ABdhPJyuOEXmaCM+TGYzMuW7Y5FKOpp4wnpTdqH3IdxX/TQTz9aynuGEL16s1B6g9wYjmkjo8JDYfA== X-Received: by 2002:a5d:54c7:: with SMTP id x7mr5939815wrv.77.1627577572042; Thu, 29 Jul 2021 09:52:52 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:293a:bc89:7514:5218]) by smtp.gmail.com with ESMTPSA id j1sm9301709wmo.4.2021.07.29.09.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 09:52:51 -0700 (PDT) Date: Thu, 29 Jul 2021 17:52:49 +0100 From: Quentin Perret To: David Brazdil Cc: kvmarm@lists.cs.columbia.edu, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: arm64: Fix off-by-one in range_is_memory Message-ID: References: <20210728153232.1018911-1-dbrazdil@google.com> <20210728153232.1018911-2-dbrazdil@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728153232.1018911-2-dbrazdil@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 28 Jul 2021 at 15:32:31 (+0000), David Brazdil wrote: > Hyp checks whether an address range only covers RAM by checking the > start/endpoints against a list of memblock_region structs. However, > the endpoint here is exclusive but internally is treated as inclusive. > Fix the off-by-one error that caused valid address ranges to be > rejected. > > Cc: Quentin Perret > Fixes: 90134ac9cabb6 ("KVM: arm64: Protect the .hyp sections from the host") > Signed-off-by: David Brazdil > --- > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > index d938ce95d3bd..a6ce991b1467 100644 > --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c > +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > @@ -193,7 +193,7 @@ static bool range_is_memory(u64 start, u64 end) > { > struct kvm_mem_range r1, r2; > > - if (!find_mem_range(start, &r1) || !find_mem_range(end, &r2)) > + if (!find_mem_range(start, &r1) || !find_mem_range(end - 1, &r2)) > return false; > if (r1.start != r2.start) > return false; Looks good to me: Reviewed-by: Quentin Perret Thanks, Quentin