Re: [PATCH 1/2] ftrace: Introduce ftrace_need_init_nop()

[Heiko Carstens <hca@linux.ibm.com>]

On Fri, Jul 30, 2021 at 10:07:41PM -0400, Steven Rostedt wrote:
> On Wed, 28 Jul 2021 23:25:45 +0200
> Ilya Leoshkevich <iii@linux.ibm.com> wrote:
> 
> > Implementing live patching on s390 requires each function's prologue to
> > contain a very special kind of nop, which gcc and clang don't generate.
> > However, the current code assumes that if CC_USING_NOP_MCOUNT is
> > defined, then whatever the compiler generates is good enough.
> > 
> > Move the CC_USING_NOP_MCOUNT check into the new ftrace_need_init_nop()
> > macro, that the architectures can override.
> > 
> > An alternative solution is to disable using -mnop-mcount in the
> > Makefile, however, this makes the build logic (even) more complicated
> > and forces the arch-specific code to deal with the useless __fentry__
> > symbol.
> > 
> > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> 
> I'm fine with this patch, and also you taking it in via the s390 tree.
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Thanks a lot!