All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Luigi Rizzo <lrizzo@google.com>
Cc: Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org,
	David Rientjes <rientjes@google.com>,
	rizzo.unipi@gmail.com,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page_fault()
Date: Mon, 2 Aug 2021 16:13:27 +0200	[thread overview]
Message-ID: <YQf9h+qvWCx6D7XT@8bytes.org> (raw)
In-Reply-To: <20210731192637.3653796-1-lrizzo@google.com>

On Sat, Jul 31, 2021 at 12:26:37PM -0700, Luigi Rizzo wrote:
> amd_iommu_report_page_fault() has two print paths, depending on whether or
> not it can find a pci device. But the code erroneously enters the second
> path if the rate limiter in the first path triggers:
>   if (dev_data && ratelimit(A)) { A; } else if (ratelimit(B)) { B; }
> The correct code should be
>   if (dev_data) { if (ratelimit(A)) { A;} } else if (ratelimit(B)) { B; }
> 
> Signed-off-by: Luigi Rizzo <lrizzo@google.com>
> ---
>  drivers/iommu/amd/iommu.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Thanks, but I queued this patch already:

	https://lore.kernel.org/r/YPgk1dD1gPMhJXgY@wantstofly.org

Regards,

	Joerg


  parent reply	other threads:[~2021-08-02 14:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 19:26 [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page_fault() Luigi Rizzo
2021-08-02  3:52 ` David Rientjes
2021-08-02 14:13 ` Joerg Roedel [this message]
2021-08-02 14:30   ` Luigi Rizzo
2021-08-02 14:38     ` Joerg Roedel
2021-08-02 15:26       ` Luigi Rizzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQf9h+qvWCx6D7XT@8bytes.org \
    --to=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrizzo@google.com \
    --cc=rientjes@google.com \
    --cc=rizzo.unipi@gmail.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.