From: Lee Jones <lee.jones@linaro.org>
To: Alistair Francis <alistair23@gmail.com>
Cc: Alistair Francis <alistair@alistair23.me>,
Rob Herring <robh+dt@kernel.org>,
lgirdwood@gmail.com, Mark Brown <broonie@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 1/6] mfd: sy7636a: Initial commit
Date: Mon, 2 Aug 2021 11:23:26 +0100 [thread overview]
Message-ID: <YQfHnlwDbkI1J130@google.com> (raw)
In-Reply-To: <CAKmqyKO_MEFy-TWy2+3o3+pomQaSQ5WeAcE3Zy-iquas09RfRA@mail.gmail.com>
On Mon, 02 Aug 2021, Alistair Francis wrote:
> On Wed, Jul 21, 2021 at 12:53 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Thu, 08 Jul 2021, Alistair Francis wrote:
> >
> > > Initial support for the Silergy SY7636A Power Management chip.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > ---
> > > drivers/mfd/Kconfig | 9 +++++
> > > drivers/mfd/Makefile | 1 +
> > > drivers/mfd/sy7636a.c | 81 +++++++++++++++++++++++++++++++++++++
> > > include/linux/mfd/sy7636a.h | 47 +++++++++++++++++++++
> > > 4 files changed, 138 insertions(+)
> > > create mode 100644 drivers/mfd/sy7636a.c
> > > create mode 100644 include/linux/mfd/sy7636a.h
[...]
> > > +struct sy7636a {
> > > + struct device *dev;
> > > + struct regmap *regmap;
> > > + struct gpio_desc *pgood_gpio;
> >
> > This looks unused?
>
> It is used in the syy636a-regulator
If it's only used in one driver, please declare it there.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-08-02 10:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 11:57 [PATCH v7 1/6] mfd: sy7636a: Initial commit Alistair Francis
2021-07-08 11:58 ` [PATCH v7 2/6] thermal: sy7636a: Add thermal driver for sy7636a Alistair Francis
2021-07-20 15:02 ` Lee Jones
2021-07-28 8:23 ` Alistair Francis
2021-08-02 7:55 ` Lee Jones
2021-08-14 11:08 ` Daniel Lezcano
2021-07-08 11:58 ` [PATCH v7 3/6] hwmon: sy7636a: Add temperature " Alistair Francis
2021-07-20 14:59 ` Lee Jones
2021-08-02 9:48 ` Alistair Francis
2021-07-08 11:58 ` [PATCH v7 4/6] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a Alistair Francis
2021-07-08 11:58 ` [PATCH v7 5/6] ARM: dts: imx7d: remarkable2: " Alistair Francis
2021-07-08 11:58 ` [PATCH v7 6/6] ARM: dts: imx7d: remarkable2: Enable lcdif Alistair Francis
2021-07-20 14:53 ` [PATCH v7 1/6] mfd: sy7636a: Initial commit Lee Jones
2021-07-20 15:23 ` Mark Brown
2021-07-20 16:09 ` Lee Jones
2021-07-20 20:26 ` Mark Brown
2021-07-30 6:21 ` Alistair Francis
2021-07-30 11:13 ` Mark Brown
2021-08-02 9:26 ` Alistair Francis
2021-08-02 10:23 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQfHnlwDbkI1J130@google.com \
--to=lee.jones@linaro.org \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.