From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Gal Hammer <ghammer@redhat.com>
Cc: virtio-fs@redhat.com
Subject: Re: [Virtio-fs] Deleting files when using NFS as a shared folder
Date: Mon, 2 Aug 2021 11:36:37 +0100 [thread overview]
Message-ID: <YQfKtddIodKSx7NZ@work-vm> (raw)
In-Reply-To: <CAA2ifQwwtNQwChMKUSM=6B+XEtdcf+Y--a0OxSwE2pmnd+6TAg@mail.gmail.com>
* Gal Hammer (ghammer@redhat.com) wrote:
> Hello,
>
> When using NFS as a shared folder (mount type nfs4) with a Linux guest I
> have the following issue:
>
> Guest:
> $ ls -la /mnt/shared
> total 8
> drwxr-xrwx. 2 135 135 4096 Aug 2 13:08 .
> dr-xr-xr-x. 17 root root 224 May 23 10:58 ..
> -rw-r--rw-. 1 135 135 27 Aug 2 13:07 readme.txt
>
> Host:
> $ rm readme.txt
>
> Guest:
> $ ls -la /mnt/shared
> total 8
> drwxr-xrwx. 2 135 135 4096 Aug 2 13:10 .
> dr-xr-xr-x. 17 root root 224 May 23 10:58 ..
> -rw-r--rw-. 1 135 135 27 Aug 2 13:07 .nfs0000000001b600d000000005
>
> Guest:
> $ cat /mnt/shared/readme.txt
> This is a readme.txt file.
>
> So it seems that the virtiofsd has a reference to the file which the guest
> is not aware of and is unable to send a FUSE_FORGET message. This results
> in a file not actually deleted (renamed to .nfsXXX) and is still accessible
> by the guest.
>
> I have a similar problem when deleting a file from a Windows guest side.
> The FUSE_READDIR(PLUS) commands add a reference count to files which the OS
> doesn't have a file context for. However I was able to solve it (for now?)
> by keeping track of returned files' inodes.
>
> Is this behaviour current and by design?
Current problem, not really by design; the problem is the O_PATH files
that we have open for the inodes. I thought if the guest sent the
forget for the file then it got closed.
Dave
> Thanks,
>
> Gal.
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://listman.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-08-02 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 10:18 [Virtio-fs] Deleting files when using NFS as a shared folder Gal Hammer
2021-08-02 10:36 ` Dr. David Alan Gilbert [this message]
2021-08-02 10:44 ` Gal Hammer
2021-08-02 10:49 ` Max Reitz
2021-08-02 11:30 ` Gal Hammer
2021-08-02 16:34 ` Max Reitz
2021-08-02 21:15 ` Vivek Goyal
2021-08-04 9:08 ` Gal Hammer
2021-08-04 13:35 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQfKtddIodKSx7NZ@work-vm \
--to=dgilbert@redhat.com \
--cc=ghammer@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.