From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC63C4320A for ; Tue, 3 Aug 2021 16:21:26 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D17660F8F for ; Tue, 3 Aug 2021 16:21:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D17660F8F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 15F1D40284; Tue, 3 Aug 2021 16:21:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id co2Hakczy0w0; Tue, 3 Aug 2021 16:21:25 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id BA34940502; Tue, 3 Aug 2021 16:21:24 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9F1A0C0010; Tue, 3 Aug 2021 16:21:24 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 42292C000E for ; Tue, 3 Aug 2021 16:21:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 31E69835FB for ; Tue, 3 Aug 2021 16:21:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id loFqvzUIuWir for ; Tue, 3 Aug 2021 16:21:22 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by smtp1.osuosl.org (Postfix) with ESMTPS id 762FE835E9 for ; Tue, 3 Aug 2021 16:21:22 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id dad9e189-f476-11eb-9082-0050568c148b; Tue, 03 Aug 2021 16:21:28 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 5F66C194B70; Tue, 3 Aug 2021 18:21:45 +0200 (CEST) Date: Tue, 3 Aug 2021 18:21:18 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH 00/11] Provide offset-adjusted framebuffer mappings Message-ID: References: <20210803125928.27780-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210803125928.27780-1-tzimmermann@suse.de> Cc: linux-hyperv@vger.kernel.org, rodrigosiqueiramelo@gmail.com, hdegoede@redhat.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, virtualization@lists.linux-foundation.org, melissa.srw@gmail.com, drawat.floss@gmail.com, noralf@tronnes.org, daniel@ffwll.ch, airlied@redhat.com, sean@poorly.run X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Hi Thomas, On Tue, Aug 03, 2021 at 02:59:17PM +0200, Thomas Zimmermann wrote: > A framebuffer's offsets field might be non-zero to make the BO data > start at the specified offset within the BO's memory. Handle this > case in drm_gem_fb_vmap() and update all callers. So far, many drivers > ignore the offsets, which can lead to visual artifacts. > > Patch 1 adds an optional argument to drm_gem_fb_vmap() to return the > offset-adjusted data address for use with shadow-buffered planes. > > Patches 3 and 11 convert gud and vkms, which are the other callers of > drm_gem_fb_vmap(). For gud, it's just a cleanup. Vkms will handle the > framebuffer offsets correctly for its input and output framebuffers. > > The other patches convert users of shadow-buffered planes to use the > data address. After conversion, each driver will use the correct data > for non-zero offsets. > > drm/ast: Use offset-adjusted shadow-plane mappings > drm/gud: Get offset-adjusted mapping from drm_gem_fb_vmap() > drm/hyperv: Use offset-adjusted shadow-plane mappings > drm/mgag200: Use offset-adjusted shadow-plane mappings > drm/cirrus: Use offset-adjusted shadow-plane mappings > drm/gm12u320: Use offset-adjusted shadow-plane mappings > drm/simpledrm: Use offset-adjusted shadow-plane mapping > drm/udl: Use offset-adjusted shadow-plane mapping > drm/vbox: Use offset-adjusted shadow-plane mappings > drm/vkms: Use offset-adjusted shadow-plane mappings and output Everything looked good while reading through the patches. I cannot say if everything was properly converted but the patches looked good. So they are all: Acked-by: Sam Ravnborg There was a few TODO comments visible aboput using the mapping api properly. I assume this is coming in a later patch set.. Sam _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AEFAC4338F for ; Tue, 3 Aug 2021 16:21:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6BFC60EFD for ; Tue, 3 Aug 2021 16:21:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B6BFC60EFD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 33209883A9; Tue, 3 Aug 2021 16:21:24 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id 493436E88A for ; Tue, 3 Aug 2021 16:21:22 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id dad9e189-f476-11eb-9082-0050568c148b; Tue, 03 Aug 2021 16:21:28 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 5F66C194B70; Tue, 3 Aug 2021 18:21:45 +0200 (CEST) Date: Tue, 3 Aug 2021 18:21:18 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Thomas Zimmermann Cc: airlied@redhat.com, airlied@linux.ie, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, noralf@tronnes.org, drawat.floss@gmail.com, kraxel@redhat.com, hdegoede@redhat.com, sean@poorly.run, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, dri-devel@lists.freedesktop.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 00/11] Provide offset-adjusted framebuffer mappings Message-ID: References: <20210803125928.27780-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210803125928.27780-1-tzimmermann@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas, On Tue, Aug 03, 2021 at 02:59:17PM +0200, Thomas Zimmermann wrote: > A framebuffer's offsets field might be non-zero to make the BO data > start at the specified offset within the BO's memory. Handle this > case in drm_gem_fb_vmap() and update all callers. So far, many drivers > ignore the offsets, which can lead to visual artifacts. > > Patch 1 adds an optional argument to drm_gem_fb_vmap() to return the > offset-adjusted data address for use with shadow-buffered planes. > > Patches 3 and 11 convert gud and vkms, which are the other callers of > drm_gem_fb_vmap(). For gud, it's just a cleanup. Vkms will handle the > framebuffer offsets correctly for its input and output framebuffers. > > The other patches convert users of shadow-buffered planes to use the > data address. After conversion, each driver will use the correct data > for non-zero offsets. > > drm/ast: Use offset-adjusted shadow-plane mappings > drm/gud: Get offset-adjusted mapping from drm_gem_fb_vmap() > drm/hyperv: Use offset-adjusted shadow-plane mappings > drm/mgag200: Use offset-adjusted shadow-plane mappings > drm/cirrus: Use offset-adjusted shadow-plane mappings > drm/gm12u320: Use offset-adjusted shadow-plane mappings > drm/simpledrm: Use offset-adjusted shadow-plane mapping > drm/udl: Use offset-adjusted shadow-plane mapping > drm/vbox: Use offset-adjusted shadow-plane mappings > drm/vkms: Use offset-adjusted shadow-plane mappings and output Everything looked good while reading through the patches. I cannot say if everything was properly converted but the patches looked good. So they are all: Acked-by: Sam Ravnborg There was a few TODO comments visible aboput using the mapping api properly. I assume this is coming in a later patch set.. Sam