All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libqrtr-glib: add gobject-introspection optional dependency
Date: Thu, 5 Aug 2021 05:46:29 +0200	[thread overview]
Message-ID: <YQtfFVbauf2h6naz@pevik> (raw)
In-Reply-To: <20210804204442.1466003-1-fontaine.fabrice@gmail.com>

Hi Fabrice,

> gobject-introspection is an optional dependency (enabled by default)
> since the addition of the package in commit
> ea64e05a1bfbe3b258a69013462f94d7db7a9c0b

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libqrtr-glib/libqrtr-glib.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

> diff --git a/package/libqrtr-glib/libqrtr-glib.mk b/package/libqrtr-glib/libqrtr-glib.mk
> index b9fc5cf3ba..6ab8335417 100644
> --- a/package/libqrtr-glib/libqrtr-glib.mk
> +++ b/package/libqrtr-glib/libqrtr-glib.mk
> @@ -12,4 +12,11 @@ LIBQRTR_GLIB_LICENSE_FILES = COPYING.LIB
>  LIBQRTR_GLIB_INSTALL_STAGING = YES
>  LIBQRTR_GLIB_DEPENDENCIES = libglib2

> +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> +LIBQRTR_GLIB_CONF_OPTS += --enable-introspection
> +LIBQRTR_GLIB_DEPENDENCIES += gobject-introspection
> +else
> +LIBQRTR_GLIB_CONF_OPTS += --disable-introspection
> +endif
> +
>  $(eval $(autotools-package))

Thanks a lot for fixing it!
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-05  3:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 20:44 [Buildroot] [PATCH 1/1] package/libqrtr-glib: add gobject-introspection optional dependency Fabrice Fontaine
2021-08-05  3:46 ` Petr Vorel [this message]
2021-08-05 21:46 ` Thomas Petazzoni
2021-08-08 19:13 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQtfFVbauf2h6naz@pevik \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.