All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: remove RT_TRACE and DBG_88E prints from ioctl_linux.c
Date: Thu, 5 Aug 2021 13:08:08 +0200	[thread overview]
Message-ID: <YQvGmNUGjAqTMBU9@kroah.com> (raw)
In-Reply-To: <20210804141916.13832-1-martin@kaiser.cx>

On Wed, Aug 04, 2021 at 04:19:16PM +0200, Martin Kaiser wrote:
> We should use the standard mechanism for debug prints. Remove the
> prints that use driver-specific macros.
> 
> Remove all "IOL tests" from rtw_dbg_port as these tests don't make sense
> without a success/fail print at the end. (The rtl8723bs driver removed
> the tests as well.)
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> v2:
>  - remove IOL tests
> 
>  drivers/staging/r8188eu/os_dep/ioctl_linux.c | 851 +------------------
>  1 file changed, 33 insertions(+), 818 deletions(-)

Can you add this to the other series you are going to resend so I know
what is the latest to review?

thanks,

greg k-h

      reply	other threads:[~2021-08-05 11:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  7:39 [PATCH] staging: r8188eu: remove RT_TRACE and DBG_88E prints from ioctl_linux.c Martin Kaiser
2021-08-04 13:12 ` Dan Carpenter
2021-08-04 14:21   ` Martin Kaiser
2021-08-04 14:19 ` [PATCH v2] " Martin Kaiser
2021-08-05 11:08   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQvGmNUGjAqTMBU9@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.