From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5071CC4320A for ; Thu, 5 Aug 2021 18:54:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2874360F01 for ; Thu, 5 Aug 2021 18:54:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232591AbhHESys (ORCPT ); Thu, 5 Aug 2021 14:54:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241287AbhHESyq (ORCPT ); Thu, 5 Aug 2021 14:54:46 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49DCDC06179C for ; Thu, 5 Aug 2021 11:54:32 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id h14so7830902wrx.10 for ; Thu, 05 Aug 2021 11:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=GOrV3VP+r8pYdlSiWQTpaesHdYyjntzU0PvvHrN5y3GEyAm/V0Gk6/Q2DVPAjUOuHG cg9PKnXKTT6euec26ur9UeGp7ZJ1lMFf0XKNZ8JHvT1V9wtuX3S5sCHtymzoXEU9qj2q qvrLHR5Nn9+CzXn368JWDViQsPx0sYdfYo81GedinLwzH0j/KWAgMJ76cgcFRANa52Ap k/HeuXbl/H4MM5n9iS0qwck3lV1RsVGsi6ht6u6CHCiFHc0J5dQij11Gxp4rS/NpUOOz xuYYqbl/V2ElVpVt72G3YEr+BRDilwSbeYw+9JCFvZusmxJWVls+zLhfdxvvorH6XeKQ WnMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=ODhPMEq1fP9FJtGLFeIeIavIgFirjbCcI2H8i4gz/Wux++gk/ZnZXhPklGxvly8fuW ovQPXwlxHvFHLknE87fms2Hc9Nxc0tfOOUDCuV0KynP8W0O0omtyo8sQZraSTCs+BHUj NZwowQLAtWOjYj1M1Hq7NkGKsC7JqJrq37pcEqDOtq4aIS4iPrAbNvST0jJdpRtrCguo B4cKKMXKX5GyCPy200ayazenQvIaE6EmbxlDNwNJ1y8P1pQV+y3OxhrsH9VatshUqbjD CNWTV0nHEhoprKI3i/N8Z2rmnPIKQNtpOSGlu1Hxn8wkW1DqcRgPJUM6UQ6UyFRoXTcV qeUg== X-Gm-Message-State: AOAM531aVPJb/Yam3safudcdYZQfkkv1AOe2Bf1TZ+3PtSYPAJA4mgh3 c+yuocVer0BjMI+GYXI4Cr46Bg== X-Google-Smtp-Source: ABdhPJwssE+mX4OXOdITg+L7JFPUjj2TqXmuwypTLByy6roZIhynzabMmSfypihLZgWIBDpfU85saA== X-Received: by 2002:a5d:5906:: with SMTP id v6mr6899987wrd.194.1628189670642; Thu, 05 Aug 2021 11:54:30 -0700 (PDT) Received: from google.com ([109.180.115.228]) by smtp.gmail.com with ESMTPSA id p5sm7799843wrd.25.2021.08.05.11.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 11:54:30 -0700 (PDT) Date: Thu, 5 Aug 2021 19:54:27 +0100 From: Lee Jones To: Greg Kroah-Hartman Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Vineet Gupta , Will Deacon , Guo Ren , Yoshinori Sato , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , John Crispin , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Rich Felker , "David S . Miller" , Jeff Dike , Richard Weinberger , Anton Ivanov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Chris Zankel , Max Filippov , Sebastian Reichel , linux-snps-arc@lists.infradead.org, linux-csky@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules Message-ID: References: <20210805075032.723037-1-lee.jones@linaro.org> <20210805075032.723037-2-lee.jones@linaro.org> <20210805173625.GH6719@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Thu, 05 Aug 2021, Greg Kroah-Hartman wrote: > On Thu, Aug 05, 2021 at 06:36:25PM +0100, Catalin Marinas wrote: > > On Thu, Aug 05, 2021 at 08:50:30AM +0100, Lee Jones wrote: > > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > > > index b4bb67f17a2ca..cf89ce91d7145 100644 > > > --- a/arch/arm64/kernel/process.c > > > +++ b/arch/arm64/kernel/process.c > > > @@ -212,6 +212,7 @@ void machine_restart(char *cmd) > > > printk("Reboot failed -- System halted\n"); > > > while (1); > > > } > > > +EXPORT_SYMBOL(machine_restart); > > > > Should we make this EXPORT_SYMBOL_GPL? I suppose it's not for general > > use by out of tree drivers and it matches the other pm_power_off symbol > > we export in this file. > > Yes please. Sure. Thanks for the feedback. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules Date: Thu, 5 Aug 2021 19:54:27 +0100 Message-ID: References: <20210805075032.723037-1-lee.jones@linaro.org> <20210805075032.723037-2-lee.jones@linaro.org> <20210805173625.GH6719@arm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=GOrV3VP+r8pYdlSiWQTpaesHdYyjntzU0PvvHrN5y3GEyAm/V0Gk6/Q2DVPAjUOuHG cg9PKnXKTT6euec26ur9UeGp7ZJ1lMFf0XKNZ8JHvT1V9wtuX3S5sCHtymzoXEU9qj2q qvrLHR5Nn9+CzXn368JWDViQsPx0sYdfYo81GedinLwzH0j/KWAgMJ76cgcFRANa52Ap k/HeuXbl/H4MM5n9iS0qwck3lV1RsVGsi6ht6u6CHCiFHc0J5dQij11Gxp4rS/NpUOOz xuYYqbl/V2ElVpVt72G3YEr+BRDilwSbeYw+9JCFvZusmxJWVls+zLhfdxvvorH6XeKQ WnMQ== Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="utf-8" To: Greg Kroah-Hartman Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Vineet Gupta , Will Deacon , Guo Ren , Yoshinori Sato , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , John Crispin , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Paul Walmsley <> On Thu, 05 Aug 2021, Greg Kroah-Hartman wrote: > On Thu, Aug 05, 2021 at 06:36:25PM +0100, Catalin Marinas wrote: > > On Thu, Aug 05, 2021 at 08:50:30AM +0100, Lee Jones wrote: > > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > > > index b4bb67f17a2ca..cf89ce91d7145 100644 > > > --- a/arch/arm64/kernel/process.c > > > +++ b/arch/arm64/kernel/process.c > > > @@ -212,6 +212,7 @@ void machine_restart(char *cmd) > > > printk("Reboot failed -- System halted\n"); > > > while (1); > > > } > > > +EXPORT_SYMBOL(machine_restart); > > > > Should we make this EXPORT_SYMBOL_GPL? I suppose it's not for general > > use by out of tree drivers and it matches the other pm_power_off symbol > > we export in this file. > > Yes please. Sure. Thanks for the feedback. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240F5C4338F for ; Thu, 5 Aug 2021 18:54:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D63B660F01 for ; Thu, 5 Aug 2021 18:54:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D63B660F01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VzXuIrs5wKwFlnBzsDXp/qAj7eQwOFworQxmtj0haro=; b=r8zwuSZlC+FU91 C1X3/k6IGAYIt8cgH4TAiCj39x259Btn5jcCgSxSvYRzTjOCodDRF5FcaqnKslub3/ePa352Fr8SN EiqZuxWUS0Vstjyls1aD9uqB3WNIVwG0ZyugB6net2IJtGGe+V02fNYQlIUG7GAcf8rK0PLcDj/ZZ Xm+9Vi7MCWkT7/te2VE9DUrzMFs+H9RCwbC4IX/DLMH5dN5GGr/sU7qUAzgiAAazLR52kaZ/ct2vP 6W+/9906dk/A3RG7ANhvaZbiePXQxIhSSS3whRg2Z/lL1yqpLrhqeVyAgXnBqclB09GoauYmDeKoH JKGRF1agbPki/4z+U3rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBiVo-00AZ4K-O2; Thu, 05 Aug 2021 18:54:36 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBiVl-00AZ2i-QD for linux-riscv@lists.infradead.org; Thu, 05 Aug 2021 18:54:35 +0000 Received: by mail-wr1-x42b.google.com with SMTP id n12so7873405wrr.2 for ; Thu, 05 Aug 2021 11:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=GOrV3VP+r8pYdlSiWQTpaesHdYyjntzU0PvvHrN5y3GEyAm/V0Gk6/Q2DVPAjUOuHG cg9PKnXKTT6euec26ur9UeGp7ZJ1lMFf0XKNZ8JHvT1V9wtuX3S5sCHtymzoXEU9qj2q qvrLHR5Nn9+CzXn368JWDViQsPx0sYdfYo81GedinLwzH0j/KWAgMJ76cgcFRANa52Ap k/HeuXbl/H4MM5n9iS0qwck3lV1RsVGsi6ht6u6CHCiFHc0J5dQij11Gxp4rS/NpUOOz xuYYqbl/V2ElVpVt72G3YEr+BRDilwSbeYw+9JCFvZusmxJWVls+zLhfdxvvorH6XeKQ WnMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=O2cd8VVdWj/AbFMJbXJJt6krUd/sLjjK4OE6FKzozTSzj9/Ddm0lAE96fuhH67+3PQ LGfU+GVnahW7TtRCdALNmoPOo0l5y8cdROKE0fjBESmIiJoxrlXUaq5p4CjWvbDw2JPB Cxmow8KQEnVeeOW7YB2282VHXs2OvjQ9mpyzO6vm6AW6ZZdSFo7cQJipKCy5U2nAC3BO dDyx/dYAF4GKPVYwix1B0trBA9p0ghvfSxV/8o//kK46GVsNMxJ9VjtwHh25XfJv3NH5 kIV3vJlH73zEdkz5mcCPwLwHD8BRwa1CQr2BZngvdbJnXkkeSZ8weTR33rl3yxXLR5z+ 4hJg== X-Gm-Message-State: AOAM532JZjxswF3qVkXtCmzoi+gQWYOtlQ4ODhXavXV7iLSJ+X12N8we yaamGhe5Lu15upA6pWaSL9SnWA== X-Google-Smtp-Source: ABdhPJwssE+mX4OXOdITg+L7JFPUjj2TqXmuwypTLByy6roZIhynzabMmSfypihLZgWIBDpfU85saA== X-Received: by 2002:a5d:5906:: with SMTP id v6mr6899987wrd.194.1628189670642; Thu, 05 Aug 2021 11:54:30 -0700 (PDT) Received: from google.com ([109.180.115.228]) by smtp.gmail.com with ESMTPSA id p5sm7799843wrd.25.2021.08.05.11.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 11:54:30 -0700 (PDT) Date: Thu, 5 Aug 2021 19:54:27 +0100 From: Lee Jones To: Greg Kroah-Hartman Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Vineet Gupta , Will Deacon , Guo Ren , Yoshinori Sato , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , John Crispin , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Rich Felker , "David S . Miller" , Jeff Dike , Richard Weinberger , Anton Ivanov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Chris Zankel , Max Filippov , Sebastian Reichel , linux-snps-arc@lists.infradead.org, linux-csky@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules Message-ID: References: <20210805075032.723037-1-lee.jones@linaro.org> <20210805075032.723037-2-lee.jones@linaro.org> <20210805173625.GH6719@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_115433_884635_17F873F7 X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwNSBBdWcgMjAyMSwgR3JlZyBLcm9haC1IYXJ0bWFuIHdyb3RlOgoKPiBPbiBUaHUs IEF1ZyAwNSwgMjAyMSBhdCAwNjozNjoyNVBNICswMTAwLCBDYXRhbGluIE1hcmluYXMgd3JvdGU6 Cj4gPiBPbiBUaHUsIEF1ZyAwNSwgMjAyMSBhdCAwODo1MDozMEFNICswMTAwLCBMZWUgSm9uZXMg d3JvdGU6Cj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2tlcm5lbC9wcm9jZXNzLmMgYi9h cmNoL2FybTY0L2tlcm5lbC9wcm9jZXNzLmMKPiA+ID4gaW5kZXggYjRiYjY3ZjE3YTJjYS4uY2Y4 OWNlOTFkNzE0NSAxMDA2NDQKPiA+ID4gLS0tIGEvYXJjaC9hcm02NC9rZXJuZWwvcHJvY2Vzcy5j Cj4gPiA+ICsrKyBiL2FyY2gvYXJtNjQva2VybmVsL3Byb2Nlc3MuYwo+ID4gPiBAQCAtMjEyLDYg KzIxMiw3IEBAIHZvaWQgbWFjaGluZV9yZXN0YXJ0KGNoYXIgKmNtZCkKPiA+ID4gIAlwcmludGso IlJlYm9vdCBmYWlsZWQgLS0gU3lzdGVtIGhhbHRlZFxuIik7Cj4gPiA+ICAJd2hpbGUgKDEpOwo+ ID4gPiAgfQo+ID4gPiArRVhQT1JUX1NZTUJPTChtYWNoaW5lX3Jlc3RhcnQpOwo+ID4gCj4gPiBT aG91bGQgd2UgbWFrZSB0aGlzIEVYUE9SVF9TWU1CT0xfR1BMPyBJIHN1cHBvc2UgaXQncyBub3Qg Zm9yIGdlbmVyYWwKPiA+IHVzZSBieSBvdXQgb2YgdHJlZSBkcml2ZXJzIGFuZCBpdCBtYXRjaGVz IHRoZSBvdGhlciBwbV9wb3dlcl9vZmYgc3ltYm9sCj4gPiB3ZSBleHBvcnQgaW4gdGhpcyBmaWxl Lgo+IAo+IFllcyBwbGVhc2UuCgpTdXJlLgoKVGhhbmtzIGZvciB0aGUgZmVlZGJhY2suCgotLSAK TGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBT ZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MK Rm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0 CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2591FC4338F for ; Thu, 5 Aug 2021 18:54:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E085C60F3A for ; Thu, 5 Aug 2021 18:54:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E085C60F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7D5ScfJ8CiqJEmccO6P0dSoaUxJLn0V3U1lU7mrpopY=; b=c7EPLh9Dv9WIee +R9EaqFjfztx6MwktJq0liIrxExpMQsFcJiS9OBdLV1YJc35aBZh84r8qLSmAqNStQpVZtVvN71xZ khTy03JWb9Pqmu8slRtCZG+yiCflilrYC1xl1pfcsyNt54ArCx9DT/sZ4bE1bu+Yp5wAn/E0KD4Et bxgFr45lGx7dA7/jBrPDgcS2HV34CkDI/pLjwYlFZ2fvrAm78RGeP+JRalzC0JOE2m0yFg6tBkTGY Tk9tA4BwOpqGn3mg4CYHJPYgp7hzgXHguo6zlDYU5XaQjD8RdKxU+ZyYZO87wlEczdI0JHTLByamp +KrEvC8DNNDkZVb1V/SQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBiVo-00AZ4C-Eh; Thu, 05 Aug 2021 18:54:36 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBiVl-00AZ2h-Pd for linux-snps-arc@lists.infradead.org; Thu, 05 Aug 2021 18:54:35 +0000 Received: by mail-wr1-x435.google.com with SMTP id p5so7882907wro.7 for ; Thu, 05 Aug 2021 11:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=GOrV3VP+r8pYdlSiWQTpaesHdYyjntzU0PvvHrN5y3GEyAm/V0Gk6/Q2DVPAjUOuHG cg9PKnXKTT6euec26ur9UeGp7ZJ1lMFf0XKNZ8JHvT1V9wtuX3S5sCHtymzoXEU9qj2q qvrLHR5Nn9+CzXn368JWDViQsPx0sYdfYo81GedinLwzH0j/KWAgMJ76cgcFRANa52Ap k/HeuXbl/H4MM5n9iS0qwck3lV1RsVGsi6ht6u6CHCiFHc0J5dQij11Gxp4rS/NpUOOz xuYYqbl/V2ElVpVt72G3YEr+BRDilwSbeYw+9JCFvZusmxJWVls+zLhfdxvvorH6XeKQ WnMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=OMf/THhRh9aBrkCMy9aNP7wvfeiKAbLKOy/SlHyao5FkhmedcfPe6KRCw+FKHpp3ng K4qCw8BpcTDSWWVG6T9NTzwvuB+lgdbI1tUrghC1rBmPr4iSld0n+nUYD1knhQtU27kk 85uaqSliYRcOeeBvIpMydzQJ4dXdKzR9oGYiiHqbHlfVD6Nyl6dpxpyKKOEKbG6QWFyW l2GHv67TYTsz3wJQQVVp053lyYSEkZdiMpqxuo15AOpNAN0ldJNdgoCf/OBspjRFx2UR n/2EDt6Id3YQk1bKtHvWq4rny6PcZCNfcWN5Cklc14X5Kyom7JJGE2ZabYekjh3OtzZq H4qA== X-Gm-Message-State: AOAM532lCzWgstQ+t/HG9KW0XkP/Q4n5VnQlIruYz51v9k1TC87WJlAP LE2SSLLu4oKQMfSP0bTCTvJrpg== X-Google-Smtp-Source: ABdhPJwssE+mX4OXOdITg+L7JFPUjj2TqXmuwypTLByy6roZIhynzabMmSfypihLZgWIBDpfU85saA== X-Received: by 2002:a5d:5906:: with SMTP id v6mr6899987wrd.194.1628189670642; Thu, 05 Aug 2021 11:54:30 -0700 (PDT) Received: from google.com ([109.180.115.228]) by smtp.gmail.com with ESMTPSA id p5sm7799843wrd.25.2021.08.05.11.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 11:54:30 -0700 (PDT) Date: Thu, 5 Aug 2021 19:54:27 +0100 From: Lee Jones To: Greg Kroah-Hartman Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Vineet Gupta , Will Deacon , Guo Ren , Yoshinori Sato , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , John Crispin , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E . J . Bottomley" , Helge Deller , Michael Ellerman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Rich Felker , "David S . Miller" , Jeff Dike , Richard Weinberger , Anton Ivanov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Chris Zankel , Max Filippov , Sebastian Reichel , linux-snps-arc@lists.infradead.org, linux-csky@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules Message-ID: References: <20210805075032.723037-1-lee.jones@linaro.org> <20210805075032.723037-2-lee.jones@linaro.org> <20210805173625.GH6719@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_115433_864779_26A4BD8E X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwNSBBdWcgMjAyMSwgR3JlZyBLcm9haC1IYXJ0bWFuIHdyb3RlOgoKPiBPbiBUaHUs IEF1ZyAwNSwgMjAyMSBhdCAwNjozNjoyNVBNICswMTAwLCBDYXRhbGluIE1hcmluYXMgd3JvdGU6 Cj4gPiBPbiBUaHUsIEF1ZyAwNSwgMjAyMSBhdCAwODo1MDozMEFNICswMTAwLCBMZWUgSm9uZXMg d3JvdGU6Cj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2tlcm5lbC9wcm9jZXNzLmMgYi9h cmNoL2FybTY0L2tlcm5lbC9wcm9jZXNzLmMKPiA+ID4gaW5kZXggYjRiYjY3ZjE3YTJjYS4uY2Y4 OWNlOTFkNzE0NSAxMDA2NDQKPiA+ID4gLS0tIGEvYXJjaC9hcm02NC9rZXJuZWwvcHJvY2Vzcy5j Cj4gPiA+ICsrKyBiL2FyY2gvYXJtNjQva2VybmVsL3Byb2Nlc3MuYwo+ID4gPiBAQCAtMjEyLDYg KzIxMiw3IEBAIHZvaWQgbWFjaGluZV9yZXN0YXJ0KGNoYXIgKmNtZCkKPiA+ID4gIAlwcmludGso IlJlYm9vdCBmYWlsZWQgLS0gU3lzdGVtIGhhbHRlZFxuIik7Cj4gPiA+ICAJd2hpbGUgKDEpOwo+ ID4gPiAgfQo+ID4gPiArRVhQT1JUX1NZTUJPTChtYWNoaW5lX3Jlc3RhcnQpOwo+ID4gCj4gPiBT aG91bGQgd2UgbWFrZSB0aGlzIEVYUE9SVF9TWU1CT0xfR1BMPyBJIHN1cHBvc2UgaXQncyBub3Qg Zm9yIGdlbmVyYWwKPiA+IHVzZSBieSBvdXQgb2YgdHJlZSBkcml2ZXJzIGFuZCBpdCBtYXRjaGVz IHRoZSBvdGhlciBwbV9wb3dlcl9vZmYgc3ltYm9sCj4gPiB3ZSBleHBvcnQgaW4gdGhpcyBmaWxl Lgo+IAo+IFllcyBwbGVhc2UuCgpTdXJlLgoKVGhhbmtzIGZvciB0aGUgZmVlZGJhY2suCgotLSAK TGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBT ZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MK Rm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtc25wcy1hcmMgbWFpbGluZyBs aXN0CmxpbnV4LXNucHMtYXJjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1zbnBzLWFyYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CBB7C4338F for ; Thu, 5 Aug 2021 18:55:08 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BDB860F3A for ; Thu, 5 Aug 2021 18:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0BDB860F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Ggd8V302cz3dBb for ; Fri, 6 Aug 2021 04:55:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=GOrV3VP+; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::42f; helo=mail-wr1-x42f.google.com; envelope-from=lee.jones@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=GOrV3VP+; dkim-atps=neutral Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Ggd7y6l5Mz2yyM for ; Fri, 6 Aug 2021 04:54:38 +1000 (AEST) Received: by mail-wr1-x42f.google.com with SMTP id p5so7882903wro.7 for ; Thu, 05 Aug 2021 11:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=GOrV3VP+r8pYdlSiWQTpaesHdYyjntzU0PvvHrN5y3GEyAm/V0Gk6/Q2DVPAjUOuHG cg9PKnXKTT6euec26ur9UeGp7ZJ1lMFf0XKNZ8JHvT1V9wtuX3S5sCHtymzoXEU9qj2q qvrLHR5Nn9+CzXn368JWDViQsPx0sYdfYo81GedinLwzH0j/KWAgMJ76cgcFRANa52Ap k/HeuXbl/H4MM5n9iS0qwck3lV1RsVGsi6ht6u6CHCiFHc0J5dQij11Gxp4rS/NpUOOz xuYYqbl/V2ElVpVt72G3YEr+BRDilwSbeYw+9JCFvZusmxJWVls+zLhfdxvvorH6XeKQ WnMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=QuWQp/Skt59tuai2KoBozlSa/fdGugT1P09CZa0u6xp4iyYsuXEfX/qQreqd2nG5wR u244DFtXLU60pbBWyquj/xlQCNEH/kYqXyJ0mSvqLjgicQMctaj8azsB7x2PY7zsU5m3 TgSM+curLv8aF9+EOrid+uvZxUDBxE4DHFfWP27lkOAOpF0FG60dGMZpnI4w+yhuuca5 5uaAqs6W5Z7R92uW9SV3aAgS43Ep8kwwPhbgtwGGN/7fh+fjW64SPndDTJjJltOH86ht IRpBxBLJhbBVfI1jtGupaGkrH7MWwkJBpP3l00obXZYzGyzYjw5xXZDMUPPWm4UBUh0+ 5uZw== X-Gm-Message-State: AOAM530JzRuwjLxJPTYPn2jcFpTwXDxCcBbQXpgBZDJGZDlvhgJ3W5NF QTDNb3oqP5rXUYudSvNqTSv1PA== X-Google-Smtp-Source: ABdhPJwssE+mX4OXOdITg+L7JFPUjj2TqXmuwypTLByy6roZIhynzabMmSfypihLZgWIBDpfU85saA== X-Received: by 2002:a5d:5906:: with SMTP id v6mr6899987wrd.194.1628189670642; Thu, 05 Aug 2021 11:54:30 -0700 (PDT) Received: from google.com ([109.180.115.228]) by smtp.gmail.com with ESMTPSA id p5sm7799843wrd.25.2021.08.05.11.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 11:54:30 -0700 (PDT) Date: Thu, 5 Aug 2021 19:54:27 +0100 From: Lee Jones To: Greg Kroah-Hartman Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules Message-ID: References: <20210805075032.723037-1-lee.jones@linaro.org> <20210805075032.723037-2-lee.jones@linaro.org> <20210805173625.GH6719@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-sh@vger.kernel.org, Catalin Marinas , Paul Walmsley , Sebastian Reichel , "James E . J . Bottomley" , Max Filippov , Guo Ren , linux-csky@vger.kernel.org, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , Thomas Gleixner , Anton Ivanov , Jonas Bonn , linux-s390@vger.kernel.org, Brian Cain , Helge Deller , Ley Foon Tan , Christian Borntraeger , Ingo Molnar , Geert Uytterhoeven , linux-snps-arc@lists.infradead.org, Jeff Dike , uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, Albert Ou , Vasily Gorbik , Heiko Carstens , linux-um@lists.infradead.org, Stefan Kristiansson , linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , John Crispin , Stafford Horne , linux-arm-kernel@lists.infradead.org, Chris Zankel , Michal Simek , Thomas Bogendoerfer , linux-mips@vger.kernel.org, Yoshinori Sato , linux-parisc@vger.kernel.org, Vineet Gupta , linux-kernel@vger.kernel.org, Palmer Dabbelt , Richard Weinberger , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 05 Aug 2021, Greg Kroah-Hartman wrote: > On Thu, Aug 05, 2021 at 06:36:25PM +0100, Catalin Marinas wrote: > > On Thu, Aug 05, 2021 at 08:50:30AM +0100, Lee Jones wrote: > > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > > > index b4bb67f17a2ca..cf89ce91d7145 100644 > > > --- a/arch/arm64/kernel/process.c > > > +++ b/arch/arm64/kernel/process.c > > > @@ -212,6 +212,7 @@ void machine_restart(char *cmd) > > > printk("Reboot failed -- System halted\n"); > > > while (1); > > > } > > > +EXPORT_SYMBOL(machine_restart); > > > > Should we make this EXPORT_SYMBOL_GPL? I suppose it's not for general > > use by out of tree drivers and it matches the other pm_power_off symbol > > we export in this file. > > Yes please. Sure. Thanks for the feedback. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog