From: Greg KH <gregkh@linuxfoundation.org>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
Cc: "andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"yury.norov@gmail.com" <yury.norov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"dave.hansen@intel.com" <dave.hansen@intel.com>,
"linux@rasmusvillemoes.dk" <linux@rasmusvillemoes.dk>,
"rafael@kernel.org" <rafael@kernel.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"agordeev@linux.ibm.com" <agordeev@linux.ibm.com>,
"sbrivio@redhat.com" <sbrivio@redhat.com>,
"jianpeng.ma@intel.com" <jianpeng.ma@intel.com>,
"valentin.schneider@arm.com" <valentin.schneider@arm.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"bristot@redhat.com" <bristot@redhat.com>,
"guodong.xu@linaro.org" <guodong.xu@linaro.org>,
tangchengchang <tangchengchang@huawei.com>,
"Zengtao (B)" <prime.zeng@hisilicon.com>,
yangyicong <yangyicong@huawei.com>,
"tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
Linuxarm <linuxarm@huawei.com>,
"tiantao (H)" <tiantao6@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH v8 1/5] cpumask: introduce cpumap_print_to_buf to support large bitmask and list
Date: Fri, 6 Aug 2021 06:46:54 +0200 [thread overview]
Message-ID: <YQy+voTd/Oknohx9@kroah.com> (raw)
In-Reply-To: <53c5fec4223f4c398b81362acf7441b5@hisilicon.com>
On Thu, Aug 05, 2021 at 11:05:59PM +0000, Song Bao Hua (Barry Song) wrote:
> > > +int bitmap_print_to_buf(bool list, char *buf, const unsigned long *maskp,
> > > + int nmaskbits, loff_t off, size_t count)
> >
> > No need to put the kernel doc for both the .h and .c file, only put it
> > in one place please (where ever it ties into the kernel documentation)
> >
>
> Actually they are two different modules. One is cpumap, the other one is
> bitmap. But they do have some duplicated content.
> I'd prefer to remove the duplicated part from cpumap.
Ah, I missed that they were two different functions, sorry. But yes,
removing duplication is good.
thanks,
greg k-h
next prev parent reply other threads:[~2021-08-06 4:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 5:42 [PATCH v8 0/5] use bin_attribute to break the size limitation of cpumap ABI Barry Song
2021-07-29 5:42 ` [PATCH v8 1/5] cpumask: introduce cpumap_print_to_buf to support large bitmask and list Barry Song
2021-08-05 12:52 ` Greg KH
2021-08-05 23:05 ` Song Bao Hua (Barry Song)
2021-08-06 4:46 ` Greg KH [this message]
2021-07-29 5:42 ` [PATCH v8 2/5] topology: use bin_attribute to break the size limitation of cpumap ABI Barry Song
2021-07-29 5:42 ` [PATCH v8 3/5] drivers/base/node.c: " Barry Song
2021-07-29 5:42 ` [PATCH v8 4/5] lib: test_bitmap: add bitmap_print_to_buf test cases Barry Song
2021-07-29 5:42 ` [PATCH v8 5/5] bitmap: extend comment to bitmap_print_to_buf Barry Song
2021-07-29 17:50 ` [PATCH v8 0/5] use bin_attribute to break the size limitation of cpumap ABI Andrew Morton
2021-07-30 5:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQy+voTd/Oknohx9@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bristot@redhat.com \
--cc=dave.hansen@intel.com \
--cc=guodong.xu@linaro.org \
--cc=jianpeng.ma@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxarm@huawei.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sbrivio@redhat.com \
--cc=song.bao.hua@hisilicon.com \
--cc=tangchengchang@huawei.com \
--cc=tiantao6@hisilicon.com \
--cc=tim.c.chen@linux.intel.com \
--cc=valentin.schneider@arm.com \
--cc=yangyicong@huawei.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.