From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Sergey Ryazanov <ryazanov.s.a@gmail.com>,
Network Development <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v1 1/1] wwan: core: Avoid returning error pointer from wwan_create_dev()
Date: Fri, 6 Aug 2021 12:07:51 +0300 [thread overview]
Message-ID: <YQz75yaecp016zOb@smile.fi.intel.com> (raw)
In-Reply-To: <CAMZdPi_+GpG8h2tJ1AxOj6HaPiXXDh6aC2RvO=+zXRy_AQpWkg@mail.gmail.com>
On Thu, Aug 05, 2021 at 09:53:57PM +0200, Loic Poulain wrote:
> On Thu, 5 Aug 2021 at 20:38, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > wwan_create_dev() is expected to return either valid pointer or NULL,
> > In some cases it might return the error pointer. Prevent this by converting
> > it to NULL after wwan_dev_get_by_parent().
>
> wwan_create_dev is called both from wwan_register_ops() and
> wwan_create_port(), one using IS_ERR and the other using NULL testing,
> they should be aligned as well.
Ah, good catch!
I just sent v2, but eventually I have decided to switch to error pointer since
it seems the most used pattern in the code.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-06 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 18:31 [PATCH v1 1/1] wwan: core: Avoid returning error pointer from wwan_create_dev() Andy Shevchenko
2021-08-05 19:53 ` Loic Poulain
2021-08-06 9:07 ` Andy Shevchenko [this message]
2021-08-06 9:13 ` Sergey Ryazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQz75yaecp016zOb@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.