From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CF672FAF for ; Wed, 18 Aug 2021 18:24:55 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 8fbb1805-0051-11ec-b37b-0050568c148b; Wed, 18 Aug 2021 18:24:44 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id CD104194B25; Wed, 18 Aug 2021 20:25:04 +0200 (CEST) Date: Wed, 18 Aug 2021 20:24:52 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Nikola Pavlica Cc: dri-devel@lists.freedesktop.org, thierry.reding@gmail.com, airlied@linux.ie, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: display: simple: Add Vivax TPC-9150 panel Message-ID: References: <20210818144648.72665-1-pavlica.nikola@gmail.com> <20210818144648.72665-2-pavlica.nikola@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818144648.72665-2-pavlica.nikola@gmail.com> Hi Nikola, On Wed, Aug 18, 2021 at 04:46:47PM +0200, Nikola Pavlica wrote: > This tablet display is unique and hence must be added to documentation. > Unfortunately, it's real make and number is not known due to obscure and > missing documentation and lack of writing on the display assembly > itself. > > So the natural alternative that came to mind is to name the panel after > the device that contained it (an Android tablet). Hopefully that isn't > an issue. > > I can confirm that the parameters that I've obtained are correct since > they came from a dump of the original Android OS. > > Signed-off-by: Nikola Pavlica Reviewed-by: Sam Ravnborg I like this to be *before* the patch to panel-simple.c, as we cannot apply the panel-simple.c patch before the compatible is documented. Or we can apply it, but checkpatch will complain and that will stop me applying. So in other words - reverse the order of the patches. Sam > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > index 62b0d54d87b7..d0efefa5a820 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > @@ -285,6 +285,8 @@ properties: > - urt,umsh-8596md-11t > - urt,umsh-8596md-19t > - urt,umsh-8596md-20t > + # Vivax TPC-9150 tablet 9.0" WSVGA TFT LCD panel > + - vivax,tpc9150-panel > # VXT 800x480 color TFT LCD panel > - vxt,vl050-8048nt-c01 > # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel > -- > 2.32.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D255C4338F for ; Wed, 18 Aug 2021 18:26:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9A7C60E90 for ; Wed, 18 Aug 2021 18:26:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E9A7C60E90 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zt/J4L7k7Yt5kfz+o/6c1gEW15PgsSpgzqYWFSWAoWA=; b=IdlyUmpg/OMH+w ymsFViGjGNc+60hugegIMlujGEa2Ny66X3Qmn8vzYLGPbiB8QrYPxmjCEga+5dVIaB4NWB7NB3qRn 4ZpazYY148CTjZWOCLij95ofEvyJFMFtMoXFIJG2ct2aHrX0U+g53V7NYvEW6QgBT/aQUWBSQfziq 3HMPTTcKl4gJRviSUnUp4/ZPyae94CwGoDMRKkXlUuSo/wN5gsG1BIZ/yVrBNx3O9Ab2xtgJlLqQ/ RYZqIGwly8bgT4HHI0twy6Lz846aZ2mzUPkUV0oLXH+AJ1G5c8wLJ4NmpIMYUWrNPnFJiFWi4aKHR 4iRY5ZUPibFa/qxmtuUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGQFI-006NxA-GL; Wed, 18 Aug 2021 18:25:00 +0000 Received: from mx1.smtp.larsendata.com ([91.221.196.215]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGQFD-006NvX-Nw for linux-arm-kernel@lists.infradead.org; Wed, 18 Aug 2021 18:24:57 +0000 Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 8fbb1805-0051-11ec-b37b-0050568c148b; Wed, 18 Aug 2021 18:24:44 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id CD104194B25; Wed, 18 Aug 2021 20:25:04 +0200 (CEST) Date: Wed, 18 Aug 2021 20:24:52 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Nikola Pavlica Cc: dri-devel@lists.freedesktop.org, thierry.reding@gmail.com, airlied@linux.ie, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: display: simple: Add Vivax TPC-9150 panel Message-ID: References: <20210818144648.72665-1-pavlica.nikola@gmail.com> <20210818144648.72665-2-pavlica.nikola@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210818144648.72665-2-pavlica.nikola@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_112455_962309_BAC82007 X-CRM114-Status: GOOD ( 21.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nikola, On Wed, Aug 18, 2021 at 04:46:47PM +0200, Nikola Pavlica wrote: > This tablet display is unique and hence must be added to documentation. > Unfortunately, it's real make and number is not known due to obscure and > missing documentation and lack of writing on the display assembly > itself. > > So the natural alternative that came to mind is to name the panel after > the device that contained it (an Android tablet). Hopefully that isn't > an issue. > > I can confirm that the parameters that I've obtained are correct since > they came from a dump of the original Android OS. > > Signed-off-by: Nikola Pavlica Reviewed-by: Sam Ravnborg I like this to be *before* the patch to panel-simple.c, as we cannot apply the panel-simple.c patch before the compatible is documented. Or we can apply it, but checkpatch will complain and that will stop me applying. So in other words - reverse the order of the patches. Sam > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > index 62b0d54d87b7..d0efefa5a820 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > @@ -285,6 +285,8 @@ properties: > - urt,umsh-8596md-11t > - urt,umsh-8596md-19t > - urt,umsh-8596md-20t > + # Vivax TPC-9150 tablet 9.0" WSVGA TFT LCD panel > + - vivax,tpc9150-panel > # VXT 800x480 color TFT LCD panel > - vxt,vl050-8048nt-c01 > # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel > -- > 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel