From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Yury Norov <yury.norov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] lib/vsprintf: don't increment buf in bitmap_list_string
Date: Thu, 19 Aug 2021 18:35:35 +0900 [thread overview]
Message-ID: <YR4l52k6oWrg7G9O@google.com> (raw)
In-Reply-To: <YR1o+/8E/FbW2xL8@yury-ThinkPad>
On (21/08/18 13:10), Yury Norov wrote:
> On Wed, Aug 18, 2021 at 12:36:51PM -0700, Andrew Morton wrote:
> > On Wed, 18 Aug 2021 12:17:18 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> > > On Tue, Aug 17, 2021 at 12:37:35PM -0700, Yury Norov wrote:
> > >
> > > Thanks!
> > >
> > > > Increment is confusing as the buf is overritten at the same line.
> > >
> > > > Fixes: b1c4af4d3d6b (vsprintf: rework bitmap_list_string) (next-20210817)
> > >
> > > Fixes tag has its special format. I don't think we need it here, just to ask
> > > Andrew in comments that it needs to be folded.
> >
> > I'm assuming that Sergey will be handling this one?
>
> This is a fix to recent bitmap series. If you fold-in into
> b1c4af4d3d6b, would be also OK.
This type of patches simpler to handle when they sent as a reply
to the patch they fix.
prev parent reply other threads:[~2021-08-19 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 19:37 [PATCH] lib/vsprintf: don't increment buf in bitmap_list_string Yury Norov
2021-08-18 9:17 ` Andy Shevchenko
2021-08-18 19:36 ` Andrew Morton
2021-08-18 20:10 ` Yury Norov
2021-08-19 9:35 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR4l52k6oWrg7G9O@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.