From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [COMMITTED] setsockopt08: includes netinet/in.h
Date: Fri, 20 Aug 2021 11:37:06 +0200 [thread overview]
Message-ID: <YR93wpTZMw9oT1O4@pevik> (raw)
In-Reply-To: <874kc2n8tx.fsf@suse.de>
> Hell Li,
> Li Wang <liwang@redhat.com> writes:
> >> > The conflict happened early in tst_test.h and I guess some header files
> >> > between line#14 to line#44 probably involves <linux/if.h>, but I'm not
> >> sure
> >> > which one is the culprit.
> >> Interesting, really something in in tst_test.h with combination of
> >> lapi/ip_tables.h. This combination is only in 2 tests, setsockopt0{3,8}.c,
> >> setsockopt03.c already had <netinet/in.h>.
> > I eventually caught that "tst_capability.h" is the key point.
> > To includes <netinet/in.h> before that can avoid the conflict.
> > But still not sure how it made things broken (i.e. where includes
> > <linux/if.h>).
> >> > If we simply put the <netinet/in.h> at the top of tst_test.h, the
> >> > conflict disappears
> >> > as well.
> >> > See experiment commit:
> >> https://github.com/wangli5665/ltp/commit/0155df479811d9a51f30e09accb330238607f73d
> >> I'd be for adding it there, with comment why it's there. We can prevent
> >> problems
> >> with failing another test in the future. (+ remove it from both tests).
> > I'm OK with this fix.
> > @Cyril, @Richard, what do you think? any other thoughts?
> We need to clean up our headers, which is a bigger problem. Most tests
> do not need all the stuff in tst_test.h. It is just a load of unecessary
> work.
> Cleaning up the headers is a big challenge. It would be easier if we
> know what will break older distros. So I suggest adding something like:
> #ifdef _X_H
> # error "You should include X before Y ..."
> #endif
+1 for this.
> to one or more headers.
> Otherwise I'm fine with the above solution as a "temporary" fix.
quotation marks in "temporary" are correct, "temporary" means forever :).
Kind regards,
Petr
prev parent reply other threads:[~2021-08-20 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 2:56 [LTP] [COMMITTED] setsockopt08: includes netinet/in.h Li Wang
2021-08-06 5:40 ` Petr Vorel
2021-08-06 5:55 ` Petr Vorel
2021-08-06 8:29 ` Li Wang
2021-08-06 9:37 ` Petr Vorel
2021-08-06 10:18 ` Li Wang
2021-08-06 10:52 ` Richard Palethorpe
2021-08-09 4:03 ` Li Wang
2021-08-20 9:37 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR93wpTZMw9oT1O4@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.