From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 993FCC432BE for ; Mon, 9 Aug 2021 09:05:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C21F60EE7 for ; Mon, 9 Aug 2021 09:05:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234061AbhHIJGM (ORCPT ); Mon, 9 Aug 2021 05:06:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234095AbhHIJGM (ORCPT ); Mon, 9 Aug 2021 05:06:12 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47330C0613CF for ; Mon, 9 Aug 2021 02:05:51 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id i10-20020a05600c354ab029025a0f317abfso13990974wmq.3 for ; Mon, 09 Aug 2021 02:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=90uNnlJE5iHK79/8GYVpG/M6EW6OsXMEoHMUbHWYZbc=; b=LXg512mauFVdZqBZuUfn8USTSGm4NLLMcdLW88SJ/u0Sa1w8EHb6zM9bt8408x5vxL C3Rx4IHDQ4+VnVWPK+VE7kPw5csGgL5L10tgPn3DG0bq/ShCthfbEo2U74eYzYGkpNNd qV8dPAdnOcfCHYwupSLouUCjAmxAbmysOkXgx4KgUdDUhkEhTBI05Pe/PrianrKSX4wc mzkkVXa7eEm/O8Lwz4SC/vuPGoe++NB4OGOpWGsimEQovWr117juEqVK+n1RNpyDlzEL vC0DnLX8ThougFfHAQkPXwVIpGSWzBtCBQ4FNrgrSCz5SOY10Pnw/rbgDVZsr5Pddic5 sQvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=90uNnlJE5iHK79/8GYVpG/M6EW6OsXMEoHMUbHWYZbc=; b=Aqr0URDC0pmZKTVL1Tm3O7LqSM+KnbAtiEDY/+1qO1jLILRSjNBlMjPUbgei2pRErX P8NyQte24JnPjHdO/dtuiV/5AeQL6qLvSAAdklPihwYUII6pYcUhLi7gmZWaJEuTQGUm WBx+/9Y3loSRpecqDyrK8RFWqot3nehc1YFUefsgDfPFgbDo5D8o/4+2f4kNphnqec+L wFmuSeSIIJ9UqMnP4Wx175CL/8YNrBb8AfhuVrF6cYzVdpxzvZUYKEyRUb+YQmERm9nR BpCxbeFVE2CG+xnyTRSzZNi2TLtzsfdvnt4y7X3eaPG55nVEqceVuGtZI44NadJ6XJQH pDnA== X-Gm-Message-State: AOAM533UXL7x4wvb19e3SJAQhFzU6bmdQps+4311kRTrFkI+QoLltakZ AJAg1H4rrkjUeZwy6AEs6CVHjA== X-Google-Smtp-Source: ABdhPJxYuYeHY8fFHmkbqr9+K9X8cx3jH9r/IAs6cTIqFLHWwpnHcJ1kR7JylqUwlmjs50g6e6+iig== X-Received: by 2002:a05:600c:154d:: with SMTP id f13mr15817826wmg.0.1628499949941; Mon, 09 Aug 2021 02:05:49 -0700 (PDT) Received: from google.com ([95.146.142.85]) by smtp.gmail.com with ESMTPSA id q14sm17943641wrs.8.2021.08.09.02.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 02:05:49 -0700 (PDT) Date: Mon, 9 Aug 2021 10:05:47 +0100 From: Lee Jones To: Chris Cc: Andy Shevchenko , Hans de Goede , Platform Driver , "open list:GPIO SUBSYSTEM" , Christian Lamparter Subject: Re: [PATCH v2] platform/x86: add meraki-mx100 platform driver Message-ID: References: <20210806005755.2295193-1-chrisrblake93@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, 06 Aug 2021, Chris wrote: > On Fri, Aug 6, 2021 at 8:59 AM Andy Shevchenko > wrote: > > > > On Fri, Aug 6, 2021 at 4:55 PM Hans de Goede wrote: > > > On 8/6/21 9:52 AM, Andy Shevchenko wrote: > > > > On Fri, Aug 6, 2021 at 5:47 AM Chris Blake wrote: > > > > ... > > > > > >> +#include > > > > > > > > Does this provide a GPIO controller driver? I don't think so. > > > > > > Actually GPIO controller drivers use > > > for board files / glue code which > > > e.g. needs to add lookup-tables, which this code does, > > > so including this header is correct. > > > > Ah, indeed. I stand corrected. > > > > Hello, > > Thank you both for the feedback, i'll work on getting the fixes > implemented. The only one I have issues with is finding the git hash > for the dependency commit in mfd, since I don't see it merged up yet > to the maintainers staging branch at > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/. Check again. :) > @Lee, sorry to tag you in but any chance you have the git hash for the > PR I did earlier that you accepted for 5.15? It was named: mfd: > lpc_ich: Enable GPIO driver for DH89xxCC. ef0eea5b151ae ("mfd: lpc_ich: Enable GPIO driver for DH89xxCC") -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog