From: Leon Romanovsky <leon@kernel.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: saeedm@nvidia.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] net/mlx5e: Make use of pr_warn()
Date: Mon, 9 Aug 2021 13:24:38 +0300 [thread overview]
Message-ID: <YRECZn/N9qSQkhKu@unreal> (raw)
In-Reply-To: <20210809090843.2456-1-caihuoqing@baidu.com>
On Mon, Aug 09, 2021 at 05:08:43PM +0800, Cai Huoqing wrote:
> to replace printk(KERN_WARNING ...) with pr_warn() kindly
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index e5c4344a114e..ab7c059e630f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -2702,7 +2702,7 @@ static int offload_pedit_fields(struct mlx5e_priv *priv,
> if (s_mask && a_mask) {
> NL_SET_ERR_MSG_MOD(extack,
> "can't set and add to the same HW field");
> - printk(KERN_WARNING "mlx5: can't set and add to the same HW field (%x)\n", f->field);
> + pr_warn("mlx5: can't set and add to the same HW field (%x)\n", f->field);
It should be "mlx5_core_warn(priv->mdev, ....") and not pr_warn.
> return -EOPNOTSUPP;
> }
>
> @@ -2741,8 +2741,8 @@ static int offload_pedit_fields(struct mlx5e_priv *priv,
> if (first < next_z && next_z < last) {
> NL_SET_ERR_MSG_MOD(extack,
> "rewrite of few sub-fields isn't supported");
> - printk(KERN_WARNING "mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n",
> - mask);
> + pr_warn("mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n",
> + mask);
ditto
Thanks
> return -EOPNOTSUPP;
> }
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-08-09 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 9:08 [PATCH] net/mlx5e: Make use of pr_warn() Cai Huoqing
2021-08-09 10:24 ` Leon Romanovsky [this message]
2021-08-09 20:37 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRECZn/N9qSQkhKu@unreal \
--to=leon@kernel.org \
--cc=caihuoqing@baidu.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.