From: Al Viro <viro@zeniv.linux.org.uk>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] iter revert problems
Date: Mon, 9 Aug 2021 15:52:39 +0000 [thread overview]
Message-ID: <YRFPR25scNRYaRzW@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <cover.1628509745.git.asml.silence@gmail.com>
On Mon, Aug 09, 2021 at 12:52:35PM +0100, Pavel Begunkov wrote:
> For the bug description see 2/2. As mentioned there the current problems
> is because of generic_write_checks(), but there was also a similar case
> fixed in 5.12, which should have been triggerable by normal
> write(2)/read(2) and others.
>
> It may be better to enforce reexpands as a long term solution, but for
> now this patchset is quickier and easier to backport.
Umm... Won't that screw the cases where we *are* doing proper
reexpands? AFAICS, with your patches that flag doesn't go away once
it had been set...
next prev parent reply other threads:[~2021-08-09 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 11:52 [PATCH 0/2] iter revert problems Pavel Begunkov
2021-08-09 11:52 ` [PATCH 1/2] iov_iter: mark truncated iters Pavel Begunkov
2021-08-09 11:52 ` [PATCH 2/2] io_uring: don't retry with truncated iter Pavel Begunkov
2021-08-09 15:52 ` Al Viro [this message]
2021-08-09 18:56 ` [PATCH 0/2] iter revert problems Pavel Begunkov
2021-08-10 8:47 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRFPR25scNRYaRzW@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.