From: Ido Schimmel <idosch@idosch.org>
To: Mark Bloch <mbloch@nvidia.com>
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com,
vladbu@nvidia.com, cong.wang@bytedance.com, jhs@mojatatu.com,
jiri@resnulli.us
Subject: Re: [net-next PATCH v2] net/sched: cls_api, reset flags on replay
Date: Tue, 10 Aug 2021 10:41:34 +0300 [thread overview]
Message-ID: <YRItrkt3capthkUE@shredder> (raw)
In-Reply-To: <20210810034305.63997-1-mbloch@nvidia.com>
On Tue, Aug 10, 2021 at 03:43:05AM +0000, Mark Bloch wrote:
> tc_new_tfilter() can replay a request if it got EAGAIN. The cited commit
> didn't account for this when it converted TC action ->init() API
> to use flags instead of parameters. This can lead to passing stale flags
> down the call chain which results in trying to lock rtnl when it's
> already locked, deadlocking the entire system.
>
> Fix by making sure to reset flags on each replay.
[...]
> Fixes: 695176bfe5de ("net_sched: refactor TC action init API")
> Signed-off-by: Mark Bloch <mbloch@nvidia.com>
> Reviewed-by: Vlad Buslov <vladbu@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2021-08-10 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 3:43 [net-next PATCH v2] net/sched: cls_api, reset flags on replay Mark Bloch
2021-08-10 7:41 ` Ido Schimmel [this message]
2021-08-10 23:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRItrkt3capthkUE@shredder \
--to=idosch@idosch.org \
--cc=cong.wang@bytedance.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.