From: Greg KH <gregkh@linuxfoundation.org>
To: SeongJae Park <sj38.park@gmail.com>
Cc: akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
mm-commits@vger.kernel.org, SeongJae Park <sjpark@amazon.de>
Subject: Re: [PATCH] selftests/damon/debugfs_attrs: Add missing execute permission
Date: Tue, 10 Aug 2021 13:27:44 +0200 [thread overview]
Message-ID: <YRJisBs9AunccCD4@kroah.com> (raw)
In-Reply-To: <20210810112050.22225-1-sj38.park@gmail.com>
On Tue, Aug 10, 2021 at 11:20:50AM +0000, SeongJae Park wrote:
> From: SeongJae Park <sjpark@amazon.de>
>
> Commit 04edafbc0c07 ("mm/damon: add user space selftests") of
> linux-mm[1] gives no execute permission to 'debugfs_attrs.sh' file.
> This results in a DAMON selftest failure as below:
>
> $ make -C tools/testing/selftests/damon run_tests
> make: Entering directory '/home/sjpark/linux/tools/testing/selftests/damon'
> TAP version 13
> 1..1
> # selftests: damon: debugfs_attrs.sh
> # Warning: file debugfs_attrs.sh is not executable, correct this.
> not ok 1 selftests: damon: debugfs_attrs.sh
> make: Leaving directory '/home/sjpark/linux/tools/testing/selftests/damon'
>
> To solve the problem, this commit adds the execute permission for
> 'debugfs_attrs.sh' file.
>
> [1] https://github.com/hnaz/linux-mm/commit/04edafbc0c07
>
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
> tools/testing/selftests/damon/debugfs_attrs.sh | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh
>
> diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
> old mode 100644
> new mode 100755
> --
> 2.17.1
>
Why not fix the tools to execute the file properly as changing the mode
of a file does not work well with all tools that we use (i.e. patch
files.)
thanks,
greg k-h
next prev parent reply other threads:[~2021-08-10 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 0:42 + mm-damon-add-user-space-selftests.patch added to -mm tree akpm
2021-08-10 11:20 ` [PATCH] selftests/damon/debugfs_attrs: Add missing execute permission SeongJae Park
2021-08-10 11:27 ` Greg KH [this message]
2021-08-10 14:08 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRJisBs9AunccCD4@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.