From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] [v2, 1/6] syscalls/sysfs: Convert sysfs01 to the new API
Date: Tue, 10 Aug 2021 15:54:15 +0200 [thread overview]
Message-ID: <YRKFBxpUwJExuMzi@yuki> (raw)
In-Reply-To: <69afbc39-4c9d-dbab-beb2-4ff43d733818@uniontech.com>
Hi!
> I checked with "checkpatch.pl -f" and there were no errors or warnings.
> I use "git am" to apply the patch normally without any warning. How did
> you check that there are spaces.
Have you used recent enough version?
Latest kernel git:
$ ~/linux/scripts/checkpatch.pl -f sysfs01.c
ERROR: code indent should use tabs where possible
#20: FILE: sysfs01.c:20:
+ /* option 1, buf holds fs name */$
ERROR: code indent should use tabs where possible
#21: FILE: sysfs01.c:21:
+ TST_EXP_POSITIVE(tst_syscall(__NR_sysfs, 1, "proc"),$
WARNING: please, no spaces at the start of a line
#21: FILE: sysfs01.c:21:
+ TST_EXP_POSITIVE(tst_syscall(__NR_sysfs, 1, "proc"),$
ERROR: code indent should use tabs where possible
#22: FILE: sysfs01.c:22:
+ "sysfs(1,'proc')");$
WARNING: please, no spaces at the start of a line
#22: FILE: sysfs01.c:22:
...
$ cd ~/linux/; git describe
v5.14-rc5-2-g9a73fa375d58
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2021-08-10 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 6:24 [LTP] [PATCH] [v2, 1/6] syscalls/sysfs: Convert sysfs01 to the new API sujiaxun
2021-08-10 9:55 ` Cyril Hrubis
2021-08-10 10:58 ` sujiaxun
2021-08-10 13:54 ` Cyril Hrubis [this message]
2021-08-11 2:45 ` sujiaxun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRKFBxpUwJExuMzi@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.