From: Greg KH <gregkh@linuxfoundation.org>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] staging: r8188eu: remove lines from Makefile that silence build warnings
Date: Wed, 11 Aug 2021 09:40:53 +0200 [thread overview]
Message-ID: <YRN/BYRayELQnM+2@kroah.com> (raw)
In-Reply-To: <20210810235047.177883-9-phil@philpotter.co.uk>
On Wed, Aug 11, 2021 at 12:50:47AM +0100, Phillip Potter wrote:
> Remove the several lines from the Makefile that append EXTRA_CFLAGS options
> to silence build warnings about unused variables, unused functions and such
> like. This will enable cleanup of missed warnings, and easier spotting
> of future such problems.
>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> drivers/staging/r8188eu/Makefile | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile
> index 152d6325b4d9..7f6658f931d1 100644
> --- a/drivers/staging/r8188eu/Makefile
> +++ b/drivers/staging/r8188eu/Makefile
> @@ -2,15 +2,6 @@ SHELL := /bin/bash
> EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS)
> EXTRA_CFLAGS += -O1
>
> -EXTRA_CFLAGS += -Wno-unused-variable
> -EXTRA_CFLAGS += -Wno-unused-value
> -EXTRA_CFLAGS += -Wno-unused-label
> -EXTRA_CFLAGS += -Wno-unused-parameter
> -EXTRA_CFLAGS += -Wno-unused-function
> -EXTRA_CFLAGS += -Wno-unused
> -
> -EXTRA_CFLAGS += -Wno-uninitialized
> -
Ah, that is why I didn't see any warnings! Thanks for these changes,
will go queue them up now.
greg k-h
next prev parent reply other threads:[~2021-08-11 7:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 23:50 [PATCH 0/8] staging: r8188eu: cleanup several warnings Phillip Potter
2021-08-10 23:50 ` [PATCH 1/8] staging: r8188eu: remove unused functions from os_dep/ioctl_linux.c Phillip Potter
2021-08-11 7:40 ` Greg KH
2021-08-11 23:29 ` Phillip Potter
2021-08-10 23:50 ` [PATCH 2/8] staging: r8188eu: remove unused oid_null_function function Phillip Potter
2021-08-10 23:50 ` [PATCH 3/8] staging: r8188eu: remove unused label from recv_indicatepkt_reorder Phillip Potter
2021-08-10 23:50 ` [PATCH 4/8] staging: r8188eu: remove rtw_mfree_sta_priv_lock function Phillip Potter
2021-08-10 23:50 ` [PATCH 5/8] staging: r8188eu: remove unused variable from rtl8188e_init_dm_priv Phillip Potter
2021-08-10 23:50 ` [PATCH 6/8] staging: r8188eu: remove unused variable from rtw_init_drv_sw Phillip Potter
2021-08-10 23:50 ` [PATCH 7/8] staging: r8188eu: remove unused variable from rtw_init_recv_timer Phillip Potter
2021-08-10 23:50 ` [PATCH 8/8] staging: r8188eu: remove lines from Makefile that silence build warnings Phillip Potter
2021-08-11 7:40 ` Greg KH [this message]
2021-08-11 6:39 ` [PATCH 0/8] staging: r8188eu: cleanup several warnings Michael Straube
2021-08-11 23:30 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRN/BYRayELQnM+2@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.