From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C143FC4338F for ; Wed, 11 Aug 2021 13:17:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A891060FD9 for ; Wed, 11 Aug 2021 13:17:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230170AbhHKNSN (ORCPT ); Wed, 11 Aug 2021 09:18:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231217AbhHKNSK (ORCPT ); Wed, 11 Aug 2021 09:18:10 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B46CCC061765 for ; Wed, 11 Aug 2021 06:17:46 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 6so1913793wme.5 for ; Wed, 11 Aug 2021 06:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2xXMH953pZKCgCZ25e4o88jpheK19gphzrEklU0JwmQ=; b=N4jsEQMm8u5Z3lUmz5YhckOJN30t7GmxaBr/GyBrLlCIypYSx4DQdSeWJ3lYSvvYBN fj7stKjnQStjvf+Yr3j+QuN6RIRSGi284w9wZFzo1CUEt0VAY71Y9r4T+xdecrqCwSXi Xf/8F05FY0CXoaKedUtvqCKv4UVZHXCJZHuHpn+wynWUnWaeX+4dZNlVsuzMIQ/ly7W6 PufK/ExoII8fGmC4rVj9r1TRSMuyfzGzjVzSUSXVBin5n3ciHmb45XOQDoYpoZkeGxnn 1+ptpUmArPo/T8A2nEow1cRfU7t8SVlU93GNLR1XebZ8LsGyvxOiiiUk61doZafLRtPw Jf3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2xXMH953pZKCgCZ25e4o88jpheK19gphzrEklU0JwmQ=; b=isrTbf+Jf/UhXR1r2P/GCcmzHjgQWrIsw15VqwITE+up4TRg5rRvhrbq4OF+2kltvv FSMzKK0RvHESWUM5h539QM7huCopAd3fN2HSNNg8Y+fkYhSIJ1SBZu6c/0MObdj2yzyq svjbSe5IofW3aAN3Rk0uOLx3kL5PlkOAp1kJJqiAygpwgmPirOGxPM+hKhK/NuJV/Y6s 6J17yUJAcoewSB+Uv89a6rEs4cKfPOtj6SSy2ou5G//UX+5KktRZBN4r51jYXjDVHPww MmXhi7WDo0rvF7A4vwIFyIoKfNaQchX9IXrG1P2ZeFM4B0nkGBsgQUBV8tqXtXBLgI8J d2Bg== X-Gm-Message-State: AOAM5311sHFhW+82gV+kQddP6rRugUTyalPwN1lrfRkW44Oh+mJej3l6 gbV5WAq5w86lMcZQ753MhgobZg== X-Google-Smtp-Source: ABdhPJwIUxJpPNGUgdCSYFBLbtc9j6za/dLf5bCk68g89565QOV9b0vnjKefGnpYPFSTCxW9pYRBcA== X-Received: by 2002:a7b:c102:: with SMTP id w2mr10068103wmi.133.1628687865175; Wed, 11 Aug 2021 06:17:45 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:43fd:e634:73d9:e10e]) by smtp.gmail.com with ESMTPSA id t15sm25828059wrw.48.2021.08.11.06.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Aug 2021 06:17:44 -0700 (PDT) Date: Wed, 11 Aug 2021 14:17:39 +0100 From: Quentin Perret To: Viresh Kumar Cc: Rafael Wysocki , Sudeep Holla , Cristian Marussi , linux-pm@vger.kernel.org, Vincent Guittot , Lukasz Luba , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 9/9] cpufreq: scmi: Use .register_em() callback Message-ID: References: <6094d891b4cb0cba3357e2894c8a4431c4c65e67.1628682874.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6094d891b4cb0cba3357e2894c8a4431c4c65e67.1628682874.git.viresh.kumar@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wednesday 11 Aug 2021 at 17:28:47 (+0530), Viresh Kumar wrote: > Set the newly added .register_em() callback to register with the EM > after the cpufreq policy is properly initialized. > > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/scmi-cpufreq.c | 55 ++++++++++++++++++++-------------- > 1 file changed, 32 insertions(+), 23 deletions(-) > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > index 75f818d04b48..b916c9e22921 100644 > --- a/drivers/cpufreq/scmi-cpufreq.c > +++ b/drivers/cpufreq/scmi-cpufreq.c > @@ -22,7 +22,9 @@ > > struct scmi_data { > int domain_id; > + int nr_opp; > struct device *cpu_dev; > + cpumask_var_t opp_shared_cpus; Can we use policy->related_cpus and friends directly in the callback instead? That should simplify the patch a bit. Also, we can probably afford calling dev_pm_opp_get_opp_count() from the em_register callback as it is not a hot path, which would avoid wasting some 'resident' memory here that is only used during init. Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DDBC4338F for ; Wed, 11 Aug 2021 13:19:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC8E960EE2 for ; Wed, 11 Aug 2021 13:19:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC8E960EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C4I1PPwQsgr4gJRn3lhGHjhWGlDkiVUYrYgDdAm0TlE=; b=tIC7u8DRquK28r 5mjGmZc7msPiTl5MsV18MJUFqSiSeVgEFMrOqNhbc9mWh0shaIbqAAstsRqgzRF0yK8YIurhynk2U iihmB9BCYg12bpHIuY2I/J5uZ0la1vksDFB6IKigQEnL8QySJEvA3c6ijhlY/lEwidr17cf2tWVva DcDbsSlMA46eTYcs34OYXGF8ePFZwsPXyuJZF7kGPaYyh7nfTZxjf4mjMD9SElaThQr5CmJAkgVKX KAskZTxnYqcG3fVqjkXD3PfPQ27aaTq71eNr5+mWJ0kGCuk9aVq/fxIumV/6GNAofTtTPONh1Wh0K 1w1dh5p96rXrWyZlyvIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDo7I-007IUC-80; Wed, 11 Aug 2021 13:17:56 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDo7D-007ISp-7D for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 13:17:53 +0000 Received: by mail-wm1-x332.google.com with SMTP id d131-20020a1c1d890000b02902516717f562so1953438wmd.3 for ; Wed, 11 Aug 2021 06:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2xXMH953pZKCgCZ25e4o88jpheK19gphzrEklU0JwmQ=; b=N4jsEQMm8u5Z3lUmz5YhckOJN30t7GmxaBr/GyBrLlCIypYSx4DQdSeWJ3lYSvvYBN fj7stKjnQStjvf+Yr3j+QuN6RIRSGi284w9wZFzo1CUEt0VAY71Y9r4T+xdecrqCwSXi Xf/8F05FY0CXoaKedUtvqCKv4UVZHXCJZHuHpn+wynWUnWaeX+4dZNlVsuzMIQ/ly7W6 PufK/ExoII8fGmC4rVj9r1TRSMuyfzGzjVzSUSXVBin5n3ciHmb45XOQDoYpoZkeGxnn 1+ptpUmArPo/T8A2nEow1cRfU7t8SVlU93GNLR1XebZ8LsGyvxOiiiUk61doZafLRtPw Jf3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2xXMH953pZKCgCZ25e4o88jpheK19gphzrEklU0JwmQ=; b=KvyIHaxRZTCBbVKAXe2deryYWoBiqxwqdORg3CKLA/vpPy+R9TSNhK+U0Mne2h1de9 qimQqdz9Xd1oWRIkbtPUkhRHRXMLKkl14bRJUIrWDZ05jL+sAE9l5EREFjYcSYhdIuUX NUg6FP77xqOYNaJl1EoG6Fe/cjcYRMYTkqLmNkZe87DZ5fHBnkQFLWU8Fv14FpiYClQk 1uviSq357XxSZ3PyY0qaFoo3EvL57lz2nCZhN/g2pvmlrrsHKY+Ir74Lqfjj4XXv6f7U l3XdT48RapMwAQGRcFsRXjfLY/ca6PWQtN1xHqgASMrkQXK6YiiT2snxvhZwqsT6v6T1 Jcyw== X-Gm-Message-State: AOAM530IAqWo3U+pP3bX4TxBN2/XRdI6D8ZqTIA7ll+gXw73Ua3cvGLK 4sjKO2NnZa6xltRMDKffd0kqMQ== X-Google-Smtp-Source: ABdhPJwIUxJpPNGUgdCSYFBLbtc9j6za/dLf5bCk68g89565QOV9b0vnjKefGnpYPFSTCxW9pYRBcA== X-Received: by 2002:a7b:c102:: with SMTP id w2mr10068103wmi.133.1628687865175; Wed, 11 Aug 2021 06:17:45 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:43fd:e634:73d9:e10e]) by smtp.gmail.com with ESMTPSA id t15sm25828059wrw.48.2021.08.11.06.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Aug 2021 06:17:44 -0700 (PDT) Date: Wed, 11 Aug 2021 14:17:39 +0100 From: Quentin Perret To: Viresh Kumar Cc: Rafael Wysocki , Sudeep Holla , Cristian Marussi , linux-pm@vger.kernel.org, Vincent Guittot , Lukasz Luba , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 9/9] cpufreq: scmi: Use .register_em() callback Message-ID: References: <6094d891b4cb0cba3357e2894c8a4431c4c65e67.1628682874.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6094d891b4cb0cba3357e2894c8a4431c4c65e67.1628682874.git.viresh.kumar@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_061751_301402_3C918BAA X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 11 Aug 2021 at 17:28:47 (+0530), Viresh Kumar wrote: > Set the newly added .register_em() callback to register with the EM > after the cpufreq policy is properly initialized. > > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/scmi-cpufreq.c | 55 ++++++++++++++++++++-------------- > 1 file changed, 32 insertions(+), 23 deletions(-) > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > index 75f818d04b48..b916c9e22921 100644 > --- a/drivers/cpufreq/scmi-cpufreq.c > +++ b/drivers/cpufreq/scmi-cpufreq.c > @@ -22,7 +22,9 @@ > > struct scmi_data { > int domain_id; > + int nr_opp; > struct device *cpu_dev; > + cpumask_var_t opp_shared_cpus; Can we use policy->related_cpus and friends directly in the callback instead? That should simplify the patch a bit. Also, we can probably afford calling dev_pm_opp_get_opp_count() from the em_register callback as it is not a hot path, which would avoid wasting some 'resident' memory here that is only used during init. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel