From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A05D8C4338F for ; Wed, 11 Aug 2021 14:09:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4426D60F56 for ; Wed, 11 Aug 2021 14:09:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4426D60F56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EAC366E133; Wed, 11 Aug 2021 14:09:32 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C7146E0F7; Wed, 11 Aug 2021 14:09:30 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="194716609" X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="194716609" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 07:09:20 -0700 X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="503506436" Received: from gdthomps-mobl.amr.corp.intel.com (HELO intel.com) ([10.255.37.76]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 07:09:18 -0700 Date: Wed, 11 Aug 2021 10:09:17 -0400 From: Rodrigo Vivi To: Jani Nikula Cc: Daniel Vetter , Matt Roper , Joonas Lahtinen , DRI , Intel Graphics , Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List Message-ID: References: <20210715141854.1ad4a956@canb.auug.org.au> <162823181614.15830.10618174106053255881@jlahtine-mobl.ger.corp.intel.com> <20210809161939.GS1556418@mdroper-desk1.amr.corp.intel.com> <8735rgo3hi.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8735rgo3hi.fsf@intel.com> Subject: Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Aug 11, 2021 at 10:16:41AM +0300, Jani Nikula wrote: > On Tue, 10 Aug 2021, Daniel Vetter wrote: > > On Mon, Aug 09, 2021 at 09:19:39AM -0700, Matt Roper wrote: > >> On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vetter wrote: > >> > On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahtinen wrote: > >> > > Hi Matt, > >> > > > >> > > Always use the dim tooling when applying patches, it will do the right > >> > > thing with regards to adding the S-o-b. > >> > > >> > fd.o server rejects any pushes that haven't been done by dim, so how did > >> > this get through? > >> > >> I definitely used dim for all of these patches, but I'm not sure how I > >> lost my s-o-b on this one. Maybe when I edited the commit message after > >> 'dim extract-tags' I accidentally deleted an extra line when I removed > >> the extract-tags marker? It's the only patch where the line is missing, > >> so it's almost certainly human error on my part rather than something > >> dim did wrong. > > > > Yeah that's an expected failure model, and dim is supposed to catch that > > by rechecking for sobs when you push. See dim_push_branch -> > > checkpatch_commit_push_range in dim. So you can hand-edit stuff however > > you want, dim /should/ catch it when pushing. That it didn't is kinda > > confusing and I'd like to know why that slipped through. > > One of the failures that happened here was that the commit was part of a > topic branch that was merged and pushed directly. All merges should > happen via pull requests on the list, and applied (preferrably by > maintainers or at least with their acks recorded on the merge) using dim > apply-pull which should also have the checks. My bad. I have asked Matt to go ahead with the topic branch. So it is an ack, which didn't get recorded. But I didn't expect this case of missing dim checks with this flow. Sorry, Rodrigo. > > > BR, > Jani. > > > > >> > Matt, can you pls figure out and type up the patch to > >> > plug that hole? > >> > >> Are you referring to a patch for dim here? The i915 patch has already > >> landed, so we can't change its commit message now. > > > > Yeah dim, not drm-intel, that can't be fixed anymore because it's all > > baked in. > > -Daniel > > > >> > >> > >> Matt > >> > >> > > >> > Thanks, Daniel > >> > > >> > > > >> > > Regards, Joonas > >> > > > >> > > Quoting Stephen Rothwell (2021-07-15 07:18:54) > >> > > > Hi all, > >> > > > > >> > > > Commit > >> > > > > >> > > > db47fe727e1f ("drm/i915/step: s/_revid_tbl/_revids") > >> > > > > >> > > > is missing a Signed-off-by from its committer. > >> > > > > >> > > > -- > >> > > > Cheers, > >> > > > Stephen Rothwell > >> > > >> > -- > >> > Daniel Vetter > >> > Software Engineer, Intel Corporation > >> > http://blog.ffwll.ch > >> > >> -- > >> Matt Roper > >> Graphics Software Engineer > >> VTT-OSGC Platform Enablement > >> Intel Corporation > >> (916) 356-2795 > > -- > Jani Nikula, Intel Open Source Graphics Center