From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, linux-block@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 1/6] bio: optimize initialization of a bio
Date: Thu, 12 Aug 2021 08:51:56 +0200 [thread overview]
Message-ID: <YRTFDLv7R4ltlvpa@infradead.org> (raw)
In-Reply-To: <20210811193533.766613-2-axboe@kernel.dk>
On Wed, Aug 11, 2021 at 01:35:28PM -0600, Jens Axboe wrote:
> The memset() used is measurably slower in targeted benchmarks. Get rid
> of it and fill in the bio manually, in a separate helper.
If you have some numbers if would be great to throw them in here.
> +static inline void __bio_init(struct bio *bio)
Why is this split from bio_init and what are the criteria where an
initialization goes?
> + bio->bi_flags = bio->bi_ioprio = bio->bi_write_hint = 0;
Please keep each initialization on a separate line.
next prev parent reply other threads:[~2021-08-12 6:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 19:35 [PATCHSET v4 0/6] Enable bio recycling for polled IO Jens Axboe
2021-08-11 19:35 ` [PATCH 1/6] bio: optimize initialization of a bio Jens Axboe
2021-08-12 6:51 ` Christoph Hellwig [this message]
2021-08-12 15:29 ` Jens Axboe
2021-08-11 19:35 ` [PATCH 2/6] fs: add kiocb alloc cache flag Jens Axboe
2021-08-12 6:54 ` Christoph Hellwig
2021-08-12 14:52 ` Jens Axboe
2021-08-11 19:35 ` [PATCH 3/6] bio: add allocation cache abstraction Jens Axboe
2021-08-12 7:01 ` Christoph Hellwig
2021-08-12 15:08 ` Jens Axboe
2021-08-12 15:18 ` Christoph Hellwig
2021-08-12 15:26 ` Jens Axboe
2021-08-11 19:35 ` [PATCH 4/6] block: clear BIO_PERCPU_CACHE flag if polling isn't supported Jens Axboe
2021-08-11 19:35 ` [PATCH 5/6] io_uring: enable use of bio alloc cache Jens Axboe
2021-08-11 19:35 ` [PATCH 6/6] block: enable use of bio allocation cache Jens Axboe
2021-08-12 7:04 ` Christoph Hellwig
2021-08-12 14:52 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2021-08-12 15:41 [PATCHSET v5 0/6] Enable bio recycling for polled IO Jens Axboe
2021-08-12 15:41 ` [PATCH 1/6] bio: optimize initialization of a bio Jens Axboe
2021-08-12 16:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRTFDLv7R4ltlvpa@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.