From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D99C4320A for ; Thu, 12 Aug 2021 17:08:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7650610A7 for ; Thu, 12 Aug 2021 17:08:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234686AbhHLRJC (ORCPT ); Thu, 12 Aug 2021 13:09:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234664AbhHLRJA (ORCPT ); Thu, 12 Aug 2021 13:09:00 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4C18C061756 for ; Thu, 12 Aug 2021 10:08:34 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id a5so8120854plh.5 for ; Thu, 12 Aug 2021 10:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jDdIls0s5fGI9MVwDFqlnBbZBqc/nZFHSatF0n+nY7U=; b=Bg72VbLR6hRMQEh1yVIWIL4gxLdS9uI61QFRBRGMUISLehiSwhZINXEuqNDY/yCxsY b3kwi2EeW8Va6nJ2QiK2eapkOJvJo6JMxjJa+kZ3mrBoBLPuTqFeCO5YO/pQ5HADRmH5 t6p/Xlg5b3Q08aeGqpUbmKzJCBJ90jNC9m0eU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jDdIls0s5fGI9MVwDFqlnBbZBqc/nZFHSatF0n+nY7U=; b=VkTQ7robKtvzTq2cCXcD74JDul6MNPNr7462GSb1yzf2WLGffneMAHlzrAObF2scCJ wImCI9B2LhSjguRGtKUvn3CXQihcJusn8bzm8+bincvZVvrr/UB6gON3JQJHXAEoLWOE r7T+C8/+JyxWjtwQtidcuG7dpt+aLVujPnCLbqGYlrt2Jw3SGjSH+atoxa7qWY6zt32w bVUcNrbFIBao7Key89G3DlGFw0KZsKdSmXMpY/MIAiJkIWrEVefN/1ZmIAX3w9M/A7CU +mjKY8KLVS8znfnBK/4eUTsL+jR+WVJIEpsiXQWEuzias/Vb0ILwDBIk1Qd9AKF5zf8Y VmEA== X-Gm-Message-State: AOAM531Y3vZnjLO6t7fXF6H0WLoVAoDwhwAQkslmHsw7NyuQf3PZUdP5 IUoaQmZ8liNZVK2VJKk3VEjU/A== X-Google-Smtp-Source: ABdhPJxw1ta+VAzWkZwmcPY7XJWFJsLSEVJXqz1nQBIEQaoXiTKpmlpDo6+aNFXGjT1vC/w8J6/AdA== X-Received: by 2002:a65:63d7:: with SMTP id n23mr4809377pgv.46.1628788114293; Thu, 12 Aug 2021 10:08:34 -0700 (PDT) Received: from localhost ([2620:15c:202:201:6683:43e5:ba4c:d76c]) by smtp.gmail.com with UTF8SMTPSA id e35sm11206858pjk.28.2021.08.12.10.08.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 10:08:33 -0700 (PDT) Date: Thu, 12 Aug 2021 10:08:31 -0700 From: Matthias Kaehlcke To: Roger Quadros Cc: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi , Bastien Nocera , Peter Chen , devicetree@vger.kernel.org, Michal Simek , linux-kernel@vger.kernel.org, Douglas Anderson , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Ravi Chandra Sadineni , Stephen Boyd , Al Cooper , Andrey Zhizhikin , Andy Gross , Aswath Govindraju , Bjorn Andersson , Catalin Marinas , Dmitry Baryshkov , Dmitry Osipenko , Enric Balletbo i Serra , Fabio Estevam , Guido =?utf-8?Q?G=C3=BCnther?= , Jagan Teki , Nishanth Menon , Pawel Laszczak , Shawn Guo , Vinod Koul , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v15 0/6] usb: misc: Add onboard_usb_hub driver Message-ID: References: <20210727004118.2583774-1-mka@chromium.org> <8a8cae28-6617-76d3-1742-3f151a149069@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Roger, On Wed, Aug 11, 2021 at 03:56:15PM +0300, Roger Quadros wrote: > > > On 11/08/2021 15:38, Roger Quadros wrote: > > Hi Matthias, > > > > On 09/08/2021 18:49, Matthias Kaehlcke wrote: > >> Hi Greg, > >> > >> Just wanted to check if this series is still on your radar. Is > >> there anything that blocks it from landing (further ACKs, ...)? > >> > >> Thanks > >> > >> Matthias > >> > >> On Mon, Jul 26, 2021 at 05:41:12PM -0700, Matthias Kaehlcke wrote: > >>> This series adds: > >>> - the onboard_usb_hub_driver > >>> - glue in the xhci-plat driver to create and destroy the > >>> onboard_usb_hub platform devices if needed > >>> - a device tree binding for the Realtek RTS5411 USB hub controller > >>> - device tree changes that add RTS5411 entries for the QCA SC7180 > >>> based boards trogdor and lazor > >>> - a couple of stubs for platform device functions to avoid > >>> unresolved symbols with certain kernel configs > >>> > >>> The main issue the driver addresses is that a USB hub needs to be > >>> powered before it can be discovered. For discrete onboard hubs (an > >>> example for such a hub is the Realtek RTS5411) this is often solved > >>> by supplying the hub with an 'always-on' regulator, which is kind > >>> of a hack. Some onboard hubs may require further initialization > >>> steps, like changing the state of a GPIO or enabling a clock, which > >>> requires even more hacks. This driver creates a platform device > >>> representing the hub which performs the necessary initialization. > >>> Currently it only supports switching on a single regulator, support > >>> for multiple regulators or other actions can be added as needed. > >>> Different initialization sequences can be supported based on the > >>> compatible string. > >>> > >>> Besides performing the initialization the driver can be configured > >>> to power the hub off during system suspend. This can help to extend > >>> battery life on battery powered devices which have no requirements > >>> to keep the hub powered during suspend. The driver can also be > >>> configured to leave the hub powered when a wakeup capable USB device > >>> is connected when suspending, and power it off otherwise. > >>> > >>> Changes in v15: > >>> - adjusted dependencies of USB_DWC3_CORE to make sure it can only > >>> be enabled when at least one of USB_DWC3_HOST, USB_DWC3_GADGET > >>> or USB_DWC3_DUAL_ROLE is selectable > >>> > >>> Changes in v14: > >>> - rebased on top of v5.14-rc1 > >>> - dropped DT binding patch which landed in v5.13 > >>> > >>> Changes in v13: > >>> - added patch "usb: Specify dependency on USB_XHCI_PLATFORM with > >>> 'depends on'" to the series to avoid Kconfig conflicts > >>> - added patch "arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM" > >>> to the series to keep effective defconfig unchanged > >>> > >>> Changes in v12: > >>> - onboard_hub driver: use IS_ENABLED(CONFIG_USB_ONBOARD_HUB_MODULE) > >>> in onboard_hub.h to also check for the driver built as module > >>> - onboard_hub_driver: include onboard_hub.h again to make sure there > >>> are prototype declarations for the public functions > >>> > >>> Changes in v11: > >>> - support multiple onboard hubs connected to the same parent > >>> - don't include ‘onboard_hub.h’ from the onboard hub driver > >>> > >>> Changes in v10: > >>> - always use of_is_onboard_usb_hub() stub unless ONBOARD_USB_HUB=y/m > >>> - keep 'regulator-boot-on' property for pp3300_hub > >>> > >>> Changes in v9: > >>> - added dependency on ONBOARD_USB_HUB (or !!ONBOARD_USB_HUB) to > >>> USB_PLATFORM_XHCI > >>> > >>> Changes in v7: > >>> - updated DT binding > >>> - series rebased on qcom/arm64-for-5.13 > >>> > >>> Changes in v6: > >>> - updated summary > >>> > >>> Changes in v5: > >>> - cover letter added > >>> > >>> Matthias Kaehlcke (6): > >>> usb: misc: Add onboard_usb_hub driver > >>> of/platform: Add stubs for of_platform_device_create/destroy() > >>> arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM > >>> usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' > >>> usb: host: xhci-plat: Create platform device for onboard hubs in > >>> probe() > >>> arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub > >>> > >>> .../sysfs-bus-platform-onboard-usb-hub | 8 + > >>> MAINTAINERS | 7 + > >>> .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 +- > >>> .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +- > >>> .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 +- > >>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 19 +- > >>> arch/arm64/configs/defconfig | 1 + > >>> drivers/usb/cdns3/Kconfig | 2 +- > >>> drivers/usb/dwc3/Kconfig | 5 +- > >>> drivers/usb/host/Kconfig | 5 +- > > > > These Kconfig changes are causing the resulting .config to be different. > > For example, if I start with omap2plus_defconfig, the resulting .config > > before and after your series is different as shown below > > > > :/work/linux$ diff /tmp/.config .config > > 1902d1901 > > < # CONFIG_HISI_HIKEY_USB is not set > > 4992c4991 > > < CONFIG_USB_XHCI_PLATFORM=m > > --- > >> # CONFIG_USB_XHCI_PLATFORM is not set > > 5073,5075c5072 > > < # CONFIG_USB_DWC3_HOST is not set > > < # CONFIG_USB_DWC3_GADGET is not set > > < CONFIG_USB_DWC3_DUAL_ROLE=y > > --- > >> CONFIG_USB_DWC3_GADGET=y > > 5173a5171 > >> # CONFIG_USB_ONBOARD_HUB is not set > > 5285c5283 > > < CONFIG_USB_ROLE_SWITCH=m > > --- > >> # CONFIG_USB_ROLE_SWITCH is not set > > > > I would expect the same issues for multi_v7_defconfig and multi_v8_defconfig as well. > > Sorry I meant defconfig for arm64, not multi_v8_defconfig. > > I checked that for arm64 defconfig it is ok. > > > I'm ok to update the relevant defconfigs files so that the resulting .config is identical to > > before your series. Thanks! > > With the below patch you can fix it for omap2plus_defconfig and multi_v7_defconfig. > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index d9abaae118dd..8c175ab37377 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -787,6 +787,7 @@ CONFIG_SND_AUDIO_GRAPH_CARD=m > CONFIG_USB=y > CONFIG_USB_OTG=y > CONFIG_USB_XHCI_HCD=y > +CONFIG_USB_XHCI_PLATFORM=y > CONFIG_USB_XHCI_MVEBU=y > CONFIG_USB_XHCI_TEGRA=m > CONFIG_USB_EHCI_HCD=y > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig > index 2ac2418084ab..a015fb04fa25 100644 > --- a/arch/arm/configs/omap2plus_defconfig > +++ b/arch/arm/configs/omap2plus_defconfig > @@ -562,6 +562,7 @@ CONFIG_USB=m > CONFIG_USB_ANNOUNCE_NEW_DEVICES=y > CONFIG_USB_MON=m > CONFIG_USB_XHCI_HCD=m > +CONFIG_USB_XHCI_PLATFORM=m > CONFIG_USB_EHCI_HCD=m > CONFIG_USB_OHCI_HCD=m > CONFIG_USB_ACM=m Thanks for testing! I completely forgot that arm32 has all these different defconfigs. While trying to adjust qcom_defconfig I came across something that confuses me. The original defconfig results in: # CONFIG_USB_XHCI_HCD is not set CONFIG_USB_DWC3_DUAL_ROLE=y My assumption was that xHCI support is need for dwc3 dual mode (which is made explicit by https://lore.kernel.org/patchwork/patch/1468240/), is that incorrect? Maybe without xHCI support the controller can still operate in USB 2.0 dual role mode? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD5E5C4338F for ; Thu, 12 Aug 2021 17:11:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E6E960E78 for ; Thu, 12 Aug 2021 17:11:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9E6E960E78 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BYNBCg5u7hyVVTGtoZbEgmAZmOJpEw5JCQGqFjR2hpE=; b=HM8iCCSyqpfmyA RzrTN1cArSfA/hnetQEwr76ZEeptoze88hTRF5ULa8EEHXQVuRe1PX6OwENVPc+uTTN+uQN/YkWqx c3mFzUyYMycal2r91yNGe9VbzRtmWdeX0VLV4n7+JaAeZjBYWskRv10FovPma9cFqIu8RaprtjnFH Cll/MlDTPXLt0N7NBaFsIITTzuwMJqpfR9FoUPmoOtbR/9f+WzWVtfHZOdeUDmPkF/oetqGROCAGK ADF40TcGDdc/SDM1OOh253b7wCFLyQcb363Oc6Vd9LOwl5gOQk8hd9kG2/UdgvYiBKegNFzPHk8LJ QiUfcgtBxuS73txaFbXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEECX-00AjDE-Hw; Thu, 12 Aug 2021 17:09:05 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEECR-00Aj7B-QA for linux-arm-kernel@lists.infradead.org; Thu, 12 Aug 2021 17:09:03 +0000 Received: by mail-pj1-x1034.google.com with SMTP id w13-20020a17090aea0db029017897a5f7bcso11731857pjy.5 for ; Thu, 12 Aug 2021 10:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jDdIls0s5fGI9MVwDFqlnBbZBqc/nZFHSatF0n+nY7U=; b=Bg72VbLR6hRMQEh1yVIWIL4gxLdS9uI61QFRBRGMUISLehiSwhZINXEuqNDY/yCxsY b3kwi2EeW8Va6nJ2QiK2eapkOJvJo6JMxjJa+kZ3mrBoBLPuTqFeCO5YO/pQ5HADRmH5 t6p/Xlg5b3Q08aeGqpUbmKzJCBJ90jNC9m0eU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jDdIls0s5fGI9MVwDFqlnBbZBqc/nZFHSatF0n+nY7U=; b=STCUZJxv8DzjbiSUD8OJfrRLdqlqICYesIRK+KCixxmupeMp2jcRd2CiMDu4PVxmJ0 QWVrZTMjHO3MHui/AiUDBTCVELzRIOs5893OFEcmbT8j6DwP1ywNq0z5A58Tc6kSDRYC kOwvbuY82fp3CsOMBCrvJt4Xcb5/zTNGlUS24Yq5m+/29LwpkWjOvm2K10cKuEZQ2Ogx DPIZ1elFeJOBeuQFwJ/l8Vc5SOFrkjVPQerDtVabP0VUi0Oxxoshu1tpy3CR7AR9P94v 4PchbYU8ikeVpTDFSLrp0sYUEBTshNcjbFuRkliBoBz3hLWV5tHjAe1Az7fV/Mywd8O6 nbNA== X-Gm-Message-State: AOAM532wtrOPpI3xoYn45tcEIz3rPnJI2cFCAiNMVw38DoeBuzortTU8 akQ0ZRAkJwtlFvyucOp1KAfqYw== X-Google-Smtp-Source: ABdhPJxw1ta+VAzWkZwmcPY7XJWFJsLSEVJXqz1nQBIEQaoXiTKpmlpDo6+aNFXGjT1vC/w8J6/AdA== X-Received: by 2002:a65:63d7:: with SMTP id n23mr4809377pgv.46.1628788114293; Thu, 12 Aug 2021 10:08:34 -0700 (PDT) Received: from localhost ([2620:15c:202:201:6683:43e5:ba4c:d76c]) by smtp.gmail.com with UTF8SMTPSA id e35sm11206858pjk.28.2021.08.12.10.08.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 10:08:33 -0700 (PDT) Date: Thu, 12 Aug 2021 10:08:31 -0700 From: Matthias Kaehlcke To: Roger Quadros Cc: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi , Bastien Nocera , Peter Chen , devicetree@vger.kernel.org, Michal Simek , linux-kernel@vger.kernel.org, Douglas Anderson , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Ravi Chandra Sadineni , Stephen Boyd , Al Cooper , Andrey Zhizhikin , Andy Gross , Aswath Govindraju , Bjorn Andersson , Catalin Marinas , Dmitry Baryshkov , Dmitry Osipenko , Enric Balletbo i Serra , Fabio Estevam , Guido =?utf-8?Q?G=C3=BCnther?= , Jagan Teki , Nishanth Menon , Pawel Laszczak , Shawn Guo , Vinod Koul , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v15 0/6] usb: misc: Add onboard_usb_hub driver Message-ID: References: <20210727004118.2583774-1-mka@chromium.org> <8a8cae28-6617-76d3-1742-3f151a149069@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210812_100859_905604_86FDBCE6 X-CRM114-Status: GOOD ( 48.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUm9nZXIsCgpPbiBXZWQsIEF1ZyAxMSwgMjAyMSBhdCAwMzo1NjoxNVBNICswMzAwLCBSb2dl ciBRdWFkcm9zIHdyb3RlOgo+IAo+IAo+IE9uIDExLzA4LzIwMjEgMTU6MzgsIFJvZ2VyIFF1YWRy b3Mgd3JvdGU6Cj4gPiBIaSBNYXR0aGlhcywKPiA+IAo+ID4gT24gMDkvMDgvMjAyMSAxODo0OSwg TWF0dGhpYXMgS2FlaGxja2Ugd3JvdGU6Cj4gPj4gSGkgR3JlZywKPiA+Pgo+ID4+IEp1c3Qgd2Fu dGVkIHRvIGNoZWNrIGlmIHRoaXMgc2VyaWVzIGlzIHN0aWxsIG9uIHlvdXIgcmFkYXIuIElzCj4g Pj4gdGhlcmUgYW55dGhpbmcgdGhhdCBibG9ja3MgaXQgZnJvbSBsYW5kaW5nIChmdXJ0aGVyIEFD S3MsIC4uLik/Cj4gPj4KPiA+PiBUaGFua3MKPiA+Pgo+ID4+IE1hdHRoaWFzCj4gPj4KPiA+PiBP biBNb24sIEp1bCAyNiwgMjAyMSBhdCAwNTo0MToxMlBNIC0wNzAwLCBNYXR0aGlhcyBLYWVobGNr ZSB3cm90ZToKPiA+Pj4gVGhpcyBzZXJpZXMgYWRkczoKPiA+Pj4gLSB0aGUgb25ib2FyZF91c2Jf aHViX2RyaXZlcgo+ID4+PiAtIGdsdWUgaW4gdGhlIHhoY2ktcGxhdCBkcml2ZXIgdG8gY3JlYXRl IGFuZCBkZXN0cm95IHRoZQo+ID4+PiAgIG9uYm9hcmRfdXNiX2h1YiBwbGF0Zm9ybSBkZXZpY2Vz IGlmIG5lZWRlZAo+ID4+PiAtIGEgZGV2aWNlIHRyZWUgYmluZGluZyBmb3IgdGhlIFJlYWx0ZWsg UlRTNTQxMSBVU0IgaHViIGNvbnRyb2xsZXIKPiA+Pj4gLSBkZXZpY2UgdHJlZSBjaGFuZ2VzIHRo YXQgYWRkIFJUUzU0MTEgZW50cmllcyBmb3IgdGhlIFFDQSBTQzcxODAKPiA+Pj4gICBiYXNlZCBi b2FyZHMgdHJvZ2RvciBhbmQgbGF6b3IKPiA+Pj4gLSBhIGNvdXBsZSBvZiBzdHVicyBmb3IgcGxh dGZvcm0gZGV2aWNlIGZ1bmN0aW9ucyB0byBhdm9pZAo+ID4+PiAgIHVucmVzb2x2ZWQgc3ltYm9s cyB3aXRoIGNlcnRhaW4ga2VybmVsIGNvbmZpZ3MKPiA+Pj4KPiA+Pj4gVGhlIG1haW4gaXNzdWUg dGhlIGRyaXZlciBhZGRyZXNzZXMgaXMgdGhhdCBhIFVTQiBodWIgbmVlZHMgdG8gYmUKPiA+Pj4g cG93ZXJlZCBiZWZvcmUgaXQgY2FuIGJlIGRpc2NvdmVyZWQuIEZvciBkaXNjcmV0ZSBvbmJvYXJk IGh1YnMgKGFuCj4gPj4+IGV4YW1wbGUgZm9yIHN1Y2ggYSBodWIgaXMgdGhlIFJlYWx0ZWsgUlRT NTQxMSkgdGhpcyBpcyBvZnRlbiBzb2x2ZWQKPiA+Pj4gYnkgc3VwcGx5aW5nIHRoZSBodWIgd2l0 aCBhbiAnYWx3YXlzLW9uJyByZWd1bGF0b3IsIHdoaWNoIGlzIGtpbmQKPiA+Pj4gb2YgYSBoYWNr LiBTb21lIG9uYm9hcmQgaHVicyBtYXkgcmVxdWlyZSBmdXJ0aGVyIGluaXRpYWxpemF0aW9uCj4g Pj4+IHN0ZXBzLCBsaWtlIGNoYW5naW5nIHRoZSBzdGF0ZSBvZiBhIEdQSU8gb3IgZW5hYmxpbmcg YSBjbG9jaywgd2hpY2gKPiA+Pj4gcmVxdWlyZXMgZXZlbiBtb3JlIGhhY2tzLiBUaGlzIGRyaXZl ciBjcmVhdGVzIGEgcGxhdGZvcm0gZGV2aWNlCj4gPj4+IHJlcHJlc2VudGluZyB0aGUgaHViIHdo aWNoIHBlcmZvcm1zIHRoZSBuZWNlc3NhcnkgaW5pdGlhbGl6YXRpb24uCj4gPj4+IEN1cnJlbnRs eSBpdCBvbmx5IHN1cHBvcnRzIHN3aXRjaGluZyBvbiBhIHNpbmdsZSByZWd1bGF0b3IsIHN1cHBv cnQKPiA+Pj4gZm9yIG11bHRpcGxlIHJlZ3VsYXRvcnMgb3Igb3RoZXIgYWN0aW9ucyBjYW4gYmUg YWRkZWQgYXMgbmVlZGVkLgo+ID4+PiBEaWZmZXJlbnQgaW5pdGlhbGl6YXRpb24gc2VxdWVuY2Vz IGNhbiBiZSBzdXBwb3J0ZWQgYmFzZWQgb24gdGhlCj4gPj4+IGNvbXBhdGlibGUgc3RyaW5nLgo+ ID4+Pgo+ID4+PiBCZXNpZGVzIHBlcmZvcm1pbmcgdGhlIGluaXRpYWxpemF0aW9uIHRoZSBkcml2 ZXIgY2FuIGJlIGNvbmZpZ3VyZWQKPiA+Pj4gdG8gcG93ZXIgdGhlIGh1YiBvZmYgZHVyaW5nIHN5 c3RlbSBzdXNwZW5kLiBUaGlzIGNhbiBoZWxwIHRvIGV4dGVuZAo+ID4+PiBiYXR0ZXJ5IGxpZmUg b24gYmF0dGVyeSBwb3dlcmVkIGRldmljZXMgd2hpY2ggaGF2ZSBubyByZXF1aXJlbWVudHMKPiA+ Pj4gdG8ga2VlcCB0aGUgaHViIHBvd2VyZWQgZHVyaW5nIHN1c3BlbmQuIFRoZSBkcml2ZXIgY2Fu IGFsc28gYmUKPiA+Pj4gY29uZmlndXJlZCB0byBsZWF2ZSB0aGUgaHViIHBvd2VyZWQgd2hlbiBh IHdha2V1cCBjYXBhYmxlIFVTQiBkZXZpY2UKPiA+Pj4gaXMgY29ubmVjdGVkIHdoZW4gc3VzcGVu ZGluZywgYW5kIHBvd2VyIGl0IG9mZiBvdGhlcndpc2UuCj4gPj4+Cj4gPj4+IENoYW5nZXMgaW4g djE1Ogo+ID4+PiAtIGFkanVzdGVkIGRlcGVuZGVuY2llcyBvZiBVU0JfRFdDM19DT1JFIHRvIG1h a2Ugc3VyZSBpdCBjYW4gb25seQo+ID4+PiAgIGJlIGVuYWJsZWQgd2hlbiBhdCBsZWFzdCBvbmUg b2YgVVNCX0RXQzNfSE9TVCwgVVNCX0RXQzNfR0FER0VUCj4gPj4+ICAgb3IgVVNCX0RXQzNfRFVB TF9ST0xFIGlzIHNlbGVjdGFibGUKPiA+Pj4KPiA+Pj4gQ2hhbmdlcyBpbiB2MTQ6Cj4gPj4+IC0g cmViYXNlZCBvbiB0b3Agb2YgdjUuMTQtcmMxCj4gPj4+IC0gZHJvcHBlZCBEVCBiaW5kaW5nIHBh dGNoIHdoaWNoIGxhbmRlZCBpbiB2NS4xMwo+ID4+Pgo+ID4+PiBDaGFuZ2VzIGluIHYxMzoKPiA+ Pj4gLSBhZGRlZCBwYXRjaCAidXNiOiBTcGVjaWZ5IGRlcGVuZGVuY3kgb24gVVNCX1hIQ0lfUExB VEZPUk0gd2l0aAo+ID4+PiAgICdkZXBlbmRzIG9uJyIgdG8gdGhlIHNlcmllcyB0byBhdm9pZCBL Y29uZmlnIGNvbmZsaWN0cwo+ID4+PiAtIGFkZGVkIHBhdGNoICJhcm02NDogZGVmY29uZmlnOiBF eHBsaWNpdGx5IGVuYWJsZSBVU0JfWEhDSV9QTEFURk9STSIKPiA+Pj4gICB0byB0aGUgc2VyaWVz IHRvIGtlZXAgZWZmZWN0aXZlIGRlZmNvbmZpZyB1bmNoYW5nZWQKPiA+Pj4KPiA+Pj4gQ2hhbmdl cyBpbiB2MTI6Cj4gPj4+IC0gb25ib2FyZF9odWIgZHJpdmVyOiB1c2UgSVNfRU5BQkxFRChDT05G SUdfVVNCX09OQk9BUkRfSFVCX01PRFVMRSkKPiA+Pj4gICBpbiBvbmJvYXJkX2h1Yi5oIHRvIGFs c28gY2hlY2sgZm9yIHRoZSBkcml2ZXIgYnVpbHQgYXMgbW9kdWxlCj4gPj4+IC0gb25ib2FyZF9o dWJfZHJpdmVyOiBpbmNsdWRlIG9uYm9hcmRfaHViLmggYWdhaW4gdG8gbWFrZSBzdXJlIHRoZXJl Cj4gPj4+ICAgYXJlIHByb3RvdHlwZSBkZWNsYXJhdGlvbnMgZm9yIHRoZSBwdWJsaWMgZnVuY3Rp b25zCj4gPj4+Cj4gPj4+IENoYW5nZXMgaW4gdjExOgo+ID4+PiAtIHN1cHBvcnQgbXVsdGlwbGUg b25ib2FyZCBodWJzIGNvbm5lY3RlZCB0byB0aGUgc2FtZSBwYXJlbnQKPiA+Pj4gLSBkb24ndCBp bmNsdWRlIOKAmG9uYm9hcmRfaHViLmjigJkgZnJvbSB0aGUgb25ib2FyZCBodWIgZHJpdmVyCj4g Pj4+Cj4gPj4+IENoYW5nZXMgaW4gdjEwOgo+ID4+PiAtIGFsd2F5cyB1c2Ugb2ZfaXNfb25ib2Fy ZF91c2JfaHViKCkgc3R1YiB1bmxlc3MgT05CT0FSRF9VU0JfSFVCPXkvbQo+ID4+PiAtIGtlZXAg J3JlZ3VsYXRvci1ib290LW9uJyBwcm9wZXJ0eSBmb3IgcHAzMzAwX2h1Ygo+ID4+Pgo+ID4+PiBD aGFuZ2VzIGluIHY5Ogo+ID4+PiAtIGFkZGVkIGRlcGVuZGVuY3kgb24gT05CT0FSRF9VU0JfSFVC IChvciAhIU9OQk9BUkRfVVNCX0hVQikgdG8KPiA+Pj4gICBVU0JfUExBVEZPUk1fWEhDSQo+ID4+ Pgo+ID4+PiBDaGFuZ2VzIGluIHY3Ogo+ID4+PiAtIHVwZGF0ZWQgRFQgYmluZGluZwo+ID4+PiAt IHNlcmllcyByZWJhc2VkIG9uIHFjb20vYXJtNjQtZm9yLTUuMTMKPiA+Pj4KPiA+Pj4gQ2hhbmdl cyBpbiB2NjoKPiA+Pj4gLSB1cGRhdGVkIHN1bW1hcnkKPiA+Pj4KPiA+Pj4gQ2hhbmdlcyBpbiB2 NToKPiA+Pj4gLSBjb3ZlciBsZXR0ZXIgYWRkZWQKPiA+Pj4KPiA+Pj4gTWF0dGhpYXMgS2FlaGxj a2UgKDYpOgo+ID4+PiAgIHVzYjogbWlzYzogQWRkIG9uYm9hcmRfdXNiX2h1YiBkcml2ZXIKPiA+ Pj4gICBvZi9wbGF0Zm9ybTogQWRkIHN0dWJzIGZvciBvZl9wbGF0Zm9ybV9kZXZpY2VfY3JlYXRl L2Rlc3Ryb3koKQo+ID4+PiAgIGFybTY0OiBkZWZjb25maWc6IEV4cGxpY2l0bHkgZW5hYmxlIFVT Ql9YSENJX1BMQVRGT1JNCj4gPj4+ICAgdXNiOiBTcGVjaWZ5IGRlcGVuZGVuY2llcyBvbiBVU0Jf WEhDSV9QTEFURk9STSB3aXRoICdkZXBlbmRzIG9uJwo+ID4+PiAgIHVzYjogaG9zdDogeGhjaS1w bGF0OiBDcmVhdGUgcGxhdGZvcm0gZGV2aWNlIGZvciBvbmJvYXJkIGh1YnMgaW4KPiA+Pj4gICAg IHByb2JlKCkKPiA+Pj4gICBhcm02NDogZHRzOiBxY29tOiBzYzcxODAtdHJvZ2RvcjogQWRkIG5v ZGVzIGZvciBvbmJvYXJkIFVTQiBodWIKPiA+Pj4KPiA+Pj4gIC4uLi9zeXNmcy1idXMtcGxhdGZv cm0tb25ib2FyZC11c2ItaHViICAgICAgICB8ICAgOCArCj4gPj4+ICBNQUlOVEFJTkVSUyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDcgKwo+ID4+PiAgLi4uL2Jvb3QvZHRz L3Fjb20vc2M3MTgwLXRyb2dkb3ItbGF6b3ItcjAuZHRzIHwgIDE5ICstCj4gPj4+ICAuLi4vYm9v dC9kdHMvcWNvbS9zYzcxODAtdHJvZ2Rvci1sYXpvci1yMS5kdHMgfCAgMTIgKy0KPiA+Pj4gIC4u Li9hcm02NC9ib290L2R0cy9xY29tL3NjNzE4MC10cm9nZG9yLXIxLmR0cyB8ICAxOSArLQo+ID4+ PiAgYXJjaC9hcm02NC9ib290L2R0cy9xY29tL3NjNzE4MC10cm9nZG9yLmR0c2kgIHwgIDE5ICst Cj4gPj4+ICBhcmNoL2FybTY0L2NvbmZpZ3MvZGVmY29uZmlnICAgICAgICAgICAgICAgICAgfCAg IDEgKwo+ID4+PiAgZHJpdmVycy91c2IvY2RuczMvS2NvbmZpZyAgICAgICAgICAgICAgICAgICAg IHwgICAyICstCj4gPj4+ICBkcml2ZXJzL3VzYi9kd2MzL0tjb25maWcgICAgICAgICAgICAgICAg ICAgICAgfCAgIDUgKy0KPiA+Pj4gIGRyaXZlcnMvdXNiL2hvc3QvS2NvbmZpZyAgICAgICAgICAg ICAgICAgICAgICB8ICAgNSArLQo+ID4gCj4gPiBUaGVzZSBLY29uZmlnIGNoYW5nZXMgYXJlIGNh dXNpbmcgdGhlIHJlc3VsdGluZyAuY29uZmlnIHRvIGJlIGRpZmZlcmVudC4KPiA+IEZvciBleGFt cGxlLCBpZiBJIHN0YXJ0IHdpdGggb21hcDJwbHVzX2RlZmNvbmZpZywgdGhlIHJlc3VsdGluZyAu Y29uZmlnCj4gPiBiZWZvcmUgYW5kIGFmdGVyIHlvdXIgc2VyaWVzIGlzIGRpZmZlcmVudCBhcyBz aG93biBiZWxvdwo+ID4gCj4gPiA6L3dvcmsvbGludXgkIGRpZmYgL3RtcC8uY29uZmlnIC5jb25m aWcKPiA+IDE5MDJkMTkwMQo+ID4gPCAjIENPTkZJR19ISVNJX0hJS0VZX1VTQiBpcyBub3Qgc2V0 Cj4gPiA0OTkyYzQ5OTEKPiA+IDwgQ09ORklHX1VTQl9YSENJX1BMQVRGT1JNPW0KPiA+IC0tLQo+ ID4+ICMgQ09ORklHX1VTQl9YSENJX1BMQVRGT1JNIGlzIG5vdCBzZXQKPiA+IDUwNzMsNTA3NWM1 MDcyCj4gPiA8ICMgQ09ORklHX1VTQl9EV0MzX0hPU1QgaXMgbm90IHNldAo+ID4gPCAjIENPTkZJ R19VU0JfRFdDM19HQURHRVQgaXMgbm90IHNldAo+ID4gPCBDT05GSUdfVVNCX0RXQzNfRFVBTF9S T0xFPXkKPiA+IC0tLQo+ID4+IENPTkZJR19VU0JfRFdDM19HQURHRVQ9eQo+ID4gNTE3M2E1MTcx Cj4gPj4gIyBDT05GSUdfVVNCX09OQk9BUkRfSFVCIGlzIG5vdCBzZXQKPiA+IDUyODVjNTI4Mwo+ ID4gPCBDT05GSUdfVVNCX1JPTEVfU1dJVENIPW0KPiA+IC0tLQo+ID4+ICMgQ09ORklHX1VTQl9S T0xFX1NXSVRDSCBpcyBub3Qgc2V0Cj4gPiAKPiA+IEkgd291bGQgZXhwZWN0IHRoZSBzYW1lIGlz c3VlcyBmb3IgbXVsdGlfdjdfZGVmY29uZmlnIGFuZCBtdWx0aV92OF9kZWZjb25maWcgYXMgd2Vs bC4KPiAKPiBTb3JyeSBJIG1lYW50IGRlZmNvbmZpZyBmb3IgYXJtNjQsIG5vdCBtdWx0aV92OF9k ZWZjb25maWcuCj4gCj4gSSBjaGVja2VkIHRoYXQgZm9yIGFybTY0IGRlZmNvbmZpZyBpdCBpcyBv ay4KPiAKPiA+IEknbSBvayB0byB1cGRhdGUgdGhlIHJlbGV2YW50IGRlZmNvbmZpZ3MgZmlsZXMg c28gdGhhdCB0aGUgcmVzdWx0aW5nIC5jb25maWcgaXMgaWRlbnRpY2FsIHRvCj4gPiBiZWZvcmUg eW91ciBzZXJpZXMuIFRoYW5rcyEKPiAKPiBXaXRoIHRoZSBiZWxvdyBwYXRjaCB5b3UgY2FuIGZp eCBpdCBmb3Igb21hcDJwbHVzX2RlZmNvbmZpZyBhbmQgbXVsdGlfdjdfZGVmY29uZmlnLgo+IAo+ IGRpZmYgLS1naXQgYS9hcmNoL2FybS9jb25maWdzL211bHRpX3Y3X2RlZmNvbmZpZyBiL2FyY2gv YXJtL2NvbmZpZ3MvbXVsdGlfdjdfZGVmY29uZmlnCj4gaW5kZXggZDlhYmFhZTExOGRkLi44YzE3 NWFiMzczNzcgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm0vY29uZmlncy9tdWx0aV92N19kZWZjb25m aWcKPiArKysgYi9hcmNoL2FybS9jb25maWdzL211bHRpX3Y3X2RlZmNvbmZpZwo+IEBAIC03ODcs NiArNzg3LDcgQEAgQ09ORklHX1NORF9BVURJT19HUkFQSF9DQVJEPW0KPiAgQ09ORklHX1VTQj15 Cj4gIENPTkZJR19VU0JfT1RHPXkKPiAgQ09ORklHX1VTQl9YSENJX0hDRD15Cj4gK0NPTkZJR19V U0JfWEhDSV9QTEFURk9STT15Cj4gIENPTkZJR19VU0JfWEhDSV9NVkVCVT15Cj4gIENPTkZJR19V U0JfWEhDSV9URUdSQT1tCj4gIENPTkZJR19VU0JfRUhDSV9IQ0Q9eQo+IGRpZmYgLS1naXQgYS9h cmNoL2FybS9jb25maWdzL29tYXAycGx1c19kZWZjb25maWcgYi9hcmNoL2FybS9jb25maWdzL29t YXAycGx1c19kZWZjb25maWcKPiBpbmRleCAyYWMyNDE4MDg0YWIuLmEwMTVmYjA0ZmEyNSAxMDA2 NDQKPiAtLS0gYS9hcmNoL2FybS9jb25maWdzL29tYXAycGx1c19kZWZjb25maWcKPiArKysgYi9h cmNoL2FybS9jb25maWdzL29tYXAycGx1c19kZWZjb25maWcKPiBAQCAtNTYyLDYgKzU2Miw3IEBA IENPTkZJR19VU0I9bQo+ICBDT05GSUdfVVNCX0FOTk9VTkNFX05FV19ERVZJQ0VTPXkKPiAgQ09O RklHX1VTQl9NT049bQo+ICBDT05GSUdfVVNCX1hIQ0lfSENEPW0KPiArQ09ORklHX1VTQl9YSENJ X1BMQVRGT1JNPW0KPiAgQ09ORklHX1VTQl9FSENJX0hDRD1tCj4gIENPTkZJR19VU0JfT0hDSV9I Q0Q9bQo+ICBDT05GSUdfVVNCX0FDTT1tCgpUaGFua3MgZm9yIHRlc3RpbmchCgpJIGNvbXBsZXRl bHkgZm9yZ290IHRoYXQgYXJtMzIgaGFzIGFsbCB0aGVzZSBkaWZmZXJlbnQgZGVmY29uZmlncy4K CldoaWxlIHRyeWluZyB0byBhZGp1c3QgcWNvbV9kZWZjb25maWcgSSBjYW1lIGFjcm9zcyBzb21l dGhpbmcgdGhhdCBjb25mdXNlcwptZS4gVGhlIG9yaWdpbmFsIGRlZmNvbmZpZyByZXN1bHRzIGlu OgoKIyBDT05GSUdfVVNCX1hIQ0lfSENEIGlzIG5vdCBzZXQKQ09ORklHX1VTQl9EV0MzX0RVQUxf Uk9MRT15CgpNeSBhc3N1bXB0aW9uIHdhcyB0aGF0IHhIQ0kgc3VwcG9ydCBpcyBuZWVkIGZvciBk d2MzIGR1YWwgbW9kZSAod2hpY2ggaXMKbWFkZSBleHBsaWNpdCBieSBodHRwczovL2xvcmUua2Vy bmVsLm9yZy9wYXRjaHdvcmsvcGF0Y2gvMTQ2ODI0MC8pLCBpcwp0aGF0IGluY29ycmVjdD8gTWF5 YmUgd2l0aG91dCB4SENJIHN1cHBvcnQgdGhlIGNvbnRyb2xsZXIgY2FuIHN0aWxsCm9wZXJhdGUg aW4gVVNCIDIuMCBkdWFsIHJvbGUgbW9kZT8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK