From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D35C4338F for ; Fri, 13 Aug 2021 13:12:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD12261038 for ; Fri, 13 Aug 2021 13:12:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CD12261038 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dFNz8ttK1qq1XhYZ3vVykawPrfLgRQ0Xr2HGnjrKk7E=; b=C2/1xH3ZORziwa pXVCqEMAp5RdVavuPAVgLc7tpWDQN61rsgYAkX929a50lupLY5ZrcOK8VtJHkUqEJ/9U5pPQNZQly eoAyKzv06Ff96xYOAbZAN8QrO2mjuKICoCugI4CZnUJYjQ1BahtDoOq/rv/Ixsx/O4vadXLD6YNe1 0yV2LdAEDth1PvW1Hp7Yp3WPRufRUQgxOm0rXdg+YbFF8JEUk1xqsKBWk8FpJxyc6cA+vXwExYMgp kdFhWtZSJhhbW0fjcoYExgmDeRp7/+A5dDRKE8PxWhhrSAq+rQqydSoWjCM4qdbr0NYc2Oo5C4Qrf ni0A9qFY+YFdfEwU5wUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEWww-00CfBi-7R; Fri, 13 Aug 2021 13:10:14 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEWwp-00Cf9S-Pd for linux-arm-kernel@lists.infradead.org; Fri, 13 Aug 2021 13:10:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=1MSq2rQag7F3xmCmN6ikUcDNWFi9NhmjIJ0Jw9gtSAE=; b=5skMoLKWDaeRTcHfip7Lr85djs Co5nHQJapgTa55QkQn/CwkMV6sX0om90O1e+1C2XMiu4+KvoJ8Vhlo+ZZZP7Eqe5gyMkyaDW2Lo/G woknjEH98xX7BTwnDH7yiV/HunJiYJA927m0FiS+P21LnmmZR5ogwMJK9ipOLKamNzHM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mEWwc-00HUwL-8f; Fri, 13 Aug 2021 15:09:54 +0200 Date: Fri, 13 Aug 2021 15:09:54 +0200 From: Andrew Lunn To: hongbo.wang@nxp.com Cc: hongjun.chen@nxp.com, po.liu@nxp.com, shawnguo@kernel.org, leoyang.li@nxp.com, vladimir.oltean@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] arm64: dts: fsl: ls1028a-rdb: Add dts file to choose swp5 as dsa master Message-ID: References: <20210813030155.23097-1-hongbo.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210813030155.23097-1-hongbo.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210813_061007_879628_B0288F83 X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 13, 2021 at 11:01:55AM +0800, hongbo.wang@nxp.com wrote: > From: hongbo wang > > some use cases want to use swp4-eno2 link as ordinary data path, > so we can enable swp5 as dsa master, the data from kernel can > be transmitted to eno3, then send to swp5 via internal link, switch will > forward it to swp0-3. > > the data to kernel will come from swp0-3, and received by kernel > via swp5-eno3 link. > new file mode 100644 > index 000000000000..a88396c137a1 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb-dsa-swp5-eno3.dts > @@ -0,0 +1,27 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Device Tree file for NXP LS1028A RDB with dsa master swp5-eno3. > + * > + * Copyright 2018-2021 NXP > + * > + * Hongbo Wang > + * > + */ > + > +/dts-v1/; > +#include "fsl-ls1028a-rdb.dts" You will end up with two DT blobs with the same top level compatible. This is going to cause confusion. I suggest you add an additional top level compatible to make it clear this differs from the compatible = "fsl,ls1028a-rdb", "fsl,ls1028a" blob. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0792FC432BE for ; Fri, 13 Aug 2021 13:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D544A6103A for ; Fri, 13 Aug 2021 13:10:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239352AbhHMNKl (ORCPT ); Fri, 13 Aug 2021 09:10:41 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48548 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239062AbhHMNKl (ORCPT ); Fri, 13 Aug 2021 09:10:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=1MSq2rQag7F3xmCmN6ikUcDNWFi9NhmjIJ0Jw9gtSAE=; b=5skMoLKWDaeRTcHfip7Lr85djs Co5nHQJapgTa55QkQn/CwkMV6sX0om90O1e+1C2XMiu4+KvoJ8Vhlo+ZZZP7Eqe5gyMkyaDW2Lo/G woknjEH98xX7BTwnDH7yiV/HunJiYJA927m0FiS+P21LnmmZR5ogwMJK9ipOLKamNzHM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mEWwc-00HUwL-8f; Fri, 13 Aug 2021 15:09:54 +0200 Date: Fri, 13 Aug 2021 15:09:54 +0200 From: Andrew Lunn To: hongbo.wang@nxp.com Cc: hongjun.chen@nxp.com, po.liu@nxp.com, shawnguo@kernel.org, leoyang.li@nxp.com, vladimir.oltean@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] arm64: dts: fsl: ls1028a-rdb: Add dts file to choose swp5 as dsa master Message-ID: References: <20210813030155.23097-1-hongbo.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210813030155.23097-1-hongbo.wang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Aug 13, 2021 at 11:01:55AM +0800, hongbo.wang@nxp.com wrote: > From: hongbo wang > > some use cases want to use swp4-eno2 link as ordinary data path, > so we can enable swp5 as dsa master, the data from kernel can > be transmitted to eno3, then send to swp5 via internal link, switch will > forward it to swp0-3. > > the data to kernel will come from swp0-3, and received by kernel > via swp5-eno3 link. > new file mode 100644 > index 000000000000..a88396c137a1 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb-dsa-swp5-eno3.dts > @@ -0,0 +1,27 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Device Tree file for NXP LS1028A RDB with dsa master swp5-eno3. > + * > + * Copyright 2018-2021 NXP > + * > + * Hongbo Wang > + * > + */ > + > +/dts-v1/; > +#include "fsl-ls1028a-rdb.dts" You will end up with two DT blobs with the same top level compatible. This is going to cause confusion. I suggest you add an additional top level compatible to make it clear this differs from the compatible = "fsl,ls1028a-rdb", "fsl,ls1028a" blob. Andrew