From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24CC2C4338F for ; Fri, 13 Aug 2021 18:25:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF0BB610CF for ; Fri, 13 Aug 2021 18:25:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DF0BB610CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W//0bED/XqyO4/ZjAJMrn1yclh1JnYbqrQo6uKhrvWY=; b=MgtwGB4UNJQQKu 2s+jEC3HG/wMA/pmjOVm7Uwjh9bMEKhrOASovCHfEeFSaX1w73gZoJ6MRpJxV21+PArSR+YXd6Mg+ FgfmiEs0sRGDC0DDDGN4ZPDyixvNKW0qIE5mDK8RTQ+t0fMqZ6EELSbKuuDxlMcCkhprAtnGHUWDz gAm4fhX4WM+gdThI0ipS7JO9vm4IoqZDxWlQBiSjdveXei+kKv2AaOWM3UoW04B65O7OBgC4Dqfkz 4pNTBTZwAIPyA6rW03FqEK0Q6ae1aIlOX6ySFdomt02sQSibbyyoc16+q6q/+SkenRB4qVFriCs9F 4YUg2pUkkGn2aY7MrN0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEbpi-00DMH1-FT; Fri, 13 Aug 2021 18:23:06 +0000 Received: from mail-ot1-f49.google.com ([209.85.210.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEbpe-00DMFx-HB for linux-arm-kernel@lists.infradead.org; Fri, 13 Aug 2021 18:23:04 +0000 Received: by mail-ot1-f49.google.com with SMTP id c2-20020a0568303482b029048bcf4c6bd9so13037112otu.8 for ; Fri, 13 Aug 2021 11:23:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=tpbnD/GvsLKZ81IxmHwIGA1dTzsxr0AhEtp1onHyNnw=; b=U+quEZgr3Oj3mGK1Wrgl3L9o0WJTOuRv4KOBUySGq7aeUh+4WcLTUk267NKxn81tk/ SLXfO1FAS5M/2xcEgpGIM69ObOrrb2Ul652IzeMDp8r51EkSz5mNYtP0Ui5WI8RzNjN/ iRok7Qhw1EhF2N4DQed4HTGDJRC0p7eJF5wIiy3VHVsEmfO16RWdTWDzhKJNNV2bx8eN sQ6C/ruI7Vd5WJb2UxWWtE4n9MuFXi9o1u8cagDZV0cGFYHY3XkbL3HzY6lczPfBgncM 6UblsLqReeQrYAvAEFk8bFsYDTBmP/06ykUtMnSdW9RQavkAodIWJp5XzY6gP3xzkQbA Glzw== X-Gm-Message-State: AOAM531Oq4XMXNChH0er9xAi7BBz/jkuHWou/q77kA4j3i+rmmZNVLzZ VL2e5pb2LNgzNBQ8WaD/IA== X-Google-Smtp-Source: ABdhPJwBIl+MNB6h2HTYTrEN5YMc98K25OaHILkcATZKTfAT7H2+jo3+d7Pf4mOgjUu+xMOy2WLylg== X-Received: by 2002:a9d:4590:: with SMTP id x16mr3154518ote.94.1628878981431; Fri, 13 Aug 2021 11:23:01 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id bf41sm500815oib.41.2021.08.13.11.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 11:23:00 -0700 (PDT) Received: (nullmailer pid 3804702 invoked by uid 1000); Fri, 13 Aug 2021 18:22:59 -0000 Date: Fri, 13 Aug 2021 13:22:59 -0500 From: Rob Herring To: Joakim Zhang Cc: Andrew Lunn , Florian Fainelli , "davem@davemloft.net" , "kuba@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "kernel@pengutronix.de" , dl-linux-imx , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH net-next 1/3] dt-bindings: net: fsl, fec: add "fsl, wakeup-irq" property Message-ID: References: <20210805074615.29096-1-qiangqing.zhang@nxp.com> <20210805074615.29096-2-qiangqing.zhang@nxp.com> <2e1a14bf-2fa8-ed39-d133-807c4e14859c@gmail.com> <498f3cee-8f37-2ab1-93c4-5472572ecc37@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210813_112302_623553_22E6F2DD X-CRM114-Status: GOOD ( 38.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBBdWcgMTEsIDIwMjEgYXQgMDc6NTc6NDZBTSArMDAwMCwgSm9ha2ltIFpoYW5nIHdy b3RlOgo+IAo+IEhpIEFuZHJldywKPiAKPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4g PiBGcm9tOiBBbmRyZXcgTHVubiA8YW5kcmV3QGx1bm4uY2g+Cj4gPiBTZW50OiAyMDIx5bm0OOac iDEw5pelIDIyOjMzCj4gPiBUbzogSm9ha2ltIFpoYW5nIDxxaWFuZ3FpbmcuemhhbmdAbnhwLmNv bT4KPiA+IENjOiBGbG9yaWFuIEZhaW5lbGxpIDxmLmZhaW5lbGxpQGdtYWlsLmNvbT47IGRhdmVt QGRhdmVtbG9mdC5uZXQ7Cj4gPiBrdWJhQGtlcm5lbC5vcmc7IHJvYmgrZHRAa2VybmVsLm9yZzsg c2hhd25ndW9Aa2VybmVsLm9yZzsKPiA+IHMuaGF1ZXJAcGVuZ3V0cm9uaXguZGU7IGZlc3RldmFt QGdtYWlsLmNvbTsga2VybmVsQHBlbmd1dHJvbml4LmRlOwo+ID4gZGwtbGludXgtaW14IDxsaW51 eC1pbXhAbnhwLmNvbT47IG5ldGRldkB2Z2VyLmtlcm5lbC5vcmc7Cj4gPiBkZXZpY2V0cmVlQHZn ZXIua2VybmVsLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsKPiA+IGxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+ID4gU3ViamVjdDogUmU6IFtQQVRDSCBuZXQt bmV4dCAxLzNdIGR0LWJpbmRpbmdzOiBuZXQ6IGZzbCwgZmVjOiBhZGQgImZzbCwKPiA+IHdha2V1 cC1pcnEiIHByb3BlcnR5Cj4gPiAKPiA+ID4gPiA+IDEpIEZFQyBjb250cm9sbGVyIGhhcyB1cCB0 byA0IGludGVycnVwdCBsaW5lcyBhbmQgYWxsIG9mIHRoZXNlIGFyZQo+ID4gPiA+ID4gcm91dGVk IHRvIEdJQwo+ID4gPiA+IGludGVycnVwdCBjb250cm9sbGVyLgo+ID4gPiA+ID4gMikgRkVDIGhh cyBhIHdha2V1cCBpbnRlcnJ1cHQgc2lnbmFsIGFuZCBhbHdheXMgYXJlIG1peGVkIHdpdGgKPiA+ ID4gPiA+IG90aGVyCj4gPiA+ID4gaW50ZXJydXB0IHNpZ25hbHMsIGFuZCB0aGVuIG91dHB1dCB0 byBvbmUgaW50ZXJydXB0IGxpbmUuCj4gPiA+ID4gPiAzKSBGb3IgbGVnYWN5IFNvQ3MsIHdha2V1 cCBpbnRlcnJ1cHQgYXJlIG1peGVkIHRvIGludDAgbGluZSwgYnV0Cj4gPiA+ID4gPiBmb3IgaS5N WDhNCj4gPiA+ID4gc2VyaWFscywgYXJlIG1peGVkIHRvIGludDIgbGluZS4KPiA+IAo+ID4gU28g eW91IG5lZWQgdG8ga25vdyB3aGljaCBvZiB0aGUgaW50ZXJydXB0cyBsaXN0ZWQgaXMgdGhlIHdh a2UgdXAgaW50ZXJydXB0LgoKV2UgYWxyZWFkeSBoYXZlIGEgd2F5IHRvIGRvIHRoaXMgYnkgdXNp bmcgJ3dha2V1cCcgZm9yIHRoZSAKaW50ZXJydXB0LW5hbWVzIGVudHJ5LiBCdXQgSSBndWVzcyB0 aGF0IHNoaXAgaGFzIHNhaWxlZCBoZXJlIGFuZCB0aGF0IAp3b3VsZG4ndCB3b3JrIHdlbGwgaWYg bm90IGp1c3QgYSB3YWtldXAgc291cmNlICh0aG91Z2ggeW91IGNvdWxkIHJlcGVhdCAKYW4gaW50 ZXJydXB0IGxpbmUgdGhhdCdzIHRoZSB3YWtldXAgc291cmNlKS4KCj4gPiAKPiA+IEkgY2FuIHNl ZSBhIGZldyB3YXlzIHRvIGRvIHRoaXM6Cj4gPiAKPiA+IFRoZSBGRUMgZHJpdmVyIGFscmVhZHkg aGFzIHF1aXJrcy4gQWRkIGEgcXVpcmsgdG8gZmVjX2lteDhtcV9pbmZvIGFuZAo+ID4gZmVjX2lt eDhxbV9pbmZvIHRvIGluZGljYXRlIHRoZXNlIHNob3VsZCB1c2UgaW50Mi4KCkJpbmdvIQoKTm90 ZSB0aGF0IGlmIHRoZSBkZXZpY2UgaXMgd2FrZXVwIGNhcGFibGUsIGl0IHNob3VsZCBoYXZlIGEg Cid3YWtldXAtc291cmNlJyBwcm9wZXJ0eSBpbiB0aGlzIGNhc2UuCgo+ID4gCj4gPiBvcgo+ID4g Cj4gPiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xs ZXIvaW50ZXJydXB0cy50eHQKPiA+IAo+ID4gICBiKSB0d28gY2VsbHMKPiA+ICAgLS0tLS0tLS0t LS0tCj4gPiAgIFRoZSAjaW50ZXJydXB0LWNlbGxzIHByb3BlcnR5IGlzIHNldCB0byAyIGFuZCB0 aGUgZmlyc3QgY2VsbCBkZWZpbmVzIHRoZQo+ID4gICBpbmRleCBvZiB0aGUgaW50ZXJydXB0IHdp dGhpbiB0aGUgY29udHJvbGxlciwgd2hpbGUgdGhlIHNlY29uZCBjZWxsIGlzIHVzZWQKPiA+ICAg dG8gc3BlY2lmeSBhbnkgb2YgdGhlIGZvbGxvd2luZyBmbGFnczoKPiA+ICAgICAtIGJpdHNbMzow XSB0cmlnZ2VyIHR5cGUgYW5kIGxldmVsIGZsYWdzCj4gPiAgICAgICAgIDEgPSBsb3ctdG8taGln aCBlZGdlIHRyaWdnZXJlZAo+ID4gICAgICAgICAyID0gaGlnaC10by1sb3cgZWRnZSB0cmlnZ2Vy ZWQKPiA+ICAgICAgICAgNCA9IGFjdGl2ZSBoaWdoIGxldmVsLXNlbnNpdGl2ZQo+ID4gICAgICAg ICA4ID0gYWN0aXZlIGxvdyBsZXZlbC1zZW5zaXRpdmUKPiA+IAo+ID4gWW91IGNvdWxkIGFkZAo+ ID4gCj4gPiAgICAgICAgMTggPSB3YWtldXAgc291cmNlCgpJJ2QgYmUgb2theSB3aXRoIHRoaXMg KHRob3VnaCBpdCBzaG91bGQgYmUgYSBwb3dlciBvZiAyIG51bWJlcikuCgo+ID4gCj4gPiBhbmQg ZXh0ZW5kIHRvIGNvcmUgdG8gZWl0aGVyIGRvIGFsbCB0aGUgd29yayBmb3IgeW91LCBvciB0ZWxs IHlvdSB0aGlzIGludGVycnVwdCBpcwo+ID4gZmxhZ2dlZCBhcyBiZWluZyBhIHdha2V1cCBzb3Vy Y2UuIFRoaXMgc29sdXRpb24gaGFzIHRoZSBhZHZhbnRhZ2Ugb2YgaXQgc2hvdWxkCj4gPiBiZSB1 c2FibGUgaW4gb3RoZXIgZHJpdmVycy4KCkFub3RoZXIgb3B0aW9uIGlzIGNvdWxkbid0IHlvdSBq dXN0IGVuYWJsZSBhbGwgdGhlIGludGVycnVwdHMgYXMgd2FrZXVwIApzb3VyY2VzPyBQcmVzdW1h Ymx5LCBvbmx5IG9uZSBvZiB0aGVtIHdvdWxkIHRyaWdnZXIgYSB3YWtldXAuCgo+IAo+IFRoYW5r cyBhIGxvdCBmb3IgeW91ciBjb21tZW50cyBmaXJzdCEKPiAKPiBJIGp1c3QgbG9vayBpbnRvIHRo ZSBpcnEgY29kZSwgaWYgd2UgZXh0ZW5kIGJpdFs1XSB0byBjYXJyeSB3YWtldXAgaW5mbyAoIGR1 ZSB0byBiaXRbNF0gaXMgdXNlZCBmb3IgSVJRX1RZUEVfUFJPQkUpLCAKPiB0aGVuIGNvbmZpZ3Vy ZSBpdCBpbiB0aGUgVFlQRSBmaWVsZCBvZiAnaW50ZXJydXB0cycgcHJvcGVydHksIHNvIHRoYXQg aW50ZXJydXB0IGNvbnRyb2xsZXIgd291bGQga25vdyB3aGljaCBpbnRlcnJ1cHQKPiBpcyB3YWtl dXAgY2FwYWJsZS4gCj4gSSB0aGluayB0aGVyZSBpcyBubyBtdWNoIHdvcmsgY29yZSB3b3VsZCBk bywgbWF5IGp1c3Qgc2V0IHRoaXMgaW50ZXJydXB0IHdha3VwIGNhcGFibGUuIEFub3RoZXIgZnVu Y3Rpb25hbGl0eSBpcwo+IGRyaXZlciBzaWRlIGdldCB0aGlzIGluZm8gdG8gaWRlbnRpZnkgd2hp Y2ggbWl4ZWQgaW50ZXJydXB0IGhhcyB3YWtldXAgY2FwYWJpbGl0eSwgd2UgY2FuIGV4cG9ydCBz eW1ib2wgZnJvbSBrZXJuZWwvaXJxL2lycWRvbWFpbi5jLgo+IAo+IFRoZSBpbnRlbnRpb24gaXMg dG8gbGV0IGRyaXZlciBrbm93IHdoaWNoIGludGVycnVwdCBpcyB3YWtldXAgY2FwYWJsZSwgSSB3 b3VsZCBjaG9vc2UgdG8gcHJvdmlkZXIgdGhpcyBpbiBzcGVjaWZpYyBkcml2ZXIsCj4gaW5zdGVh ZCBvZiBpbnRlcnJ1cHQgY29udHJvbGxlciwgaXQgc2VlbXMgdG8gbWUgdGhhdCBvdGhlcnMgbWF5 IGFsbCBjaG9vc2UgdGhpcyBzb2x1dGlvbiBmb3Igd2FrZXVwIG1peGVkIGludGVycnVwdC4KPiAK PiBTbyBJIHdvdWxkIHByZWZlciBzb2x1dGlvbiAxLCBpdCdzIGVhc2llciBhbmQgdW5kZXItY29u dHJvbC4gSSBjYW4gaGF2ZSBhIHRyeSBpZiB5b3Ugc3Ryb25nbHkgcmVjb21tZW5kIHNvbHV0aW9u IDIuCj4gCj4gQmVzdCBSZWdhcmRzLAo+IEpvYWtpbSBaaGFuZwo+ID4gCSAgQW5kcmV3CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62CF8C4338F for ; Fri, 13 Aug 2021 18:23:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39F64610CF for ; Fri, 13 Aug 2021 18:23:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232122AbhHMSX3 (ORCPT ); Fri, 13 Aug 2021 14:23:29 -0400 Received: from mail-ot1-f41.google.com ([209.85.210.41]:35505 "EHLO mail-ot1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229612AbhHMSX2 (ORCPT ); Fri, 13 Aug 2021 14:23:28 -0400 Received: by mail-ot1-f41.google.com with SMTP id r19-20020a0568301353b029050aa53c3801so13069688otq.2; Fri, 13 Aug 2021 11:23:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=tpbnD/GvsLKZ81IxmHwIGA1dTzsxr0AhEtp1onHyNnw=; b=CsbUsRWkFx/madDgjOXIO8ErTdlKsirgy21rY1OBp6ogSA1JCM0WpFdh03mNplU3+o Wg+u01QlKmGq0XLAe9TSrLzUlqUfMszSp4p23OFsvw5YVBuufwxgkVu43ZFbnIp2zgnd KhNC5mgjpS7OsMQwft8MTQyr56WiupKdSohfWfEkP77g3cAHemeTVvKB6FloD5uIsZPR FQiO2GcwFDVHMdb5yh6qKjuuQDoWvGZZV3CJIjb/YRlpSntghAQJsgiuaI2+Sy2PlX6u EoJvP1hyzUE9OWKpWO91ZtetG8a8H+OPCCp5nVs4pYLKAA9v1B+BgtldSpRS5v+XFOYj U59g== X-Gm-Message-State: AOAM5304r1bIbQ3JKeLmY8fUEOY1Xx4ckxevxw0JQKyawGN1KtWW3HAm Nr/IRvYyJHyEMOzJS6wPeA== X-Google-Smtp-Source: ABdhPJwBIl+MNB6h2HTYTrEN5YMc98K25OaHILkcATZKTfAT7H2+jo3+d7Pf4mOgjUu+xMOy2WLylg== X-Received: by 2002:a9d:4590:: with SMTP id x16mr3154518ote.94.1628878981431; Fri, 13 Aug 2021 11:23:01 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id bf41sm500815oib.41.2021.08.13.11.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 11:23:00 -0700 (PDT) Received: (nullmailer pid 3804702 invoked by uid 1000); Fri, 13 Aug 2021 18:22:59 -0000 Date: Fri, 13 Aug 2021 13:22:59 -0500 From: Rob Herring To: Joakim Zhang Cc: Andrew Lunn , Florian Fainelli , "davem@davemloft.net" , "kuba@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "kernel@pengutronix.de" , dl-linux-imx , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH net-next 1/3] dt-bindings: net: fsl, fec: add "fsl, wakeup-irq" property Message-ID: References: <20210805074615.29096-1-qiangqing.zhang@nxp.com> <20210805074615.29096-2-qiangqing.zhang@nxp.com> <2e1a14bf-2fa8-ed39-d133-807c4e14859c@gmail.com> <498f3cee-8f37-2ab1-93c4-5472572ecc37@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Aug 11, 2021 at 07:57:46AM +0000, Joakim Zhang wrote: > > Hi Andrew, > > > -----Original Message----- > > From: Andrew Lunn > > Sent: 2021年8月10日 22:33 > > To: Joakim Zhang > > Cc: Florian Fainelli ; davem@davemloft.net; > > kuba@kernel.org; robh+dt@kernel.org; shawnguo@kernel.org; > > s.hauer@pengutronix.de; festevam@gmail.com; kernel@pengutronix.de; > > dl-linux-imx ; netdev@vger.kernel.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > linux-arm-kernel@lists.infradead.org > > Subject: Re: [PATCH net-next 1/3] dt-bindings: net: fsl, fec: add "fsl, > > wakeup-irq" property > > > > > > > 1) FEC controller has up to 4 interrupt lines and all of these are > > > > > routed to GIC > > > > interrupt controller. > > > > > 2) FEC has a wakeup interrupt signal and always are mixed with > > > > > other > > > > interrupt signals, and then output to one interrupt line. > > > > > 3) For legacy SoCs, wakeup interrupt are mixed to int0 line, but > > > > > for i.MX8M > > > > serials, are mixed to int2 line. > > > > So you need to know which of the interrupts listed is the wake up interrupt. We already have a way to do this by using 'wakeup' for the interrupt-names entry. But I guess that ship has sailed here and that wouldn't work well if not just a wakeup source (though you could repeat an interrupt line that's the wakeup source). > > > > I can see a few ways to do this: > > > > The FEC driver already has quirks. Add a quirk to fec_imx8mq_info and > > fec_imx8qm_info to indicate these should use int2. Bingo! Note that if the device is wakeup capable, it should have a 'wakeup-source' property in this case. > > > > or > > > > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > > > > b) two cells > > ------------ > > The #interrupt-cells property is set to 2 and the first cell defines the > > index of the interrupt within the controller, while the second cell is used > > to specify any of the following flags: > > - bits[3:0] trigger type and level flags > > 1 = low-to-high edge triggered > > 2 = high-to-low edge triggered > > 4 = active high level-sensitive > > 8 = active low level-sensitive > > > > You could add > > > > 18 = wakeup source I'd be okay with this (though it should be a power of 2 number). > > > > and extend to core to either do all the work for you, or tell you this interrupt is > > flagged as being a wakeup source. This solution has the advantage of it should > > be usable in other drivers. Another option is couldn't you just enable all the interrupts as wakeup sources? Presumably, only one of them would trigger a wakeup. > > Thanks a lot for your comments first! > > I just look into the irq code, if we extend bit[5] to carry wakeup info ( due to bit[4] is used for IRQ_TYPE_PROBE), > then configure it in the TYPE field of 'interrupts' property, so that interrupt controller would know which interrupt > is wakeup capable. > I think there is no much work core would do, may just set this interrupt wakup capable. Another functionality is > driver side get this info to identify which mixed interrupt has wakeup capability, we can export symbol from kernel/irq/irqdomain.c. > > The intention is to let driver know which interrupt is wakeup capable, I would choose to provider this in specific driver, > instead of interrupt controller, it seems to me that others may all choose this solution for wakeup mixed interrupt. > > So I would prefer solution 1, it's easier and under-control. I can have a try if you strongly recommend solution 2. > > Best Regards, > Joakim Zhang > > Andrew