From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30909C4338F for ; Fri, 13 Aug 2021 14:28:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAE3F6103A for ; Fri, 13 Aug 2021 14:28:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EAE3F6103A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JINM8weIagQwHAK957R3k6O+PBJJI0WVF9LTQ7tf6NI=; b=3m2ZmGWUXpcsXi Bt77Qe5v4Ki49zu8nSNQ4HxzcA3d2IYqbZivCOGHUH3rm75C7Baqthr/9NveFv+flsFAHP7JLu8IX UgmyunO0FOFvgSwSJZsjFv+NO54akF4A6PGm5UTpGeocXBgdhEJSTnOIC7KMZhmXR8e3VXRzHhOTZ /DxPznLlOUNN8Bzy9mBWx7VmNxxvLsU+QEDt3TiAdYgOZWgB2MxkW0tTprzhVoNbWkjBll78NeF0h bGdrbrdafHXdh0zpRmalTd55+eYon0oVhZrYRM6uuqLooZvwvNkCi3PKLzXYVInwLIlpOgFK2RiIv zHX/yZYkeuZv5qV68aDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEY84-00CmUC-4r; Fri, 13 Aug 2021 14:25:48 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEY7y-00CmTf-IX for linux-arm-kernel@lists.infradead.org; Fri, 13 Aug 2021 14:25:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=WlPeAz+fOM46u4crKDyWZXDMo6OIVTCqZUK83A3UzQA=; b=iYRWKU+sLrPy3kawzxm6vKVQj3 Rct6m1QVc+he+YyI0LnY3NIpevKiULYD7Clm0TaWcoaUermgrIY3lvOxWf5GpqZjqHR9U95MbPJjF kM/hXOOfAHUn0/ebPmZrwM3nE68mDNl2Gmyayr0feJJxjAAoCIWFkDDg8VDD+M/YR58c=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mEY7t-00HVYl-QT; Fri, 13 Aug 2021 16:25:37 +0200 Date: Fri, 13 Aug 2021 16:25:37 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: Hongbo Wang , Hongjun Chen , Po Liu , "shawnguo@kernel.org" , Leo Li , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "f.fainelli@gmail.com" , "vivien.didelot@gmail.com" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXT] Re: [PATCH v1] arm64: dts: fsl: ls1028a-rdb: Add dts file to choose swp5 as dsa master Message-ID: References: <20210813030155.23097-1-hongbo.wang@nxp.com> <20210813140745.fwjkmixzgvikvffz@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210813140745.fwjkmixzgvikvffz@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210813_072542_655312_3630E73C X-CRM114-Status: GOOD ( 15.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > this "fsl-ls1028a-rdb-dsa-swp5-eno3.dts" is also for fsl-ls1028a-rdb platform, > > the only difference with "fsl-ls1028a-rdb.dts" is that it use swp5 as dsa master, not swp4, > > and it's based on "fsl-ls1028a-rdb.dts", so I choose this manner, > > if "fsl-ls1028a-rdb.dts" has some modification for new version, this file don't need be changed. > > I tend to agree with Hongbo. What confusion is it going to cause? I don't know if Debian, or any other distribution, ever implemented it, but it was suggested that the install media read the available DT blobs and present the user with a list they can choose from. I've no idea if this was based on the blob filename, or if it read the compatible string. The Compatible string is also printed in the kernel log at boot. If it is not unique, you need further information to figure out the blob sources. We probably needs Rob input. Are there other boards with multiple blobs? Do they use the same or different compatible strings? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294C9C4338F for ; Fri, 13 Aug 2021 14:25:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13E3361042 for ; Fri, 13 Aug 2021 14:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240176AbhHMO0Q (ORCPT ); Fri, 13 Aug 2021 10:26:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48622 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240082AbhHMO0Q (ORCPT ); Fri, 13 Aug 2021 10:26:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=WlPeAz+fOM46u4crKDyWZXDMo6OIVTCqZUK83A3UzQA=; b=iYRWKU+sLrPy3kawzxm6vKVQj3 Rct6m1QVc+he+YyI0LnY3NIpevKiULYD7Clm0TaWcoaUermgrIY3lvOxWf5GpqZjqHR9U95MbPJjF kM/hXOOfAHUn0/ebPmZrwM3nE68mDNl2Gmyayr0feJJxjAAoCIWFkDDg8VDD+M/YR58c=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mEY7t-00HVYl-QT; Fri, 13 Aug 2021 16:25:37 +0200 Date: Fri, 13 Aug 2021 16:25:37 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: Hongbo Wang , Hongjun Chen , Po Liu , "shawnguo@kernel.org" , Leo Li , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "f.fainelli@gmail.com" , "vivien.didelot@gmail.com" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXT] Re: [PATCH v1] arm64: dts: fsl: ls1028a-rdb: Add dts file to choose swp5 as dsa master Message-ID: References: <20210813030155.23097-1-hongbo.wang@nxp.com> <20210813140745.fwjkmixzgvikvffz@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210813140745.fwjkmixzgvikvffz@skbuf> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > > this "fsl-ls1028a-rdb-dsa-swp5-eno3.dts" is also for fsl-ls1028a-rdb platform, > > the only difference with "fsl-ls1028a-rdb.dts" is that it use swp5 as dsa master, not swp4, > > and it's based on "fsl-ls1028a-rdb.dts", so I choose this manner, > > if "fsl-ls1028a-rdb.dts" has some modification for new version, this file don't need be changed. > > I tend to agree with Hongbo. What confusion is it going to cause? I don't know if Debian, or any other distribution, ever implemented it, but it was suggested that the install media read the available DT blobs and present the user with a list they can choose from. I've no idea if this was based on the blob filename, or if it read the compatible string. The Compatible string is also printed in the kernel log at boot. If it is not unique, you need further information to figure out the blob sources. We probably needs Rob input. Are there other boards with multiple blobs? Do they use the same or different compatible strings? Andrew