From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE674C4338F for ; Fri, 13 Aug 2021 15:21:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B215E60F14 for ; Fri, 13 Aug 2021 15:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241710AbhHMPVk (ORCPT ); Fri, 13 Aug 2021 11:21:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:33678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242662AbhHMPSQ (ORCPT ); Fri, 13 Aug 2021 11:18:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D30D860EE4; Fri, 13 Aug 2021 15:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628867869; bh=97FxDBhO+gj5hTWln0ptZn6i/yb6QPwappDqtDluh0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LVeb2thJxXDJATCxsv91PjHEbhEmwPMZw6lcyLvj2UZIfPpWvNmUlmykXYJpviYHv cZR0Ju0yGs3qK4fZZmQMTvFO0WFfGY3JiI621qzAA2bfSW2Ip932jC0+KjhBSUxz2N bggO4B2ddBF1gUzIqJfJq0Q8fvQfCjL7MMKfe3AA= Date: Fri, 13 Aug 2021 17:14:08 +0200 From: gregkh To: Robin Murphy Cc: Qian Cai , =?utf-8?B?dG9tYmluZmFuKOiMg+WFtSk=?= , Bing Fan , linux-serial , linux-kernel , Linux ARM Subject: Re: [Internet]Re: [PATCH v5] arm pl011 serial: support multi-irq request Message-ID: References: <7535ae2f-6a12-8203-0498-8ac85ab0d9a7@arm.com> <290c01ec-173f-755f-788e-2a33a69586e8@quicinc.com> <0819592c-1baa-e98d-9118-5abde8b8c562@quicinc.com> <67cd6c830e33491e99ea4d2480f4a89d@tencent.com> <09918b566884413898f63b92ddd037a0@tencent.com> <0206c94d-c91b-b7da-8132-d06e23c9d964@quicinc.com> <0f77be70-08fd-6fdd-227d-611c01c54788@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f77be70-08fd-6fdd-227d-611c01c54788@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, Aug 13, 2021 at 04:09:50PM +0100, Robin Murphy wrote: > On 2021-08-13 16:01, gregkh wrote: > > On Fri, Aug 13, 2021 at 09:42:52AM -0400, Qian Cai wrote: > > > > > > > > > On 8/12/2021 11:32 PM, tombinfan(范兵) wrote: > > > > hello, > > > > > > > > I have sent the modified patch to the following mailboxes. THX > > > > > > > > gregkh@linuxfoundation.org > > > > linux-serial@vger.kernel.org > > > > linux-kernel@vger.kernel.org > > > > > > Thanks for the pointer. It is good to get some reviews from Arm > > > people in the first place, so we don't break Arm like this. > > > > > > Anyway, for anyone who might be watching, here is the new patch, > > > > > > https://lore.kernel.org/linux-serial/1628825490-18937-1-git-send-email-hptsfb@gmail.com/ > > > > > > Unfortunately, I saw Greg mentioned that it was not based on > > > tty-next, so not something I can apply easily on linux-next here > > > as well. > > > > That is because the code in tty-next (and linux-next), looks to already > > do exactly what you submitted, right? > > > > So is this working now for everyone in linux-next? > > AFAICS commit b0819465be8b in linux-next still results in > amba_device-specific code being called from sbsa_uart_startup() and > sbsa_uart_shutdown(), which is what blows up. Ick, ok, can someone send me a revert with this information in it please? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39068C4338F for ; Fri, 13 Aug 2021 15:19:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 064AD60EE4 for ; Fri, 13 Aug 2021 15:19:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 064AD60EE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/EsviEGPS3H30LLbd5mCOHz5ZSIKPPleMa5y8QBZh20=; b=d/SMJqK1uTT5p8 NHtZUf9VxDvy1X0TTs94ipOqrDJL5A3e2D+ylneLLLouSkjde1XCOmxnnrFYublbMCZr0GKLfCI6e ny8Xhm128IwWJtZB/oD8UzLeAeWXagk8ux27DPK3IIqaxeKooIf0a8wRK9qJBZyEw+mkk3hN3pUgb CyobCmiEitixoQZzsU7B20zEeK/1j17F6cFa7u72toFFLKUqWf3+Hxc9qIYBIvlt/ko8nt1i/towL oCQ6oQ40RALidS0i3x/D+O3st/OvOGQBGGLYa+AyVZDjsyGgoP72G2dZyHsTdmwmUg/VTAVcfXPJh Z2TXgUzHunzFtMHfz0hg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEYwW-00Cva9-Kl; Fri, 13 Aug 2021 15:17:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEYwP-00CvYc-R4 for linux-arm-kernel@lists.infradead.org; Fri, 13 Aug 2021 15:17:53 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D30D860EE4; Fri, 13 Aug 2021 15:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628867869; bh=97FxDBhO+gj5hTWln0ptZn6i/yb6QPwappDqtDluh0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LVeb2thJxXDJATCxsv91PjHEbhEmwPMZw6lcyLvj2UZIfPpWvNmUlmykXYJpviYHv cZR0Ju0yGs3qK4fZZmQMTvFO0WFfGY3JiI621qzAA2bfSW2Ip932jC0+KjhBSUxz2N bggO4B2ddBF1gUzIqJfJq0Q8fvQfCjL7MMKfe3AA= Date: Fri, 13 Aug 2021 17:14:08 +0200 From: gregkh To: Robin Murphy Cc: Qian Cai , =?utf-8?B?dG9tYmluZmFuKOiMg+WFtSk=?= , Bing Fan , linux-serial , linux-kernel , Linux ARM Subject: Re: [Internet]Re: [PATCH v5] arm pl011 serial: support multi-irq request Message-ID: References: <7535ae2f-6a12-8203-0498-8ac85ab0d9a7@arm.com> <290c01ec-173f-755f-788e-2a33a69586e8@quicinc.com> <0819592c-1baa-e98d-9118-5abde8b8c562@quicinc.com> <67cd6c830e33491e99ea4d2480f4a89d@tencent.com> <09918b566884413898f63b92ddd037a0@tencent.com> <0206c94d-c91b-b7da-8132-d06e23c9d964@quicinc.com> <0f77be70-08fd-6fdd-227d-611c01c54788@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0f77be70-08fd-6fdd-227d-611c01c54788@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210813_081749_940302_9EA7C3AB X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBdWcgMTMsIDIwMjEgYXQgMDQ6MDk6NTBQTSArMDEwMCwgUm9iaW4gTXVycGh5IHdy b3RlOgo+IE9uIDIwMjEtMDgtMTMgMTY6MDEsIGdyZWdraCB3cm90ZToKPiA+IE9uIEZyaSwgQXVn IDEzLCAyMDIxIGF0IDA5OjQyOjUyQU0gLTA0MDAsIFFpYW4gQ2FpIHdyb3RlOgo+ID4gPiAKPiA+ ID4gCj4gPiA+IE9uIDgvMTIvMjAyMSAxMTozMiBQTSwgdG9tYmluZmFuKOiMg+WFtSkgd3JvdGU6 Cj4gPiA+ID4gaGVsbG8sCj4gPiA+ID4gCj4gPiA+ID4gSSBoYXZlIHNlbnQgdGhlIG1vZGlmaWVk IHBhdGNoIHRvIHRoZSBmb2xsb3dpbmcgbWFpbGJveGVzLiBUSFgKPiA+ID4gPiAKPiA+ID4gPiBn cmVna2hAbGludXhmb3VuZGF0aW9uLm9yZwo+ID4gPiA+IGxpbnV4LXNlcmlhbEB2Z2VyLmtlcm5l bC5vcmcKPiA+ID4gPiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnCj4gPiA+IAo+ID4gPiBU aGFua3MgZm9yIHRoZSBwb2ludGVyLiBJdCBpcyBnb29kIHRvIGdldCBzb21lIHJldmlld3MgZnJv bSBBcm0KPiA+ID4gcGVvcGxlIGluIHRoZSBmaXJzdCBwbGFjZSwgc28gd2UgZG9uJ3QgYnJlYWsg QXJtIGxpa2UgdGhpcy4KPiA+ID4gCj4gPiA+IEFueXdheSwgZm9yIGFueW9uZSB3aG8gbWlnaHQg YmUgd2F0Y2hpbmcsIGhlcmUgaXMgdGhlIG5ldyBwYXRjaCwKPiA+ID4gCj4gPiA+IGh0dHBzOi8v bG9yZS5rZXJuZWwub3JnL2xpbnV4LXNlcmlhbC8xNjI4ODI1NDkwLTE4OTM3LTEtZ2l0LXNlbmQt ZW1haWwtaHB0c2ZiQGdtYWlsLmNvbS8KPiA+ID4gCj4gPiA+IFVuZm9ydHVuYXRlbHksIEkgc2F3 IEdyZWcgbWVudGlvbmVkIHRoYXQgaXQgd2FzIG5vdCBiYXNlZCBvbgo+ID4gPiB0dHktbmV4dCwg c28gbm90IHNvbWV0aGluZyBJIGNhbiBhcHBseSBlYXNpbHkgb24gbGludXgtbmV4dCBoZXJlCj4g PiA+IGFzIHdlbGwuCj4gPiAKPiA+IFRoYXQgaXMgYmVjYXVzZSB0aGUgY29kZSBpbiB0dHktbmV4 dCAoYW5kIGxpbnV4LW5leHQpLCBsb29rcyB0byBhbHJlYWR5Cj4gPiBkbyBleGFjdGx5IHdoYXQg eW91IHN1Ym1pdHRlZCwgcmlnaHQ/Cj4gPiAKPiA+IFNvIGlzIHRoaXMgd29ya2luZyBub3cgZm9y IGV2ZXJ5b25lIGluIGxpbnV4LW5leHQ/Cj4gCj4gQUZBSUNTIGNvbW1pdCBiMDgxOTQ2NWJlOGIg aW4gbGludXgtbmV4dCBzdGlsbCByZXN1bHRzIGluCj4gYW1iYV9kZXZpY2Utc3BlY2lmaWMgY29k ZSBiZWluZyBjYWxsZWQgZnJvbSBzYnNhX3VhcnRfc3RhcnR1cCgpIGFuZAo+IHNic2FfdWFydF9z aHV0ZG93bigpLCB3aGljaCBpcyB3aGF0IGJsb3dzIHVwLgoKSWNrLCAgb2ssIGNhbiBzb21lb25l IHNlbmQgbWUgYSByZXZlcnQgd2l0aCB0aGlzIGluZm9ybWF0aW9uIGluIGl0CnBsZWFzZT8KCnRo YW5rcywKCmdyZWcgay1oCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==