From: Rob Herring <robh@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Dario Binacchi <dariobin@libero.it>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Wolfgang Grandegger <wg@grandegger.com>,
devicetree@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v5] dt-bindings: net: can: c_can: convert to json-schema
Date: Fri, 13 Aug 2021 14:04:20 -0500 [thread overview]
Message-ID: <YRbCNNPbYSC66gIP@robh.at.kernel.org> (raw)
In-Reply-To: <20210806072045.akase7hseu4wrxxt@pengutronix.de>
On Fri, Aug 06, 2021 at 09:20:45AM +0200, Marc Kleine-Budde wrote:
> On 05.08.2021 21:27:50, Dario Binacchi wrote:
> > Convert the Bosch C_CAN/D_CAN controller device tree binding
> > documentation to json-schema.
> >
> > Document missing properties.
> > Remove "ti,hwmods" as it is no longer used in TI dts.
> > Make "clocks" required as it is used in all dts.
> > Update the examples.
> >
> > Signed-off-by: Dario Binacchi <dariobin@libero.it>
>
> [...]
>
> > +if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - bosch,d_can
> > +
> > +then:
> > + properties:
> > + interrupts:
> > + minItems: 4
> > + maxItems: 4
>
> The driver uses only 1 interrupt, on the other hand the only in-tree
> user the bosch,d_can compatible specifies 4 interrupts.
The DT should reflect all the interrupts. It can't know what some OS or
some version of OS actually uses.
Rob
next prev parent reply other threads:[~2021-08-13 19:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 19:27 [PATCH v5] dt-bindings: net: can: c_can: convert to json-schema Dario Binacchi
2021-08-06 7:20 ` Marc Kleine-Budde
2021-08-13 19:04 ` Rob Herring [this message]
2021-08-13 19:05 ` Rob Herring
2021-08-16 11:15 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRbCNNPbYSC66gIP@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=dariobin@libero.it \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.