From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12170C43214 for ; Fri, 13 Aug 2021 20:13:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FA7D61042 for ; Fri, 13 Aug 2021 20:13:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6FA7D61042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 31A3217F2; Fri, 13 Aug 2021 22:12:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 31A3217F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628885600; bh=MYUzrejtEl7l9RwDqY0F5OpLgetekGe13y2OLZd+CNM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cnNjwfXScPU2nPFXT+QJCoeyYPkDgwLFlxZ3ATNtljkNE631gb5/RNDDdrontHwtL hY8NpS5PXQGnFAx9IsoZjrIqiJr8pLFhKasJgWmFTbEYemi4qAyttCEuL1a4tZ8Xnp 0aZAHnQPko0MR8xs5BN/tXTPLYsyCb+8hN3IHiqw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B11AFF8020D; Fri, 13 Aug 2021 22:12:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 274A3F802D2; Fri, 13 Aug 2021 22:12:27 +0200 (CEST) Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4D145F80129 for ; Fri, 13 Aug 2021 22:12:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4D145F80129 Received: by mail-oi1-f176.google.com with SMTP id t128so17622708oig.1 for ; Fri, 13 Aug 2021 13:12:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=brjSAKvcG3w//6u1qpeaPj8Sen2eVcNEcaY+HnZUn+Q=; b=gIbb/ajbab2AoZN73QnpBsMUPsbpt4Jg1Vg9hu52keFU/I8lONa6zimn0bGWZB0kq0 omJZMdKsuISlJRKI/Pc0c+P9HsykM2D0bNWURTkqQUxc0leB2wWPOI1J0cMUJzkcaFYn WyeIbIFKnhM6WRH/GhWF1Nu+iVPzvW+fBcm8eCds5D2Fp0Rgpeqfdxavm5M0KR/ueVSW EQflMDQRzdY9BeAb95MOfd3DHQhYPYxKyok16eStL34rY/ozDkVwMV1rY1KVQXynubbO 5jHL2TSyMCloztVv3ZeXQMa4eK/hpKhkgpJOLQgSqPFBZpXRv7rsAr6gNOJYmA0yQgnH V01A== X-Gm-Message-State: AOAM532o4Qe1fMx7ma2ykALddkUfKrdii8L5yCan5TmT18TyjKOvNuTo d+25ME98zr44LPdb/2ycjg== X-Google-Smtp-Source: ABdhPJwGTSMtK+9NYP9pDRzcZrjvm0ClM2a1UqumCqT/+n4os3icmryyREvNZp/z5ivhq9qWazn64A== X-Received: by 2002:a05:6808:1906:: with SMTP id bf6mr3371811oib.52.1628885537689; Fri, 13 Aug 2021 13:12:17 -0700 (PDT) Received: from robh.at.kernel.org (2603-8080-2a06-ed00-7254-0b80-dd3c-00c6.res6.spectrum.com. [2603:8080:2a06:ed00:7254:b80:dd3c:c6]) by smtp.gmail.com with ESMTPSA id t13sm453083oor.37.2021.08.13.13.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 13:12:17 -0700 (PDT) Received: (nullmailer pid 3944256 invoked by uid 1000); Fri, 13 Aug 2021 20:12:15 -0000 Date: Fri, 13 Aug 2021 15:12:15 -0500 From: Rob Herring To: Geert Uytterhoeven Subject: Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters Message-ID: References: <20210806102930.3024-1-biju.das.jz@bp.renesas.com> <20210806102930.3024-3-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA Development Mailing List , Geert Uytterhoeven , Kuninori Morimoto , Prabhakar Mahadev Lad , Liam Girdwood , Biju Das , Linux-Renesas , Vinod Koul , Mark Brown , Chris Paterson , Biju Das , Chris Brandt X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Aug 09, 2021 at 02:57:33PM +0200, Geert Uytterhoeven wrote: > Hi Biju, > > On Fri, Aug 6, 2021 at 12:29 PM Biju Das wrote: > > The DMAC driver on RZ/G2L expects the slave channel configuration > > to be passed in dmas property. > > This patch updates the example node to include the encoded slave > > channel configuration. > > > > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support") > > Signed-off-by: Biju Das > > Reviewed-by: Lad Prabhakar > > > v3->v4: > > * Updated bindings as the DMAC driver on RZ/G2L expects the > > slave channel configuration to be passed in dmas property. > > Thanks for the update! > > > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > > @@ -93,8 +93,8 @@ examples: > > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; > > power-domains = <&cpg>; > > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>; > > - dmas = <&dmac 0x255>, > > - <&dmac 0x256>; > > + dmas = <&dmac 0x2655>, > > + <&dmac 0x2656>; > > dma-names = "tx", "rx"; > > #sound-dai-cells = <0>; > > }; > > I think it would be good to describe the expected format in the description > for the dmas property, so the DTS writer knows what the numerical > values in the example really mean. Yes, but that's a property of the DMA controller binding, not this one. It could vary from chip to chip. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC22C4320A for ; Fri, 13 Aug 2021 20:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 434E761042 for ; Fri, 13 Aug 2021 20:12:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234363AbhHMUMp (ORCPT ); Fri, 13 Aug 2021 16:12:45 -0400 Received: from mail-oi1-f177.google.com ([209.85.167.177]:44613 "EHLO mail-oi1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234313AbhHMUMp (ORCPT ); Fri, 13 Aug 2021 16:12:45 -0400 Received: by mail-oi1-f177.google.com with SMTP id w6so17529733oiv.11; Fri, 13 Aug 2021 13:12:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=brjSAKvcG3w//6u1qpeaPj8Sen2eVcNEcaY+HnZUn+Q=; b=h2AeIqOK5E+5VKn0bTaR0fJoNZ91hJRFmWJf7amBLAW7AAoqNv+hEhJBIeWq2cnP/p oiYBg7oaehrVqkGPCkPKuxktF4oRXTMJQlu+/A1XLJXNnbFYhbnXfVnEIk4SaVdJUagV WzVEnN3ildSEFxZYpGUqGBBgR0rwDFxdWiphvjRt+BT7tGylrfOdLPnR7mPdGb4F2JSN Uz8MfK+YLBiwbn8lG8AWUl4ptTPCN0+/XVrGTlJWAzkbi27blgubJ6dX9dYgjFb7U9bZ IrrNEUv58O4E1Yg4MBvuynkCKYCA9YGA8HdbfXA2Tu9S2RqbbqnwSqPjO0SQf02jL8w3 bxbg== X-Gm-Message-State: AOAM531NCiDPhBFhevqXUF4/yeEFL33W1m//4KW+/MiGjFAfEtte79EZ lAMZlvbedK7wABstgl1E6i3+ktJD6A== X-Google-Smtp-Source: ABdhPJwGTSMtK+9NYP9pDRzcZrjvm0ClM2a1UqumCqT/+n4os3icmryyREvNZp/z5ivhq9qWazn64A== X-Received: by 2002:a05:6808:1906:: with SMTP id bf6mr3371811oib.52.1628885537689; Fri, 13 Aug 2021 13:12:17 -0700 (PDT) Received: from robh.at.kernel.org (2603-8080-2a06-ed00-7254-0b80-dd3c-00c6.res6.spectrum.com. [2603:8080:2a06:ed00:7254:b80:dd3c:c6]) by smtp.gmail.com with ESMTPSA id t13sm453083oor.37.2021.08.13.13.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 13:12:17 -0700 (PDT) Received: (nullmailer pid 3944256 invoked by uid 1000); Fri, 13 Aug 2021 20:12:15 -0000 Date: Fri, 13 Aug 2021 15:12:15 -0500 From: Rob Herring To: Geert Uytterhoeven Cc: Biju Das , Liam Girdwood , Mark Brown , Vinod Koul , Chris Brandt , Kuninori Morimoto , ALSA Development Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad , Linux-Renesas Subject: Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters Message-ID: References: <20210806102930.3024-1-biju.das.jz@bp.renesas.com> <20210806102930.3024-3-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Mon, Aug 09, 2021 at 02:57:33PM +0200, Geert Uytterhoeven wrote: > Hi Biju, > > On Fri, Aug 6, 2021 at 12:29 PM Biju Das wrote: > > The DMAC driver on RZ/G2L expects the slave channel configuration > > to be passed in dmas property. > > This patch updates the example node to include the encoded slave > > channel configuration. > > > > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support") > > Signed-off-by: Biju Das > > Reviewed-by: Lad Prabhakar > > > v3->v4: > > * Updated bindings as the DMAC driver on RZ/G2L expects the > > slave channel configuration to be passed in dmas property. > > Thanks for the update! > > > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml > > @@ -93,8 +93,8 @@ examples: > > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; > > power-domains = <&cpg>; > > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>; > > - dmas = <&dmac 0x255>, > > - <&dmac 0x256>; > > + dmas = <&dmac 0x2655>, > > + <&dmac 0x2656>; > > dma-names = "tx", "rx"; > > #sound-dai-cells = <0>; > > }; > > I think it would be good to describe the expected format in the description > for the dmas property, so the DTS writer knows what the numerical > values in the example really mean. Yes, but that's a property of the DMA controller binding, not this one. It could vary from chip to chip. Rob