From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C283C4338F for ; Fri, 13 Aug 2021 22:24:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB73F610EA for ; Fri, 13 Aug 2021 22:24:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB73F610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 433811782; Sat, 14 Aug 2021 00:23:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 433811782 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628893448; bh=hcoCcqTEKhAgWMqSboxEuD80WB/nWnzjDnYaJEXj8L4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=k6ZMnpS+/374Ld8jzFL+qA/KJb/NzYjLbzjOdzi7znp7X5aDYzMzZeEArP0SF6qrp rhvtltPeCWT5dYhQbJYEY/Ys+5x58DGY1vwjGydepyncor/UV8g3R8OKOUDpuXasrB 1aPsDvEtk/99o8oNoW4hlrI0mmVXhzkUGQS6Bp7M= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CAA31F8020D; Sat, 14 Aug 2021 00:23:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C853EF802D2; Sat, 14 Aug 2021 00:23:15 +0200 (CEST) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E314DF80129 for ; Sat, 14 Aug 2021 00:23:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E314DF80129 Received: by mail-oi1-f174.google.com with SMTP id w6so18014510oiv.11 for ; Fri, 13 Aug 2021 15:23:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jC2PUYWO6/b2RNk6g7rayeCm9jNbK7Ru4h0UAMkLO4w=; b=AYuBvi9Rkp2Ls/kym63smEttOlSWsutqnBEQspiTtbC0iIr40GskZZTqeuzJEcTR7E ZqNEzV3VrBLirOhKBpYdhB8YdpG6Pua2Lfbnf4c98+rLMs8VmNeYXJheZlS9esNVUZ+t sukvLyPsmUlcI4Yj/wb5Uy9RgdHGk3VX3XFYYX8cECatCVi7yhoQ4Kc2cPOXc4ircZjM OcpOPKlGJyzztpsqPNGzBEDPbac8d+L61JuUkY8aDbi0H7z5bk61MvJmOYnb+Y9TLjlq bAHlWPX/U/dJuatayDT5APrh1UD+DtGisDK8pv22sgiGiNzBna3Idz5mAsEKKK6p+x/K B3IQ== X-Gm-Message-State: AOAM5327MNrGSdc9deAgoW2zBn3Ykf8+6tIvXba7TJnJnl8PuXLmFikG laUXPCNqERcAZ79N4GscyA== X-Google-Smtp-Source: ABdhPJyUUN4I1uIXZyw9oxHDZusxdXapylWJtreLq2VsbbxT8qfPv1qHmQvenD+ZV/RnDYQf+EAEkg== X-Received: by 2002:aca:60d6:: with SMTP id u205mr3773176oib.99.1628893386667; Fri, 13 Aug 2021 15:23:06 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id d2sm574798otl.32.2021.08.13.15.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 15:23:05 -0700 (PDT) Received: (nullmailer pid 4044137 invoked by uid 1000); Fri, 13 Aug 2021 22:23:04 -0000 Date: Fri, 13 Aug 2021 17:23:04 -0500 From: Rob Herring To: Srinivas Kandagatla Subject: Re: [PATCH v4 01/20] soc: dt-bindings: qcom: apr: convert to yaml Message-ID: References: <20210809112339.8368-1-srinivas.kandagatla@linaro.org> <20210809112339.8368-2-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210809112339.8368-2-srinivas.kandagatla@linaro.org> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, tiwai@suse.de, plai@codeaurora.org, lgirdwood@gmail.com, broonie@kernel.org, bjorn.andersson@linaro.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Aug 09, 2021 at 12:23:20PM +0100, Srinivas Kandagatla wrote: > Convert APR bindings to yaml format so that we could add new bindings support. > > All the dsp services bindings are now part of apr bindings instead > of adding them to audio bindings. > > Signed-off-by: Srinivas Kandagatla > --- > .../devicetree/bindings/soc/qcom/qcom,apr.txt | 134 ------------------ > .../bindings/soc/qcom/qcom,apr.yaml | 127 +++++++++++++++++ > 2 files changed, 127 insertions(+), 134 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > deleted file mode 100644 > index 2e2f6dc351c0..000000000000 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > +++ /dev/null > @@ -1,134 +0,0 @@ > -Qualcomm APR (Asynchronous Packet Router) binding > - > -This binding describes the Qualcomm APR. APR is a IPC protocol for > -communication between Application processor and QDSP. APR is mainly > -used for audio/voice services on the QDSP. > - > -- compatible: > - Usage: required > - Value type: > - Definition: must be "qcom,apr-v", example "qcom,apr-v2" > - > -- qcom,apr-domain > - Usage: required > - Value type: > - Definition: Destination processor ID. > - Possible values are : > - 1 - APR simulator > - 2 - PC > - 3 - MODEM > - 4 - ADSP > - 5 - APPS > - 6 - MODEM2 > - 7 - APPS2 > - > -= APR SERVICES > -Each subnode of the APR node represents service tied to this apr. The name > -of the nodes are not important. The properties of these nodes are defined > -by the individual bindings for the specific service > -- All APR services MUST contain the following property: > - > -- reg > - Usage: required > - Value type: > - Definition: APR Service ID > - Possible values are : > - 3 - DSP Core Service > - 4 - Audio Front End Service. > - 5 - Voice Stream Manager Service. > - 6 - Voice processing manager. > - 7 - Audio Stream Manager Service. > - 8 - Audio Device Manager Service. > - 9 - Multimode voice manager. > - 10 - Core voice stream. > - 11 - Core voice processor. > - 12 - Ultrasound stream manager. > - 13 - Listen stream manager. > - > -- qcom,protection-domain > - Usage: optional > - Value type: > - Definition: Must list the protection domain service name and path > - that the particular apr service has a dependency on. > - Possible values are : > - "avs/audio", "msm/adsp/audio_pd". > - "kernel/elf_loader", "msm/modem/wlan_pd". > - "tms/servreg", "msm/adsp/audio_pd". > - "tms/servreg", "msm/modem/wlan_pd". > - "tms/servreg", "msm/slpi/sensor_pd". > - > -= EXAMPLE > -The following example represents a QDSP based sound card on a MSM8996 device > -which uses apr as communication between Apps and QDSP. > - > - apr { > - compatible = "qcom,apr-v2"; > - qcom,apr-domain = ; > - > - apr-service@3 { > - compatible = "qcom,q6core"; > - reg = ; > - }; > - > - apr-service@4 { > - compatible = "qcom,q6afe"; > - reg = ; > - > - dais { > - #sound-dai-cells = <1>; > - dai@1 { > - reg = ; > - }; > - }; > - }; > - > - apr-service@7 { > - compatible = "qcom,q6asm"; > - reg = ; > - ... > - }; > - > - apr-service@8 { > - compatible = "qcom,q6adm"; > - reg = ; > - ... > - }; > - }; > - > -= EXAMPLE 2 > -The following example represents a QDSP based sound card with protection domain > -dependencies specified. Here some of the apr services are dependent on services > -running on protection domain hosted on ADSP/SLPI remote processors while others > -have no such dependency. > - > - apr { > - compatible = "qcom,apr-v2"; > - qcom,glink-channels = "apr_audio_svc"; > - qcom,apr-domain = ; > - > - apr-service@3 { > - compatible = "qcom,q6core"; > - reg = ; > - }; > - > - q6afe: apr-service@4 { > - compatible = "qcom,q6afe"; > - reg = ; > - qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > - ... > - }; > - > - q6asm: apr-service@7 { > - compatible = "qcom,q6asm"; > - reg = ; > - qcom,protection-domain = "tms/servreg", "msm/slpi/sensor_pd"; > - ... > - }; > - > - q6adm: apr-service@8 { > - compatible = "qcom,q6adm"; > - reg = ; > - qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > - ... > - }; > - }; > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml > new file mode 100644 > index 000000000000..12650f7084f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml > @@ -0,0 +1,127 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,apr.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm APR (Asynchronous Packet Router) binding > + > +maintainers: > + - Srinivas Kandagatla > + > +description: | > + This binding describes the Qualcomm APR, APR is a IPC protocol for > + communication between Application processor and QDSP. APR is mainly > + used for audio/voice services on the QDSP. > + > +properties: > + compatible: > + enum: > + - qcom,apr This wasn't a valid compatible before. > + - qcom,apr-v2 > + > + qcom,apr-domain: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 3, 4, 5, 6, 7] > + description: > + Selects the processor domain for apr > + 1 = APR simulator > + 2 = PC Domain > + 3 = Modem Domain > + 4 = ADSP Domain > + 5 = Application processor Domain > + 6 = Modem2 Domain > + 7 = Application Processor2 Domain > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > +#APR Services > +patternProperties: > + "^apr-service@[0-9a-e]$": Based on reg, this should be: [3-9a-d] > + type: object > + description: > + APR node's client devices use subnodes for desired static port services. > + > + properties: > + compatible: > + enum: > + - qcom,q6core > + - qcom,q6asm > + - qcom,q6afe > + - qcom,q6adm > + > + reg: > + enum: [3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13] > + description: > + APR Service ID > + 3 = DSP Core Service > + 4 = Audio Front End Service. > + 5 = Voice Stream Manager Service. > + 6 = Voice processing manager. > + 7 = Audio Stream Manager Service. > + 8 = Audio Device Manager Service. > + 9 = Multimode voice manager. > + 10 = Core voice stream. > + 11 = Core voice processor. > + 12 = Ultrasound stream manager. > + 13 = Listen stream manager. > + > + qcom,protection-domain: > + $ref: /schemas/types.yaml#/definitions/string-array > + description: protection domain service name and path for apr service > + has dependency on. > + items: > + - const: avs/audio > + - const: msm/adsp/audio_pd You've dropped a bunch of possible values. > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + additionalProperties: false > + > +required: > + - compatible > + - qcom,apr-domain > + > +additionalProperties: false > + > +examples: > + - | > + #include > + apr { > + compatible = "qcom,apr-v2"; > + qcom,apr-domain = ; > + #address-cells = <1>; > + #size-cells = <0>; > + > + q6core: apr-service@3 { > + compatible = "qcom,q6core"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + }; > + > + q6afe: apr-service@4 { > + compatible = "qcom,q6afe"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + }; > + > + q6asm: apr-service@7 { > + compatible = "qcom,q6asm"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + }; > + > + q6adm: apr-service@8 { > + compatible = "qcom,q6adm"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + }; > + }; > -- > 2.21.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ADCFC432BE for ; Fri, 13 Aug 2021 22:23:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5F9C610CF for ; Fri, 13 Aug 2021 22:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235032AbhHMWXg (ORCPT ); Fri, 13 Aug 2021 18:23:36 -0400 Received: from mail-oi1-f176.google.com ([209.85.167.176]:39875 "EHLO mail-oi1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234982AbhHMWXe (ORCPT ); Fri, 13 Aug 2021 18:23:34 -0400 Received: by mail-oi1-f176.google.com with SMTP id bj40so18117835oib.6 for ; Fri, 13 Aug 2021 15:23:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jC2PUYWO6/b2RNk6g7rayeCm9jNbK7Ru4h0UAMkLO4w=; b=sduJxEeXptp6q0JzXQI4iGNVMzondUWw5iVvdNbwsU/qSgZA5R5resfXu04yKWykBn 7SZzG4jVg0mfSvkkm7/FzXSQEQqgaJScASFgELdM5/DApbbO/WKg3M1IBlAiSlBu/G6A YKbLTf5rJdKBg/JbcEQebxPysL2hGSd8jPS1ySJHENCA47tHxMhGDYiJ+Xw6MOptWgRP 0qSZaRUy6uGHtkGcwl9eT2EJD2QvHJj2NfCq9YO2VwrRSLnBeQYCG8jwsIEs3gOnVr05 CXBVHDn3mfNbZ8aTA6DxO1aYNxJth1cKeAHQ3fqWioLH/yi87dbaMO63D/t6SOXvxKPw QLQA== X-Gm-Message-State: AOAM532Jiojm1VXl58dO2V6FSQS2Qudub7VB5UZ3/ORBmMepj9JJInfv To1dDefU6zvj4gj0hM7c8Q== X-Google-Smtp-Source: ABdhPJyUUN4I1uIXZyw9oxHDZusxdXapylWJtreLq2VsbbxT8qfPv1qHmQvenD+ZV/RnDYQf+EAEkg== X-Received: by 2002:aca:60d6:: with SMTP id u205mr3773176oib.99.1628893386667; Fri, 13 Aug 2021 15:23:06 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id d2sm574798otl.32.2021.08.13.15.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 15:23:05 -0700 (PDT) Received: (nullmailer pid 4044137 invoked by uid 1000); Fri, 13 Aug 2021 22:23:04 -0000 Date: Fri, 13 Aug 2021 17:23:04 -0500 From: Rob Herring To: Srinivas Kandagatla Cc: bjorn.andersson@linaro.org, broonie@kernel.org, plai@codeaurora.org, tiwai@suse.de, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, lgirdwood@gmail.com, bgoswami@codeaurora.org Subject: Re: [PATCH v4 01/20] soc: dt-bindings: qcom: apr: convert to yaml Message-ID: References: <20210809112339.8368-1-srinivas.kandagatla@linaro.org> <20210809112339.8368-2-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210809112339.8368-2-srinivas.kandagatla@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Aug 09, 2021 at 12:23:20PM +0100, Srinivas Kandagatla wrote: > Convert APR bindings to yaml format so that we could add new bindings support. > > All the dsp services bindings are now part of apr bindings instead > of adding them to audio bindings. > > Signed-off-by: Srinivas Kandagatla > --- > .../devicetree/bindings/soc/qcom/qcom,apr.txt | 134 ------------------ > .../bindings/soc/qcom/qcom,apr.yaml | 127 +++++++++++++++++ > 2 files changed, 127 insertions(+), 134 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > deleted file mode 100644 > index 2e2f6dc351c0..000000000000 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt > +++ /dev/null > @@ -1,134 +0,0 @@ > -Qualcomm APR (Asynchronous Packet Router) binding > - > -This binding describes the Qualcomm APR. APR is a IPC protocol for > -communication between Application processor and QDSP. APR is mainly > -used for audio/voice services on the QDSP. > - > -- compatible: > - Usage: required > - Value type: > - Definition: must be "qcom,apr-v", example "qcom,apr-v2" > - > -- qcom,apr-domain > - Usage: required > - Value type: > - Definition: Destination processor ID. > - Possible values are : > - 1 - APR simulator > - 2 - PC > - 3 - MODEM > - 4 - ADSP > - 5 - APPS > - 6 - MODEM2 > - 7 - APPS2 > - > -= APR SERVICES > -Each subnode of the APR node represents service tied to this apr. The name > -of the nodes are not important. The properties of these nodes are defined > -by the individual bindings for the specific service > -- All APR services MUST contain the following property: > - > -- reg > - Usage: required > - Value type: > - Definition: APR Service ID > - Possible values are : > - 3 - DSP Core Service > - 4 - Audio Front End Service. > - 5 - Voice Stream Manager Service. > - 6 - Voice processing manager. > - 7 - Audio Stream Manager Service. > - 8 - Audio Device Manager Service. > - 9 - Multimode voice manager. > - 10 - Core voice stream. > - 11 - Core voice processor. > - 12 - Ultrasound stream manager. > - 13 - Listen stream manager. > - > -- qcom,protection-domain > - Usage: optional > - Value type: > - Definition: Must list the protection domain service name and path > - that the particular apr service has a dependency on. > - Possible values are : > - "avs/audio", "msm/adsp/audio_pd". > - "kernel/elf_loader", "msm/modem/wlan_pd". > - "tms/servreg", "msm/adsp/audio_pd". > - "tms/servreg", "msm/modem/wlan_pd". > - "tms/servreg", "msm/slpi/sensor_pd". > - > -= EXAMPLE > -The following example represents a QDSP based sound card on a MSM8996 device > -which uses apr as communication between Apps and QDSP. > - > - apr { > - compatible = "qcom,apr-v2"; > - qcom,apr-domain = ; > - > - apr-service@3 { > - compatible = "qcom,q6core"; > - reg = ; > - }; > - > - apr-service@4 { > - compatible = "qcom,q6afe"; > - reg = ; > - > - dais { > - #sound-dai-cells = <1>; > - dai@1 { > - reg = ; > - }; > - }; > - }; > - > - apr-service@7 { > - compatible = "qcom,q6asm"; > - reg = ; > - ... > - }; > - > - apr-service@8 { > - compatible = "qcom,q6adm"; > - reg = ; > - ... > - }; > - }; > - > -= EXAMPLE 2 > -The following example represents a QDSP based sound card with protection domain > -dependencies specified. Here some of the apr services are dependent on services > -running on protection domain hosted on ADSP/SLPI remote processors while others > -have no such dependency. > - > - apr { > - compatible = "qcom,apr-v2"; > - qcom,glink-channels = "apr_audio_svc"; > - qcom,apr-domain = ; > - > - apr-service@3 { > - compatible = "qcom,q6core"; > - reg = ; > - }; > - > - q6afe: apr-service@4 { > - compatible = "qcom,q6afe"; > - reg = ; > - qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > - ... > - }; > - > - q6asm: apr-service@7 { > - compatible = "qcom,q6asm"; > - reg = ; > - qcom,protection-domain = "tms/servreg", "msm/slpi/sensor_pd"; > - ... > - }; > - > - q6adm: apr-service@8 { > - compatible = "qcom,q6adm"; > - reg = ; > - qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > - ... > - }; > - }; > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml > new file mode 100644 > index 000000000000..12650f7084f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml > @@ -0,0 +1,127 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,apr.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm APR (Asynchronous Packet Router) binding > + > +maintainers: > + - Srinivas Kandagatla > + > +description: | > + This binding describes the Qualcomm APR, APR is a IPC protocol for > + communication between Application processor and QDSP. APR is mainly > + used for audio/voice services on the QDSP. > + > +properties: > + compatible: > + enum: > + - qcom,apr This wasn't a valid compatible before. > + - qcom,apr-v2 > + > + qcom,apr-domain: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [1, 2, 3, 4, 5, 6, 7] > + description: > + Selects the processor domain for apr > + 1 = APR simulator > + 2 = PC Domain > + 3 = Modem Domain > + 4 = ADSP Domain > + 5 = Application processor Domain > + 6 = Modem2 Domain > + 7 = Application Processor2 Domain > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > +#APR Services > +patternProperties: > + "^apr-service@[0-9a-e]$": Based on reg, this should be: [3-9a-d] > + type: object > + description: > + APR node's client devices use subnodes for desired static port services. > + > + properties: > + compatible: > + enum: > + - qcom,q6core > + - qcom,q6asm > + - qcom,q6afe > + - qcom,q6adm > + > + reg: > + enum: [3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13] > + description: > + APR Service ID > + 3 = DSP Core Service > + 4 = Audio Front End Service. > + 5 = Voice Stream Manager Service. > + 6 = Voice processing manager. > + 7 = Audio Stream Manager Service. > + 8 = Audio Device Manager Service. > + 9 = Multimode voice manager. > + 10 = Core voice stream. > + 11 = Core voice processor. > + 12 = Ultrasound stream manager. > + 13 = Listen stream manager. > + > + qcom,protection-domain: > + $ref: /schemas/types.yaml#/definitions/string-array > + description: protection domain service name and path for apr service > + has dependency on. > + items: > + - const: avs/audio > + - const: msm/adsp/audio_pd You've dropped a bunch of possible values. > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + additionalProperties: false > + > +required: > + - compatible > + - qcom,apr-domain > + > +additionalProperties: false > + > +examples: > + - | > + #include > + apr { > + compatible = "qcom,apr-v2"; > + qcom,apr-domain = ; > + #address-cells = <1>; > + #size-cells = <0>; > + > + q6core: apr-service@3 { > + compatible = "qcom,q6core"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + }; > + > + q6afe: apr-service@4 { > + compatible = "qcom,q6afe"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + }; > + > + q6asm: apr-service@7 { > + compatible = "qcom,q6asm"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + }; > + > + q6adm: apr-service@8 { > + compatible = "qcom,q6adm"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + }; > + }; > -- > 2.21.0 > >