From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E96B2F80 for ; Mon, 16 Aug 2021 07:12:03 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3C9296023E; Mon, 16 Aug 2021 07:12:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629097922; bh=wuC3MbKwNcYgbRdNFJ0/jHurY/1bsRRkCdawma6fyec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yjxbn0WjN6lBB+eErzldT52ZiTS5ASm7BUmcveyRDhvsicLuYCaXRDfOzD3YRXZqW FsEqxoJhPTgiqQPHY4UTrIQJOQuIcmfEw59jgZJVwI0+J9TUHxl2bqTSq0U+Pc9V7B jk66hVaSQoqMJ2hLzmr7HORgt1U5x05+vSmQ4t5w= Date: Mon, 16 Aug 2021 09:12:00 +0200 From: Greg KH To: Phillip Potter Cc: Larry.Finger@lwfinger.net, straube.linux@gmail.com, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: remove unused variable and DBG_88E in hal/rtl8188e_cmd.c Message-ID: References: <20210815230518.91656-1-phil@philpotter.co.uk> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210815230518.91656-1-phil@philpotter.co.uk> On Mon, Aug 16, 2021 at 12:05:18AM +0100, Phillip Potter wrote: > Remove set but unused variable init_rate from rtl8188e_Add_RateATid > function in hal/rtl8188e_cmd.c, as it fixes a kernel test robot warning. > Removing the call to get_highest_rate_idx has no side effects here so is > safe. > > Also remove the DBG_88E macro call in this function, as it is not > particularly clear in my opinion. Additionally, rename variable > shortGIrate to short_gi_rate to conform to kernel camel case rules, > and improve general spacing around operators, some of which triggers > checkpatch 'CHECK' messages. These are not related to the test robot > warning. > > Reported-by: kernel test robot > Signed-off-by: Phillip Potter > --- > drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) As Fabio said, this should be split up into multiple patches. If you ever have to say "also" in a changelog text, that's a good hint that the patch should be broken up. thanks, greg k-h