From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C35C4338F for ; Mon, 16 Aug 2021 07:46:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55D4E61ADF for ; Mon, 16 Aug 2021 07:46:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 55D4E61ADF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aVmkEdKEomDTyn0HAuC9WczSX4jJtwmhybHnNMxm1vQ=; b=Lgh4tePpwIkZFi Blbp7b+FxQHljRHZnGdUSEzDLFuqX+B6i35T4AIhPiuLArVixkoDcfy5GHEhngUNXNZ/nk1gN5icO JovI3z7mM+lafUteiTetu5E2xArqCN7vDG5s8fCS/WTNOmaSlmq8KMkTLHj3yZBZp56+pJSYa0WET E+zoAQusSzgzqGweKug8jPLvMUXUEIqE6uTaO2DgCTHLHoGeTvy2IeFg5pSw32oUEFdqbMV/xnscX nssupNsdJETXcFkOFFE/QbGdEaOnHsbLdgVC+/G83w+Jk2uCBhz8Kpa+wWrOz2W1ae1teqlw2NoFL E3iZi19fLPr4WOIo4PIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFXI8-00GPob-MT; Mon, 16 Aug 2021 07:44:16 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFXHm-00GPhq-P5 for linux-arm-kernel@lists.infradead.org; Mon, 16 Aug 2021 07:43:58 +0000 Received: by mail-wr1-x433.google.com with SMTP id v4so15046120wro.12 for ; Mon, 16 Aug 2021 00:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ZqL0RGrRiTOD68QIEn9gbIo3HjYGdm7ebHQq8KAmFwI=; b=m2U/rhpi57WfQtcrjZShp+0U0iUZrCIeIlL3o+QA8dx/Znh9WXz8YKHNBycvwTff6B r4CpSM11RJkPX15PcDtkD1u6NuCBghhqBlHHuvr+w8poh3t2NnI0mTo3iFGoa/98mzSH ik1T10K8BXVUrfQdQgRv1wdMsSWqj736m0eSdVijmoOL1EQngLvxrUEjW6Fh9blV1N8b 300O70y/IItVEuTAQQQgu8sZU55xGJbDcCTw1XFtcOr0dL8Dv1w5etRJXXXiSVEOaQke h/hJJxCqEjMRBo93LKo+hg2SW1l+gz6MgsBHvdWDbUNxzzTA1pk3hrZNffZ7713vpqlr Pfzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ZqL0RGrRiTOD68QIEn9gbIo3HjYGdm7ebHQq8KAmFwI=; b=AmQv64qXiqbXsS0+ukypM9mkVfZw/F7sxNxP/FzelxrFLC29LT3jqYKGFWNGqypQuH +BWDEGU+XUyk7NxTQg++ChNuw9wfNIE0rjJQAEFbPqdUyYQrJkKwqsCfsa1DTA1KiWhT Gaqbkl4E53BtPhThwyneQqzZxtaQYDVvnl5l8IT2pNMOChdbOneJbEfu6dBJHSMWIgGv jlJwKP0NhP+KxNHheTRSaFxVoFk0CDftTYzcrXVzjyOCyWdOZnyb+Y6vBjCe43Hublpk mjjzP+4HS/HQaXELL+YwL8l+x3X01lVfgGCHgIa5hLfQg9/0oM2R/2OF52t5iRnvIblW aZxA== X-Gm-Message-State: AOAM532rztxnLlzFhsqGfxEeOIUptubufyvBiFO91dbYWOrkAeZS+1xk bznrr35ssfK/+K0a3+CWVzJPtg== X-Google-Smtp-Source: ABdhPJyN5it7Ymm9ZTJeLU7IN52N9VqFMrVEYXMmgmJ++xpct2mZFk4mzNlgx1OKoKqKKCLP5rTY8g== X-Received: by 2002:a5d:634a:: with SMTP id b10mr17103251wrw.305.1629099832597; Mon, 16 Aug 2021 00:43:52 -0700 (PDT) Received: from google.com ([2.31.167.59]) by smtp.gmail.com with ESMTPSA id f10sm10391869wrx.40.2021.08.16.00.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 00:43:52 -0700 (PDT) Date: Mon, 16 Aug 2021 08:43:53 +0100 From: Lee Jones To: Thomas Gleixner Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ming Lei , Hannes Reinecke Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG Message-ID: References: <20210617073136.315723-1-lee.jones@linaro.org> <8735rhs7n6.ffs@tglx> <87fsvgp4jd.ffs@tglx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87fsvgp4jd.ffs@tglx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_004354_898415_2AB4EF29 X-CRM114-Status: GOOD ( 23.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxMSBBdWcgMjAyMSwgVGhvbWFzIEdsZWl4bmVyIHdyb3RlOgoKPiBPbiBXZWQsIEF1 ZyAxMSAyMDIxIGF0IDA4OjU3LCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBUdWUsIDEwIEF1ZyAy MDIxLCBUaG9tYXMgR2xlaXhuZXIgd3JvdGU6Cj4gPj4gPiBAQCAtNDIsNyArNDIsNyBAQCBzdGF0 aWMgaW5saW5lIGJvb2wgaXJxX25lZWRzX2ZpeHVwKHN0cnVjdCBpcnFfZGF0YSAqZCkKPiA+PiA+ ICAJCSAqIElmIHRoaXMgaGFwcGVucyB0aGVuIHRoZXJlIHdhcyBhIG1pc3NlZCBJUlEgZml4dXAg YXQgc29tZQo+ID4+ID4gIAkJICogcG9pbnQuIFdhcm4gYWJvdXQgaXQgYW5kIGVuZm9yY2UgZml4 dXAuCj4gPj4gPiAgCQkgKi8KPiA+PiA+IC0JCXByX3dhcm4oIkVmZi4gYWZmaW5pdHkgJSpwYmwg b2YgSVJRICV1IGNvbnRhaW5zIG9ubHkgb2ZmbGluZSBDUFVzIGFmdGVyIG9mZmxpbmluZyBDUFUg JXVcbiIsCj4gPj4gCj4gPj4gVGhpcyBvbmUgaXMgY2xlYXJseSBhIHdhcm5pbmcgYXMgdGhpcyBz aG91bGQgbm90IGhhcHBlbi4gU2VlIHRoZQo+ID4+IGNvbW1lbnRzIGFyb3VuZCB0aGF0Lgo+ID4+ IAo+ID4+ID4gKwkJcHJfZGVidWcoIkVmZi4gYWZmaW5pdHkgJSpwYmwgb2YgSVJRICV1IGNvbnRh aW5zIG9ubHkgb2ZmbGluZSBDUFVzIGFmdGVyIG9mZmxpbmluZyBDUFUgJXVcbiIsCj4gPj4gPiAg CQkJY3B1bWFza19wcl9hcmdzKG0pLCBkLT5pcnEsIGNwdSk7Cj4gPj4gPiAgCQlyZXR1cm4gdHJ1 ZTsKPiA+PiA+ICAJfQo+ID4+ID4gQEAgLTE2Niw3ICsxNjYsNyBAQCB2b2lkIGlycV9taWdyYXRl X2FsbF9vZmZfdGhpc19jcHUodm9pZCkKPiA+PiA+ICAJCXJhd19zcGluX3VubG9jaygmZGVzYy0+ bG9jayk7Cj4gPj4gPiAgCj4gPj4gPiAgCQlpZiAoYWZmaW5pdHlfYnJva2VuKSB7Cj4gPj4gPiAt CQkJcHJfd2Fybl9yYXRlbGltaXRlZCgiSVJRICV1OiBubyBsb25nZXIgYWZmaW5lIHRvIENQVSV1 XG4iLAo+ID4+ID4gKwkJCXByX2RlYnVnX3JhdGVsaW1pdGVkKCJJUlEgJXU6IG5vIGxvbmdlciBh ZmZpbmUgdG8gQ1BVJXVcbiIsCj4gPj4gPiAgCQkJCQkgICAgaXJxLCBzbXBfcHJvY2Vzc29yX2lk KCkpOwo+ID4+IAo+ID4+IE1heWJlLCBidXQgZGlzdHJvIHBlb3BsZSBtaWdodCBoYXZlIG9waW5p b25zIG9uIHRoYXQuCj4gPgo+ID4gVGhlIHRyb3VibGUgaXMsIGV2ZW4gaWYgdGhlc2UgYXJlIHJl YWwgd2FybmluZ3MsIHRoZXkgaGF2ZSBhbiBhZmZlY3QKPiA+IG9uIHBlcmZvcm1hbmNlIG9uIHJl YWwgcHJvZHVjdHMuICBUbyB0aGUgcG9pbnQgd2hlcmUgc28gbXVjaCBsb2dnaW5nCj4gPiBidWls ZHMgdXAgZHVyaW5nIHByZS1yZWxlYXNlIHRlc3RpbmcsIHRoYXQgaXQgc2V0cyBvZmYgdGhlIHdh dGNoZG9nKHMpCj4gPiBvbiBzb21lIGhpZ2ggcHJvZmlsZSBjb25zdW1lciBkZXZpY2VzLgo+IAo+ IEknbSBmaW5lIHdpdGggbWFraW5nIHRoZSBzZWNvbmQgb25lIGRlYnVnLCBidXQgdGhlIGZpcnN0 IG9uZSByZWFsbHkKPiBzaG91bGQgbm90IHRyaWdnZXIgYXQgYWxsLgoKVW5kZXJzdG9vZC4gIEkn bGwgZm9sbG93LXVwIHdpdGggYSBzdWJzZXF1ZW50IHBhdGNoIGFuZCByZXBvcnQgYmFjawp3aXRo IHlvdXIgYWR2aWNlLiAgVGhhbmtzIFRob21hcy4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10K U2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSC IE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9v ayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B228AC4338F for ; Mon, 16 Aug 2021 07:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D58361AFA for ; Mon, 16 Aug 2021 07:43:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234481AbhHPHo1 (ORCPT ); Mon, 16 Aug 2021 03:44:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234168AbhHPHoZ (ORCPT ); Mon, 16 Aug 2021 03:44:25 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5C79C061764 for ; Mon, 16 Aug 2021 00:43:53 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id r6so22207663wrt.4 for ; Mon, 16 Aug 2021 00:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ZqL0RGrRiTOD68QIEn9gbIo3HjYGdm7ebHQq8KAmFwI=; b=m2U/rhpi57WfQtcrjZShp+0U0iUZrCIeIlL3o+QA8dx/Znh9WXz8YKHNBycvwTff6B r4CpSM11RJkPX15PcDtkD1u6NuCBghhqBlHHuvr+w8poh3t2NnI0mTo3iFGoa/98mzSH ik1T10K8BXVUrfQdQgRv1wdMsSWqj736m0eSdVijmoOL1EQngLvxrUEjW6Fh9blV1N8b 300O70y/IItVEuTAQQQgu8sZU55xGJbDcCTw1XFtcOr0dL8Dv1w5etRJXXXiSVEOaQke h/hJJxCqEjMRBo93LKo+hg2SW1l+gz6MgsBHvdWDbUNxzzTA1pk3hrZNffZ7713vpqlr Pfzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ZqL0RGrRiTOD68QIEn9gbIo3HjYGdm7ebHQq8KAmFwI=; b=DtS1usjGCwCJgDaVPN2sdReRCZERTEEc5W802pA9vWEZYnVo73aE91oWc6Hj+sr3Ov xTCjirX3+ZxlJUOP6boD68T8+g1qH3H0GtpgIEnj6lEgmm3FK2QSvEaodqUc0AHpygbU eAL5U8ICcUmaKNZOJgEA9Pt2lwfL+7qaPPrvf3+KaNPg3GyBath7hq9qQlBGdyvR8mvN bbUvG6BkaKgMUGrJyTcc7CudTI9zeffbWtWOcD3FKjGkKw2l9VpjRHWWQTh5eRVdc+iR csgOcQfhqSj7w8lxREhP+i9iNeckw4oBqmlP3i2anV+/uaaZctmkBO9MtLB9JVOm0lfK xj2w== X-Gm-Message-State: AOAM530Yh6qD6/flW1ZS3bEykFnycv1zh3/JfBNhahzBGVtG0/h321kH tca2GMDgUeUVa7sv/W24XeOlRg== X-Google-Smtp-Source: ABdhPJyN5it7Ymm9ZTJeLU7IN52N9VqFMrVEYXMmgmJ++xpct2mZFk4mzNlgx1OKoKqKKCLP5rTY8g== X-Received: by 2002:a5d:634a:: with SMTP id b10mr17103251wrw.305.1629099832597; Mon, 16 Aug 2021 00:43:52 -0700 (PDT) Received: from google.com ([2.31.167.59]) by smtp.gmail.com with ESMTPSA id f10sm10391869wrx.40.2021.08.16.00.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 00:43:52 -0700 (PDT) Date: Mon, 16 Aug 2021 08:43:53 +0100 From: Lee Jones To: Thomas Gleixner Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ming Lei , Hannes Reinecke Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG Message-ID: References: <20210617073136.315723-1-lee.jones@linaro.org> <8735rhs7n6.ffs@tglx> <87fsvgp4jd.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87fsvgp4jd.ffs@tglx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Aug 2021, Thomas Gleixner wrote: > On Wed, Aug 11 2021 at 08:57, Lee Jones wrote: > > On Tue, 10 Aug 2021, Thomas Gleixner wrote: > >> > @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d) > >> > * If this happens then there was a missed IRQ fixup at some > >> > * point. Warn about it and enforce fixup. > >> > */ > >> > - pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", > >> > >> This one is clearly a warning as this should not happen. See the > >> comments around that. > >> > >> > + pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", > >> > cpumask_pr_args(m), d->irq, cpu); > >> > return true; > >> > } > >> > @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void) > >> > raw_spin_unlock(&desc->lock); > >> > > >> > if (affinity_broken) { > >> > - pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n", > >> > + pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n", > >> > irq, smp_processor_id()); > >> > >> Maybe, but distro people might have opinions on that. > > > > The trouble is, even if these are real warnings, they have an affect > > on performance on real products. To the point where so much logging > > builds up during pre-release testing, that it sets off the watchdog(s) > > on some high profile consumer devices. > > I'm fine with making the second one debug, but the first one really > should not trigger at all. Understood. I'll follow-up with a subsequent patch and report back with your advice. Thanks Thomas. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog