From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26C64C4338F for ; Mon, 16 Aug 2021 12:47:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2AFF63275 for ; Mon, 16 Aug 2021 12:47:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D2AFF63275 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WNtRLrfO6slqVxFnXOzDX7MLRK4yQYUmWIRe3EwsrKU=; b=aC170ZkagTNaG4 d/Un4D2nqNmtj0amkyZ5NprUIVO5XRK/qpEpS0YVGiPvrHWxAy4EK9IVfsWtQ5tYo9jKlDg4AcKJh Rnoo0QqJtXdLjkgBx42GBueyIWHLzfOEB2VQlpaUdYuoekuPnm0h8sYNPZl1R83b0jkbkWsM2ICM2 QpN/zcbmtMR+h0L8J0sO5wbIHwzsy1+F3SOJ21nvocwMM+5Wv47kCLoK3jpQC5xr7MIuJTC3VbsFZ qZge1/s08ADjxyVYRuBPHQ29x43kXqoRwXnSdz3ouI1VW0IdMw3+daEAiHGOMj5y1DM44By3+ezmC JuAKiAUNs9N205sX4SFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFc1h-00GyF6-Ap; Mon, 16 Aug 2021 12:47:37 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFc1R-00GyBT-7c for linux-amlogic@lists.infradead.org; Mon, 16 Aug 2021 12:47:25 +0000 Received: by mail-wm1-x331.google.com with SMTP id k4so11494896wms.3 for ; Mon, 16 Aug 2021 05:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=628UnG3xjkZBMBG0VGNKw9sLYLAdXr0sKp9IjqwLtm4=; b=nZUz0VgbAkxNJAiE9MAc/dLOh2wdouuGcy/tenu3ofifjwk5tWoE9ZMx1LtFAEZYIU QONqerIapPAAGzvIzkk/mNlH+qQeSp9tMDcVDsKW5gHXTzTPLztrAx7KngfSMjnuJFFo dHjxPf1qCxFJXqCyutbB3kV8NXqXw7PiZrMYagWbqpoVZ48LNLECUze9dYDjAjmVxNfx pKcEWV8s3eBmVp/N0w03KvQG8OpcaUurrTSEe0xJVYnMZ/+PVAm6NZQFE0aSiva4j427 Db+1TcjkumK3wixTTwieyOb2i3wons09jv0G1iypy/bykk7/FJ06CIC/E5UwDgA9Ty8H Hw6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=628UnG3xjkZBMBG0VGNKw9sLYLAdXr0sKp9IjqwLtm4=; b=r028L9ZSAgP5+KxCNo2YmEgmjY1i3t2BK1ImwQaC7VQwZGHwwF4ibGn8UdDvuQ3Mju NO9tZfZjWWFlGjDGItVUrU5Ii9gith5sKf/rRgOTq0mt1IJpSGx0Nehhb7uBc0XM1lyf 1BhtCPEanNljnsjFCpFVIExwkMBqNBAR1XNznekSCjo7/vsMlAXPSWS5q47w4zeVsh1Z ss6H26N6Fuva+ETWunvvTjeUAcrBf/NYDRQsi5DeVw/SDUczx4HsUHFv4gIz9TbINSIp WF4+2JVogtzygfQMv1CFOF7VGPJaLxKYMRlohb9CvdAPyWZW44ZvABy8AIZu4sePVxZK 32Ig== X-Gm-Message-State: AOAM530gY8F5M28uiNsv/ni1qlBE1t4mZJjHivkGIoL7GRBeiGhx5uqF Jqs+LOCHveRZlJoi+tm7KwKFjQ== X-Google-Smtp-Source: ABdhPJzzWSQkQOBKWoi/NFlSIrCnrGUOE8L5DC8bQK9YcmtgJr492sWEK0o8hMmdRhhMLeglR7G/kg== X-Received: by 2002:a05:600c:4ba4:: with SMTP id e36mr5859426wmp.82.1629118039320; Mon, 16 Aug 2021 05:47:19 -0700 (PDT) Received: from google.com ([2.31.167.59]) by smtp.gmail.com with ESMTPSA id z126sm10724473wmc.11.2021.08.16.05.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 05:47:18 -0700 (PDT) Date: Mon, 16 Aug 2021 13:47:16 +0100 From: Lee Jones To: Saravana Kannan Cc: Marc Zyngier , Andrew Lunn , Kevin Hilman , Neil Armstrong , Jerome Brunet , linux-amlogic@lists.infradead.org, linux-arm-kernel , open list , netdev , Android Kernel Team Subject: Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module Message-ID: References: <7hsga8kb8z.fsf@baylibre.com> <87r1hwwier.wl-maz@kernel.org> <7h7diwgjup.fsf@baylibre.com> <87im0m277h.wl-maz@kernel.org> <87sfzpwq4f.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_054721_313401_DFE51DFE X-CRM114-Status: GOOD ( 51.16 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwNSBBdWcgMjAyMSwgTGVlIEpvbmVzIHdyb3RlOgoKPiBPbiBXZWQsIDA0IEF1ZyAy MDIxLCBTYXJhdmFuYSBLYW5uYW4gd3JvdGU6Cj4gCj4gPiBPbiBXZWQsIEF1ZyA0LCAyMDIxIGF0 IDExOjIwIEFNIFNhcmF2YW5hIEthbm5hbiA8c2FyYXZhbmFrQGdvb2dsZS5jb20+IHdyb3RlOgo+ ID4gPgo+ID4gPiBPbiBXZWQsIEF1ZyA0LCAyMDIxIGF0IDE6NTAgQU0gTWFyYyBaeW5naWVyIDxt YXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiBPbiBXZWQsIDA0IEF1ZyAyMDIx IDAyOjM2OjQ1ICswMTAwLAo+ID4gPiA+IFNhcmF2YW5hIEthbm5hbiA8c2FyYXZhbmFrQGdvb2ds ZS5jb20+IHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gSGkgU2FyYXZhbmEsCj4gPiA+ID4KPiA+ID4g PiBUaGFua3MgZm9yIGxvb2tpbmcgaW50byB0aGlzLgo+ID4gPgo+ID4gPiBZb3UgYXJlIHdlbGNv bWUuIEkganVzdCBkb24ndCB3YW50IHBlb3BsZSB0byB0aGluayBmd19kZXZsaW5rIGlzIGJyb2tl biA6KQo+ID4gPgo+ID4gPiA+Cj4gPiA+ID4gWy4uLl0KPiA+ID4gPgo+ID4gPiA+ID4gPiBTYXJh dmFuYSwgY291bGQgeW91IHBsZWFzZSBoYXZlIGEgbG9vayBmcm9tIGEgZndfZGV2bGluayBwZXJz cGVjdGl2ZT8KPiA+ID4gPiA+Cj4gPiA+ID4gPiBTaWdoLi4uIEkgc3BlbnQgc2V2ZXJhbCBob3Vy cyBsb29raW5nIGF0IHRoaXMgYW5kIHdyb3RlIHVwIGFuIGFuYWx5c2lzCj4gPiA+ID4gPiBhbmQg dGhlbiByZWFsaXplZCBJIG1pZ2h0IGJlIGxvb2tpbmcgYXQgdGhlIHdyb25nIERUIGZpbGVzLgo+ ID4gPiA+ID4KPiA+ID4gPiA+IE1hcmMsIGNhbiB5b3UgcG9pbnQgbWUgdG8gdGhlIGJvYXJkIGZp bGUgaW4gdXBzdHJlYW0gdGhhdCBjb3JyZXNwb25kcwo+ID4gPiA+ID4gdG8gdGhlIHBsYXRmb3Jt IGluIHdoaWNoIHlvdSBzZWUgdGhpcyBpc3N1ZT8gSSdtIG5vdCBhc2tpbmcgZm9yIFsxXSwKPiA+ ID4gPiA+IGJ1dCB0aGUgYWN0dWFsIGZpbmFsIC5kdHMgKG5vdCAuZHRzaSkgZmlsZSB0aGF0IGNv cnJlc3BvbmRzIHRvIHRoZQo+ID4gPiA+ID4gcGxhdGZvcm0vYm9hcmQvc3lzdGVtLgo+ID4gPiA+ Cj4gPiA+ID4gVGhlIHBsYXRmb3JtIEkgY2FuIHJlcHJvZHVjZSB0aGlzIG9uIGlzIGRlc2NyaWJl ZCBpbgo+ID4gPiA+IGFyY2gvYXJtNjQvYm9vdC9kdHMvYW1sb2dpYy9tZXNvbi1zbTEta2hhZGFz LXZpbTNsLmR0cy4gSXQgaXMgYW4KPiA+ID4gPiBpbnRyaWNhdGUgbWF6ZSBvZiBpbmNsdXNpb24s IG5vZGUgbWVyZ2UgYW5kIG90aGVyIERUIHN1YnRsZXRpZXMuIEkKPiA+ID4gPiBzdWdnZXN0IHlv dSBsb29rIGF0IHRoZSBkZWNvbXBpbGVkIHZlcnNpb24gdG8gZ2V0IGEgdmlldyBvZiB0aGUKPiA+ ID4gPiByZXN1bHQuCj4gPiA+Cj4gPiA+IFRoYW5rcy4gQWZ0ZXIgZGVjb21waWxpbmcgaXQsIGl0 IGxvb2tzIHNvbWV0aGluZyBsaWtlIChzdHJpcHBlZCBhCj4gPiA+IGJ1bmNoIG9mIHJlZyBhbmQg YWRkcmVzcyBwcm9wZXJ0aWVzIGFuZCBhZGRlZCB0aGUgbGFiZWxzIGJhY2spOgo+ID4gPgo+ID4g PiBldGhfcGh5OiBtZGlvLW11bHRpcGxleGVyQDRjMDAwIHsKPiA+ID4gICAgICAgICBjb21wYXRp YmxlID0gImFtbG9naWMsZzEyYS1tZGlvLW11eCI7Cj4gPiA+ICAgICAgICAgY2xvY2tzID0gPDB4 MDIgMHgxMyAweDFlIDB4MDIgMHhiMT47Cj4gPiA+ICAgICAgICAgY2xvY2stbmFtZXMgPSAicGNs a1wwY2xraW4wXDBjbGtpbjEiOwo+ID4gPiAgICAgICAgIG1kaW8tcGFyZW50LWJ1cyA9IDwweDIy PjsKPiA+ID4KPiA+ID4gICAgICAgICBleHRfbWRpbzogbWRpb0AwIHsKPiA+ID4gICAgICAgICAg ICAgICAgIHJlZyA9IDwweDAwPjsKPiA+ID4KPiA+ID4gICAgICAgICAgICAgICAgIGV0aGVybmV0 LXBoeUAwIHsKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgbWF4LXNwZWVkID0gPDB4M2U4 PjsKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgaW50ZXJydXB0LXBhcmVudCA9IDwweDIz PjsKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgaW50ZXJydXB0cyA9IDwweDFhIDB4MDg+ Owo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICBwaGFuZGxlID0gPDB4MTY+Owo+ID4gPiAg ICAgICAgICAgICAgICAgfTsKPiA+ID4gICAgICAgICB9Owo+ID4gPgo+ID4gPiAgICAgICAgIGlu dF9tZGlvOiBtZGlvQDEgewo+ID4gPiAgICAgICAgICAgICAgICAgLi4uCj4gPiA+ICAgICAgICAg fQo+ID4gPiB9Cj4gPiA+Cj4gPiA+IEFuZCBwaGFuZGxlIDB4MjMgcmVmZXJzIHRvIHRoZSBncGlv X2ludGMgaW50ZXJydXB0IGNvbnRyb2xsZXIgd2l0aCB0aGUKPiA+ID4gbW9kdWxhciBkcml2ZXIu Cj4gPiA+Cj4gPiA+ID4gPiBCYXNlZCBvbiB5b3VyIGVycm9yIG1lc3NhZ2VzLCBpdCdzIGZhaWxp bmcgZm9yIG1kaW9AMCB3aGljaAo+ID4gPiA+ID4gY29ycmVzcG9uZHMgdG8gZXh0X21kaW8uIEJ1 dCBub25lIG9mIHRoZSBib2FyZCBkdHMgZmlsZXMgaW4gdXBzdHJlYW0KPiA+ID4gPiA+IGhhdmUg YSBjb21wYXRpYmxlIHByb3BlcnR5IGZvciAiZXh0X21kaW8iLiBXaGljaCBtZWFucyBmd19kZXZs aW5rCj4gPiA+ID4gPiBfc2hvdWxkXyBwcm9wYWdhdGUgdGhlIGdwaW9faW50YyBJUlEgZGVwZW5k ZW5jeSBhbGwgdGhlIHdheSB1cCB0bwo+ID4gPiA+ID4gZXRoX3BoeS4KPiA+ID4gPiA+Cj4gPiA+ ID4gPiBBbHNvLCBpbiB0aGUgZmFpbGluZyBjYXNlLCBjYW4geW91IHJ1bjoKPiA+ID4gPiA+IGxz IC1sZCBzdXBwbGllcjoqCj4gPiA+ID4gPgo+ID4gPiA+ID4gaW4gdGhlIC9zeXMvZGV2aWNlcy8u Li4uPHNvbWV0aGluZz4vIGZvbGRlciB0aGF0IGNvcnJlc3BvbmRzIHRvIHRoZQo+ID4gPiA+ID4g ImV0aF9waHk6IG1kaW8tbXVsdGlwbGV4ZXJANGMwMDAiIERUIG5vZGUgYW5kIHRlbGwgbWUgd2hh dCBpdCBzaG93cz8KPiA+ID4gPgo+ID4gPiA+IEhlcmUgeW91IGdvOgo+ID4gPiA+Cj4gPiA+ID4g cm9vdEB0aWdlci1yb2FjaDp+IyBmaW5kIC9zeXMvZGV2aWNlcy8gLW5hbWUgJ3N1cHBsaWVyKid8 Z3JlcCAtaSBtZGlvIHwgeGFyZ3MgbHMgLWxkCj4gPiA+ID4gbHJ3eHJ3eHJ3eCAxIHJvb3Qgcm9v dCAwIEF1ZyAgNCAwOTo0NyAvc3lzL2RldmljZXMvcGxhdGZvcm0vc29jL2ZmNjAwMDAwLmJ1cy9m ZjY0YzAwMC5tZGlvLW11bHRpcGxleGVyL3N1cHBsaWVyOnBsYXRmb3JtOmZmNjNjMDAwLnN5c3Rl bS1jb250cm9sbGVyOmNsb2NrLWNvbnRyb2xsZXIgLT4gLi4vLi4vLi4vLi4vdmlydHVhbC9kZXZs aW5rL3BsYXRmb3JtOmZmNjNjMDAwLnN5c3RlbS1jb250cm9sbGVyOmNsb2NrLWNvbnRyb2xsZXIt LXBsYXRmb3JtOmZmNjRjMDAwLm1kaW8tbXVsdGlwbGV4ZXIKPiA+ID4KPiA+ID4gQXMgd2UgZGlz Y3Vzc2VkIG92ZXIgY2hhdCwgdGhpcyB3YXMgdGFrZW4gYWZ0ZXIgdGhlIG1kaW8tbXVsdGlwbGV4 ZXIKPiA+ID4gZHJpdmVyICJzdWNjZXNzZnVsbHkiIHByb2JlcyB0aGlzIGRldmljZS4gVGhpcyB3 aWxsIGNhdXNlCj4gPiA+IFNZTkNfU1RBVEVfT05MWSBkZXZpY2UgbGlua3MgY3JlYXRlZCBieSBm d19kZXZsaW5rIHRvIGJlIGRlbGV0ZWQKPiA+ID4gKGJlY2F1c2UgdGhleSBhcmUgdXNlbGVzcyBh ZnRlciBhIGRldmljZSBwcm9iZXMpLiBTbywgdGhpcyBkb2Vzbid0Cj4gPiA+IHNob3cgdGhlIGlu Zm8gSSB3YXMgaG9waW5nIHRvIGRlbW9uc3RyYXRlLgo+ID4gPgo+ID4gPiBJbiBhbnkgY2FzZSwg b25lIGNhbiBzZWUgdGhhdCBmd19kZXZsaW5rIHByb3Blcmx5IGNyZWF0ZWQgdGhlIGRldmljZQo+ ID4gPiBsaW5rIGZvciB0aGUgY2xvY2tzIGRlcGVuZGVuY3kuIFNvIGZ3X2RldmxpbmsgaXMgcGFy c2luZyB0aGlzIG5vZGUKPiA+ID4gcHJvcGVybHkuIEJ1dCBpdCBkb2Vzbid0IGNyZWF0ZSBhIHNp bWlsYXIgcHJvYmUgb3JkZXIgZW5mb3JjaW5nIGRldmljZQo+ID4gPiBsaW5rIGJldHdlZW4gdGhl IG1kaW8tbXVsdGlwbGV4ZXIgYW5kIHRoZSBncGlvX2ludGMgYmVjYXVzZSB0aGUKPiA+ID4gZGVw ZW5kZW5jeSBpcyBvbmx5IHByZXNlbnQgaW4gYSBncmFuZCBjaGlsZCBEVCBub2RlIChldGhlcm5l dC1waHlAMAo+ID4gPiB1bmRlciBleHRfbWRpbykuIFNvIGZ3X2RldmxpbmsgaXMgd29ya2luZyBh cyBpbnRlbmRlZC4KPiA+ID4KPiA+ID4gSSBzcGVudCBzZXZlcmFsIGhvdXJzIHNxdWludGluZyBh dCB0aGUgY29kZS9EVCB5ZXN0ZXJkYXkuIEhlcmUncyB3aGF0Cj4gPiA+IGlzIGdvaW5nIG9uIGFu ZCBjYXVzaW5nIHRoZSBwcm9ibGVtOgo+ID4gPgo+ID4gPiBUaGUgZmFpbGluZyBkcml2ZXIgaW4g dGhpcyBjYXNlIGlzCj4gPiA+IGRyaXZlcnMvbmV0L21kaW8vbWRpby1tdXgtbWVzb24tZzEyYS5j LiBBbmQgdGhlIG9ubHkgRFQgbm9kZSBpdCdzCj4gPiA+IGhhbmRsaW5nIGlzIHdoYXQgSSBwYXN0 ZWQgYWJvdmUgaW4gdGhpcyBlbWFpbC4gSW4gdGhlIGZhaWx1cmUgY2FzZSwKPiA+ID4gdGhlIGNh bGwgZmxvdyBpcyBzb21ldGhpbmcgbGlrZSB0aGlzOgo+ID4gPgo+ID4gPiBnMTJhX21kaW9fbXV4 X3Byb2JlKCkKPiA+ID4gLT4gbWRpb19tdXhfaW5pdCgpCj4gPiA+IC0+IG9mX21kaW9idXNfcmVn aXN0ZXIoZXh0X21kaW8gRFQgbm9kZSkKPiA+ID4gLT4gb2ZfbWRpb2J1c19yZWdpc3Rlcl9waHko ZXh0X21kaW8gRFQgbm9kZSkKPiA+ID4gLT4gc2V2ZXJhbCBjYWxscyBkZWVwIGZ3bm9kZV9tZGlv YnVzX3BoeV9kZXZpY2VfcmVnaXN0ZXIoZXRoZXJuZXRfcGh5IERUIG5vZGUpCj4gPiA+IC0+IFRy aWVkIHRvIGdldCB0aGUgSVJRIGxpc3RlZCBpbiBldGhlcm5ldF9waHkgYW5kIGZhaWxzIHdpdGgK PiA+ID4gLUVQUk9CRV9ERUZFUiBiZWNhdXNlIHRoZSBJUlEgZHJpdmVyIGlzbid0IGxvYWRlZCB5 ZXQuCj4gPiA+Cj4gPiA+IFRoZSBlcnJvciBpcyBwcm9wYWdhdGVkIGNvcnJlY3RseSBhbGwgdGhl IHdheSB1cCB0byBvZl9tZGlvYnVzX3JlZ2lzdGVyKCksIGJ1dAo+ID4gPiBtZGlvX211eF9pbml0 KCkgaWdub3JlcyB0aGUgLUVQUk9CRV9ERUZFUiBmcm9tIG9mX21kaW9idXNfcmVnaXN0ZXIoKSBh bmQganVzdAo+ID4gPiBjb250aW51ZXMgb24gd2l0aCB0aGUgcmVzdCBvZiB0aGUgc3R1ZmYgYW5k IHJldHVybnMgc3VjY2VzcyBhcyBsb25nIGFzCj4gPiA+IG9uZSBvZiB0aGUgY2hpbGQgbm9kZXMg KGluIHRoaXMgY2FzZSBpbnRfbWRpbykgc3VjY2VlZHMuCj4gPiA+Cj4gPiA+IFNpbmNlIHRoZSBw cm9iZSByZXR1cm5zIDAgd2l0aG91dCByZWFsbHkgc3VjY2VlZGluZywgbmV0d29ya2luZyBzdHVm Zgo+ID4gPiBqdXN0IGZhaWxzIGJhZGx5IGFmdGVyIHRoaXMuIFNvLCBJTU8sIHRoZSByZWFsIHBy b2JsZW0gaXMgd2l0aAo+ID4gPiBtZGlvX211eF9pbml0KCkgbm90IHByb3BhZ2F0aW5nIHVwIHRo ZSAtRVBST0JFX0RFRkVSLiBJIGdhdmUgTWFyYyBhCj4gPiA+IHF1aWNrIGhhY2sgKHBhc3RlZCBh dCB0aGUgZW5kIG9mIHRoaXMgZW1haWwpIHRvIHRlc3QgbXkgdGhlb3J5IGFuZCBoZQo+ID4gPiBj b25maXJtZWQgdGhhdCBpdCBmaXhlcyB0aGUgaXNzdWUgKGEgZmV3IGRlZmVycmVkIHByb2JlcyBs YXRlciwgdGhpbmdzCj4gPiA+IHdvcmsgcHJvcGVybHkpLgo+ID4gPgo+ID4gPiBBbmRyZXcsIEkg ZG9uJ3Qgc2VlIGFueSBnb29kIHJlYXNvbiBmb3IgbWRpb19tdXhfaW5pdCgpIG5vdAo+ID4gPiBw cm9wYWdhdGluZyB0aGUgZXJyb3JzIHVwIGNvcnJlY3RseSAoYXQgbGVhc3QgZm9yIEVQUk9CRV9E RUZFUikuIEknbGwKPiA+ID4gc2VuZCBhIHBhdGNoIHRvIGZpeCB0aGlzLiBQbGVhc2UgbGV0IG1l IGtub3cgaWYgdGhlcmUncyBhIHJlYXNvbiBpdAo+ID4gPiBoYXMgdG8gc3RheSBhcy1pcy4KPiA+ IAo+ID4gSSBzZW50IG91dCB0aGUgcHJvcGVyIGZpeCBhcyBhIHNlcmllczoKPiA+IGh0dHBzOi8v bG9yZS5rZXJuZWwub3JnL2xrbWwvMjAyMTA4MDQyMTQzMzMuOTI3OTg1LTEtc2FyYXZhbmFrQGdv b2dsZS5jb20vVC8jdAo+ID4gCj4gPiBNYXJjLCBjYW4geW91IGdpdmUgaXQgYSBzaG90IHBsZWFz ZT8KPiA+IAo+ID4gLVNhcmF2YW5hCj4gCj4gU3VwZXJzdGFyISAgVGhhbmtzIGZvciB0YWtpbmcg dGhlIHRpbWUgdG8gcmVjdGlmeSB0aGlzIGZvciBhbGwgb2YgdXMuCgpKdXN0IHRvIGNsYXJpZnk6 CgogIEFyZSB3ZSB3YWl0aW5nIG9uIGEgc3Vic2VxdWVudCBwYXRjaCBzdWJtaXNzaW9uIGF0IHRo aXMgcG9pbnQ/CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVh ZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2Fy ZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1s b2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E465C4338F for ; Mon, 16 Aug 2021 12:49:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DBF963276 for ; Mon, 16 Aug 2021 12:49:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2DBF963276 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b+6K//oLpvAJakgjY1fN7OSiQe7eeNPHLTUAlcUMf+0=; b=2+0b8CUExizL65 MTaqvhVZ8cLrMpvQgs8oTY8WRrsnOgYbLfEBAMPbsDQXNiHF1PlUb/eD2HA0O+IVJervVIJmwJwyv yMsgiJvd1dP66xCGdJUO71V9SvjWO6qtENL4mwtNmM8cTlsbqrOmDh+umZLJsOBPepxIwihj+/XkY K4O3GI5Ji92VATyt38wucXIz72D2wGOf395R9OEwRHUY0LOErB/ihFWbUBvJt+fjFHw8eCCUwoN6G faeAEO6jcMjUhoKJaO92jH5ypj6TCYfAZ50cdcPIlOy16bxTCM3/WFdT1LjiNmth0dTtvr7hof7Rx 6H6t2bZBS82hq6uOhbgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFc1X-00GyDi-Ia; Mon, 16 Aug 2021 12:47:27 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFc1R-00GyBS-4j for linux-arm-kernel@lists.infradead.org; Mon, 16 Aug 2021 12:47:25 +0000 Received: by mail-wm1-x32c.google.com with SMTP id u1so11541359wmm.0 for ; Mon, 16 Aug 2021 05:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=628UnG3xjkZBMBG0VGNKw9sLYLAdXr0sKp9IjqwLtm4=; b=nZUz0VgbAkxNJAiE9MAc/dLOh2wdouuGcy/tenu3ofifjwk5tWoE9ZMx1LtFAEZYIU QONqerIapPAAGzvIzkk/mNlH+qQeSp9tMDcVDsKW5gHXTzTPLztrAx7KngfSMjnuJFFo dHjxPf1qCxFJXqCyutbB3kV8NXqXw7PiZrMYagWbqpoVZ48LNLECUze9dYDjAjmVxNfx pKcEWV8s3eBmVp/N0w03KvQG8OpcaUurrTSEe0xJVYnMZ/+PVAm6NZQFE0aSiva4j427 Db+1TcjkumK3wixTTwieyOb2i3wons09jv0G1iypy/bykk7/FJ06CIC/E5UwDgA9Ty8H Hw6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=628UnG3xjkZBMBG0VGNKw9sLYLAdXr0sKp9IjqwLtm4=; b=mkdOxMrs3SOO1NBLd5xiXfW69hz3hGsZTRhYWVNW+IODlYW3G6TEVpaPobgJ9/HjHl H5Gsy2LtsEh6mgwIY5ogvWRIw3Agx2fuWw4ILzOlSGeXzHKr/G2S9z+VJWaI2s1X/iG+ VY0gT9C/IlBkrSEIQpk7j3dhguSjedQhBrrECLzJvBPqwx2izv8UvNI+bFDiTl6Gr8PN Ul9I/C16IOu1rohcAQiYV6F3YHvpGdwSDbbKIa//M4PZ25RHA52c25p4x8DQNtgWAE8D uZQtjUNQXQcCq8s8gYVoVwXMHPiIhHO2J0gSbTAGWYgDTnMYjcjzbOj1x6Dnq8tbhyyF PYjA== X-Gm-Message-State: AOAM531OvcNVUfOskn8I5muOnXXah+kZ6MIGMX7suNFgD93YwayISBiO mrYC4xxQeGBuhHhmNgxA9N3ssw== X-Google-Smtp-Source: ABdhPJzzWSQkQOBKWoi/NFlSIrCnrGUOE8L5DC8bQK9YcmtgJr492sWEK0o8hMmdRhhMLeglR7G/kg== X-Received: by 2002:a05:600c:4ba4:: with SMTP id e36mr5859426wmp.82.1629118039320; Mon, 16 Aug 2021 05:47:19 -0700 (PDT) Received: from google.com ([2.31.167.59]) by smtp.gmail.com with ESMTPSA id z126sm10724473wmc.11.2021.08.16.05.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 05:47:18 -0700 (PDT) Date: Mon, 16 Aug 2021 13:47:16 +0100 From: Lee Jones To: Saravana Kannan Cc: Marc Zyngier , Andrew Lunn , Kevin Hilman , Neil Armstrong , Jerome Brunet , linux-amlogic@lists.infradead.org, linux-arm-kernel , open list , netdev , Android Kernel Team Subject: Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module Message-ID: References: <7hsga8kb8z.fsf@baylibre.com> <87r1hwwier.wl-maz@kernel.org> <7h7diwgjup.fsf@baylibre.com> <87im0m277h.wl-maz@kernel.org> <87sfzpwq4f.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_054721_242713_3CFE9C5D X-CRM114-Status: GOOD ( 52.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwNSBBdWcgMjAyMSwgTGVlIEpvbmVzIHdyb3RlOgoKPiBPbiBXZWQsIDA0IEF1ZyAy MDIxLCBTYXJhdmFuYSBLYW5uYW4gd3JvdGU6Cj4gCj4gPiBPbiBXZWQsIEF1ZyA0LCAyMDIxIGF0 IDExOjIwIEFNIFNhcmF2YW5hIEthbm5hbiA8c2FyYXZhbmFrQGdvb2dsZS5jb20+IHdyb3RlOgo+ ID4gPgo+ID4gPiBPbiBXZWQsIEF1ZyA0LCAyMDIxIGF0IDE6NTAgQU0gTWFyYyBaeW5naWVyIDxt YXpAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiBPbiBXZWQsIDA0IEF1ZyAyMDIx IDAyOjM2OjQ1ICswMTAwLAo+ID4gPiA+IFNhcmF2YW5hIEthbm5hbiA8c2FyYXZhbmFrQGdvb2ds ZS5jb20+IHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gSGkgU2FyYXZhbmEsCj4gPiA+ID4KPiA+ID4g PiBUaGFua3MgZm9yIGxvb2tpbmcgaW50byB0aGlzLgo+ID4gPgo+ID4gPiBZb3UgYXJlIHdlbGNv bWUuIEkganVzdCBkb24ndCB3YW50IHBlb3BsZSB0byB0aGluayBmd19kZXZsaW5rIGlzIGJyb2tl biA6KQo+ID4gPgo+ID4gPiA+Cj4gPiA+ID4gWy4uLl0KPiA+ID4gPgo+ID4gPiA+ID4gPiBTYXJh dmFuYSwgY291bGQgeW91IHBsZWFzZSBoYXZlIGEgbG9vayBmcm9tIGEgZndfZGV2bGluayBwZXJz cGVjdGl2ZT8KPiA+ID4gPiA+Cj4gPiA+ID4gPiBTaWdoLi4uIEkgc3BlbnQgc2V2ZXJhbCBob3Vy cyBsb29raW5nIGF0IHRoaXMgYW5kIHdyb3RlIHVwIGFuIGFuYWx5c2lzCj4gPiA+ID4gPiBhbmQg dGhlbiByZWFsaXplZCBJIG1pZ2h0IGJlIGxvb2tpbmcgYXQgdGhlIHdyb25nIERUIGZpbGVzLgo+ ID4gPiA+ID4KPiA+ID4gPiA+IE1hcmMsIGNhbiB5b3UgcG9pbnQgbWUgdG8gdGhlIGJvYXJkIGZp bGUgaW4gdXBzdHJlYW0gdGhhdCBjb3JyZXNwb25kcwo+ID4gPiA+ID4gdG8gdGhlIHBsYXRmb3Jt IGluIHdoaWNoIHlvdSBzZWUgdGhpcyBpc3N1ZT8gSSdtIG5vdCBhc2tpbmcgZm9yIFsxXSwKPiA+ ID4gPiA+IGJ1dCB0aGUgYWN0dWFsIGZpbmFsIC5kdHMgKG5vdCAuZHRzaSkgZmlsZSB0aGF0IGNv cnJlc3BvbmRzIHRvIHRoZQo+ID4gPiA+ID4gcGxhdGZvcm0vYm9hcmQvc3lzdGVtLgo+ID4gPiA+ Cj4gPiA+ID4gVGhlIHBsYXRmb3JtIEkgY2FuIHJlcHJvZHVjZSB0aGlzIG9uIGlzIGRlc2NyaWJl ZCBpbgo+ID4gPiA+IGFyY2gvYXJtNjQvYm9vdC9kdHMvYW1sb2dpYy9tZXNvbi1zbTEta2hhZGFz LXZpbTNsLmR0cy4gSXQgaXMgYW4KPiA+ID4gPiBpbnRyaWNhdGUgbWF6ZSBvZiBpbmNsdXNpb24s IG5vZGUgbWVyZ2UgYW5kIG90aGVyIERUIHN1YnRsZXRpZXMuIEkKPiA+ID4gPiBzdWdnZXN0IHlv dSBsb29rIGF0IHRoZSBkZWNvbXBpbGVkIHZlcnNpb24gdG8gZ2V0IGEgdmlldyBvZiB0aGUKPiA+ ID4gPiByZXN1bHQuCj4gPiA+Cj4gPiA+IFRoYW5rcy4gQWZ0ZXIgZGVjb21waWxpbmcgaXQsIGl0 IGxvb2tzIHNvbWV0aGluZyBsaWtlIChzdHJpcHBlZCBhCj4gPiA+IGJ1bmNoIG9mIHJlZyBhbmQg YWRkcmVzcyBwcm9wZXJ0aWVzIGFuZCBhZGRlZCB0aGUgbGFiZWxzIGJhY2spOgo+ID4gPgo+ID4g PiBldGhfcGh5OiBtZGlvLW11bHRpcGxleGVyQDRjMDAwIHsKPiA+ID4gICAgICAgICBjb21wYXRp YmxlID0gImFtbG9naWMsZzEyYS1tZGlvLW11eCI7Cj4gPiA+ICAgICAgICAgY2xvY2tzID0gPDB4 MDIgMHgxMyAweDFlIDB4MDIgMHhiMT47Cj4gPiA+ICAgICAgICAgY2xvY2stbmFtZXMgPSAicGNs a1wwY2xraW4wXDBjbGtpbjEiOwo+ID4gPiAgICAgICAgIG1kaW8tcGFyZW50LWJ1cyA9IDwweDIy PjsKPiA+ID4KPiA+ID4gICAgICAgICBleHRfbWRpbzogbWRpb0AwIHsKPiA+ID4gICAgICAgICAg ICAgICAgIHJlZyA9IDwweDAwPjsKPiA+ID4KPiA+ID4gICAgICAgICAgICAgICAgIGV0aGVybmV0 LXBoeUAwIHsKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgbWF4LXNwZWVkID0gPDB4M2U4 PjsKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgaW50ZXJydXB0LXBhcmVudCA9IDwweDIz PjsKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgaW50ZXJydXB0cyA9IDwweDFhIDB4MDg+ Owo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICBwaGFuZGxlID0gPDB4MTY+Owo+ID4gPiAg ICAgICAgICAgICAgICAgfTsKPiA+ID4gICAgICAgICB9Owo+ID4gPgo+ID4gPiAgICAgICAgIGlu dF9tZGlvOiBtZGlvQDEgewo+ID4gPiAgICAgICAgICAgICAgICAgLi4uCj4gPiA+ICAgICAgICAg fQo+ID4gPiB9Cj4gPiA+Cj4gPiA+IEFuZCBwaGFuZGxlIDB4MjMgcmVmZXJzIHRvIHRoZSBncGlv X2ludGMgaW50ZXJydXB0IGNvbnRyb2xsZXIgd2l0aCB0aGUKPiA+ID4gbW9kdWxhciBkcml2ZXIu Cj4gPiA+Cj4gPiA+ID4gPiBCYXNlZCBvbiB5b3VyIGVycm9yIG1lc3NhZ2VzLCBpdCdzIGZhaWxp bmcgZm9yIG1kaW9AMCB3aGljaAo+ID4gPiA+ID4gY29ycmVzcG9uZHMgdG8gZXh0X21kaW8uIEJ1 dCBub25lIG9mIHRoZSBib2FyZCBkdHMgZmlsZXMgaW4gdXBzdHJlYW0KPiA+ID4gPiA+IGhhdmUg YSBjb21wYXRpYmxlIHByb3BlcnR5IGZvciAiZXh0X21kaW8iLiBXaGljaCBtZWFucyBmd19kZXZs aW5rCj4gPiA+ID4gPiBfc2hvdWxkXyBwcm9wYWdhdGUgdGhlIGdwaW9faW50YyBJUlEgZGVwZW5k ZW5jeSBhbGwgdGhlIHdheSB1cCB0bwo+ID4gPiA+ID4gZXRoX3BoeS4KPiA+ID4gPiA+Cj4gPiA+ ID4gPiBBbHNvLCBpbiB0aGUgZmFpbGluZyBjYXNlLCBjYW4geW91IHJ1bjoKPiA+ID4gPiA+IGxz IC1sZCBzdXBwbGllcjoqCj4gPiA+ID4gPgo+ID4gPiA+ID4gaW4gdGhlIC9zeXMvZGV2aWNlcy8u Li4uPHNvbWV0aGluZz4vIGZvbGRlciB0aGF0IGNvcnJlc3BvbmRzIHRvIHRoZQo+ID4gPiA+ID4g ImV0aF9waHk6IG1kaW8tbXVsdGlwbGV4ZXJANGMwMDAiIERUIG5vZGUgYW5kIHRlbGwgbWUgd2hh dCBpdCBzaG93cz8KPiA+ID4gPgo+ID4gPiA+IEhlcmUgeW91IGdvOgo+ID4gPiA+Cj4gPiA+ID4g cm9vdEB0aWdlci1yb2FjaDp+IyBmaW5kIC9zeXMvZGV2aWNlcy8gLW5hbWUgJ3N1cHBsaWVyKid8 Z3JlcCAtaSBtZGlvIHwgeGFyZ3MgbHMgLWxkCj4gPiA+ID4gbHJ3eHJ3eHJ3eCAxIHJvb3Qgcm9v dCAwIEF1ZyAgNCAwOTo0NyAvc3lzL2RldmljZXMvcGxhdGZvcm0vc29jL2ZmNjAwMDAwLmJ1cy9m ZjY0YzAwMC5tZGlvLW11bHRpcGxleGVyL3N1cHBsaWVyOnBsYXRmb3JtOmZmNjNjMDAwLnN5c3Rl bS1jb250cm9sbGVyOmNsb2NrLWNvbnRyb2xsZXIgLT4gLi4vLi4vLi4vLi4vdmlydHVhbC9kZXZs aW5rL3BsYXRmb3JtOmZmNjNjMDAwLnN5c3RlbS1jb250cm9sbGVyOmNsb2NrLWNvbnRyb2xsZXIt LXBsYXRmb3JtOmZmNjRjMDAwLm1kaW8tbXVsdGlwbGV4ZXIKPiA+ID4KPiA+ID4gQXMgd2UgZGlz Y3Vzc2VkIG92ZXIgY2hhdCwgdGhpcyB3YXMgdGFrZW4gYWZ0ZXIgdGhlIG1kaW8tbXVsdGlwbGV4 ZXIKPiA+ID4gZHJpdmVyICJzdWNjZXNzZnVsbHkiIHByb2JlcyB0aGlzIGRldmljZS4gVGhpcyB3 aWxsIGNhdXNlCj4gPiA+IFNZTkNfU1RBVEVfT05MWSBkZXZpY2UgbGlua3MgY3JlYXRlZCBieSBm d19kZXZsaW5rIHRvIGJlIGRlbGV0ZWQKPiA+ID4gKGJlY2F1c2UgdGhleSBhcmUgdXNlbGVzcyBh ZnRlciBhIGRldmljZSBwcm9iZXMpLiBTbywgdGhpcyBkb2Vzbid0Cj4gPiA+IHNob3cgdGhlIGlu Zm8gSSB3YXMgaG9waW5nIHRvIGRlbW9uc3RyYXRlLgo+ID4gPgo+ID4gPiBJbiBhbnkgY2FzZSwg b25lIGNhbiBzZWUgdGhhdCBmd19kZXZsaW5rIHByb3Blcmx5IGNyZWF0ZWQgdGhlIGRldmljZQo+ ID4gPiBsaW5rIGZvciB0aGUgY2xvY2tzIGRlcGVuZGVuY3kuIFNvIGZ3X2RldmxpbmsgaXMgcGFy c2luZyB0aGlzIG5vZGUKPiA+ID4gcHJvcGVybHkuIEJ1dCBpdCBkb2Vzbid0IGNyZWF0ZSBhIHNp bWlsYXIgcHJvYmUgb3JkZXIgZW5mb3JjaW5nIGRldmljZQo+ID4gPiBsaW5rIGJldHdlZW4gdGhl IG1kaW8tbXVsdGlwbGV4ZXIgYW5kIHRoZSBncGlvX2ludGMgYmVjYXVzZSB0aGUKPiA+ID4gZGVw ZW5kZW5jeSBpcyBvbmx5IHByZXNlbnQgaW4gYSBncmFuZCBjaGlsZCBEVCBub2RlIChldGhlcm5l dC1waHlAMAo+ID4gPiB1bmRlciBleHRfbWRpbykuIFNvIGZ3X2RldmxpbmsgaXMgd29ya2luZyBh cyBpbnRlbmRlZC4KPiA+ID4KPiA+ID4gSSBzcGVudCBzZXZlcmFsIGhvdXJzIHNxdWludGluZyBh dCB0aGUgY29kZS9EVCB5ZXN0ZXJkYXkuIEhlcmUncyB3aGF0Cj4gPiA+IGlzIGdvaW5nIG9uIGFu ZCBjYXVzaW5nIHRoZSBwcm9ibGVtOgo+ID4gPgo+ID4gPiBUaGUgZmFpbGluZyBkcml2ZXIgaW4g dGhpcyBjYXNlIGlzCj4gPiA+IGRyaXZlcnMvbmV0L21kaW8vbWRpby1tdXgtbWVzb24tZzEyYS5j LiBBbmQgdGhlIG9ubHkgRFQgbm9kZSBpdCdzCj4gPiA+IGhhbmRsaW5nIGlzIHdoYXQgSSBwYXN0 ZWQgYWJvdmUgaW4gdGhpcyBlbWFpbC4gSW4gdGhlIGZhaWx1cmUgY2FzZSwKPiA+ID4gdGhlIGNh bGwgZmxvdyBpcyBzb21ldGhpbmcgbGlrZSB0aGlzOgo+ID4gPgo+ID4gPiBnMTJhX21kaW9fbXV4 X3Byb2JlKCkKPiA+ID4gLT4gbWRpb19tdXhfaW5pdCgpCj4gPiA+IC0+IG9mX21kaW9idXNfcmVn aXN0ZXIoZXh0X21kaW8gRFQgbm9kZSkKPiA+ID4gLT4gb2ZfbWRpb2J1c19yZWdpc3Rlcl9waHko ZXh0X21kaW8gRFQgbm9kZSkKPiA+ID4gLT4gc2V2ZXJhbCBjYWxscyBkZWVwIGZ3bm9kZV9tZGlv YnVzX3BoeV9kZXZpY2VfcmVnaXN0ZXIoZXRoZXJuZXRfcGh5IERUIG5vZGUpCj4gPiA+IC0+IFRy aWVkIHRvIGdldCB0aGUgSVJRIGxpc3RlZCBpbiBldGhlcm5ldF9waHkgYW5kIGZhaWxzIHdpdGgK PiA+ID4gLUVQUk9CRV9ERUZFUiBiZWNhdXNlIHRoZSBJUlEgZHJpdmVyIGlzbid0IGxvYWRlZCB5 ZXQuCj4gPiA+Cj4gPiA+IFRoZSBlcnJvciBpcyBwcm9wYWdhdGVkIGNvcnJlY3RseSBhbGwgdGhl IHdheSB1cCB0byBvZl9tZGlvYnVzX3JlZ2lzdGVyKCksIGJ1dAo+ID4gPiBtZGlvX211eF9pbml0 KCkgaWdub3JlcyB0aGUgLUVQUk9CRV9ERUZFUiBmcm9tIG9mX21kaW9idXNfcmVnaXN0ZXIoKSBh bmQganVzdAo+ID4gPiBjb250aW51ZXMgb24gd2l0aCB0aGUgcmVzdCBvZiB0aGUgc3R1ZmYgYW5k IHJldHVybnMgc3VjY2VzcyBhcyBsb25nIGFzCj4gPiA+IG9uZSBvZiB0aGUgY2hpbGQgbm9kZXMg KGluIHRoaXMgY2FzZSBpbnRfbWRpbykgc3VjY2VlZHMuCj4gPiA+Cj4gPiA+IFNpbmNlIHRoZSBw cm9iZSByZXR1cm5zIDAgd2l0aG91dCByZWFsbHkgc3VjY2VlZGluZywgbmV0d29ya2luZyBzdHVm Zgo+ID4gPiBqdXN0IGZhaWxzIGJhZGx5IGFmdGVyIHRoaXMuIFNvLCBJTU8sIHRoZSByZWFsIHBy b2JsZW0gaXMgd2l0aAo+ID4gPiBtZGlvX211eF9pbml0KCkgbm90IHByb3BhZ2F0aW5nIHVwIHRo ZSAtRVBST0JFX0RFRkVSLiBJIGdhdmUgTWFyYyBhCj4gPiA+IHF1aWNrIGhhY2sgKHBhc3RlZCBh dCB0aGUgZW5kIG9mIHRoaXMgZW1haWwpIHRvIHRlc3QgbXkgdGhlb3J5IGFuZCBoZQo+ID4gPiBj b25maXJtZWQgdGhhdCBpdCBmaXhlcyB0aGUgaXNzdWUgKGEgZmV3IGRlZmVycmVkIHByb2JlcyBs YXRlciwgdGhpbmdzCj4gPiA+IHdvcmsgcHJvcGVybHkpLgo+ID4gPgo+ID4gPiBBbmRyZXcsIEkg ZG9uJ3Qgc2VlIGFueSBnb29kIHJlYXNvbiBmb3IgbWRpb19tdXhfaW5pdCgpIG5vdAo+ID4gPiBw cm9wYWdhdGluZyB0aGUgZXJyb3JzIHVwIGNvcnJlY3RseSAoYXQgbGVhc3QgZm9yIEVQUk9CRV9E RUZFUikuIEknbGwKPiA+ID4gc2VuZCBhIHBhdGNoIHRvIGZpeCB0aGlzLiBQbGVhc2UgbGV0IG1l IGtub3cgaWYgdGhlcmUncyBhIHJlYXNvbiBpdAo+ID4gPiBoYXMgdG8gc3RheSBhcy1pcy4KPiA+ IAo+ID4gSSBzZW50IG91dCB0aGUgcHJvcGVyIGZpeCBhcyBhIHNlcmllczoKPiA+IGh0dHBzOi8v bG9yZS5rZXJuZWwub3JnL2xrbWwvMjAyMTA4MDQyMTQzMzMuOTI3OTg1LTEtc2FyYXZhbmFrQGdv b2dsZS5jb20vVC8jdAo+ID4gCj4gPiBNYXJjLCBjYW4geW91IGdpdmUgaXQgYSBzaG90IHBsZWFz ZT8KPiA+IAo+ID4gLVNhcmF2YW5hCj4gCj4gU3VwZXJzdGFyISAgVGhhbmtzIGZvciB0YWtpbmcg dGhlIHRpbWUgdG8gcmVjdGlmeSB0aGlzIGZvciBhbGwgb2YgdXMuCgpKdXN0IHRvIGNsYXJpZnk6 CgogIEFyZSB3ZSB3YWl0aW5nIG9uIGEgc3Vic2VxdWVudCBwYXRjaCBzdWJtaXNzaW9uIGF0IHRo aXMgcG9pbnQ/CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVh ZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2Fy ZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB189C43214 for ; Mon, 16 Aug 2021 12:47:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B26FE63275 for ; Mon, 16 Aug 2021 12:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235250AbhHPMrz (ORCPT ); Mon, 16 Aug 2021 08:47:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229806AbhHPMrw (ORCPT ); Mon, 16 Aug 2021 08:47:52 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCB83C061764 for ; Mon, 16 Aug 2021 05:47:20 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id f12-20020a05600c4e8c00b002e6bdd6ffe2so9131854wmq.5 for ; Mon, 16 Aug 2021 05:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=628UnG3xjkZBMBG0VGNKw9sLYLAdXr0sKp9IjqwLtm4=; b=nZUz0VgbAkxNJAiE9MAc/dLOh2wdouuGcy/tenu3ofifjwk5tWoE9ZMx1LtFAEZYIU QONqerIapPAAGzvIzkk/mNlH+qQeSp9tMDcVDsKW5gHXTzTPLztrAx7KngfSMjnuJFFo dHjxPf1qCxFJXqCyutbB3kV8NXqXw7PiZrMYagWbqpoVZ48LNLECUze9dYDjAjmVxNfx pKcEWV8s3eBmVp/N0w03KvQG8OpcaUurrTSEe0xJVYnMZ/+PVAm6NZQFE0aSiva4j427 Db+1TcjkumK3wixTTwieyOb2i3wons09jv0G1iypy/bykk7/FJ06CIC/E5UwDgA9Ty8H Hw6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=628UnG3xjkZBMBG0VGNKw9sLYLAdXr0sKp9IjqwLtm4=; b=Mixg1dmxUStJrYk0dkhe9mRpt4L58HZu7KSP7EgdS6T/MyvIpOyYCtCW9Yw2WlqzB1 p0MdhCKmBwCl18guF3jVcWZZgEF7zfCpIl7chESAMr3a21YnvSvoasIiyXflWOqxWwl+ 3O3p4xaSkq9AStfBeUYyqwtoVI4rAftZ1LteOSAQgpGJkBijtsbHaNoCMsJrtW/f8S5z Zu14d68WcrJGvXNEecmw5HXpjyVAvUP35/8lv8nIVT9UtzqZUWoVQEqfPeTGEV1PUkFQ RApH4AW/uH422hrTrnsMIi6IDVISLJckmQS+ypn12Lt5lDeCh+OeRH/PsqyLIEvjg9a+ 6xxg== X-Gm-Message-State: AOAM530aYldPWP8vrkqUDs1QaAdTmo3ndiJGQuBAg03yxgmWJT2jOrSX 0Gcd3iLv+K/ibYiqm3HIpcpYfg== X-Google-Smtp-Source: ABdhPJzzWSQkQOBKWoi/NFlSIrCnrGUOE8L5DC8bQK9YcmtgJr492sWEK0o8hMmdRhhMLeglR7G/kg== X-Received: by 2002:a05:600c:4ba4:: with SMTP id e36mr5859426wmp.82.1629118039320; Mon, 16 Aug 2021 05:47:19 -0700 (PDT) Received: from google.com ([2.31.167.59]) by smtp.gmail.com with ESMTPSA id z126sm10724473wmc.11.2021.08.16.05.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 05:47:18 -0700 (PDT) Date: Mon, 16 Aug 2021 13:47:16 +0100 From: Lee Jones To: Saravana Kannan Cc: Marc Zyngier , Andrew Lunn , Kevin Hilman , Neil Armstrong , Jerome Brunet , linux-amlogic@lists.infradead.org, linux-arm-kernel , open list , netdev , Android Kernel Team Subject: Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module Message-ID: References: <7hsga8kb8z.fsf@baylibre.com> <87r1hwwier.wl-maz@kernel.org> <7h7diwgjup.fsf@baylibre.com> <87im0m277h.wl-maz@kernel.org> <87sfzpwq4f.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Aug 2021, Lee Jones wrote: > On Wed, 04 Aug 2021, Saravana Kannan wrote: > > > On Wed, Aug 4, 2021 at 11:20 AM Saravana Kannan wrote: > > > > > > On Wed, Aug 4, 2021 at 1:50 AM Marc Zyngier wrote: > > > > > > > > On Wed, 04 Aug 2021 02:36:45 +0100, > > > > Saravana Kannan wrote: > > > > > > > > Hi Saravana, > > > > > > > > Thanks for looking into this. > > > > > > You are welcome. I just don't want people to think fw_devlink is broken :) > > > > > > > > > > > [...] > > > > > > > > > > Saravana, could you please have a look from a fw_devlink perspective? > > > > > > > > > > Sigh... I spent several hours looking at this and wrote up an analysis > > > > > and then realized I might be looking at the wrong DT files. > > > > > > > > > > Marc, can you point me to the board file in upstream that corresponds > > > > > to the platform in which you see this issue? I'm not asking for [1], > > > > > but the actual final .dts (not .dtsi) file that corresponds to the > > > > > platform/board/system. > > > > > > > > The platform I can reproduce this on is described in > > > > arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts. It is an > > > > intricate maze of inclusion, node merge and other DT subtleties. I > > > > suggest you look at the decompiled version to get a view of the > > > > result. > > > > > > Thanks. After decompiling it, it looks something like (stripped a > > > bunch of reg and address properties and added the labels back): > > > > > > eth_phy: mdio-multiplexer@4c000 { > > > compatible = "amlogic,g12a-mdio-mux"; > > > clocks = <0x02 0x13 0x1e 0x02 0xb1>; > > > clock-names = "pclk\0clkin0\0clkin1"; > > > mdio-parent-bus = <0x22>; > > > > > > ext_mdio: mdio@0 { > > > reg = <0x00>; > > > > > > ethernet-phy@0 { > > > max-speed = <0x3e8>; > > > interrupt-parent = <0x23>; > > > interrupts = <0x1a 0x08>; > > > phandle = <0x16>; > > > }; > > > }; > > > > > > int_mdio: mdio@1 { > > > ... > > > } > > > } > > > > > > And phandle 0x23 refers to the gpio_intc interrupt controller with the > > > modular driver. > > > > > > > > Based on your error messages, it's failing for mdio@0 which > > > > > corresponds to ext_mdio. But none of the board dts files in upstream > > > > > have a compatible property for "ext_mdio". Which means fw_devlink > > > > > _should_ propagate the gpio_intc IRQ dependency all the way up to > > > > > eth_phy. > > > > > > > > > > Also, in the failing case, can you run: > > > > > ls -ld supplier:* > > > > > > > > > > in the /sys/devices/..../ folder that corresponds to the > > > > > "eth_phy: mdio-multiplexer@4c000" DT node and tell me what it shows? > > > > > > > > Here you go: > > > > > > > > root@tiger-roach:~# find /sys/devices/ -name 'supplier*'|grep -i mdio | xargs ls -ld > > > > lrwxrwxrwx 1 root root 0 Aug 4 09:47 /sys/devices/platform/soc/ff600000.bus/ff64c000.mdio-multiplexer/supplier:platform:ff63c000.system-controller:clock-controller -> ../../../../virtual/devlink/platform:ff63c000.system-controller:clock-controller--platform:ff64c000.mdio-multiplexer > > > > > > As we discussed over chat, this was taken after the mdio-multiplexer > > > driver "successfully" probes this device. This will cause > > > SYNC_STATE_ONLY device links created by fw_devlink to be deleted > > > (because they are useless after a device probes). So, this doesn't > > > show the info I was hoping to demonstrate. > > > > > > In any case, one can see that fw_devlink properly created the device > > > link for the clocks dependency. So fw_devlink is parsing this node > > > properly. But it doesn't create a similar probe order enforcing device > > > link between the mdio-multiplexer and the gpio_intc because the > > > dependency is only present in a grand child DT node (ethernet-phy@0 > > > under ext_mdio). So fw_devlink is working as intended. > > > > > > I spent several hours squinting at the code/DT yesterday. Here's what > > > is going on and causing the problem: > > > > > > The failing driver in this case is > > > drivers/net/mdio/mdio-mux-meson-g12a.c. And the only DT node it's > > > handling is what I pasted above in this email. In the failure case, > > > the call flow is something like this: > > > > > > g12a_mdio_mux_probe() > > > -> mdio_mux_init() > > > -> of_mdiobus_register(ext_mdio DT node) > > > -> of_mdiobus_register_phy(ext_mdio DT node) > > > -> several calls deep fwnode_mdiobus_phy_device_register(ethernet_phy DT node) > > > -> Tried to get the IRQ listed in ethernet_phy and fails with > > > -EPROBE_DEFER because the IRQ driver isn't loaded yet. > > > > > > The error is propagated correctly all the way up to of_mdiobus_register(), but > > > mdio_mux_init() ignores the -EPROBE_DEFER from of_mdiobus_register() and just > > > continues on with the rest of the stuff and returns success as long as > > > one of the child nodes (in this case int_mdio) succeeds. > > > > > > Since the probe returns 0 without really succeeding, networking stuff > > > just fails badly after this. So, IMO, the real problem is with > > > mdio_mux_init() not propagating up the -EPROBE_DEFER. I gave Marc a > > > quick hack (pasted at the end of this email) to test my theory and he > > > confirmed that it fixes the issue (a few deferred probes later, things > > > work properly). > > > > > > Andrew, I don't see any good reason for mdio_mux_init() not > > > propagating the errors up correctly (at least for EPROBE_DEFER). I'll > > > send a patch to fix this. Please let me know if there's a reason it > > > has to stay as-is. > > > > I sent out the proper fix as a series: > > https://lore.kernel.org/lkml/20210804214333.927985-1-saravanak@google.com/T/#t > > > > Marc, can you give it a shot please? > > > > -Saravana > > Superstar! Thanks for taking the time to rectify this for all of us. Just to clarify: Are we waiting on a subsequent patch submission at this point? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog