From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 276CF173 for ; Tue, 17 Aug 2021 15:46:29 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 1a1bb594-ff72-11eb-b37b-0050568c148b; Tue, 17 Aug 2021 15:45:09 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 2547A194B56; Tue, 17 Aug 2021 17:45:28 +0200 (CEST) Date: Tue, 17 Aug 2021 17:45:16 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Nikola Pavlica Cc: dri-devel@lists.freedesktop.org, thierry.reding@gmail.com, airlied@linux.ie, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel-simple: Add Vivax TPC-9150 panel Message-ID: References: <20210817083201.675133-1-pavlica.nikola@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210817083201.675133-1-pavlica.nikola@gmail.com> Hi Nikola, see a few comments in the following. On Tue, Aug 17, 2021 at 10:32:01AM +0200, Nikola Pavlica wrote: > The model and make of the LCD panel of the Vivax TPC-9150 is unknown, > hence the panel settings that were retrieved with a FEX dump are named > after the device NOT the actual panel. > > The LCD in question is a 50 pin MISO TFT LCD panel of the resolution > 1024x600 used by the aforementioned device. > > Signed-off-by: Nikola Pavlica > --- > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 4e2dad314c79..97fc3c5740bb 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -4090,6 +4090,29 @@ static const struct panel_desc arm_rtsm = { > .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > }; > > +static const struct drm_display_mode vivax_tpc9150_panel_mode = { > + .clock = 60000, > + .hdisplay = 1024, > + .hsync_start = 1024 + 160, > + .hsync_end = 1024 + 160 + 100, > + .htotal = 1024 + 160 + 100 + 60, > + .vdisplay = 600, > + .vsync_start = 600 + 12, > + .vsync_end = 600 + 12 + 10, > + .vtotal = 600 + 12 + 10 + 13, > +}; .flags? > + > +static const struct panel_desc vivax_tpc9150_panel = { > + .modes = &vivax_tpc9150_panel_mode, > + .num_modes = 1, > + .size = { > + .width = 223, > + .height = 125, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH, > +}; Specifying .connector_type is mandatory today. Please specify .bpc too. Consider if .bus_flags cover it all, they can be a little tricky to add them all. And many many displays have failed to do so. I hope to see a new version soon with these comments and also the comments from Thierry fixed. Sam > + > static const struct of_device_id platform_of_match[] = { > { > .compatible = "ampire,am-1280800n3tzqw-t00h", > @@ -4103,6 +4126,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "arm,rtsm-display", > .data = &arm_rtsm, > + }, { > + .compatible = "vivax,tpc9150-panel", > + .data = &vivax_tpc9150_panel, > }, { > .compatible = "armadeus,st0700-adapt", > .data = &armadeus_st0700_adapt, > -- > 2.32.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65C78C4320A for ; Tue, 17 Aug 2021 15:47:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F06960FD9 for ; Tue, 17 Aug 2021 15:47:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3F06960FD9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FB7Lkj63YQA2NByp2D4HbcyBECZRlPTSEcWKrYoBerg=; b=AAbuoDEz+qoVWo KLBqa7FfkW7+CV10Pm++zxxEqNo36Rg/HwL3wWhFthlNWb2i7TSA52erJH/xtNt1bv0BwiEx0ntHZ vU++sj61QKsQYgbtPflYEUqF43egAnupqgBi59+IOfK4SjXbMnFL2FZ1aorxWvB0KvguizWH1q6k5 35gRAHntv0zERYl0rKf+qankayM50xsQR/HhhNYwybPjgRsnslV9SFL3Sfmuc+so3m9wQQrgDHCQC 0gUE9dXaJuJ+6J+bSGhub+exbCqCHkO1nrwTyb8y8QPAg8EMVmQmu0NbTPP3XrBiIsz6qtapaLofG k5Xz3+DaxBsPsHJjQr/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mG1HM-002qOR-FG; Tue, 17 Aug 2021 15:45:28 +0000 Received: from mx1.smtp.larsendata.com ([91.221.196.215]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mG1HH-002qMv-Oa for linux-arm-kernel@lists.infradead.org; Tue, 17 Aug 2021 15:45:25 +0000 Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 1a1bb594-ff72-11eb-b37b-0050568c148b; Tue, 17 Aug 2021 15:45:09 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 2547A194B56; Tue, 17 Aug 2021 17:45:28 +0200 (CEST) Date: Tue, 17 Aug 2021 17:45:16 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Nikola Pavlica Cc: dri-devel@lists.freedesktop.org, thierry.reding@gmail.com, airlied@linux.ie, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel-simple: Add Vivax TPC-9150 panel Message-ID: References: <20210817083201.675133-1-pavlica.nikola@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210817083201.675133-1-pavlica.nikola@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210817_084523_987380_92314123 X-CRM114-Status: GOOD ( 21.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nikola, see a few comments in the following. On Tue, Aug 17, 2021 at 10:32:01AM +0200, Nikola Pavlica wrote: > The model and make of the LCD panel of the Vivax TPC-9150 is unknown, > hence the panel settings that were retrieved with a FEX dump are named > after the device NOT the actual panel. > > The LCD in question is a 50 pin MISO TFT LCD panel of the resolution > 1024x600 used by the aforementioned device. > > Signed-off-by: Nikola Pavlica > --- > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 4e2dad314c79..97fc3c5740bb 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -4090,6 +4090,29 @@ static const struct panel_desc arm_rtsm = { > .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > }; > > +static const struct drm_display_mode vivax_tpc9150_panel_mode = { > + .clock = 60000, > + .hdisplay = 1024, > + .hsync_start = 1024 + 160, > + .hsync_end = 1024 + 160 + 100, > + .htotal = 1024 + 160 + 100 + 60, > + .vdisplay = 600, > + .vsync_start = 600 + 12, > + .vsync_end = 600 + 12 + 10, > + .vtotal = 600 + 12 + 10 + 13, > +}; .flags? > + > +static const struct panel_desc vivax_tpc9150_panel = { > + .modes = &vivax_tpc9150_panel_mode, > + .num_modes = 1, > + .size = { > + .width = 223, > + .height = 125, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH, > +}; Specifying .connector_type is mandatory today. Please specify .bpc too. Consider if .bus_flags cover it all, they can be a little tricky to add them all. And many many displays have failed to do so. I hope to see a new version soon with these comments and also the comments from Thierry fixed. Sam > + > static const struct of_device_id platform_of_match[] = { > { > .compatible = "ampire,am-1280800n3tzqw-t00h", > @@ -4103,6 +4126,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "arm,rtsm-display", > .data = &arm_rtsm, > + }, { > + .compatible = "vivax,tpc9150-panel", > + .data = &vivax_tpc9150_panel, > }, { > .compatible = "armadeus,st0700-adapt", > .data = &armadeus_st0700_adapt, > -- > 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel