All of lore.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Daniel Steger <dsteger@xilinx.com>
Cc: "rafael@kernel.org" <rafael@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs: sysfs: do not remove files if group is null
Date: Tue, 17 Aug 2021 18:18:07 +0200	[thread overview]
Message-ID: <YRvhP3qchzjAPsdA@kroah.com> (raw)
In-Reply-To: <BY5PR02MB68170E18D6B5C79BB0AC9083C1FE9@BY5PR02MB6817.namprd02.prod.outlook.com>

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Aug 17, 2021 at 04:13:48PM +0000, Daniel Steger wrote:
> Hi Greg, Rafael, 
> 
> Have you had a chance to review this patch?

What patch?

> 
> Thank You,
> Daniel
> 
> -----Original Message-----
> From: Daniel Steger <daniel.steger@xilinx.com> 
> Sent: Monday, August 9, 2021 1:42 PM
> To: gregkh@linuxfoundation.org; rafael@kernel.org
> Cc: linux-kernel@vger.kernel.org; Daniel Steger <dsteger@xilinx.com>
> Subject: [PATCH] fs: sysfs: do not remove files if group is null

What is the message id of this, I do not see it on my side at all.

> 
> The current implementation allows the remove_files() API to be called without checking if the grp->name is null. Ensure that the group name is valid prior to removing files.

At the least, wrap your lines at 72 columns, we can't take this as-is...

thanks,

greg k-h

  reply	other threads:[~2021-08-17 16:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210809204228.2987376-1-daniel.steger@xilinx.com>
2021-08-17 16:13 ` [PATCH] fs: sysfs: do not remove files if group is null Daniel Steger
2021-08-17 16:18   ` gregkh [this message]
2021-08-17 16:19     ` gregkh
2021-08-18  1:07 Daniel Steger
2021-08-18  5:35 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2021-08-19 19:10 Daniel Steger
2021-08-21 11:52 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRvhP3qchzjAPsdA@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dsteger@xilinx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.