From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mGG9R-0001SC-UD for mharc-grub-devel@gnu.org; Wed, 18 Aug 2021 03:38:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGG9Q-0001RR-RS for grub-devel@gnu.org; Wed, 18 Aug 2021 03:38:16 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:47064) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGG9O-0008He-G6 for grub-devel@gnu.org; Wed, 18 Aug 2021 03:38:16 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D60C322039; Wed, 18 Aug 2021 07:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1629272292; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aD7FW9izhlR650bq8qPoOvi4h4R+6Huf4Dbys1vaSw0=; b=Esiyl7zGrkLGyxbF/FA+1W3XmekuolfNziPSEITz2fsg9qEdJkIS0Dg6LFzCxQ3idi8Bwn VSfS4TMYid82qOV/iXXBnq1Qs0D0BIDz2KgL7Uk7FQG7EqNB5WSkyuyKL7gS4sIJ6+kyVs s8FGkT6oaGYL12ssVixWFWVrZZ2Pl2M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1629272292; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aD7FW9izhlR650bq8qPoOvi4h4R+6Huf4Dbys1vaSw0=; b=135WGZe7z7O65MBnLtn3t2yF6E4sAu8WhatQbyWT8fgKuzcPltWjNnW2T+SZItsjNTgUgl AO2g1pJJTChQUkDg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id AC81713357; Wed, 18 Aug 2021 07:38:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id dPXwJ+S4HGEwAQAAGKfGzw (envelope-from ); Wed, 18 Aug 2021 07:38:12 +0000 Date: Wed, 18 Aug 2021 09:38:11 +0200 From: Petr Vorel To: Daniel Kiper , grub-devel@gnu.org Subject: Re: [PATCH 2/2] autogen.sh: Detect python Message-ID: Reply-To: Petr Vorel References: <20210806064508.4489-1-pvorel@suse.cz> <20210806064508.4489-2-pvorel@suse.cz> <20210809115229.toe34etovoul62ss@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=195.135.220.28; envelope-from=pvorel@suse.cz; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2021 07:38:17 -0000 > Hi Daniel, > sorry for longer time to reply (vacation). > > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > > > It help to avoid error on distros which has only python3 binary: > > > ./autogen.sh: line 20: python: command not found > > > Using bash builtin 'command -v' to avoid requiring which as extra > > > dependency (usable on containers). > command -v is supported in other common shells (busybox sh and dash), > I'll add it to the commit message. > IMHO it's non-POSIX extension, but because it's support we use it in LTP shell > API, where we expect very minimal shell tools (i.e. no bash, no core utils). Actually "command -v" [1] and "type" [2] are POSIX. Kind regards, Petr [1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/command.html [2] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/type.html