From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CBF4C432BE for ; Wed, 1 Sep 2021 22:04:17 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 7CB0C6108E for ; Wed, 1 Sep 2021 22:04:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7CB0C6108E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EA64B4B0AC; Wed, 1 Sep 2021 18:04:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dO6WzE1C+TVm; Wed, 1 Sep 2021 18:04:12 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 174394B11E; Wed, 1 Sep 2021 18:04:12 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A10FA4B0B4 for ; Wed, 1 Sep 2021 18:04:10 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9mhZkcH6LP79 for ; Wed, 1 Sep 2021 18:04:09 -0400 (EDT) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 8B85D4B0AC for ; Wed, 1 Sep 2021 18:04:09 -0400 (EDT) Received: by mail-io1-f47.google.com with SMTP id a15so1130232iot.2 for ; Wed, 01 Sep 2021 15:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uAcZD9SKFW1AVCpO9fy2xcE9RkcQWlr+7iJy1aKTS5k=; b=IqadqVyNMf/GZSVQLByPmoGST5Yoe6VHJSXDJKjBpMmn12ALTuYElYhDRaFxgUJUnh Ei97BB4BG2dhB0qxmaygwLY66TG2qW8NKDzECdYdgqAl8nmRSlDYtcr3TI42eifXXsRf MtTeSKtV9bxupkt2+vheAfn70IzWWR3OgdmgxiY6RCP+/kIpsMylxa88a9gECQKYBM12 QorJM/x/GLXBb/UWm+hzcrkGhoCM/gBGgmi1sB9G7jJUnEXBvG+5ngzDKj2d+aV7WZJS fgMm5+8NEGJTfXvzf0xCZHa9BSFI3GGL68GZkKT/EJ18Ym4XqeRflMw+VXgeQEZmaJFk VAoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uAcZD9SKFW1AVCpO9fy2xcE9RkcQWlr+7iJy1aKTS5k=; b=njZGhCaIV6GpboTaro/EhMoQYCD4S1D4E6NuHNLesbVxsbsmSY/I/sN3Y8e0e9+2JE 18+863XTL53MKoiM1h9W7RMUsM7HUsCgk1bie0nDZTWY08f+2YwsKVb4NIoPkK3xruyp eUYYUgws4fDjptqyy9cl9T8O6lbgN+znFjfMQ2ccTJVlZmV17nI+OVdyJKPqrlxj/yUh 1bwqnIMl77JSYcsMnkN6KJGUzL3BDHrLyRyssclcwsjRi8Y1dndCbDnee5RmWthUnl0j nn+k9h/d7nkidCWEtoC6cBciR558wiyo3xBe7TZFliXowZpf2o8aEHpmTm2H7+c6xDVm LM2Q== X-Gm-Message-State: AOAM531B18q0CkQQ7AVw6Yt3QPd873zS9E4YB+h9480Nfs8u0LxW4Wq0 oRbhkCQTrMb7XdDcdXG5s9ttpQ== X-Google-Smtp-Source: ABdhPJwTRdJFJ6ex11gPL8dYES9aQ8TT1xcF+pPFPuvFnHsEfoKjvOB5PvAT01pIWLgFdsX/2UcxFA== X-Received: by 2002:a5d:8d06:: with SMTP id p6mr20177ioj.7.1630533848737; Wed, 01 Sep 2021 15:04:08 -0700 (PDT) Received: from google.com (194.225.68.34.bc.googleusercontent.com. [34.68.225.194]) by smtp.gmail.com with ESMTPSA id g14sm418990ila.28.2021.09.01.15.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 15:04:08 -0700 (PDT) Date: Wed, 1 Sep 2021 22:04:04 +0000 From: Oliver Upton To: Raghavendra Rao Ananta Subject: Re: [PATCH v3 00/12] KVM: arm64: selftests: Introduce arch_timer selftest Message-ID: References: <20210901211412.4171835-1-rananta@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210901211412.4171835-1-rananta@google.com> Cc: kvm@vger.kernel.org, Will Deacon , Catalin Marinas , Peter Shier , linux-kernel@vger.kernel.org, Marc Zyngier , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Sep 01, 2021 at 09:14:00PM +0000, Raghavendra Rao Ananta wrote: > Hello, > > The patch series adds a KVM selftest to validate the behavior of > ARM's generic timer (patch-11). The test programs the timer IRQs > periodically, and for each interrupt, it validates the behaviour > against the architecture specifications. The test further provides > a command-line interface to configure the number of vCPUs, the > period of the timer, and the number of iterations that the test > has to run for. > > Patch-12 adds an option to randomly migrate the vCPUs to different > physical CPUs across the system. The bug for the fix provided by > Marc with commit 3134cc8beb69d0d ("KVM: arm64: vgic: Resample HW > pending state on deactivation") was discovered using arch_timer > test with vCPU migrations. > > Since the test heavily depends on interrupts, patch-10 adds a host > library to setup ARM Generic Interrupt Controller v3 (GICv3). This > includes creating a vGIC device, setting up distributor and > redistributor attributes, and mapping the guest physical addresses. > Symmetrical to this, patch-9 adds a guest library to talk to the vGIC, > which includes initializing the controller, enabling/disabling the > interrupts, and so on. > > Furthermore, additional processor utilities such as accessing the MMIO > (via readl/writel), read/write to assembler unsupported registers, > basic delay generation, enable/disable local IRQs, and so on, are also > introduced that the test/GICv3 takes advantage of (patches 1 through 8). > > The patch series, specifically the library support, is derived from the > kvm-unit-tests and the kernel itself. > > Regards, > Raghavendra For later submissions, can you include a lore.kernel.org link to your older revisions of the series? NBD now, its easy to find in my inbox but just for future reference. -- Best, Oliver _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 199F8C432BE for ; Wed, 1 Sep 2021 22:06:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D72B361053 for ; Wed, 1 Sep 2021 22:06:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D72B361053 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KOT3OpMHtgV/qJEUO5W0tfwIu/xLI5Byz3elDMBiHBg=; b=tiJQW2M/KdR+KT euDHUwxLpa/j2l5Mz0SxA7jVbmXv55FVSGdna/0Cq34QpPX3H0YMRte5ilhJmr1rJoXtZiYuGHj0d 9pJ8W1wpYHWeQRFcQpfWIGj16kLC3fYmRIglt5UlXa4T9r1bVB+6N5hI1vCMcjO8+63NX60mW1Yzq W0vWVFC262SszI4FU/xddcVld+EFczDJ7eeT/eH5BazZyPVzxo1n4asJ5rWP1ooSkhWLQ8Qz+58Dc 1K3YW9iCJhr95sKvI88jNWiK6CbguLnpnHzcSJoBYI5J3Z+dbgtMNjfRi+x//fAmPkfNJXy7B9/zt pWatOlEPa6GIGUqsFpog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLYLD-007cDl-E2; Wed, 01 Sep 2021 22:04:19 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLYL9-007cBK-N6 for linux-arm-kernel@lists.infradead.org; Wed, 01 Sep 2021 22:04:17 +0000 Received: by mail-io1-xd33.google.com with SMTP id z1so1094700ioh.7 for ; Wed, 01 Sep 2021 15:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uAcZD9SKFW1AVCpO9fy2xcE9RkcQWlr+7iJy1aKTS5k=; b=IqadqVyNMf/GZSVQLByPmoGST5Yoe6VHJSXDJKjBpMmn12ALTuYElYhDRaFxgUJUnh Ei97BB4BG2dhB0qxmaygwLY66TG2qW8NKDzECdYdgqAl8nmRSlDYtcr3TI42eifXXsRf MtTeSKtV9bxupkt2+vheAfn70IzWWR3OgdmgxiY6RCP+/kIpsMylxa88a9gECQKYBM12 QorJM/x/GLXBb/UWm+hzcrkGhoCM/gBGgmi1sB9G7jJUnEXBvG+5ngzDKj2d+aV7WZJS fgMm5+8NEGJTfXvzf0xCZHa9BSFI3GGL68GZkKT/EJ18Ym4XqeRflMw+VXgeQEZmaJFk VAoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uAcZD9SKFW1AVCpO9fy2xcE9RkcQWlr+7iJy1aKTS5k=; b=GnueOPxPNfyxuQq4O1UzPXqLDZZxymE8/sEg+EGaFGdIiXXOd7jw2qqushIw/KejbF sub5iOLXzR27PU1A40SMIzfXvvRCy66mtbY8bsFiQ8/9Fjltfo3wFoBqS/mzSU8inB8y 3ct5JNL1QD4y41/KRaHiOwXgHmvcINMNzkTXBRdfXbmlsuEQ1p45IXIq6kcIvKlY8qeF kqG8AS5DL76drIwZX83SG07+40Ln9QHt3cckaejM5+nHNSVCEEwxZOK/4ercD2j4oLOW prqWwgz8uIMUmEQx2xOGfidSTX/5ddOopdzYoN/03zKR4j4rfO9w98PsMbkjzmH0H9WX UQxA== X-Gm-Message-State: AOAM533ymnKdZRDfCxJaOCeNrp2U+IwXJt7Ivo+1ip0FtDRFpCE5Htli tNhppEI07SxcwRAW5fpmJuwb1w== X-Google-Smtp-Source: ABdhPJwTRdJFJ6ex11gPL8dYES9aQ8TT1xcF+pPFPuvFnHsEfoKjvOB5PvAT01pIWLgFdsX/2UcxFA== X-Received: by 2002:a5d:8d06:: with SMTP id p6mr20177ioj.7.1630533848737; Wed, 01 Sep 2021 15:04:08 -0700 (PDT) Received: from google.com (194.225.68.34.bc.googleusercontent.com. [34.68.225.194]) by smtp.gmail.com with ESMTPSA id g14sm418990ila.28.2021.09.01.15.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 15:04:08 -0700 (PDT) Date: Wed, 1 Sep 2021 22:04:04 +0000 From: Oliver Upton To: Raghavendra Rao Ananta Cc: Paolo Bonzini , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v3 00/12] KVM: arm64: selftests: Introduce arch_timer selftest Message-ID: References: <20210901211412.4171835-1-rananta@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210901211412.4171835-1-rananta@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210901_150415_804342_E3D2A70D X-CRM114-Status: GOOD ( 21.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 01, 2021 at 09:14:00PM +0000, Raghavendra Rao Ananta wrote: > Hello, > > The patch series adds a KVM selftest to validate the behavior of > ARM's generic timer (patch-11). The test programs the timer IRQs > periodically, and for each interrupt, it validates the behaviour > against the architecture specifications. The test further provides > a command-line interface to configure the number of vCPUs, the > period of the timer, and the number of iterations that the test > has to run for. > > Patch-12 adds an option to randomly migrate the vCPUs to different > physical CPUs across the system. The bug for the fix provided by > Marc with commit 3134cc8beb69d0d ("KVM: arm64: vgic: Resample HW > pending state on deactivation") was discovered using arch_timer > test with vCPU migrations. > > Since the test heavily depends on interrupts, patch-10 adds a host > library to setup ARM Generic Interrupt Controller v3 (GICv3). This > includes creating a vGIC device, setting up distributor and > redistributor attributes, and mapping the guest physical addresses. > Symmetrical to this, patch-9 adds a guest library to talk to the vGIC, > which includes initializing the controller, enabling/disabling the > interrupts, and so on. > > Furthermore, additional processor utilities such as accessing the MMIO > (via readl/writel), read/write to assembler unsupported registers, > basic delay generation, enable/disable local IRQs, and so on, are also > introduced that the test/GICv3 takes advantage of (patches 1 through 8). > > The patch series, specifically the library support, is derived from the > kvm-unit-tests and the kernel itself. > > Regards, > Raghavendra For later submissions, can you include a lore.kernel.org link to your older revisions of the series? NBD now, its easy to find in my inbox but just for future reference. -- Best, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86163C432BE for ; Wed, 1 Sep 2021 22:04:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62E9261090 for ; Wed, 1 Sep 2021 22:04:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232093AbhIAWFH (ORCPT ); Wed, 1 Sep 2021 18:05:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232007AbhIAWFG (ORCPT ); Wed, 1 Sep 2021 18:05:06 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7D90C061575 for ; Wed, 1 Sep 2021 15:04:09 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id f6so1189200iox.0 for ; Wed, 01 Sep 2021 15:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uAcZD9SKFW1AVCpO9fy2xcE9RkcQWlr+7iJy1aKTS5k=; b=IqadqVyNMf/GZSVQLByPmoGST5Yoe6VHJSXDJKjBpMmn12ALTuYElYhDRaFxgUJUnh Ei97BB4BG2dhB0qxmaygwLY66TG2qW8NKDzECdYdgqAl8nmRSlDYtcr3TI42eifXXsRf MtTeSKtV9bxupkt2+vheAfn70IzWWR3OgdmgxiY6RCP+/kIpsMylxa88a9gECQKYBM12 QorJM/x/GLXBb/UWm+hzcrkGhoCM/gBGgmi1sB9G7jJUnEXBvG+5ngzDKj2d+aV7WZJS fgMm5+8NEGJTfXvzf0xCZHa9BSFI3GGL68GZkKT/EJ18Ym4XqeRflMw+VXgeQEZmaJFk VAoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uAcZD9SKFW1AVCpO9fy2xcE9RkcQWlr+7iJy1aKTS5k=; b=goHaK2Kpdm4hDUJ3l+MsN+YEP5cszPiFuSfNRdKXrj92EytMpJ8ucmy4Bit63hNwWE uuKGCKhyMRitHLeIuYDpuNj1QZQXjgQzlLE0LUynD8L34Dap/bjN2N3S3M5goBMHMjM6 oYGvCe34LDihxDYj5ot3P2L13qw5SIFNSXxCVW7d+bizt81wi0LyZUMMs0W5jHXimYf2 kmbxVZT6pRqwbRYPNeg8nU0jK0UIa3Dxyfhm8igu6+BCH57TOidozQBLOlwpprfog+X+ /V09IvSsCSHCneW4+ySQ3QgLdV2wgj6RaPi0ZJrbqTM0xjKL7G1GF3aM4vbPWR+wTzc7 PsYw== X-Gm-Message-State: AOAM530j8P3eHfXqVI9HAQcYPwdpvN39FnHL6m5HN/wseEe/I45Q/9+x TRV5qcubxP9evR0WyjTcrqhd0g== X-Google-Smtp-Source: ABdhPJwTRdJFJ6ex11gPL8dYES9aQ8TT1xcF+pPFPuvFnHsEfoKjvOB5PvAT01pIWLgFdsX/2UcxFA== X-Received: by 2002:a5d:8d06:: with SMTP id p6mr20177ioj.7.1630533848737; Wed, 01 Sep 2021 15:04:08 -0700 (PDT) Received: from google.com (194.225.68.34.bc.googleusercontent.com. [34.68.225.194]) by smtp.gmail.com with ESMTPSA id g14sm418990ila.28.2021.09.01.15.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 15:04:08 -0700 (PDT) Date: Wed, 1 Sep 2021 22:04:04 +0000 From: Oliver Upton To: Raghavendra Rao Ananta Cc: Paolo Bonzini , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v3 00/12] KVM: arm64: selftests: Introduce arch_timer selftest Message-ID: References: <20210901211412.4171835-1-rananta@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210901211412.4171835-1-rananta@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Sep 01, 2021 at 09:14:00PM +0000, Raghavendra Rao Ananta wrote: > Hello, > > The patch series adds a KVM selftest to validate the behavior of > ARM's generic timer (patch-11). The test programs the timer IRQs > periodically, and for each interrupt, it validates the behaviour > against the architecture specifications. The test further provides > a command-line interface to configure the number of vCPUs, the > period of the timer, and the number of iterations that the test > has to run for. > > Patch-12 adds an option to randomly migrate the vCPUs to different > physical CPUs across the system. The bug for the fix provided by > Marc with commit 3134cc8beb69d0d ("KVM: arm64: vgic: Resample HW > pending state on deactivation") was discovered using arch_timer > test with vCPU migrations. > > Since the test heavily depends on interrupts, patch-10 adds a host > library to setup ARM Generic Interrupt Controller v3 (GICv3). This > includes creating a vGIC device, setting up distributor and > redistributor attributes, and mapping the guest physical addresses. > Symmetrical to this, patch-9 adds a guest library to talk to the vGIC, > which includes initializing the controller, enabling/disabling the > interrupts, and so on. > > Furthermore, additional processor utilities such as accessing the MMIO > (via readl/writel), read/write to assembler unsupported registers, > basic delay generation, enable/disable local IRQs, and so on, are also > introduced that the test/GICv3 takes advantage of (patches 1 through 8). > > The patch series, specifically the library support, is derived from the > kvm-unit-tests and the kernel itself. > > Regards, > Raghavendra For later submissions, can you include a lore.kernel.org link to your older revisions of the series? NBD now, its easy to find in my inbox but just for future reference. -- Best, Oliver