From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C1CE3FC1 for ; Mon, 30 Aug 2021 21:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=TpHs1BAEvLrAgbJFRKgtK+86muZwthG7/YPxSjMo0eE=; b=Wc em+DfrnqdQCFj+volp7VYLu7aADN2QWnDBGK/Ck++RwnweRAeO8t205WjuhzuWmSWv5R72LNhdaoQ rd6iMSCd7cuSWHZbeHY2u8GjnvUj+XUMaYBo+0uOI5AUoR1exQvrUKKJhSLYLqYKscdIcHRrSLzWy jS/ysEBdIIKJ+sM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mKpAw-004d94-Vc; Mon, 30 Aug 2021 23:50:42 +0200 Date: Mon, 30 Aug 2021 23:50:42 +0200 From: Andrew Lunn To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Maxime Ripard , Chen-Yu Tsai , =?utf-8?B?Q2zDqW1lbnQgQsWTc2No?= , Willy Liu , Rob Herring , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Message-ID: References: <20210830151645.18018-1-u@pkh.me> <116454729.UZi3dMzWh7@jernej-laptop> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <116454729.UZi3dMzWh7@jernej-laptop> On Mon, Aug 30, 2021 at 10:49:37PM +0200, Jernej Škrabec wrote: > Hi! > > Dne ponedeljek, 30. avgust 2021 ob 17:16:45 CEST je Clément Bœsch napisal(a): > > Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay > > config") network is broken on the NanoPi Neo 2. > > > > This patch changes the phy-mode to use internal delays both for RX and > > TX as has been done for other boards affected by the same commit. > > > > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") > > This commit fixes DT issue, so "fixes" tag should be: > Fixes: 44a94c7ef989 ("arm64: dts: allwinner: H5: Restore EMAC changes") > > Here, a node with wrong phy-mode property was added to NanoPi Neo 2 board DT. Hi Jernej I would say, it is debatable. The board broke when the driver started acting on the value, which is commit bbc4d71d6354. It could be argued it was always technically broken, since it has the wrong value, but practically, it was not broken. One of the rules for stable is: - It must fix a real bug that bothers people (not a, "This could be a problem..." type thing). So i would argue, anything before bbc4d71d6354 does not fulfil stable requirements, since it does not bother anybody. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A21C432BE for ; Mon, 30 Aug 2021 21:52:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C41760FA0 for ; Mon, 30 Aug 2021 21:52:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C41760FA0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L/sRG583RUJ7bYgOxpr5WXxKFKvihQtfFgsiG2CaqGE=; b=Nsk0JBEtbDJHmx SezXNhAWBKS9grfN8CySCOCX3GCbi5dY8rbfpmauemuBIRb7v8FJ7QFfoMLff5SrpV9W4IOj5dDcA f0iDUC/j2un3g5anudMVAc4Ad+q6eYNo932gfSB0r9iXZverykmeh7Tvf8juWxyF/Aj/moBZ3TZ0T Q+kOeaNiOMXye68072JmJo/cxwx+mHbQrMky/eJahSS6MJBoNCYigTQIIxEhbskS2P7wwauLlu0re YbgJ3R+BcYf04hKxXV0OCdUhgknLDXtCzrExSKnB8HbRu7EJXeXU7euQ0wVS+jmYlgFxVgTsrY88F 71h3awfxY409J5HfgNdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKpBN-000hhB-8P; Mon, 30 Aug 2021 21:51:09 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKpBF-000hfr-Tm for linux-arm-kernel@lists.infradead.org; Mon, 30 Aug 2021 21:51:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=TpHs1BAEvLrAgbJFRKgtK+86muZwthG7/YPxSjMo0eE=; b=Wc em+DfrnqdQCFj+volp7VYLu7aADN2QWnDBGK/Ck++RwnweRAeO8t205WjuhzuWmSWv5R72LNhdaoQ rd6iMSCd7cuSWHZbeHY2u8GjnvUj+XUMaYBo+0uOI5AUoR1exQvrUKKJhSLYLqYKscdIcHRrSLzWy jS/ysEBdIIKJ+sM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mKpAw-004d94-Vc; Mon, 30 Aug 2021 23:50:42 +0200 Date: Mon, 30 Aug 2021 23:50:42 +0200 From: Andrew Lunn To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Maxime Ripard , Chen-Yu Tsai , =?utf-8?B?Q2zDqW1lbnQgQsWTc2No?= , Willy Liu , Rob Herring , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Message-ID: References: <20210830151645.18018-1-u@pkh.me> <116454729.UZi3dMzWh7@jernej-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <116454729.UZi3dMzWh7@jernej-laptop> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210830_145102_005593_D67712A7 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMzAsIDIwMjEgYXQgMTA6NDk6MzdQTSArMDIwMCwgSmVybmVqIMWga3JhYmVj IHdyb3RlOgo+IEhpIQo+IAo+IERuZSBwb25lZGVsamVrLCAzMC4gYXZndXN0IDIwMjEgb2IgMTc6 MTY6NDUgQ0VTVCBqZSBDbMOpbWVudCBCxZNzY2ggbmFwaXNhbChhKToKPiA+IFNpbmNlIGNvbW1p dCBiYmM0ZDcxZDYzNTQgKCJuZXQ6IHBoeTogcmVhbHRlazogZml4IHJ0bDgyMTFlIHJ4L3R4IGRl bGF5Cj4gPiBjb25maWciKSBuZXR3b3JrIGlzIGJyb2tlbiBvbiB0aGUgTmFub1BpIE5lbyAyLgo+ ID4gCj4gPiBUaGlzIHBhdGNoIGNoYW5nZXMgdGhlIHBoeS1tb2RlIHRvIHVzZSBpbnRlcm5hbCBk ZWxheXMgYm90aCBmb3IgUlggYW5kCj4gPiBUWCBhcyBoYXMgYmVlbiBkb25lIGZvciBvdGhlciBi b2FyZHMgYWZmZWN0ZWQgYnkgdGhlIHNhbWUgY29tbWl0Lgo+ID4gCj4gPiBGaXhlczogYmJjNGQ3 MWQ2MzU0ICgibmV0OiBwaHk6IHJlYWx0ZWs6IGZpeCBydGw4MjExZSByeC90eCBkZWxheSBjb25m aWciKQo+IAo+IFRoaXMgY29tbWl0IGZpeGVzIERUIGlzc3VlLCBzbyAiZml4ZXMiIHRhZyBzaG91 bGQgYmU6Cj4gRml4ZXM6IDQ0YTk0YzdlZjk4OSAoImFybTY0OiBkdHM6IGFsbHdpbm5lcjogSDU6 IFJlc3RvcmUgRU1BQyBjaGFuZ2VzIikKPiAKPiBIZXJlLCBhIG5vZGUgd2l0aCB3cm9uZyBwaHkt bW9kZSBwcm9wZXJ0eSB3YXMgYWRkZWQgdG8gTmFub1BpIE5lbyAyIGJvYXJkIERULiAgCgpIaSBK ZXJuZWoKCkkgd291bGQgc2F5LCBpdCBpcyBkZWJhdGFibGUuIFRoZSBib2FyZCBicm9rZSB3aGVu IHRoZSBkcml2ZXIgc3RhcnRlZAphY3Rpbmcgb24gdGhlIHZhbHVlLCB3aGljaCBpcyBjb21taXQg YmJjNGQ3MWQ2MzU0LiBJdCBjb3VsZCBiZSBhcmd1ZWQKaXQgd2FzIGFsd2F5cyB0ZWNobmljYWxs eSBicm9rZW4sIHNpbmNlIGl0IGhhcyB0aGUgd3JvbmcgdmFsdWUsIGJ1dApwcmFjdGljYWxseSwg aXQgd2FzIG5vdCBicm9rZW4uIE9uZSBvZiB0aGUgcnVsZXMgZm9yIHN0YWJsZSBpczoKCiAtIEl0 IG11c3QgZml4IGEgcmVhbCBidWcgdGhhdCBib3RoZXJzIHBlb3BsZSAobm90IGEsICJUaGlzIGNv dWxkIGJlIGEKICAgcHJvYmxlbS4uLiIgdHlwZSB0aGluZykuCgpTbyBpIHdvdWxkIGFyZ3VlLCBh bnl0aGluZyBiZWZvcmUgYmJjNGQ3MWQ2MzU0IGRvZXMgbm90IGZ1bGZpbCBzdGFibGUKcmVxdWly ZW1lbnRzLCBzaW5jZSBpdCBkb2VzIG5vdCBib3RoZXIgYW55Ym9keS4KCiAgICAgIEFuZHJldwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=