From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 765D2C432BE for ; Tue, 31 Aug 2021 20:22:42 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D78206056B for ; Tue, 31 Aug 2021 20:22:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D78206056B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BF4FC16DC; Tue, 31 Aug 2021 22:21:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BF4FC16DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1630441358; bh=Y6HeAOJc57R+pryEOV3L/0aTg1XdUdn8zt8x5eSH3co=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hQvRUb2otufRwVQSOs1XgxDlzglvzIJFrE3HUPY+LdVX8dj4hJ3HEIkpXXD9LlxSx 9DsVfcAKF6j9NGZcWXBWVm5XWKSDmE9t0wUkazySzvJeiu5fyChl1Lj9vz4+dAJjrZ RvrRMWB+gaBOsY+hg5L3I4UUZlzZjQf95w32ca2g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 443C3F80254; Tue, 31 Aug 2021 22:21:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 606D2F8025B; Tue, 31 Aug 2021 22:21:45 +0200 (CEST) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E2131F80127 for ; Tue, 31 Aug 2021 22:21:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E2131F80127 Received: by mail-ot1-f54.google.com with SMTP id a20-20020a0568300b9400b0051b8ca82dfcso708960otv.3 for ; Tue, 31 Aug 2021 13:21:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bU7TZOWBzRdHnk5u7KA0MFnjQQvgfnHsYudfpjDdkdg=; b=em3ZcDk+X5v5ZHxzjRp0EQm2b6LIyjzy7BWITUiVgfN9gggwq31hUBu4nf9iIV6bj5 He2T9bd4DaPAZqEHnuAfeFhrbPeRa0EdWV+CXSIBvRNGfnqz5Heg8dk+pxjj0ERA14wJ ohCKA3AEc38xd2UiB21zh6UoT/DdTQsSZHy/k7+TL48NCqNOuBu5vJ0p/X9L6dG36ECa YAUlzLpM4SmSbl2jY20kRfPavccdyJIGftJvqwudWJRps8HF6QU3sA9saxhLfEx+vvH8 NOAW9Hs2uIq7clqPkmH/RLJS+LO1TaVGXIKF87QeHvpaY3/2HEFR91bV+iQ49w7KAGZz QPHQ== X-Gm-Message-State: AOAM530mZCYEkNnqhfardQgyJWEyLyeOKEQtyjI4E3WCyXjb+aDlPO+B FjhyJWY5l0CQukLcrFfhyg== X-Google-Smtp-Source: ABdhPJwpoOM3fs+y4Ud1Zp79FJet9tP6f4HQm/EXSCPIYe1ZMQSRol2az2XulvfPxUOZMrz2Whg0pw== X-Received: by 2002:a9d:894:: with SMTP id 20mr25702438otf.262.1630441295709; Tue, 31 Aug 2021 13:21:35 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id c10sm4259279ots.48.2021.08.31.13.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 13:21:34 -0700 (PDT) Received: (nullmailer pid 588777 invoked by uid 1000); Tue, 31 Aug 2021 20:21:33 -0000 Date: Tue, 31 Aug 2021 15:21:33 -0500 From: Rob Herring To: Sameer Pujar Subject: Re: [PATCH 04/13] ASoC: dt-bindings: tegra: Few more Tegra210 AHUB modules Message-ID: References: <1630056839-6562-1-git-send-email-spujar@nvidia.com> <1630056839-6562-5-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1630056839-6562-5-git-send-email-spujar@nvidia.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, catalin.marinas@arm.com, tiwai@suse.com, lgirdwood@gmail.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, broonie@kernel.org, thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org, sharadg@nvidia.com, will@kernel.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Aug 27, 2021 at 03:03:50PM +0530, Sameer Pujar wrote: > This patch adds YAML schema for DT bindings of few AHUB modules. > These devices will be registered as ASoC components and bindings > will be used on Tegra210 and later chips. The bindings for below > mentioned modules are added: > > * SFC (Sampling Frequency Converter) > * MVC (Master Volume Control) > * AMX (Audio Multiplexer) > * ADX (Audio Demultiplexer) > * Mixer > > Signed-off-by: Sameer Pujar > Cc: Rob Herring > --- > .../bindings/sound/nvidia,tegra210-adx.yaml | 74 ++++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-ahub.yaml | 20 ++++++ > .../bindings/sound/nvidia,tegra210-amx.yaml | 72 ++++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-mixer.yaml | 67 ++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-mvc.yaml | 79 ++++++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-sfc.yaml | 76 +++++++++++++++++++++ > 6 files changed, 388 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml > > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml > new file mode 100644 > index 0000000..9950585 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-adx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 ADX Device Tree Bindings > + > +description: | > + The Audio Demultiplexer (ADX) block takes an input stream with up to extra spaces. > + 16 channels and demultiplexes it into four output streams of up to 16 > + channels each. A byte RAM helps to form output frames by any combination > + of bytes from the input frame. Its design is identical to that of byte > + RAM in the AMX except that the data flow direction is reversed. > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^adx@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-adx > + - items: > + - enum: > + - nvidia,tegra194-adx > + - nvidia,tegra186-adx > + - const: nvidia,tegra210-adx > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: nvidia,sound-name-prefix > + pattern: "^ADX[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "ADX1" or "ADX2" ... "ADXx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + ADX has one input and four output. Accordingly ACIF (Audio Client You need to define the port numbers for the input and each output. > + Interface) RX and TX port nodes are defined to represent ADX inputs > + and output respectively. These are connected to corresponding ports > + on AHUB. > + > + patternProperties: > + '^port@[0-9]': Per above, this will need to be split at least into input and output ports. Same issues in the other schemas. > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + adx@702d3800 { > + compatible = "nvidia,tegra210-adx"; > + reg = <0x702d3800 0x100>; > + sound-name-prefix = "ADX1"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > index 1118a94..4087eeb 100644 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > @@ -85,6 +85,26 @@ patternProperties: > type: object > $ref: nvidia,tegra186-dspk.yaml# > > + '^mvc@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-mvc.yaml# > + > + '^sfc@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-sfc.yaml# > + > + '^amx@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-amx.yaml# > + > + '^adx@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-adx.yaml# > + > + '^mixer@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-mixer.yaml# > + > required: > - compatible > - reg > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml > new file mode 100644 > index 0000000..e6b365b > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-amx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 AMX Device Tree Bindings > + > +description: | > + The Audio Multiplexer (AMX) block can multiplex up to four input streams > + each of which can have maximum 16 channels and generate an output stream > + with maximum 16 channels. A byte RAM helps to form an output frame by > + any combination of bytes from the input frames. > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^amx@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-amx > + - items: > + - const: nvidia,tegra186-amx > + - const: nvidia,tegra210-amx > + - const: nvidia,tegra194-amx > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + pattern: "^AMX[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "AMX1" or "AMX2" ... "AMXx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + AMX has four inputs and one output. Accordingly ACIF (Audio Client > + Interfaces) RX and TX port nodes are defined to represent AMX inputs > + and output respectively. These are connected to corresponding ports > + on AHUB. > + > + patternProperties: > + '^port@[0-9]': > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + amx@702d3000 { > + compatible = "nvidia,tegra210-amx"; > + reg = <0x702d3000 0x100>; > + sound-name-prefix = "AMX1"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml > new file mode 100644 > index 0000000..0808355 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-mixer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 Mixer Device Tree Bindings > + > +description: | > + The Mixer supports mixing of up to ten 7.1 audio input streams and > + generate five outputs (each of which can be any combination of the > + ten input streams). > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^mixer@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-amixer > + - items: > + - enum: > + - nvidia,tegra194-amixer > + - nvidia,tegra186-amixer > + - const: nvidia,tegra210-amixer > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + const: "MIXER" Don't need quotes. A fixed string seems a bit pointless to put into DT. > + $ref: /schemas/types.yaml#/definitions/string > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + Mixer has ten inputs and five outputs. Accordingly ACIF (Audio Client > + Interfaces) RX and TX port nodes are defined to represent MIXER inputs > + and outputs respectively. These are connected to corresponding ports > + on AHUB. > + > + patternProperties: > + '^port@[0-9]': > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + mixer@702dbb00 { > + compatible = "nvidia,tegra210-amixer"; > + reg = <0x702dbb00 0x800>; > + sound-name-prefix = "MIXER"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml > new file mode 100644 > index 0000000..7d81b11 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-mvc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 MVC Device Tree Bindings > + > +description: | > + The Master Volume Control (MVC) provides gain or attenuation to a digital > + signal path. It can be used in input or output signal path for per-stream > + volume control or it can be used as master volume control. The MVC block > + has one input and one output. The input digital stream can be mono or > + multi-channel (up to 7.1 channels) stream. An independent mute control is > + also included in the MVC block. > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^mvc@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-mvc > + - items: > + - enum: > + - nvidia,tegra194-mvc > + - nvidia,tegra186-mvc > + - const: nvidia,tegra210-mvc > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + pattern: "^MVC[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "MVC1" or "MVC2" ... "MVCx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + properties: > + port@0: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as MVC input (RX) port. > + This is connected to corresponding ACIF port on AHUB. > + > + port@1: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as MVC output (TX) port. > + This is connected to corresponding ACIF port on AHUB. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + mvc@702da000 { > + compatible = "nvidia,tegra210-mvc"; > + reg = <0x702da000 0x200>; > + sound-name-prefix = "MVC1"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml > new file mode 100644 > index 0000000..5f05e2a > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-sfc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 SFC Device Tree Bindings > + > +description: | > + The Sampling Frequency Converter (SFC) converts the sampling frequency > + of the input signal from one frequency to another. It supports sampling > + frequency conversions of streams of up to two channels (stereo). > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^sfc@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-sfc > + - items: > + - enum: > + - nvidia,tegra194-sfc > + - nvidia,tegra186-sfc > + - const: nvidia,tegra210-sfc > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + pattern: "^SFC[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "SFC1" or "SFC2" ... "SFCx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + properties: > + port@0: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as SFC input (RX) port. > + This is connected to corresponding ACIF port on AHUB. > + > + port@1: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as SFC output (TX) port. > + This is connected to corresponding ACIF port on AHUB. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + sfc@702d2000 { > + compatible = "nvidia,tegra210-sfc"; > + reg = <0x702d2000 0x200>; > + sound-name-prefix = "SFC1"; > + }; > + > +... > -- > 2.7.4 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44229C4320E for ; Tue, 31 Aug 2021 20:21:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E8F560F23 for ; Tue, 31 Aug 2021 20:21:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240094AbhHaUWe (ORCPT ); Tue, 31 Aug 2021 16:22:34 -0400 Received: from mail-ot1-f47.google.com ([209.85.210.47]:46856 "EHLO mail-ot1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230011AbhHaUWb (ORCPT ); Tue, 31 Aug 2021 16:22:31 -0400 Received: by mail-ot1-f47.google.com with SMTP id v33-20020a0568300921b0290517cd06302dso634079ott.13; Tue, 31 Aug 2021 13:21:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bU7TZOWBzRdHnk5u7KA0MFnjQQvgfnHsYudfpjDdkdg=; b=d1adeLv5n8KlCimMOYypTBkFYf75iodMTNCKrJP5C7lfJ+O1vVqsS6fUVe1DnE45dv 3KSLWpr4bD7XWNaa5R18D18T24mzPmZiDeEE+0EsMEq5DG/WOy3wGuB7bVQd3a7fBDFZ ke6D2L5u9EIgC/EkqR+B5bLgsgFvJevwPhe3FGlVFk5C+3PvpLddEwSUzegkkqwiaHhJ rmB6Gkl6ZVlr6g5mHVSjIA8ZTckavdA3GpHlJgNgH40OwKrnCsvXIwW4/wTT+1FmHdiz frRgugX9/PfZsYEnd+vxTPlhYY+dKewQl7bV6UX6+t4K3dApxN1JQiKmp08V4nd8e7+7 ouVw== X-Gm-Message-State: AOAM531dvbwDdGrBMh5t0uZMjxXx5bAkF3Nme7zb6RUuHYM+hPm5bhBz bjuC6q63TkSlK2aYnno4IA== X-Google-Smtp-Source: ABdhPJwpoOM3fs+y4Ud1Zp79FJet9tP6f4HQm/EXSCPIYe1ZMQSRol2az2XulvfPxUOZMrz2Whg0pw== X-Received: by 2002:a9d:894:: with SMTP id 20mr25702438otf.262.1630441295709; Tue, 31 Aug 2021 13:21:35 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id c10sm4259279ots.48.2021.08.31.13.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 13:21:34 -0700 (PDT) Received: (nullmailer pid 588777 invoked by uid 1000); Tue, 31 Aug 2021 20:21:33 -0000 Date: Tue, 31 Aug 2021 15:21:33 -0500 From: Rob Herring To: Sameer Pujar Cc: broonie@kernel.org, lgirdwood@gmail.com, thierry.reding@gmail.com, jonathanh@nvidia.com, catalin.marinas@arm.com, will@kernel.org, perex@perex.cz, tiwai@suse.com, kuninori.morimoto.gx@renesas.com, sharadg@nvidia.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 04/13] ASoC: dt-bindings: tegra: Few more Tegra210 AHUB modules Message-ID: References: <1630056839-6562-1-git-send-email-spujar@nvidia.com> <1630056839-6562-5-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1630056839-6562-5-git-send-email-spujar@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Fri, Aug 27, 2021 at 03:03:50PM +0530, Sameer Pujar wrote: > This patch adds YAML schema for DT bindings of few AHUB modules. > These devices will be registered as ASoC components and bindings > will be used on Tegra210 and later chips. The bindings for below > mentioned modules are added: > > * SFC (Sampling Frequency Converter) > * MVC (Master Volume Control) > * AMX (Audio Multiplexer) > * ADX (Audio Demultiplexer) > * Mixer > > Signed-off-by: Sameer Pujar > Cc: Rob Herring > --- > .../bindings/sound/nvidia,tegra210-adx.yaml | 74 ++++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-ahub.yaml | 20 ++++++ > .../bindings/sound/nvidia,tegra210-amx.yaml | 72 ++++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-mixer.yaml | 67 ++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-mvc.yaml | 79 ++++++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-sfc.yaml | 76 +++++++++++++++++++++ > 6 files changed, 388 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml > > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml > new file mode 100644 > index 0000000..9950585 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-adx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 ADX Device Tree Bindings > + > +description: | > + The Audio Demultiplexer (ADX) block takes an input stream with up to extra spaces. > + 16 channels and demultiplexes it into four output streams of up to 16 > + channels each. A byte RAM helps to form output frames by any combination > + of bytes from the input frame. Its design is identical to that of byte > + RAM in the AMX except that the data flow direction is reversed. > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^adx@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-adx > + - items: > + - enum: > + - nvidia,tegra194-adx > + - nvidia,tegra186-adx > + - const: nvidia,tegra210-adx > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: nvidia,sound-name-prefix > + pattern: "^ADX[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "ADX1" or "ADX2" ... "ADXx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + ADX has one input and four output. Accordingly ACIF (Audio Client You need to define the port numbers for the input and each output. > + Interface) RX and TX port nodes are defined to represent ADX inputs > + and output respectively. These are connected to corresponding ports > + on AHUB. > + > + patternProperties: > + '^port@[0-9]': Per above, this will need to be split at least into input and output ports. Same issues in the other schemas. > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + adx@702d3800 { > + compatible = "nvidia,tegra210-adx"; > + reg = <0x702d3800 0x100>; > + sound-name-prefix = "ADX1"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > index 1118a94..4087eeb 100644 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > @@ -85,6 +85,26 @@ patternProperties: > type: object > $ref: nvidia,tegra186-dspk.yaml# > > + '^mvc@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-mvc.yaml# > + > + '^sfc@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-sfc.yaml# > + > + '^amx@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-amx.yaml# > + > + '^adx@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-adx.yaml# > + > + '^mixer@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-mixer.yaml# > + > required: > - compatible > - reg > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml > new file mode 100644 > index 0000000..e6b365b > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-amx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 AMX Device Tree Bindings > + > +description: | > + The Audio Multiplexer (AMX) block can multiplex up to four input streams > + each of which can have maximum 16 channels and generate an output stream > + with maximum 16 channels. A byte RAM helps to form an output frame by > + any combination of bytes from the input frames. > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^amx@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-amx > + - items: > + - const: nvidia,tegra186-amx > + - const: nvidia,tegra210-amx > + - const: nvidia,tegra194-amx > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + pattern: "^AMX[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "AMX1" or "AMX2" ... "AMXx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + AMX has four inputs and one output. Accordingly ACIF (Audio Client > + Interfaces) RX and TX port nodes are defined to represent AMX inputs > + and output respectively. These are connected to corresponding ports > + on AHUB. > + > + patternProperties: > + '^port@[0-9]': > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + amx@702d3000 { > + compatible = "nvidia,tegra210-amx"; > + reg = <0x702d3000 0x100>; > + sound-name-prefix = "AMX1"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml > new file mode 100644 > index 0000000..0808355 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-mixer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 Mixer Device Tree Bindings > + > +description: | > + The Mixer supports mixing of up to ten 7.1 audio input streams and > + generate five outputs (each of which can be any combination of the > + ten input streams). > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^mixer@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-amixer > + - items: > + - enum: > + - nvidia,tegra194-amixer > + - nvidia,tegra186-amixer > + - const: nvidia,tegra210-amixer > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + const: "MIXER" Don't need quotes. A fixed string seems a bit pointless to put into DT. > + $ref: /schemas/types.yaml#/definitions/string > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + Mixer has ten inputs and five outputs. Accordingly ACIF (Audio Client > + Interfaces) RX and TX port nodes are defined to represent MIXER inputs > + and outputs respectively. These are connected to corresponding ports > + on AHUB. > + > + patternProperties: > + '^port@[0-9]': > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + mixer@702dbb00 { > + compatible = "nvidia,tegra210-amixer"; > + reg = <0x702dbb00 0x800>; > + sound-name-prefix = "MIXER"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml > new file mode 100644 > index 0000000..7d81b11 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-mvc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 MVC Device Tree Bindings > + > +description: | > + The Master Volume Control (MVC) provides gain or attenuation to a digital > + signal path. It can be used in input or output signal path for per-stream > + volume control or it can be used as master volume control. The MVC block > + has one input and one output. The input digital stream can be mono or > + multi-channel (up to 7.1 channels) stream. An independent mute control is > + also included in the MVC block. > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^mvc@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-mvc > + - items: > + - enum: > + - nvidia,tegra194-mvc > + - nvidia,tegra186-mvc > + - const: nvidia,tegra210-mvc > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + pattern: "^MVC[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "MVC1" or "MVC2" ... "MVCx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + properties: > + port@0: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as MVC input (RX) port. > + This is connected to corresponding ACIF port on AHUB. > + > + port@1: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as MVC output (TX) port. > + This is connected to corresponding ACIF port on AHUB. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + mvc@702da000 { > + compatible = "nvidia,tegra210-mvc"; > + reg = <0x702da000 0x200>; > + sound-name-prefix = "MVC1"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml > new file mode 100644 > index 0000000..5f05e2a > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-sfc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 SFC Device Tree Bindings > + > +description: | > + The Sampling Frequency Converter (SFC) converts the sampling frequency > + of the input signal from one frequency to another. It supports sampling > + frequency conversions of streams of up to two channels (stereo). > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^sfc@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-sfc > + - items: > + - enum: > + - nvidia,tegra194-sfc > + - nvidia,tegra186-sfc > + - const: nvidia,tegra210-sfc > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + pattern: "^SFC[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "SFC1" or "SFC2" ... "SFCx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + properties: > + port@0: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as SFC input (RX) port. > + This is connected to corresponding ACIF port on AHUB. > + > + port@1: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as SFC output (TX) port. > + This is connected to corresponding ACIF port on AHUB. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + sfc@702d2000 { > + compatible = "nvidia,tegra210-sfc"; > + reg = <0x702d2000 0x200>; > + sound-name-prefix = "SFC1"; > + }; > + > +... > -- > 2.7.4 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3350C432BE for ; Tue, 31 Aug 2021 20:26:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7430960F23 for ; Tue, 31 Aug 2021 20:26:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7430960F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F8Vrt74Hglo3K1Fh5MiFGn7DLfwx7LzPrD0nEjHlZ3U=; b=lV8tHdB8gI0qfp +On8sLasoq+ylzMkeHwAQeeLjR7MB3sIFesvnrK4Q+YMzvXq+1SPU5H6qgEHBl1pSZLwG/UfjVyL3 kZmbDOVJPqZRB5DDVfx/1kH6DkAQoUwRxDT+RwDcIlNYz90NppiX/YwwmiF7lex2SNUfUuqiq1BBj 0A3YGEKc41iFn/SvzbPrQHCfz7MLq0JUo/UzbekMEUAZL/UVavY65y6VOK5Odx8ZBSS6dIGZ53c2a r8Dm1WwviQyTZSSqv3+Ho/pftopXk2mo2YlA405Q3QBDT6CL2hqmGsCkQQ4LC/DE+1FgBGdutVxKb D/FolUzJYHJjangVPwzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLAGO-0036ib-8x; Tue, 31 Aug 2021 20:21:44 +0000 Received: from mail-ot1-f53.google.com ([209.85.210.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLAGH-0036hR-Um for linux-arm-kernel@lists.infradead.org; Tue, 31 Aug 2021 20:21:41 +0000 Received: by mail-ot1-f53.google.com with SMTP id i8-20020a056830402800b0051afc3e373aso699095ots.5 for ; Tue, 31 Aug 2021 13:21:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bU7TZOWBzRdHnk5u7KA0MFnjQQvgfnHsYudfpjDdkdg=; b=P0/KIjDbFLxfY4UwHG3F3ZtlhOVag1ByPPDykx+TvKzBlqak0CbRMsgQkCf+bko8sL k9mvvD4P3AE0XpTSk2vOlG5IzZCOrgAeWnE8fJESTr4EIn7QoIPf9otxyMsHYYJRX9rW EeHI+kqMKlgVIwx0hvAOgYMMrqjHBWXVYh0LbfldFK891V3dmcHZe4U+lLN/aQ62VgMv kHrxPMa5wEpghCIt5bt8aXenTHG7dSWY/3Kn6Q9hnWAI0fW04QBqyKfmzvvUXF5ucwLu TkQQiOhVW5EGHnmvyYvVYOSZ2xPUgraEXeaH8RHMjxdH7Wra6eCI2SSpAx+YzVftVcyA Sdvw== X-Gm-Message-State: AOAM533jK7KG+78CluyhFSqRmYMaYEd3T98cTAQGY3ntUBoKRiUwvYTx ZS2C0fQFDbKoig3egt/kPg== X-Google-Smtp-Source: ABdhPJwpoOM3fs+y4Ud1Zp79FJet9tP6f4HQm/EXSCPIYe1ZMQSRol2az2XulvfPxUOZMrz2Whg0pw== X-Received: by 2002:a9d:894:: with SMTP id 20mr25702438otf.262.1630441295709; Tue, 31 Aug 2021 13:21:35 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id c10sm4259279ots.48.2021.08.31.13.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 13:21:34 -0700 (PDT) Received: (nullmailer pid 588777 invoked by uid 1000); Tue, 31 Aug 2021 20:21:33 -0000 Date: Tue, 31 Aug 2021 15:21:33 -0500 From: Rob Herring To: Sameer Pujar Cc: broonie@kernel.org, lgirdwood@gmail.com, thierry.reding@gmail.com, jonathanh@nvidia.com, catalin.marinas@arm.com, will@kernel.org, perex@perex.cz, tiwai@suse.com, kuninori.morimoto.gx@renesas.com, sharadg@nvidia.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 04/13] ASoC: dt-bindings: tegra: Few more Tegra210 AHUB modules Message-ID: References: <1630056839-6562-1-git-send-email-spujar@nvidia.com> <1630056839-6562-5-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1630056839-6562-5-git-send-email-spujar@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210831_132138_062195_384D3EDE X-CRM114-Status: GOOD ( 32.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 27, 2021 at 03:03:50PM +0530, Sameer Pujar wrote: > This patch adds YAML schema for DT bindings of few AHUB modules. > These devices will be registered as ASoC components and bindings > will be used on Tegra210 and later chips. The bindings for below > mentioned modules are added: > > * SFC (Sampling Frequency Converter) > * MVC (Master Volume Control) > * AMX (Audio Multiplexer) > * ADX (Audio Demultiplexer) > * Mixer > > Signed-off-by: Sameer Pujar > Cc: Rob Herring > --- > .../bindings/sound/nvidia,tegra210-adx.yaml | 74 ++++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-ahub.yaml | 20 ++++++ > .../bindings/sound/nvidia,tegra210-amx.yaml | 72 ++++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-mixer.yaml | 67 ++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-mvc.yaml | 79 ++++++++++++++++++++++ > .../bindings/sound/nvidia,tegra210-sfc.yaml | 76 +++++++++++++++++++++ > 6 files changed, 388 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml > create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml > > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml > new file mode 100644 > index 0000000..9950585 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-adx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 ADX Device Tree Bindings > + > +description: | > + The Audio Demultiplexer (ADX) block takes an input stream with up to extra spaces. > + 16 channels and demultiplexes it into four output streams of up to 16 > + channels each. A byte RAM helps to form output frames by any combination > + of bytes from the input frame. Its design is identical to that of byte > + RAM in the AMX except that the data flow direction is reversed. > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^adx@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-adx > + - items: > + - enum: > + - nvidia,tegra194-adx > + - nvidia,tegra186-adx > + - const: nvidia,tegra210-adx > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: nvidia,sound-name-prefix > + pattern: "^ADX[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "ADX1" or "ADX2" ... "ADXx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + ADX has one input and four output. Accordingly ACIF (Audio Client You need to define the port numbers for the input and each output. > + Interface) RX and TX port nodes are defined to represent ADX inputs > + and output respectively. These are connected to corresponding ports > + on AHUB. > + > + patternProperties: > + '^port@[0-9]': Per above, this will need to be split at least into input and output ports. Same issues in the other schemas. > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + adx@702d3800 { > + compatible = "nvidia,tegra210-adx"; > + reg = <0x702d3800 0x100>; > + sound-name-prefix = "ADX1"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > index 1118a94..4087eeb 100644 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > @@ -85,6 +85,26 @@ patternProperties: > type: object > $ref: nvidia,tegra186-dspk.yaml# > > + '^mvc@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-mvc.yaml# > + > + '^sfc@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-sfc.yaml# > + > + '^amx@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-amx.yaml# > + > + '^adx@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-adx.yaml# > + > + '^mixer@[0-9a-f]+$': > + type: object > + $ref: nvidia,tegra210-mixer.yaml# > + > required: > - compatible > - reg > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml > new file mode 100644 > index 0000000..e6b365b > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-amx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 AMX Device Tree Bindings > + > +description: | > + The Audio Multiplexer (AMX) block can multiplex up to four input streams > + each of which can have maximum 16 channels and generate an output stream > + with maximum 16 channels. A byte RAM helps to form an output frame by > + any combination of bytes from the input frames. > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^amx@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-amx > + - items: > + - const: nvidia,tegra186-amx > + - const: nvidia,tegra210-amx > + - const: nvidia,tegra194-amx > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + pattern: "^AMX[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "AMX1" or "AMX2" ... "AMXx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + AMX has four inputs and one output. Accordingly ACIF (Audio Client > + Interfaces) RX and TX port nodes are defined to represent AMX inputs > + and output respectively. These are connected to corresponding ports > + on AHUB. > + > + patternProperties: > + '^port@[0-9]': > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + amx@702d3000 { > + compatible = "nvidia,tegra210-amx"; > + reg = <0x702d3000 0x100>; > + sound-name-prefix = "AMX1"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml > new file mode 100644 > index 0000000..0808355 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-mixer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 Mixer Device Tree Bindings > + > +description: | > + The Mixer supports mixing of up to ten 7.1 audio input streams and > + generate five outputs (each of which can be any combination of the > + ten input streams). > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^mixer@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-amixer > + - items: > + - enum: > + - nvidia,tegra194-amixer > + - nvidia,tegra186-amixer > + - const: nvidia,tegra210-amixer > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + const: "MIXER" Don't need quotes. A fixed string seems a bit pointless to put into DT. > + $ref: /schemas/types.yaml#/definitions/string > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + Mixer has ten inputs and five outputs. Accordingly ACIF (Audio Client > + Interfaces) RX and TX port nodes are defined to represent MIXER inputs > + and outputs respectively. These are connected to corresponding ports > + on AHUB. > + > + patternProperties: > + '^port@[0-9]': > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + mixer@702dbb00 { > + compatible = "nvidia,tegra210-amixer"; > + reg = <0x702dbb00 0x800>; > + sound-name-prefix = "MIXER"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml > new file mode 100644 > index 0000000..7d81b11 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-mvc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 MVC Device Tree Bindings > + > +description: | > + The Master Volume Control (MVC) provides gain or attenuation to a digital > + signal path. It can be used in input or output signal path for per-stream > + volume control or it can be used as master volume control. The MVC block > + has one input and one output. The input digital stream can be mono or > + multi-channel (up to 7.1 channels) stream. An independent mute control is > + also included in the MVC block. > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^mvc@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-mvc > + - items: > + - enum: > + - nvidia,tegra194-mvc > + - nvidia,tegra186-mvc > + - const: nvidia,tegra210-mvc > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + pattern: "^MVC[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "MVC1" or "MVC2" ... "MVCx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + properties: > + port@0: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as MVC input (RX) port. > + This is connected to corresponding ACIF port on AHUB. > + > + port@1: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as MVC output (TX) port. > + This is connected to corresponding ACIF port on AHUB. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + mvc@702da000 { > + compatible = "nvidia,tegra210-mvc"; > + reg = <0x702da000 0x200>; > + sound-name-prefix = "MVC1"; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml > new file mode 100644 > index 0000000..5f05e2a > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-sfc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tegra210 SFC Device Tree Bindings > + > +description: | > + The Sampling Frequency Converter (SFC) converts the sampling frequency > + of the input signal from one frequency to another. It supports sampling > + frequency conversions of streams of up to two channels (stereo). > + > +maintainers: > + - Jon Hunter > + - Mohan Kumar > + - Sameer Pujar > + > +properties: > + $nodename: > + pattern: "^sfc@[0-9a-f]*$" > + > + compatible: > + oneOf: > + - const: nvidia,tegra210-sfc > + - items: > + - enum: > + - nvidia,tegra194-sfc > + - nvidia,tegra186-sfc > + - const: nvidia,tegra210-sfc > + > + reg: > + maxItems: 1 > + > + sound-name-prefix: > + pattern: "^SFC[1-9]$" > + $ref: /schemas/types.yaml#/definitions/string > + description: > + used as prefix for sink/source names of the component. Must be a > + unique string among multiple instances of the same component. > + The name can be "SFC1" or "SFC2" ... "SFCx", where x depends on > + the maximum available instances on a Tegra SoC. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + properties: > + port@0: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as SFC input (RX) port. > + This is connected to corresponding ACIF port on AHUB. > + > + port@1: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + description: | > + ACIF (Audio Client Interface) acting as SFC output (TX) port. > + This is connected to corresponding ACIF port on AHUB. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + sfc@702d2000 { > + compatible = "nvidia,tegra210-sfc"; > + reg = <0x702d2000 0x200>; > + sound-name-prefix = "SFC1"; > + }; > + > +... > -- > 2.7.4 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel