All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Bin Meng <bmeng.cn@gmail.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] softmmu/physmem: Improve guest memory allocation failure error message
Date: Fri, 20 Aug 2021 16:31:43 -0400	[thread overview]
Message-ID: <YSARLwcmNZ4vgjB1@t490s> (raw)
In-Reply-To: <20210820155211.3153137-1-philmd@redhat.com>

On Fri, Aug 20, 2021 at 05:52:11PM +0200, Philippe Mathieu-Daudé wrote:
> When Linux refuses to overcommit a seriously wild allocation we get:
> 
>   $ qemu-system-i386 -m 40000000
>   qemu-system-i386: cannot set up guest memory 'pc.ram': Cannot allocate memory
> 
> Slighly improve the error message, displaying the memory size
> requested (in case the user didn't expect unspecified memory size
> unit is in MiB):
> 
>   $ qemu-system-i386 -m 40000000
>   qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram': Cannot allocate memory
> 
> Reported-by: Bin Meng <bmeng.cn@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu



  parent reply	other threads:[~2021-08-20 20:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 15:52 [PATCH] softmmu/physmem: Improve guest memory allocation failure error message Philippe Mathieu-Daudé
2021-08-20 15:53 ` David Hildenbrand
2021-08-20 16:00   ` Philippe Mathieu-Daudé
2021-08-20 16:40     ` Igor Mammedov
2021-08-20 16:59       ` Philippe Mathieu-Daudé
2021-08-20 17:13         ` Peter Maydell
2021-08-23  8:38     ` David Hildenbrand
2021-08-23  9:23       ` Peter Maydell
2021-08-23  9:29         ` David Hildenbrand
2021-08-23 10:12           ` Philippe Mathieu-Daudé
2021-08-23 10:24             ` David Hildenbrand
2021-08-23 10:34               ` Philippe Mathieu-Daudé
2021-08-23 19:27                 ` David Hildenbrand
2021-08-24  8:37                   ` Dr. David Alan Gilbert
2021-08-24  8:53                     ` David Hildenbrand
2021-08-24 11:42                     ` Igor Mammedov
2021-08-20 20:31 ` Peter Xu [this message]
2021-08-21 10:01 ` Bin Meng
2021-08-21 10:41   ` Peter Maydell
2021-08-21 13:32   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSARLwcmNZ4vgjB1@t490s \
    --to=peterx@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=david@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.