From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Emily Shaffer <emilyshaffer@google.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] make: add INSTALL_STRIP variable
Date: Sat, 21 Aug 2021 17:35:24 +0700 [thread overview]
Message-ID: <YSDW3nsG2iWPGakF@danh.dev> (raw)
In-Reply-To: <70e609f5-bf40-658a-a021-ab7a0ad4baa1@gmail.com>
On 2021-08-21 15:24:22+0700, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> On 20/08/21 18.36, Đoàn Trần Công Danh wrote:
> > I believe it's better to write like this:
> >
> > ----- 8< ------
> > ifdef INSTALL_STRIP
> > install: strip
> > endif
> >
> > install: all
> > ....
> > ---- >8-------
> >
> > IOW, install depends on strip, not install invoke strip.
>
> Oh, I missed that.
>
> > I think it would work better for:
> >
> > make install strip
> >
>
> Wouldn't it install unstripped binaries to the prefix then stripping them in
> the build directory?
No, with:
install: strip
strip is one of install's dependencies, then strip will be executed
before install.
--
Danh
prev parent reply other threads:[~2021-08-21 10:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 10:50 [PATCH] make: add INSTALL_STRIP variable Bagas Sanjaya
2021-08-20 11:36 ` Đoàn Trần Công Danh
2021-08-20 18:16 ` Junio C Hamano
2021-08-21 2:13 ` Đoàn Trần Công Danh
2021-08-23 15:55 ` Junio C Hamano
2021-08-24 9:39 ` Bagas Sanjaya
2021-08-24 9:49 ` Johannes Schindelin
2021-08-24 18:58 ` Junio C Hamano
2021-08-21 8:24 ` Bagas Sanjaya
2021-08-21 10:35 ` Đoàn Trần Công Danh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSDW3nsG2iWPGakF@danh.dev \
--to=congdanhqx@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=bagasdotme@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.