From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D2B9C4338F for ; Mon, 23 Aug 2021 10:17:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6DC361248 for ; Mon, 23 Aug 2021 10:17:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6DC361248 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rKuPC/J8okwYWIxJpLMPw9m/EWVG+0apLPSMR3IphKc=; b=UwyZTLvbt01aJZ 46Qb+7IjiC6Qg3vgLlDNJ0YH4cBgGQJuNUPe44MWLreNmNxrrbY+ZPTKkEcYYlMAb00ERd77X/k65 Fk4jWco/zoshSUMz1YHvJOONtR2eqW1Jdt6R1p/eA4+pv49rmAufnQXxk4CfMMHydKd+oTfuMrGRq jTVHqUQIXH4m9OzXktBLl+9eYmLpFpeblF6Oee4jB1KJGuIRmpOSmrzv/X6saAiH/mBhXNexd0vM8 lvPpuWLNA2O0qZz1rZAIodp68pH6ef6hMGiF9H/JvbbZxLqEVpm7TneVJTCBbuK34vbGJCbTEn0Mp +p6jtsGUE/pgxmKBQtPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mI70v-00GJbx-SU; Mon, 23 Aug 2021 10:17:09 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mI70f-00GJVv-Cy for linux-mediatek@lists.infradead.org; Mon, 23 Aug 2021 10:16:54 +0000 Received: by mail-pf1-x432.google.com with SMTP id 18so14933519pfh.9 for ; Mon, 23 Aug 2021 03:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9sK/RO+vAHWLBWoM3ZyA29r4bWb/1hcnS47SNH5khGc=; b=wQBC/gwt1+LStQC2ASYvn+IHLUg1RkDC7LLqbN852KwAQDHhT7TvSognZ5nzBxFR8Y f0+WCGa4TsHPsSI+esH7OPVRGqU+gOqsgyi1cGgx7DgMOZEfpQFzmsCpo9clJte0DI0J D46kyX45RpcOK6WNk0hwAQht6Z5+xpZ3dti1KfOfkQMdru5v7J7VFz16cmeTisU8/xXQ QtE0Wp0V3ZTjmQjs8NosQQrxYcGkKaCBgniW6eKWE5bHk5T0uKP6qpVX2QKuNtHzjWmz 800yWoY4Rb0KzL6mX1yGLo0lMU7DQKPDGylyPd84FsF1ar8fBlPeeeF5JHq039hw5qtJ BXhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9sK/RO+vAHWLBWoM3ZyA29r4bWb/1hcnS47SNH5khGc=; b=S93HSVLncPZmmgRPT1ESTxB811x4W/hVQhmZNJRPlvk3DikY1XYr+VaWYJ+n5XYPKv zuQ9MfzamGubkLYmtdH990PiVQfx4w5A8jiAq0NsBGmKIdgoLoRPVMkcLTESe3nvGUEC qoz8nHIElDNLvasgoRsJD3IaJG+DZY9gGmO313c1GWqB2If+3IQcf3gFvQiJGFQkL8n8 zWYcRGwZSUrRjTcijwLaCE5UTkWMb30wkM6CMGnIxzd1v5q/jP5TiH6sM6oLfagGFBwl k6ZN8KUUwKQZUsC8+mPxIFfRklUwjWTSn/oz2mRo2+sa1TT1DKrda7vOA1iVQJG4mIu+ Jotw== X-Gm-Message-State: AOAM533xWgJvKziUHwBXcr0lYbR8d7sjqJvm1Ot7F3qDhESlkbOjP0X/ V/3M9BwciFgPmVckMgrxEU+Atw== X-Google-Smtp-Source: ABdhPJyRWj7JJ3uSCqHFjtFJri25dJ4A+gm2UzaZ6kNWYFkB1lyGxchigxCWWxBH8xmZnrvu7go3+g== X-Received: by 2002:a63:5f88:: with SMTP id t130mr31596784pgb.6.1629713812275; Mon, 23 Aug 2021 03:16:52 -0700 (PDT) Received: from google.com ([2401:fa00:1:10:bc5a:af6a:3f08:a084]) by smtp.gmail.com with ESMTPSA id x42sm15258542pfh.205.2021.08.23.03.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 03:16:51 -0700 (PDT) Date: Mon, 23 Aug 2021 18:16:47 +0800 From: Tzung-Bi Shih To: Irui Wang Cc: Hans Verkuil , Tzung-Bi Shih , Alexandre Courbot , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Yong Wu , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yunfei Dong , Fritz Koenig , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH 3/9] media: mtk-vcodec: Rewrite venc power manage interface Message-ID: References: <20210816105934.28265-1-irui.wang@mediatek.com> <20210816105934.28265-4-irui.wang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210816105934.28265-4-irui.wang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210823_031653_474154_8346DEB4 X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Aug 16, 2021 at 06:59:28PM +0800, Irui Wang wrote: > @@ -105,6 +106,14 @@ static int mtk_venc_comp_probe(struct platform_device *pdev) > > comp_dev->plat_dev = pdev; > > + ret = mtk_vcodec_init_enc_pm(pdev, &comp_dev->pm); > + if (ret < 0) { > + dev_err(&pdev->dev, "Failed to get venc component clock source!"); > + return ret; > + } > + > + pm_runtime_enable(&pdev->dev); mtk_vcodec_init_enc_pm() and mtk_vcodec_release_enc_pm() is more like a pair. Does it make more sense to call pm_runtime_enable() in mtk_vcodec_init_enc_pm()? _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17079C4338F for ; Mon, 23 Aug 2021 10:18:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9B6C6115A for ; Mon, 23 Aug 2021 10:18:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D9B6C6115A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6ekHzFnJIUmr5tLSXRUkx1K2BSs9Bs4ju6ZPTJYy/H0=; b=R/hHWqT0X7kENu WsU5yZZuZbkAxEymieC7RdNKEE5+dylC/+X/p7KcYGANh5+KxDlm7QNnZZIQbNCcEq8X9/4W7srHr SOANvAe1kbJ2GRuZlbxNnFhNTUD1RtSBhmhv+4bQ33tbWmiArF+jq04lHykOsuvYU+DHUMEwNcqH4 rNJjBsBY4oAonPnPuoE3/AGiCQEjskqxQ2QkY8ydg2e/ItwhBWABLEBW2B+QphSuxM6z0goCbMc6K K+TbbhCD7grdK6U85Z2nchKdqMddl11ip+GrfVbN58cPegKyiD5Yeae0OtudQcON7N9S/Pvy1yWlC ufCwFUs8HqTrortffmRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mI70j-00GJXz-Ky; Mon, 23 Aug 2021 10:16:57 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mI70f-00GJVw-60 for linux-arm-kernel@lists.infradead.org; Mon, 23 Aug 2021 10:16:54 +0000 Received: by mail-pg1-x529.google.com with SMTP id y23so16220443pgi.7 for ; Mon, 23 Aug 2021 03:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9sK/RO+vAHWLBWoM3ZyA29r4bWb/1hcnS47SNH5khGc=; b=wQBC/gwt1+LStQC2ASYvn+IHLUg1RkDC7LLqbN852KwAQDHhT7TvSognZ5nzBxFR8Y f0+WCGa4TsHPsSI+esH7OPVRGqU+gOqsgyi1cGgx7DgMOZEfpQFzmsCpo9clJte0DI0J D46kyX45RpcOK6WNk0hwAQht6Z5+xpZ3dti1KfOfkQMdru5v7J7VFz16cmeTisU8/xXQ QtE0Wp0V3ZTjmQjs8NosQQrxYcGkKaCBgniW6eKWE5bHk5T0uKP6qpVX2QKuNtHzjWmz 800yWoY4Rb0KzL6mX1yGLo0lMU7DQKPDGylyPd84FsF1ar8fBlPeeeF5JHq039hw5qtJ BXhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9sK/RO+vAHWLBWoM3ZyA29r4bWb/1hcnS47SNH5khGc=; b=mQkIKBzlOIm6zS3FzuA3mVrPAYDAUukIiNqF9hkvqofmwXO1Dyq8EXgMxrWvEjIbxO n+kSBinSPwWJt5fZcL7qkUz/wJWuavgUsQWt5ERXbHAS/PTavTCKL1KLjtjw4vWVEvyp lVpEOBO8+jTvG8vSb4YRhSAkrULdjZUly1z97/qjVU3ydtDpoGvBklKjLriAGrubIL3I jn86/iVwzjyUCzXhNXC4hwyOeAfSIFhqPfWLAsd3Wy7nIEvcR0Zd2G5oHp+qIZC5//6j 8Zcskt51sVJt4C+PcMxxKAX22HRuh3QD885X07dQypRT3s0RMzXeHcfGUgQxH2CE1z3z zqwg== X-Gm-Message-State: AOAM5331IG/8ijLOYuC9RqiKrAu5ki9j5fqNRjkxwuYnpyexry5AG0Xd PNZo0n2ms+P2yBkLjhCxGbug5A== X-Google-Smtp-Source: ABdhPJyRWj7JJ3uSCqHFjtFJri25dJ4A+gm2UzaZ6kNWYFkB1lyGxchigxCWWxBH8xmZnrvu7go3+g== X-Received: by 2002:a63:5f88:: with SMTP id t130mr31596784pgb.6.1629713812275; Mon, 23 Aug 2021 03:16:52 -0700 (PDT) Received: from google.com ([2401:fa00:1:10:bc5a:af6a:3f08:a084]) by smtp.gmail.com with ESMTPSA id x42sm15258542pfh.205.2021.08.23.03.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 03:16:51 -0700 (PDT) Date: Mon, 23 Aug 2021 18:16:47 +0800 From: Tzung-Bi Shih To: Irui Wang Cc: Hans Verkuil , Tzung-Bi Shih , Alexandre Courbot , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Yong Wu , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yunfei Dong , Fritz Koenig , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH 3/9] media: mtk-vcodec: Rewrite venc power manage interface Message-ID: References: <20210816105934.28265-1-irui.wang@mediatek.com> <20210816105934.28265-4-irui.wang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210816105934.28265-4-irui.wang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210823_031653_301923_D0152987 X-CRM114-Status: GOOD ( 13.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 16, 2021 at 06:59:28PM +0800, Irui Wang wrote: > @@ -105,6 +106,14 @@ static int mtk_venc_comp_probe(struct platform_device *pdev) > > comp_dev->plat_dev = pdev; > > + ret = mtk_vcodec_init_enc_pm(pdev, &comp_dev->pm); > + if (ret < 0) { > + dev_err(&pdev->dev, "Failed to get venc component clock source!"); > + return ret; > + } > + > + pm_runtime_enable(&pdev->dev); mtk_vcodec_init_enc_pm() and mtk_vcodec_release_enc_pm() is more like a pair. Does it make more sense to call pm_runtime_enable() in mtk_vcodec_init_enc_pm()? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3908C4338F for ; Mon, 23 Aug 2021 10:16:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B588061246 for ; Mon, 23 Aug 2021 10:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236075AbhHWKRf (ORCPT ); Mon, 23 Aug 2021 06:17:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236019AbhHWKRf (ORCPT ); Mon, 23 Aug 2021 06:17:35 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D1A2C061757 for ; Mon, 23 Aug 2021 03:16:53 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id g14so14925364pfm.1 for ; Mon, 23 Aug 2021 03:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9sK/RO+vAHWLBWoM3ZyA29r4bWb/1hcnS47SNH5khGc=; b=wQBC/gwt1+LStQC2ASYvn+IHLUg1RkDC7LLqbN852KwAQDHhT7TvSognZ5nzBxFR8Y f0+WCGa4TsHPsSI+esH7OPVRGqU+gOqsgyi1cGgx7DgMOZEfpQFzmsCpo9clJte0DI0J D46kyX45RpcOK6WNk0hwAQht6Z5+xpZ3dti1KfOfkQMdru5v7J7VFz16cmeTisU8/xXQ QtE0Wp0V3ZTjmQjs8NosQQrxYcGkKaCBgniW6eKWE5bHk5T0uKP6qpVX2QKuNtHzjWmz 800yWoY4Rb0KzL6mX1yGLo0lMU7DQKPDGylyPd84FsF1ar8fBlPeeeF5JHq039hw5qtJ BXhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9sK/RO+vAHWLBWoM3ZyA29r4bWb/1hcnS47SNH5khGc=; b=XZNyYJguh+gKke7oEh2LTYt6yp4qEUFFmo87Qi3zriqS5uF/zTtM3IcmSt1eoUj/aj Rdz6ANLmWrBA5th+nvqf4/wNYmqm7SjeTZCh6kKHbTFPttMt7hba3X+3gUMGkH5W9Wd1 KZfrEO6fp/gSoPTkaoYMouv1cRsAOVnJlYR/fVNZ+ZoYHdyt7WtVQSZ7Zxqv2o6oRvXl EhXrtzEO5qSKkdr2K6y71TK9iT+RxfQTgeyqlpFPyiT2E+tBBDvKj4g1PGBYKpNQDXDz dITqDwQKmIqJwZjVuKvMuYL1ARKkiFqDERmeuby5vIIyj9962JxjG1/gVNhdC6aUe3Eu vLig== X-Gm-Message-State: AOAM530wzFiuMBeXz4v3v3UyNwhE/IV0MR1VoGVjL+iA+iOrjOD+RhDv umCKcMLFCiIyVi+WL5MQkNX94A== X-Google-Smtp-Source: ABdhPJyRWj7JJ3uSCqHFjtFJri25dJ4A+gm2UzaZ6kNWYFkB1lyGxchigxCWWxBH8xmZnrvu7go3+g== X-Received: by 2002:a63:5f88:: with SMTP id t130mr31596784pgb.6.1629713812275; Mon, 23 Aug 2021 03:16:52 -0700 (PDT) Received: from google.com ([2401:fa00:1:10:bc5a:af6a:3f08:a084]) by smtp.gmail.com with ESMTPSA id x42sm15258542pfh.205.2021.08.23.03.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 03:16:51 -0700 (PDT) Date: Mon, 23 Aug 2021 18:16:47 +0800 From: Tzung-Bi Shih To: Irui Wang Cc: Hans Verkuil , Tzung-Bi Shih , Alexandre Courbot , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Yong Wu , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yunfei Dong , Fritz Koenig , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH 3/9] media: mtk-vcodec: Rewrite venc power manage interface Message-ID: References: <20210816105934.28265-1-irui.wang@mediatek.com> <20210816105934.28265-4-irui.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210816105934.28265-4-irui.wang@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Aug 16, 2021 at 06:59:28PM +0800, Irui Wang wrote: > @@ -105,6 +106,14 @@ static int mtk_venc_comp_probe(struct platform_device *pdev) > > comp_dev->plat_dev = pdev; > > + ret = mtk_vcodec_init_enc_pm(pdev, &comp_dev->pm); > + if (ret < 0) { > + dev_err(&pdev->dev, "Failed to get venc component clock source!"); > + return ret; > + } > + > + pm_runtime_enable(&pdev->dev); mtk_vcodec_init_enc_pm() and mtk_vcodec_release_enc_pm() is more like a pair. Does it make more sense to call pm_runtime_enable() in mtk_vcodec_init_enc_pm()?