From: Heiko Carstens <hca@linux.ibm.com>
To: CGEL <cgel.zte@gmail.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
jing yangyang <jing.yangyang@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] s390:raw3270: Convert sysfs sprintf/snprintf family to sysfs_emit
Date: Mon, 23 Aug 2021 19:37:57 +0200 [thread overview]
Message-ID: <YSPc9Yqn3xsioLwU@osiris> (raw)
In-Reply-To: <20210821035358.28350-1-jing.yangyang@zte.com.cn>
On Fri, Aug 20, 2021 at 08:53:58PM -0700, CGEL wrote:
> From: jing yangyang <jing.yangyang@zte.com.cn>
>
> Fix the following coccicheck warning:
> ./drivers/s390/char/raw3270.c:1066:8-16: WARNING: use scnprintf or sprintf
> ./drivers/s390/char/raw3270.c:1050:8-16: WARNING:use scnprintf or sprintf
> ./drivers/s390/char/raw3270.c:1058:8-16: WARNING:use scnprintf or sprintf
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
...
> static ssize_t
> raw3270_model_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> - return snprintf(buf, PAGE_SIZE, "%i\n",
> + return sysfs_emit(buf, "%i\n",
> ((struct raw3270 *) dev_get_drvdata(dev))->model);
Identation of the line following the patched line is now incorrect.
Also the sign-off chain is not correct - I also doubt that "CGEL" is a
person, but what do I know.
Not applied.
next prev parent reply other threads:[~2021-08-23 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 3:53 [PATCH linux-next] s390:raw3270: Convert sysfs sprintf/snprintf family to sysfs_emit CGEL
2021-08-23 17:37 ` Heiko Carstens [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-25 6:45 CGEL
2021-08-25 8:31 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSPc9Yqn3xsioLwU@osiris \
--to=hca@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cgel.zte@gmail.com \
--cc=gor@linux.ibm.com \
--cc=jing.yangyang@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=vneethv@linux.ibm.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.