From: Rob Herring <robh@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
frowand.list@gmail.com, robh+dt@kernel.org,
kernel-team@android.com
Subject: Re: [PATCH] of: Don't allow __of_attached_node_sysfs() without CONFIG_SYSFS
Date: Mon, 23 Aug 2021 13:48:58 -0500 [thread overview]
Message-ID: <YSPtmp1eyQdSKITz@robh.at.kernel.org> (raw)
In-Reply-To: <20210820144722.169226-1-maz@kernel.org>
On Fri, 20 Aug 2021 15:47:22 +0100, Marc Zyngier wrote:
> Trying to boot without SYSFS, but with OF_DYNAMIC quickly
> results in a crash:
>
> [ 0.088460] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000070
> [...]
> [ 0.103927] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 5.14.0-rc3 #4179
> [ 0.105810] Hardware name: linux,dummy-virt (DT)
> [ 0.107147] pstate: 80000005 (Nzcv daif -PAN -UAO -TCO BTYPE=--)
> [ 0.108876] pc : kernfs_find_and_get_ns+0x3c/0x7c
> [ 0.110244] lr : kernfs_find_and_get_ns+0x3c/0x7c
> [...]
> [ 0.134087] Call trace:
> [ 0.134800] kernfs_find_and_get_ns+0x3c/0x7c
> [ 0.136054] safe_name+0x4c/0xd0
> [ 0.136994] __of_attach_node_sysfs+0xf8/0x124
> [ 0.138287] of_core_init+0x90/0xfc
> [ 0.139296] driver_init+0x30/0x4c
> [ 0.140283] kernel_init_freeable+0x160/0x1b8
> [ 0.141543] kernel_init+0x30/0x140
> [ 0.142561] ret_from_fork+0x10/0x18
>
> While not having sysfs isn't a very common option these days,
> it is still expected that such configuration would work.
>
> Paper over it by bailing out from __of_attach_node_sysfs() if
> CONFIG_SYSFS isn't enabled.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> drivers/of/kobj.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
prev parent reply other threads:[~2021-08-23 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 14:47 [PATCH] of: Don't allow __of_attached_node_sysfs() without CONFIG_SYSFS Marc Zyngier
2021-08-23 4:01 ` Frank Rowand
2021-08-23 8:04 ` Marc Zyngier
2021-08-23 18:46 ` Rob Herring
2021-08-23 21:27 ` Frank Rowand
2021-08-23 22:14 ` Rob Herring
2021-08-23 22:21 ` Frank Rowand
2021-08-23 18:48 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSPtmp1eyQdSKITz@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.